From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1071C0219E for ; Tue, 11 Feb 2025 16:10:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A16C280005; Tue, 11 Feb 2025 11:10:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0516B280001; Tue, 11 Feb 2025 11:10:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0CEF280005; Tue, 11 Feb 2025 11:10:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BE02B280001 for ; Tue, 11 Feb 2025 11:10:17 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C06E246EBC for ; Tue, 11 Feb 2025 16:10:03 +0000 (UTC) X-FDA: 83108150286.17.CAFEFA6 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf28.hostedemail.com (Postfix) with ESMTP id 37149C0005 for ; Tue, 11 Feb 2025 16:10:00 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uJuAtNKx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6xS7tAaG; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uJuAtNKx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6xS7tAaG; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739290201; a=rsa-sha256; cv=none; b=b3TUK0YiO+cj2eYKk83zmcGAAihJh2BPyrdDG6t6zMaV7HI0PpOOsr01wf/zbquenqx4mK kjyMEvN/D69LJC0iurN4DJvDhqg6HmcIe3bx+UqNbAIXgr40v6eo4Cqqaq51y43oCm8FM3 qLhEnxG8JcLtrU5UIAbHXmi4417Fugc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uJuAtNKx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6xS7tAaG; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uJuAtNKx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6xS7tAaG; spf=pass (imf28.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739290201; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SXHr2W3erNwHQb3v7EgV4y+kPSMUWM0Hd6r5W3laQgk=; b=1WG9BBqps4aHztPg8OANSXOZGU2OkhLU673Hpfw8YL8nWlEsCaj3XmPpqShTPS/fts4SD/ OsekaIDOPcMJaubK/nG31KLO7PLSQfgpoJhTWgy8jF31dWMguroTv9xK3J5rUpQlRr/HZK VrLd3fimcZrhjeXfJwWNPiLIjXAlVEs= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D51B45C111; Tue, 11 Feb 2025 14:34:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1739284495; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SXHr2W3erNwHQb3v7EgV4y+kPSMUWM0Hd6r5W3laQgk=; b=uJuAtNKxGypX3rYm2vsTiLXme5CPsV58JRJRIDP1Qv+awCMSBxBvrMoISc9T0Wvjf9hfTf /ltqaOp+Fgn1aZb8eH8vWqNSDoaile/izQQHEZbBjjLDngguU5XntziBza63S1TZd6DgdY c6/o4jt9jcDqokq455n/j4NPxuRaJWU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1739284495; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SXHr2W3erNwHQb3v7EgV4y+kPSMUWM0Hd6r5W3laQgk=; b=6xS7tAaGtATmrVGbKw8tVQr5FHbtWfPuTaMMReK97qNe9yolPDJLEeNAnECwfKWZ19NrAy dF2VpWDnIBjn/mCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1739284495; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SXHr2W3erNwHQb3v7EgV4y+kPSMUWM0Hd6r5W3laQgk=; b=uJuAtNKxGypX3rYm2vsTiLXme5CPsV58JRJRIDP1Qv+awCMSBxBvrMoISc9T0Wvjf9hfTf /ltqaOp+Fgn1aZb8eH8vWqNSDoaile/izQQHEZbBjjLDngguU5XntziBza63S1TZd6DgdY c6/o4jt9jcDqokq455n/j4NPxuRaJWU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1739284495; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SXHr2W3erNwHQb3v7EgV4y+kPSMUWM0Hd6r5W3laQgk=; b=6xS7tAaGtATmrVGbKw8tVQr5FHbtWfPuTaMMReK97qNe9yolPDJLEeNAnECwfKWZ19NrAy dF2VpWDnIBjn/mCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AEDF313782; Tue, 11 Feb 2025 14:34:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id dxY1Kg9gq2dtUQAAD6G6ig (envelope-from ); Tue, 11 Feb 2025 14:34:55 +0000 Message-ID: <8b018dd9-37bc-468b-b992-2731c0270c12@suse.cz> Date: Tue, 11 Feb 2025 15:34:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Fix clang W=1 compiler warnings Content-Language: en-US To: Matthew Wilcox , Bart Van Assche Cc: Andrew Morton , linux-mm@kvack.org, Ivan Shapovalov , David Laight , Nathan Chancellor , Pasha Tatashin , David Rientjes , David Hildenbrand , Kaiyang Zhao , Joel Granados , Sourav Panda , Johannes Weiner , Linus Torvalds References: <20250131191231.1370466-1-bvanassche@acm.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 37149C0005 X-Stat-Signature: 53wkecigyhfwxwiac8wqecf545hkfqcp X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739290200-35267 X-HE-Meta: U2FsdGVkX18G6LT4RMKNVnSPoqE0zNIW0wkYT3Tq8D+vWOLw18E3AOKGcPCh3APLyAg/ZD01WQzuCf7UWoUXNVC203knm4+MGtfYSp1Gp0cISDexWLuYvUtKnP+DxnBGdxwm0QFHhkD3V4D5E42IyoppxWE+IP1Gn4QWh0RRtgdTg/gxFQtYVF8O4BUwHHn8uGUILZs/QzTPuVcRO/x6O8HeUioqztd6ZQe4r3gszMReiwDs+EaTeZV7j9mZ2kyhrtqMxCiu/0P65OzI/9ueLwXN5eqx2AKlH4uvEzrIquqhO6/YYIxhGJKCjHjssXSJtHQ0RRfeACIkeSVGmujWrFwbHv35KJEI7MJ5BJK5sjNJvYwR17fjaVj+FTrIXmj8QJOlp1F3MnBycSMEAzZVjwr/50oy7+x0YayQZ8xvuHOROxl0U1dZ3I/ezUJ3b7mWoLXx1IYWQzwcc5ab8PvrwwHCucgMQyg4DzWiq0cGwPqZ8rJUCOtFdd5ma1+kGuzp0kfoTCQJvHrg8oYVUmzVrPqg9KVztEUhrj0HABiPGc+ZVxE2q2/z9OCZjyvGWjuzdPnG7IzoHDcZV5pMWeNEgt28PcBvlfm6CDihPwc6KERAylw28/0BxqkHXILDW48YjWGH/3pIsJuOoSC5F1bRqpzU6TO7ohcEk2cYSuhCLo/QnuDuvTBUSvWILhNvSzBE3pKryKei/hi69E6yy89jZUCVrYgybzGiXTJdrqAalH6cnSxM2iahukWhkY4eIOueY2NW0GM2vJpXb3CDJd8mb2FmofzNehVzwJ/6N47s6EvIHzT5D2cU70Pu9H+Juf0FOKUmCIS9PpI3CMW1B24rsmvzLAM0qPtZoP67ycpTEs7a8i6kttK7eO1mx7gQlUXsqT6d1Vg08LDRAvbTyq9w7i5zA6DIsiSxVsBK8vFNR1tt8NC4s6Cca735UhqcL2HHiMyKZpIiyb3kJEhYGtW Yw1M0qYs fjmbWA0yFY6MwHcZKZ7Uf+wduursYJHuW969PrQBLZ3CJO3N+hNIO8gxbmtmXe1ZtnF8IlZcC3a1167IrnDm4SBpml9lxqcdIy7YUju4HOQRg166wp4jpsH3KYQwZ7QogQkJhwwXVvehjB7esjHgjC/cQkKLZi8kwu9NuB4BO3XYWapM5M75bU0VJXXdvS8E9Xyal4DTjQC8TebgtddqtkU7tqRDwmOtVsoE5PofoWgoIwMh6gP6hvmEK4KcWB7dzX3MNv6E+Lm1FAwyNShxcI9KnJYCVNxePtiMyIxRE5gPlMEKj4f3RpJDPV/2AaI9qhgth8cFO3RHQeMD0seKKyVbfRLUGt4fcLWrnZNUV9yRh1mFux2Mizkc24g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/8/25 11:28, Matthew Wilcox wrote: > On Fri, Jan 31, 2025 at 11:12:23AM -0800, Bart Van Assche wrote: >> Commit 30c2de0a267c ("mm/vmstat: fix a W=1 clang compiler warning") >> suppresses some but not all compiler warnings that are reported by clang >> when building mm/ with W=1. Hence revert commit 30c2de0a267c and instead >> make NR_LRU_BASE and NR_ZONE_LRU_BASE integer constants instead of >> enumeration constants. Additionally, convert the item##_NORMAL constants >> from type enum vm_event_item into int before subtracting ZONE_NORMAL. The >> latter constant has type enum zone_type. > > this patch was NAKed last year Looks like not strongly enough :) > https://lore.kernel.org/all/ZnXC5Xa4R0Mp7FCB@casper.infradead.org/ With the warning now in W=2, want to submit the revert of above, Bart?