From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A43DDC433EF for ; Tue, 12 Jul 2022 02:26:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F029F940031; Mon, 11 Jul 2022 22:26:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB220940010; Mon, 11 Jul 2022 22:26:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA0D5940031; Mon, 11 Jul 2022 22:26:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CD710940010 for ; Mon, 11 Jul 2022 22:26:52 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 9FD2360631 for ; Tue, 12 Jul 2022 02:26:52 +0000 (UTC) X-FDA: 79676859864.19.7EDD761 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf22.hostedemail.com (Postfix) with ESMTP id C4265C006C for ; Tue, 12 Jul 2022 02:26:51 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Lhl2y4VCbzlVtk; Tue, 12 Jul 2022 10:25:14 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 12 Jul 2022 10:26:47 +0800 Subject: Re: [PATCH] mm/compaction: fix set skip in fast_find_migrateblock To: Zhou Chuyi , References: <20220711123213.66068-1-zhouchuyi@bytedance.com> CC: Andrew Morton , linux-kernel From: Miaohe Lin Message-ID: <8af11329-93d4-3bbd-fe4c-343663c00a1b@huawei.com> Date: Tue, 12 Jul 2022 10:26:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220711123213.66068-1-zhouchuyi@bytedance.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657592812; a=rsa-sha256; cv=none; b=Y25r3gMUGSUd+nz9fGThKq+WoXiaIX8zLxs/fv1jQuEMtK9DdDfV8meMiA+SHfU/cmvnPj yPhY0xK7bV8wh5LQUhSxR6hZZewsUQ9kHn+MatZ7XMWgtCcUDs0a9l/7bO5me3/uMr0w52 bTYA4dZ4O5ifkMOSkCzQv5D+Zau+aPI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657592812; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qpqdCW0O8EQczxLgQRrfoTTT+iDg2MqsdcWqrc+7gA4=; b=yCO5/lfq+xI0aBZ/o/303RVYtFaaaZIbnQbQOs29ix+/qO5P9onnyoWpaUE7Chm3dg2f2N vp+Ph7DitiFyF9jCpVL635TveWZW/TsmoG0BCVqwYG44a8IeLXJsk8t3KJPzH8ItFon9jA 2gHU3gu9Hc0vL7OHaUv0q2/45c18AoA= X-Stat-Signature: 7z8x8ih4xfh6xyxxax47britc6x4ffai Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C4265C006C X-Rspam-User: X-HE-Tag: 1657592811-855160 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add Cc Andrew and linux-kernel email list. On 2022/7/11 20:32, Zhou Chuyi wrote: > From: zhouchuyi > > When we successfully find a pageblock in fast_find_migrateblock(), the block will be set skip-flag through set_pageblock_skip(). However, when entering isolate_migratepages_block(), the whole pageblock will be skipped due to the branch 'if (!valid_page && IS_ALIGNED(low_pfn, pageblock_nr_pages))'. Eventually we will goto isolate_abort and isolate nothing. > Signed-off-by: zhouchuyi It seems we should tweak the commit log to satisfy the checkpatch.pl first. > --- > mm/compaction.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 1f89b969c..a1a2b50c8 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1852,7 +1852,6 @@ static unsigned long fast_find_migrateblock(struct compact_control *cc) > pfn = cc->zone->zone_start_pfn; > cc->fast_search_fail = 0; > found_block = true; > - set_pageblock_skip(freepage); This looks like a real problem. Should we add a Fixes tag here? What's the runtime effect of it? Thanks for your patch! > break; > } > } >