From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCD9EC74A5B for ; Thu, 23 Mar 2023 15:50:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 768746B0074; Thu, 23 Mar 2023 11:50:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7184B6B0075; Thu, 23 Mar 2023 11:50:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B90B6B0078; Thu, 23 Mar 2023 11:50:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4847A6B0074 for ; Thu, 23 Mar 2023 11:50:58 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1AC184029D for ; Thu, 23 Mar 2023 15:50:58 +0000 (UTC) X-FDA: 80600601396.05.0FC35D2 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by imf05.hostedemail.com (Postfix) with ESMTP id 484F3100005 for ; Thu, 23 Mar 2023 15:50:54 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=ocSEb6p4; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf05.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=p.raghav@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679586654; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/ekrNC/98zX45M7YfQc5hSeXdmJtYi6b5R1JvXDqOBk=; b=w0erl/HeFKLPai4gYcdjBEoBQKhqe4FaLIihPqTCEPAFTPlmImCJCloW8l6lvR7NzDli2n V2bU9kpJUU2HZHuo4y5LUefrds4A1COt/HjkwwrgJnQxvvzaxxoCXx5PlYus9TAyts6CdH /adi7Y3p+1TYyjyx8unX5hSrTZpYuaE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=ocSEb6p4; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf05.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=p.raghav@samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679586654; a=rsa-sha256; cv=none; b=A8KFmW9PdqstIqAw8lMrcjqEeFUj9u5HNL/XpKgMfAWpRyUBtEqwVQPnw8cUMVDa+Ufsuf 6BJ36tSEwxB7r9JWspOh+X50D1y1LVQhXKGpQwfQgDOeHigZdOVnPCYYw+jUrD2fQx4JQe 8yno3MBRGCAGupObvRf1F9uQIy6KOJo= Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20230323155051euoutp01b0c285e7180e7a1ded636625072f07d1~PFyk2tfiR1009810098euoutp01d for ; Thu, 23 Mar 2023 15:50:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20230323155051euoutp01b0c285e7180e7a1ded636625072f07d1~PFyk2tfiR1009810098euoutp01d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1679586651; bh=/ekrNC/98zX45M7YfQc5hSeXdmJtYi6b5R1JvXDqOBk=; h=Date:Subject:To:CC:From:In-Reply-To:References:From; b=ocSEb6p4hh61NbC/5ACww2W12aIgY3AkXTCCmaphcN2wcqLN9sAouTRQY8epJ3mFL 8KjBdv9OBQfsP9yM7w4UuWkJ3/oOuyWUfqNFZXKwyDYFI8o0Hvmj2eiehBxxil18nE bi87kLF/jgxpe8mTuDLxuRWGwROWRot0EVhtj83Y= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20230323155051eucas1p11664caa8946ccba8d8d09c03772f7e9d~PFykjdNzW0552105521eucas1p1F; Thu, 23 Mar 2023 15:50:51 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 8E.BB.09503.B557C146; Thu, 23 Mar 2023 15:50:51 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230323155051eucas1p141ba678c9ff021ed5b8075447879f123~PFykP72XP1724117241eucas1p11; Thu, 23 Mar 2023 15:50:51 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20230323155051eusmtrp1332bdf7acf83a8330bca787dfa1047c0~PFykPO6sr3076630766eusmtrp1Y; Thu, 23 Mar 2023 15:50:51 +0000 (GMT) X-AuditID: cbfec7f2-ea5ff7000000251f-78-641c755b97a3 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id F8.DF.09583.B557C146; Thu, 23 Mar 2023 15:50:51 +0000 (GMT) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230323155050eusmtip12838d70fdd58c1b862205d365f7d9583~PFykEVamh3252432524eusmtip1e; Thu, 23 Mar 2023 15:50:50 +0000 (GMT) Received: from [106.110.32.65] (106.110.32.65) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 23 Mar 2023 15:50:49 +0000 Message-ID: <8adb0770-6124-e11f-2551-6582db27ed32@samsung.com> Date: Thu, 23 Mar 2023 16:50:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC v2 1/5] zram: remove zram_page_end_io function Content-Language: en-US To: Christoph Hellwig CC: , , , , , , , , , , , , , , , From: Pankaj Raghav In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [106.110.32.65] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIKsWRmVeSWpSXmKPExsWy7djPc7rRpTIpBg9WSFnMWb+GzWL13X42 i9eHPzFa7N88hcni9IRFTBbtd/uYLPbe0rbYs/cki8XlXXPYLO6t+c9qcXL9f2aLGxOeMlos +/qe3WL3xkVsFuf/Hme1+P1jDpuDgMfshossHptXaHlcPlvqsWlVJ5vHpk+T2D1OzPjN4tEw 9Rabx6/bd1g9Pm+S89j05C1TAFcUl01Kak5mWWqRvl0CV8bBB93MBRe5KxZu/cTUwDiVs4uR k0NCwETiysQrzF2MXBxCAisYJdau/8EO4XxhlLj6+B0bhPOZUeLgrRvsMC1/901igUgsZ5Ro Oj+RCa7qyNOjUP07GSWaV79hA2nhFbCT+HT9LyOIzSKgKvF06hZmiLigxMmZT4BGcXCICkRJ vHhdBhIWFnCQWNH0DqycWUBc4taT+UwgtoiApsSt5e1gxzILLGWWuNH5jxWkl01AS6KxE+w6 TgFdib61O5khejUlWrf/Zoew5SW2v53DDPGBosSkm+9ZIexaiVNbboE9ICHwilNi3dN37CAz JQRcJG4uqIeoEZZ4dXwL1PcyEqcn97BA2NUST2/8ZobobWGU6N+5ng2i11qi70wOhOkosXWl DoTJJ3HjrSDENXwSk7ZNZ57AqDoLKRxmIXl4FpIHZiF5YAEjyypG8dTS4tz01GLDvNRyveLE 3OLSvHS95PzcTYzAVHj63/FPOxjnvvqod4iRiYPxEKMEB7OSCK8bs0SKEG9KYmVValF+fFFp TmrxIUZpDhYlcV5t25PJQgLpiSWp2ampBalFMFkmDk6pBib/radVnr9byBmle/D4s4IMjQIh xjefFr5arLOUTdHq49+qO8pZWxnVv8e5/py2KOHBccvik8GdZ+fanJlQPGlLy9OWa9f8Vs/0 Me6bYKnws8vswE2unYHxZ9oW/3eS+LHxezD/rrrTbSVinKXVb5QWyLVkVB+7MPu3d+Kep5o7 wzVPvY23eT2rSF/b69xM0Ws3Tc7YzpjeyMHvN/vZtu45Vb9nlx76up2x07pzu5hv48F5yrYS PVcEl8oYS4SJBCytzhFOvpU8c+ea5xf+vYtimMJ2IPNUx4IrjTIisUVxG+bNmXE/z/zS40aJ yQzTn62+XFymsEu0RFUmVKRcaOFk81mfZzR+kep8JzlHqbtIiaU4I9FQi7moOBEAQFPE3/QD AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBKsWRmVeSWpSXmKPExsVy+t/xu7rRpTIpBre/sljMWb+GzWL13X42 i9eHPzFa7N88hcni9IRFTBbtd/uYLPbe0rbYs/cki8XlXXPYLO6t+c9qcXL9f2aLGxOeMlos +/qe3WL3xkVsFuf/Hme1+P1jDpuDgMfshossHptXaHlcPlvqsWlVJ5vHpk+T2D1OzPjN4tEw 9Rabx6/bd1g9Pm+S89j05C1TAFeUnk1RfmlJqkJGfnGJrVK0oYWRnqGlhZ6RiaWeobF5rJWR qZK+nU1Kak5mWWqRvl2CXsbBB93MBRe5KxZu/cTUwDiVs4uRk0NCwETi775JLF2MXBxCAksZ JbY828oEkZCR+HTlIzuELSzx51oXG0TRR0aJGbOnMoMkhAR2MkosnJIAYvMK2El8uv6XEcRm EVCVeDp1CzNEXFDi5MwnLCC2qECUxNM7h8DiwgIOEiua3oHVMwuIS9x6Mh9ssYiApsSt5e3M IMuYBRYzS0ye3wJ13iNGiedvrwA5HBxsAloSjZ1g13EK6Er0rd3JDDFIU6J1+292CFteYvvb OcwQHyhKTLr5nhXCrpX4/PcZ4wRG0VlI7puF5I5ZSEbNQjJqASPLKkaR1NLi3PTcYiO94sTc 4tK8dL3k/NxNjMAksu3Yzy07GFe++qh3iJGJg/EQowQHs5IIrxuzRIoQb0piZVVqUX58UWlO avEhRlNgIE1klhJNzgemsbySeEMzA1NDEzNLA1NLM2MlcV7Pgo5EIYH0xJLU7NTUgtQimD4m Dk6pBqa8jI7DStu3FW+fw3IqNHe/e5ZPg3pURE+2+YWOCtvlkbcnc0smHdnyTaXfqc5oNYtL 8GFX95dt99onFqgbVdhG8Rp0RRVe0Kssmhj47PjZR+oR+5PbN0moLJGomnuscmKygWbXkzSR uTefXr468erniqsXnioslopJivCWY98/R2eTVPFm4dRGabvipQrvTCenBOisWCyuelzH6aeO 547jT94LTj99OdA47lL5zveMqoWZs4tLNacy/3JcYFEQL36zVzC0etLdFW+blwWq88SETn7J 1Xl6QunL08GfZzGdXKhUMPtljvjLzm4Ru9MT//d/25cv63Xl1Uujtw9enTz/6drHS3Zfp06p e/XFWF6JpTgj0VCLuag4EQDHxP5hqwMAAA== X-CMS-MailID: 20230323155051eucas1p141ba678c9ff021ed5b8075447879f123 X-Msg-Generator: CA X-RootMTR: 20230322135015eucas1p1bd186e83b322213cc852c4ad6eb47090 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230322135015eucas1p1bd186e83b322213cc852c4ad6eb47090 References: <20230322135013.197076-1-p.raghav@samsung.com> <20230322135013.197076-2-p.raghav@samsung.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 484F3100005 X-Stat-Signature: bebrbzn555y1nzf8ocfmozcbr8kk3yxt X-HE-Tag: 1679586654-104698 X-HE-Meta: U2FsdGVkX18xkN2cS6Ze4c6FfXr47yKMHsKTQ8hh6C/wvbHWmOH0ljMv/6g4vIy4bqxCiglIE3+Bt6EvEbYNdfIvDbuTda3Ho3CfkvSdg8uVtmtXwUTfpyP8ooKcWTXRENbiOpFp3Eig4+VwxNrhZT6EO8VhBWpenVKY4pfYaJqNo7v3NbKXHbijgchZLzj5rnBl/T7REarXPvqImTeHzEVYYu1NwLCYxd1vXdDY/ZVuGYn0nLkJQQWdBBx/qFQk/0/fitElX5dVJkeFKSFG60HFMPtDpGPg4+LAxbl8dzQBWrBYgRxxPjDuYaGuGkoj7Ufhn7R7eoYgUKuZCaFGlm9e/1X58OvlpVwsbJBzgOZTRaK/Qt/cHcaewSUieGN6kO+PPi/hvE8/uzfbztPPal83lhfxMHE59G2GWmEUy2npIhuh5sJIn+tcBIKqDnleSLvWSG4tG06ftG/XH2LP1mv8ThoBxXiDHvMRjB3+5ItGOXymCIrBp16iBsLtLihkoshMPITxB4yiYpkCSIRVv+6ddQGAo+6mw6isylze03TPpgkyL1+sQRUJZUFd6e9pbt5pvkWKIr7R+JqRo02EUTNK3/TDpm09XB8ocuOy5i6b8T8jlNJtFkLnkOpd0xp7gc7RfxvkMo++tQxhbbIt5QidC0XDa8JjfVIXeo0vVp+96cHpA2C3Qo1DkiAV2ZS3GdXBM0gxevEPFog9Dh2x7hAHcwyRnvQK59XEIWCJeZgszcUah4x+lDd3qGcmoZ5EH2q23NKxDZsJAmVGKA7fQr62XUy3VYChn7o0ZYqwzX6GLlcqhCEa1lC+2Rntue+FlUJRTMjkvOhc9E68FWOVBoJdbE40kEXLesNdeGDL69rJvJ5+7rBVX54ATQb3AOrdokoK3WlKV2ai/+U0PlDS4x2Ai7Zr2bm+sXKM/zk8SDSYDu50lAt0xp6/zZLHr2sExBJir7VS9Px1GyGSxUQ xBoaaqjM sT9wnT80yqma0YH7id2eJRC8Au4Tf5ZYG4fPHXRP3A/mJ/3pi14AZCcXUpeihE33SaRGuFlZyBY+wt2BoCT+38gocdV19Ir93tkDMsK7oicMChfhvYQQuKpcQIUS8ThL/XYrnVJa9fvLwBZvX3TsCU/W1hv6Wl8lcBY2m1G0iN5PZ5dRg+TxuVvo8mQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023-03-23 11:35, Christoph Hellwig wrote: > On Wed, Mar 22, 2023 at 02:50:09PM +0100, Pankaj Raghav wrote: >> - if (!parent) >> - bio->bi_end_io = zram_page_end_io; >> - else >> + if (parent) > > I don't think a non-chained bio without and end_io handler can work. Hmm. Is it because in the case of non-chained bio, zram driver owns the bio, and it is the responsibility of the driver to call bio_put in the end_io handler? > This !parent case seems to come from writeback_store, and as far as > I can tell is broken already in the current code as it just fires > off an async read without ever waiting for it, using an on-stack bio > just to make things complicated. > > The bvec reading code in zram is a mess, but I have an idea how > to clean it up with a little series that should also help with > this issue. Sounds good. As a part of this series, should I just have an end_io which has a call to bio_put then? diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index b7bb52f8dfbd..faa78fce327e 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -608,10 +608,6 @@ static void free_block_bdev(struct zram *zram, unsigned long blk_idx) static void zram_page_end_io(struct bio *bio) { - struct page *page = bio_first_page_all(bio); - - page_endio(page, op_is_write(bio_op(bio)), - blk_status_to_errno(bio->bi_status)); bio_put(bio); }