From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF98AC54788 for ; Wed, 21 Feb 2024 22:22:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56D7B6B007B; Wed, 21 Feb 2024 17:22:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 51D1D6B0081; Wed, 21 Feb 2024 17:22:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E7886B0083; Wed, 21 Feb 2024 17:22:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2CCA56B007B for ; Wed, 21 Feb 2024 17:22:48 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C1B8C1A0BA5 for ; Wed, 21 Feb 2024 22:22:47 +0000 (UTC) X-FDA: 81817236774.21.345A762 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf27.hostedemail.com (Postfix) with ESMTP id A19144000B for ; Wed, 21 Feb 2024 22:22:45 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pvbuvSSr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DD8sSLUQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AwnxVk8l; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=B+ikTVhE; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708554166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P4W0Vi1tnkL5nnSLhQ7VEbuCk3ygETijT2fu5M3Nrkw=; b=Jdw/WSlPfPgQQFrloBuMMgWGHIUdtWFWEzb1oe5B7XLgq4PX7dQjohV/PYOqRgO+7JUtkb 4OaVb1TOZkgpSq2lVzDRhdZLLwiDfWOyosAqXVkRGTRJloewYV3pocdbK516TtELeWynD8 mOQNdZ5wrhPI4AzaPKsHkx1Xb5fHHbA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708554166; a=rsa-sha256; cv=none; b=CNkNWtbfiTW/I1DMocnBUnGEL8+N8VKxYyXE0+jOWqU8wp5JwcMLKGNThkuLO0gq/mYlXT h92yu/bc2+0ENuwCVhWRfvcuR0RQczJi+M19EJ93bbIIdu9gCxL+B33mTzjeXD8uabYW83 Iubw8zaOokVWerUmmTJ9m8KCYb283nw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=pvbuvSSr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DD8sSLUQ; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AwnxVk8l; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=B+ikTVhE; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F0B1A22292; Wed, 21 Feb 2024 22:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708554164; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P4W0Vi1tnkL5nnSLhQ7VEbuCk3ygETijT2fu5M3Nrkw=; b=pvbuvSSrjEVBQPOHpf6oOdCqujTB/r6DwtcG/9GCWwT3+dTGnCehUE+NW4rBxIciONRz2n 6ujcpGsX0BEf7LqLVMo+0YXV8l1/CQFyl3s4oBuorgOj9IWikadCShpZ2KgFdBxTSt1pUJ eVeWjhmUiYxuU5o3F8w0ELWXvDaD2mI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708554164; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P4W0Vi1tnkL5nnSLhQ7VEbuCk3ygETijT2fu5M3Nrkw=; b=DD8sSLUQsSzYW0aCWOG7nItZD/EZ+FM4c/RBlfldhidn0akW9pDsOgN+c3izXf2LvxrvnD A0ARzjb/VxsURPCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708554163; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P4W0Vi1tnkL5nnSLhQ7VEbuCk3ygETijT2fu5M3Nrkw=; b=AwnxVk8ly3jV0paZLFV3mrLvxLYd68nR0QGtJ0lWDoBaTITZO0A9TM4s0L9vlS4dfW1FLo t7g6tC5NbIjJuQyZGSBNHFz/5Sb6TN9I5+0U7O9bltdfPcFhJXur53HWP9I7qpdj314q1C rq6m3oypEekSU/E4gWs4IEcJb7zkdB8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708554163; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P4W0Vi1tnkL5nnSLhQ7VEbuCk3ygETijT2fu5M3Nrkw=; b=B+ikTVhEkRuRu9lJMHT2DdDG0IjkHUgG6vDuJIGycgJldYwa1jquCuEkQ/lJuW+AuecGf5 kgDwaKZMJIpEMTBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DD21513A69; Wed, 21 Feb 2024 22:22:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ja5FNbN31mWsbgAAD6G6ig (envelope-from ); Wed, 21 Feb 2024 22:22:43 +0000 Message-ID: <8ac57bb6-fe01-41aa-9e77-96be10595a26@suse.cz> Date: Wed, 21 Feb 2024 23:22:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: compaction: limit the suitable target page order to be less than cc->order Content-Language: en-US To: Andrew Morton , Baolin Wang Cc: Zi Yan , mgorman@techsingularity.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20c8fa7c-62ae-4e48-aaec-8b512519cee9@suse.cz> <5277627F-6791-46A1-AFC2-54FBF0DABF1A@nvidia.com> <83bc1070-2eb4-4fac-aecf-9cc407003ca2@linux.alibaba.com> <20240221141504.3c3cec674553b4df4bd72ec1@linux-foundation.org> From: Vlastimil Babka In-Reply-To: <20240221141504.3c3cec674553b4df4bd72ec1@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A19144000B X-Rspam-User: X-Stat-Signature: ocpbnwj3j1cmp7g5yxijniwdciq5jbqd X-Rspamd-Server: rspam03 X-HE-Tag: 1708554165-464024 X-HE-Meta: U2FsdGVkX19b8knGV5NoZR9HSsHoUVdfhhiFtjIG+FX1XGdoImOYSlnLD7M4iIy11k1EYTNfkvnHKhrbnKkXgjwUtHVk/dOiuWMGIWobb6nCfT8voQb4I4FLAi5TKzBn5spipHbDKk2jdTYn4vqlNaGiiogbhhI8xdsk6p/vUg5FxAVHCcyZ34mOFX31tIImTAhaFXquIphS/opXDjT+bOddANEQ2wWIJrBIfLUpmuTkZMc4w0n+bdBpq2AHsL07i3Qgag2xvGZllxKwTShKZcOonLhV/MTMi9umDZaObNOT7ummdPNIzJu39llfPKQaQFPHKMkEOKHSyFpVCmfstdH4S3+0/ljAyaK/gmWH3zgkyuhI4XAHADGjTgjMiWqiv2RFp4NE0C6Hegi0/rxLgCcsOD6XKpPWAV3vB1SjE+BKXTnYSrcQzdeEjaju1jqytL9sagVKPiq9PkC7UmnbDNh1y8jKWM+J/bs+CLgyIzlL+tUTW+6SEpKMP2BFAjqQ+kZv2bqoynHogrcF2UpXqrcmI9/nULCdbhSHzqgHe6K7TyF5dVtqb0rfJYrBixZdLXrvtX3Htzsnknu/47HPVVLzfakWP8unhitlvzyFT9XUqg9ZxYJdO+Gz0IRomr9dbNIDS6aevK0MkaMnJkmbkysnB5V5VJGoWsj0mC3ctVlWTx1Vqwf0/WgJY1lRdqV6M1XR03mRLVSVjNIznzUWxq1KJfR8HloBSEyHYu0LkfS6ce7Sy97Sgt7osvdDjwplsLuXA1Y/RR1Y8jLEemKg09nHFX4YY7fTcd3MVJKLAOS6n0j7lFrdJf/7fz4NaBDDi5mVfPiKAJZaQ53cw1/Xn//put3sE/KlVxzPgKPUmY0IkK614V2q9lRs5WpVe/oowEGTUVj+EaiaPEEaWDv5DYUSq8IxyQ+Ex6sKPVKoFT+/GY2eeMs/KA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000057, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/21/24 23:15, Andrew Morton wrote: > On Mon, 19 Feb 2024 10:55:59 +0800 Baolin Wang wrote: >> >> >>> Signed-off-by: Baolin Wang >> >> >> >> I doubt this will make much difference, because if such a larger order free >> >> page exists, we shouldn't have a reason to be compacting for a lower order >> >> in the first place? >> > >> > Unless kswapd gets us such a free block in the background right after >> > get_page_from_freelist() and before compaction finishes in the allocation >> > slow path. >> > >> > If this happens often and cc->order is not -1, it might be better to stop >> > compaction and get_page_from_freelist() to save cycles on unnecessary pfn >> > scanning. For completeness, when cc->order == -1, the logic does not change. >> >> Yes, this is one possible case. There are also some other concurrent >> scenarios, such as when compaction is running (after >> compaction_suitable()), at the same time, other applications release a >> large folio to the free list. In this case, the free large folio >> scanning should also be avoided. > > This went quiet. > > We have an ack from Mel. Are people OK with sending this change > upstream? It's not wrong, so I'm OK.