From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6F17C25B78 for ; Tue, 28 May 2024 07:43:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F6076B0089; Tue, 28 May 2024 03:43:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A4456B0092; Tue, 28 May 2024 03:43:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16C776B008A; Tue, 28 May 2024 03:43:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EE6416B0092 for ; Tue, 28 May 2024 03:43:48 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 92640A036C for ; Tue, 28 May 2024 07:43:48 +0000 (UTC) X-FDA: 82167015336.29.69B6960 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 6918A100016 for ; Tue, 28 May 2024 07:43:45 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dA5+csWj; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716882225; a=rsa-sha256; cv=none; b=MLQ4l1Pj2nKyDMq8ZO5BsFtY6EhH6ufHC6G4Vfz8R0F6actJKiQQOj1EXBN2fETHc+IGVF +q0Bl3IAAmGRnqFr9tRWwNL/rv1ChnUOR4ldahHOfXCdT5kxAglNJC6tkwOzopdhviG4Yq U2ZeuoATDdg5H8t3FtznthoRO08gwYc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dA5+csWj; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716882225; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tlYH/skdvPZBpSXPZaME8NdBvlZ6QuaFWdBuSnU2HNg=; b=aQaZLfJWKLmWxFlF3i2dwf7FLT+Og6vuyeg6iWb9IfDfTWKBma2UpbswDoJ4cVruL+cgUH U1H88EU3knIGcaqnBpH7bnUp1rRr9wgp5GGQtxrNsf1gutewgISEqGwmZEpN2XK/0ZQsAN oWoXpV7/E09h53aJDp7vkSHOt98Gd2Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716882224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tlYH/skdvPZBpSXPZaME8NdBvlZ6QuaFWdBuSnU2HNg=; b=dA5+csWj7jCovw4jpSAZaTP46JsgUASb3ipjNZbU14BtyOfnsbUdVzynvFaHPOgzyxow78 My2Glz4q/nkDdDyDSMthZNilZxcwZnZfeGAB7DcQhmJA7duKVN/jQoVIRbPGMy5p4mVxPJ slIupmmVb2ct/rKAEUsj70oI5+YU6nI= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-tcPlRhs4NaGDISJuGXgedg-1; Tue, 28 May 2024 03:43:43 -0400 X-MC-Unique: tcPlRhs4NaGDISJuGXgedg-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-5785fc97facso282536a12.0 for ; Tue, 28 May 2024 00:43:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716882222; x=1717487022; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tlYH/skdvPZBpSXPZaME8NdBvlZ6QuaFWdBuSnU2HNg=; b=J6DP4mIavhHJ/AX8E2byPXRGOASQo04MoaL5XIcWP0G/jj4wjE/1gJcQlEziwyMoPq zTvEM83yPdtIdkD/Xn/65851E4oZHhGqCxJt/tv3Qu66kAL6jvM/QTwcinqRnvRhEeLZ +bdf5QadXUUV1HH22YFN5xp6fXrcx+tk4voC2UL2RfeeVVKF+WqYKUOv480sHhopWfeH Dy7n86XGHAuQGsPypqM2SM8opQpgBAevzOKOXMVlELF9TlgmPOz/7iEmOeOKU4i3XD7e vfbReYEJ3YQyt1ZXQLGvsd196YBre0W8M6SZaQx+wBbO7Bwof2IK6dpR5ziXmKL2t19B BN8A== X-Forwarded-Encrypted: i=1; AJvYcCVF9LGFk4Tiv+vhz8ZiFzX6ZwVQhNqm4MPFFiF8X/AuWYDQuYJL+Oyqw8xg0my2CpaoX0SuNz+g5lM4XHRH48IzHmM= X-Gm-Message-State: AOJu0Yzx54EnuUq3n+5yHOpbg27BKkTE+N3Z7hEI76tjWavM9JjhMRby ZdEQGxI+u4nvUo+BfCEPqPCwbom56dDSlcpYxYoj/xwR+Un7oueQ7MI9Gg/dRu53G+05XolPxYZ JW/U/5SO0/21YVkbLqxAKk1P2NmC6YewqUFezpyMeGnD9W72G X-Received: by 2002:a17:906:408a:b0:a62:bc74:a883 with SMTP id a640c23a62f3a-a62bc74a9aemr473699266b.21.1716882222091; Tue, 28 May 2024 00:43:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGR/TBxPqJ+AxHlEy/X81c9ePzyGnghsIq5S1S5T3yXRoQDlv2KLbRtG+H9BBjIc4/qTw2EHQ== X-Received: by 2002:a17:906:408a:b0:a62:bc74:a883 with SMTP id a640c23a62f3a-a62bc74a9aemr473697366b.21.1716882221615; Tue, 28 May 2024 00:43:41 -0700 (PDT) Received: from ?IPV6:2003:d8:2f28:4600:d3a7:6c26:54cf:e01e? (p200300d82f284600d3a76c2654cfe01e.dip0.t-ipconnect.de. [2003:d8:2f28:4600:d3a7:6c26:54cf:e01e]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a626c93ae41sm582682866b.62.2024.05.28.00.43.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 May 2024 00:43:41 -0700 (PDT) Message-ID: <8aba80ed-7b3e-4c8c-99e8-d8a2e0b112fc@redhat.com> Date: Tue, 28 May 2024 09:43:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linus:master] [mm] d99e3140a4: BUG:KCSAN:data-race_in_folio_remove_rmap_ptes/print_report To: kernel test robot , Matthew Wilcox Cc: oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Vlastimil Babka , Luis Chamberlain , Miaohe Lin , Muchun Song , Oscar Salvador , linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <202405281431.c46a3be9-lkp@intel.com> From: David Hildenbrand In-Reply-To: <202405281431.c46a3be9-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6918A100016 X-Stat-Signature: nzdxpskh5ii3q1xnuone75cr8txfp41s X-HE-Tag: 1716882225-173960 X-HE-Meta: U2FsdGVkX1902q3VRtTEQ64z9nHu9ZKHH7PnS+G97dZ4XvoUj6jCaSFrhoOcO36dNnJju9xd4mMeunqwnlmUHMQ0NfY7gf+i82pczfotGnplgPQAOFsY+5rHF7lcZJsheQV+eO+Rb0eR2RCzB9GZ8Ve9tWw+eaqRNtOjdiUZDTF/RzBgT7M+DasoC8CXOW0li8oDcdITDWW+2SAPQdhKLNcqpbcpa2GoIGQE2YMQLinTNKU9kt9k4obAhS2bMd2GD8r6o7F7zwNWWm0k9utj00bhhB6V/R9wo72sQU9o7uijIU1ZhRIs7FFK8h6M6MejJfKKhmuhOxD8+oFVhpchD8UnA3m1il15fEeYZ5c/b3OXeMcgKSK7KDjdZiDk0EF1tFOKxqJ8no8/P9SQg0iN+t+YrF34P3N1F78fWWsu29N4OE4rtq0l6wAKxd2C7VcWa9SK5BBD0e6O6JYS3wi93a18gBjThOl31Npn/9gHIPgKf0B6qfywo7fWIXQ2HLcpvugCLWyOAv/NCDyq9j+bdkhl7YlfcvD7UacgRts1Zj1FRVZlCTuttnkohjkF1rVOlML27+VQQVWXQMPNZ80iEkMy6hh4a1AJakK8veFvLD89/QH97CRbmXwYr7SqKoKUgpFWNvwygUOc5njz9Kqs88rLyvlqDDrg83NeMITur6FotLLnYnd6PAmaOIw/mA75JO356rCY6ZG+uuctApwmXJfTaPPVrJsBeGdHWIxeUx9AsFtAZotTZUbcfYpYCixAAwducQv1w6kTvmRsIVzCGlldQRy7/oUqVPt5cTjuja/AFSjS8XLuTDYct6OhOp/LnLylA0dtZkWuBZjgmHmqkdonmp5h96mUsGDyTG8rbvElh1FsUfVbFP+WwO3Svg+OqNPg4lRBlNxCuQPgXtk5k7Z0hmM6waZB0PXk08O57WIXeiEfdXsajHkdBJVFuq2DeGLXxFfJOqiRexNr1o3 n9GSGmVU zzIBJYpQJR0XZ/o4Wp8D7Hdo6D04sYwOfGLubLcW7B7tYlYvbZAKofrk/GDY5lNJY8S4iDj5SwGIU0gw0uX+sJmx6GC88d9kwNg9yxNQm7A2Z1kkOUgbKvqSKhXZ69Y4AjZSqpxyK7IAiZKB952x4HRbQ4vnrA3xUdN5PvkUnC31CymFQPCmUu/0mYxcg6wUaLX12xNeNDd3gEr1E5eD7g9z8ClZ46+vZnncOILIYplMpXxRdnpXald1gv9sZusOB4nv2fr+vd9lFOzWHeV/tjM9219AtI106mVZAk/w2ACGbmIFBr8Cs7ULjimyo0SWuSUSnJb2BRHvH05YOK/UlgAtbx15x9ChMQfWjbVYTvhucDZmj7dzIwYwZT6dWs32/Eh4mrC6ne7wFwWioyzZ7YRaKMn+5nSNduyb4M9sbKRGmoXKB5Kq3/aCVXSy1koCI7/p2EhrrcaoOf4rSZvGwrmmHeJgl6CiT5hcFTOJZ6dhxp/54ztRktInkctyPkyPZk/2taH/742K9SRthPRDU7IMTHStdU+ig0gwvdZQFa7LxW95Se4Zzxj18BAEOGUPoZeCTOoEFzpEyP7ENBFqXSLChDw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Am 28.05.24 um 09:11 schrieb kernel test robot: > > > Hello, > > kernel test robot noticed "BUG:KCSAN:data-race_in_folio_remove_rmap_ptes/print_report" on: > > commit: d99e3140a4d33e26066183ff727d8f02f56bec64 ("mm: turn folio_test_hugetlb into a PageType") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > [test failed on linus/master c760b3725e52403dc1b28644fb09c47a83cacea6] > [test failed on linux-next/master 3689b0ef08b70e4e03b82ebd37730a03a672853a] > > in testcase: trinity > version: trinity-i386-abe9de86-1_20230429 > with following parameters: > > runtime: 300s > group: group-04 > nr_groups: 5 > > > > compiler: gcc-13 > test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G > > (please refer to attached dmesg/kmsg for entire log/backtrace) > > > we noticed this issue does not always happen. we also noticed there are > different random KCSAN issues for both this commit and its parent. but below > 4 only happen on this commit with not small rate and keep clean on parent. > Likely that's just a page_type check racing against concurrent mapcount changes. In __folio_rmap_sanity_checks() we check VM_WARN_ON_FOLIO(folio_test_hugetlb(folio), folio); To make sure we don't get hugetlb folios in the wrong rmap code path. That can easily race with concurrent mapcount changes, just like any other page_type checks that end up in folio_test_type/page_has_type e.g., from PFN walkers. Load tearing in these functions shouldn't really result in false positives (what we care about), but READ_ONCE shouldn't hurt or make a difference. From b03dc9bf27571442d886d8da624a4e4f737433f2 Mon Sep 17 00:00:00 2001 From: David Hildenbrand Date: Tue, 28 May 2024 09:37:20 +0200 Subject: [PATCH] mm: read page_type using READ_ONCE KCSAN complains about possible data races: while we check for a page_type -- for example for sanity checks -- we might concurrently modify the mapcount that overlays page_type. Let's use READ_ONCE to avoid laod tearing (shouldn't make a difference) and to make KCSAN happy. Note: nothing should really be broken besides wrong KCSAN complaints. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-lkp/202405281431.c46a3be9-lkp@intel.com Signed-off-by: David Hildenbrand --- include/linux/page-flags.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index 104078afe0b1..e46ccbb9aa58 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -955,9 +955,9 @@ PAGEFLAG_FALSE(HasHWPoisoned, has_hwpoisoned) #define PG_slab 0x00001000 #define PageType(page, flag) \ - ((page->page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE) + ((READ_ONCE(page->page_type) & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE) #define folio_test_type(folio, flag) \ - ((folio->page.page_type & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE) + ((READ_ONCE(folio->page.page_type) & (PAGE_TYPE_BASE | flag)) == PAGE_TYPE_BASE) static inline int page_type_has_type(unsigned int page_type) { @@ -966,7 +966,7 @@ static inline int page_type_has_type(unsigned int page_type) static inline int page_has_type(const struct page *page) { - return page_type_has_type(page->page_type); + return page_type_has_type(READ_ONCE(page->page_type)); } #define FOLIO_TYPE_OPS(lname, fname) \ -- 2.45.1 -- Thanks, David / dhildenb