From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93C4CC7115D for ; Sun, 22 Jun 2025 17:44:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E43006B00A1; Sun, 22 Jun 2025 13:44:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF3BF6B00A3; Sun, 22 Jun 2025 13:44:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D099C6B00A4; Sun, 22 Jun 2025 13:44:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BF2E86B00A1 for ; Sun, 22 Jun 2025 13:44:53 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 489F8100AE2 for ; Sun, 22 Jun 2025 17:44:53 +0000 (UTC) X-FDA: 83583762066.17.A70AF89 Received: from fout-a7-smtp.messagingengine.com (fout-a7-smtp.messagingengine.com [103.168.172.150]) by imf14.hostedemail.com (Postfix) with ESMTP id 2CCD9100004 for ; Sun, 22 Jun 2025 17:44:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=Yahs6+cj; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="p A2tFXj"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf14.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.150 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750614291; a=rsa-sha256; cv=none; b=vkuGoKfaAQxpPvAUJaTJyRvPTGuNTTSghCObbRtmSd4+svQcMsmtwN+RzLmcB/YP7SqLcz ABFzsavX4qCo3JzUPOY5G17fAC2uzY8/TyyZtM7D/YoKtSrUx0zgqZzNccC0UM19V9X4fi bzdxDtMQ8qkaBMlytWT33PkXZdbjPAw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=Yahs6+cj; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="p A2tFXj"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf14.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.150 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750614291; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wX0xhtUiNaavlvoeqLUK7VU9fCulEKaVWdquJFUErSQ=; b=dhQ9v/TV16xNlUdq2gqMEx7oiXqKa3A5p8vfXgSkNQ+C017B0gkoORfMy3WRXHx22YXgcN pg3mZ1MHibjJtF8PsobzjHJG12DvnzysUq10eJbt12DQ/GYNSpuondBtsLO1iLA/erDRcL gTS0rLakHkNNWA7FHfQfUMYAXm5Oi34= Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 43CE51380CEA; Sun, 22 Jun 2025 13:44:50 -0400 (EDT) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-05.internal (MEProxy); Sun, 22 Jun 2025 13:44:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1750614290; x=1750700690; bh=wX0xhtUiNaavlvoeqLUK7VU9fCulEKaVWdquJFUErSQ=; b= Yahs6+cjCA52QFm02QRROAdB00ML3PHNHPDEX8lZxqxvE/UZxIksm3cfJKloyEwC 08ViWQ01A+YR1J4lfneZZ3/+wF/OA6VWIqrHdTP7xbQOYotYJjMWa0s6t/FbK/AK jXqGXCHSLxHwSw6aff5xg5xmaJYxqWWCtoBHbYIEr3LB0KTMqxA05ccP2JJh2Dyq ftqvOmr/ItNSgKnX+IMqoKohBXHlfYuXiutqXuzNkuMzBDTkOqTfIPA4lyEsNUfq q3DPyil6nzQDxV5dvFi9R6zSZoAuVK3InQkvTZRDvvXA1FbUtb5kLik/LhRYKPhO +sSR9vTy5WxjxulK9bFM/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1750614290; x= 1750700690; bh=wX0xhtUiNaavlvoeqLUK7VU9fCulEKaVWdquJFUErSQ=; b=p A2tFXjTtjS1p5pykgpAzvkucR4+iYdEQ020f78W4MhaEh8VJiqS5A/CaEIlO76RR vI2xsv9TIqk7MsT3Hd9YD91JjRy0LKR0oMybR0Wez+pTwZ7SeioWZQT6gGjc5fqn uD97+2SMGPDUaa5/PCzMDM64vsRDEJxSzPO+L+ugPxl8A9+MlvpyGJ0qdSNKg08a 5D+E/J+oifR9cX15EqLKv1OEGAC88ORY280Gh0rrhpT7AIpraGDTaPIBmRizGobl njXLmAWKXxbee5oGwUGXXbpm4qyPCOxiKgmS2nZHZ5esyd+PsW1ZIWUcPul9uheP 0w8YUCp3gcAU8j5yB8SKw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddvgddugeejlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefoggffhffvvefkjghfufgtgfesthhqredtredtjeenucfhrhhomhepfdetrhhnugcu uegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtthgvrh hnpedvhfdvkeeuudevfffftefgvdevfedvleehvddvgeejvdefhedtgeegveehfeeljeen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnug esrghrnhgusgdruggvpdhnsggprhgtphhtthhopedufedpmhhouggvpehsmhhtphhouhht pdhrtghpthhtohepvhhinhgtvghniihordhfrhgrshgtihhnohesrghrmhdrtghomhdprh gtphhtthhopegrnhgurhgvhihknhhvlhesghhmrghilhdrtghomhdprhgtphhtthhopehr higrsghinhhinhdrrgdrrgesghhmrghilhdrtghomhdprhgtphhtthhopehsnhhovhhith holhhlsehgmhgrihhlrdgtohhmpdhrtghpthhtohepughvhihukhhovhesghhoohhglhgv rdgtohhmpdhrtghpthhtohepvghlvhgvrhesghhoohhglhgvrdgtohhmpdhrtghpthhtoh epghhlihguvghrsehgohhoghhlvgdrtghomhdprhgtphhtthhopehkrghsrghnqdguvghv sehgohhoghhlvghgrhhouhhpshdrtghomhdprhgtphhtthhopehhtghhsehinhhfrhgrug gvrggurdhorhhg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 5CC9C700062; Sun, 22 Jun 2025 13:44:49 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 X-ThreadId: Ta22caa133d9fa1a8 Date: Sun, 22 Jun 2025 19:44:29 +0200 From: "Arnd Bergmann" To: "Sabyrzhan Tasbolatov" , "Andrey Konovalov" Cc: "Andrew Morton" , "David Hildenbrand" , "Dmitry Vyukov" , "Marco Elver" , "Alexander Potapenko" , "Christoph Hellwig" , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Andrey Ryabinin" , "Vincenzo Frascino" Message-Id: <8ab6c624-28a1-47b9-93fc-190719c06727@app.fastmail.com> In-Reply-To: <20250622141142.79332-1-snovitoll@gmail.com> References: <20250622141142.79332-1-snovitoll@gmail.com> Subject: Re: [PATCH v2] mm: unexport globally copy_to_kernel_nofault Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: ouxuwo3mwrytfamwpzhjf5g3n4n8q9h1 X-Rspamd-Queue-Id: 2CCD9100004 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1750614290-382307 X-HE-Meta: U2FsdGVkX19lxFk0saQd1Ik0YtJdQa6n04Ax5rLRCKW2i9GOd3eFaLG5Yvf79H1BqxLaBBxlDwjShSKDbUExcMuNZXVP4jjwJxuHa+8wPYSnoPyxKP8tWsjXnS0ROoyMEup5X+hFCv79EpeFz6jMN05Kkwgf9y4mjaus4CyBWecclZPXJWmYDttAI9nmCdddRxhr4IOUTWyT6zrKYtSyDa0rLGxM9+81EFDJX60GonWDrDoR6/9PIpHl8bYltyIWMy1LAA0vSfeT7vGuglL1H+rmZtYU/mEDSGQNgooC8nyUy52b0j22XxTB5KCRXNuEHp73AWx5vOgRQShbPZn2WFLm00owddPOZbRDsoMkIb/wGsRWaBQDrw5qTRIO9YsRnQIJ2UpLCQM18Bx376/Um50fC3IPvyuvS/RQDzyb/64pqfOVV9dL3+K7n6ZUJzxYvhBch2a8pRln3nwU78lyzmkSMkdvXMd7zEiffMHN2umFtHYYUBS/R3N2vpRkorvELojA7jHuq9op+V2NLq9XgsrLJ1ynQ55Xw6dOvRpWb/Y9jFDV0jKSC+GK1Fg61/yx9BlQE+5NXlNqsKnJkgudeBvTFFLFHRBigitbSbjmciODXv4k8xh2OG7HRi4RkbqMEkBuhH+CWldv2qRIfF6PvynPHa9/FjJaUrAvclZwvHh2HmM+N4OeRfENgw27+b2XQW6Zrs/P1LL8AkA/CwtkHlgTDLPx0Sy8z/VNjl8dKir+MGc5W6hZnZu6qsRoExTyyQ1mB/iKSeMpqg7HOXy/aztBNucEbYMa/yJVUzGeEBleuWvhAHudvvTfTlYtIi+A+lhvnuDndDrupJDyeguH1mfQ4mBYq/CZBTrhKU8am3KKPUC1E9IVul90rUL+zBkEN0O0VvXwWxm6sX13+xHAexzRsJ26H+JogB7lF9wmgnuxfYSC6OtVloX1hqH08lIj4Qrz5YwMAvi3q6dmQay uXLg69bH ODnUX/qKtQpA+0U0pjg+X4e8F5NgtsS2l6fM9WPvyaijzOPuxS1844r5Mh814zu2aEoWqBHbsj3kA3S46mQGuNZqQoZ7XTdxEMj7me/igjUg7Hx79FWJN6QfobR5oR3km0kRg2rbQJStM+ku7kklooVhOcYN8LuS3F45HuiFvGy1GeglNSsaEvKzLVXA07+ilJJGftRsnATvuGLT6K30yXpJQuhjo9WZGdNRpXsajOTWe0g83/MncZNLeMHpWDsIq/f36bNmbQe9ch4uRqD0EwRaKuj5BuY6S+GnDr6dUKbdNFSV8CIfqsJeL5ylJo0ooiSXlMxtqsdpM0cocruHUUGifG+RWZ4WyigruVvmt59qibeiOAKSMIV7Pm++BRLxuxwnPwlFhCj8E0yeE7tx1XpORYw+PbIJRApRzDZKQs8SSIL8VIy1qKC52Quf4SetU6I2i7Z4nXobvG1k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jun 22, 2025, at 16:11, Sabyrzhan Tasbolatov wrote: > `copy_to_kernel_nofault()` is an internal helper which should not be > visible to loadable modules =E2=80=93 exporting it would give exploit = code a > cheap oracle to probe kernel addresses. Instead, keep the helper > un-exported and compile the kunit case that exercises it only when > `mm/kasan/kasan_test.o` is linked into vmlinux. > > Fixes: ca79a00bb9a8 ("kasan: migrate copy_user_test to kunit") > Suggested-by: Christoph Hellwig > Suggested-by: Marco Elver > Reviewed-by: Andrey Konovalov > Signed-off-by: Sabyrzhan Tasbolatov Acked-by: Arnd Bergmann