From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B696EC0044D for ; Thu, 12 Mar 2020 00:17:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A748C20753 for ; Thu, 12 Mar 2020 00:17:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="LTnAZVVi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A748C20753 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1F7A36B0005; Wed, 11 Mar 2020 20:17:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 180646B0006; Wed, 11 Mar 2020 20:17:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 047A06B0007; Wed, 11 Mar 2020 20:17:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id DD2C66B0005 for ; Wed, 11 Mar 2020 20:17:47 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id ABA3A8248047 for ; Thu, 12 Mar 2020 00:17:47 +0000 (UTC) X-FDA: 76584796974.07.shame26_26dfa20e2c003 X-HE-Tag: shame26_26dfa20e2c003 X-Filterd-Recvd-Size: 3769 Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Mar 2020 00:17:46 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 11 Mar 2020 17:16:13 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 11 Mar 2020 17:17:45 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 11 Mar 2020 17:17:45 -0700 Received: from [10.2.175.179] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 12 Mar 2020 00:17:45 +0000 Subject: Re: + mm-gup-track-foll_pin-pages-fix-2.patch added to -mm tree To: Claudio Imbrenda CC: Andrew Morton , , Linux-MM References: <20200307232517.0eSNFUWfN%akpm@linux-foundation.org> <202efdc4-2b19-278b-9960-3afb18b8173d@nvidia.com> <20200311111352.1dff2984@p-imbrenda> From: John Hubbard X-Nvconfidentiality: public Message-ID: <8ab0ad90-4e6b-cbc1-e3e1-c62427486711@nvidia.com> Date: Wed, 11 Mar 2020 17:14:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200311111352.1dff2984@p-imbrenda> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1583972174; bh=YVhDCmheva9HObrTaxOcUOryN6fb3wAgaVLDceNEmVY=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=LTnAZVViSFK6YmBWxnyAbvFh4nO4UQyQucFebXaPd5STQg3lWMxEixsPUomM23DYW VCtaL3qUUgLNL40elpc/h01Kv3B8t9hHYwDQIPvVy88UoVqqCkgS5c03N/tyRXZfO0 EgYPYkKhw1JO5+b5ozIQctQXlUSesmzfxZI68F58BaGtvB/O+9dwkaTULhOtHnY96o nKlBH3yLTjWBG7742e+3k+lMJF8fA7yrvTB+0BPdndTz0DLb0dLW/QaMekMFtKIbaP jDI0+DhONsrV8j6pfivbQlbjxgK9CdMls2FkSMrOdE5wdG+Nm1eEQ3/mdpzbcRXFQ6 M1rHsoTD631WA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/11/20 3:13 AM, Claudio Imbrenda wrote: > On Tue, 10 Mar 2020 18:46:40 -0700 > John Hubbard wrote: > >> On 3/7/20 3:25 PM, Andrew Morton wrote: >>> >>> The patch titled >>> Subject: mm/gup: fixup for 9947ea2c1e608e32 "mm/gup: track >>> FOLL_PIN pages" has been added to the -mm tree. Its filename is >>> mm-gup-track-foll_pin-pages-fix-2.patch >>> >> >> This appears to be causing a build failure in mm/gup.c, in mmotm, as >> of today anyway: >> >> commit 5d9ee416b570 ("pci: test for unexpectedly disabled >> bridges") >> >> >> I vaguely recall reviewing an earlier version that moved >> put_compound_head() up higher in gup.c, in order to avoid this. In > > yes, that is what I had sent > >> any case, that's what this needs in order to build. Sorry for missing >> it in the review. > > I don't think you missed it, because the patch I sent out to be > squashed did move it up > >> Claudio, did you compile-test the patch? I'm not sure how this made > > not only compile tested, I even actually tested-tested it. Andrew, do you want Claudio to resend that patch? It seems like part of it got lost, somehow. thanks, -- John Hubbard NVIDIA