From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51BA8C433F5 for ; Fri, 22 Apr 2022 17:41:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D59BC6B0073; Fri, 22 Apr 2022 13:41:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D098F6B0074; Fri, 22 Apr 2022 13:41:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B83426B0075; Fri, 22 Apr 2022 13:41:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id AAF3D6B0073 for ; Fri, 22 Apr 2022 13:41:42 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 87D4E120956 for ; Fri, 22 Apr 2022 17:41:42 +0000 (UTC) X-FDA: 79385232444.17.A88D899 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 6A299A0023 for ; Fri, 22 Apr 2022 17:41:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650649301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qS1z2/5qHncMhjCwTTUMd4XpJC28UxMysCRYKxl364Y=; b=aGsZP9YlztXAj5ng1/5Cq9YEaM9z+d+VAiiimW4hh/OAYFaZ74yp4VbCw+L/Woj7jk8DPz 3oUFEypmEHsGAl9sTUv/P/q4bkkjZke+TgPG66YqbzqsINg106IyxNc5jHaOgD0Hq/EeS9 9CNAQhArX0RsrIkBhEPgNNwYUChN0EY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-576-wgWQpoKsPXed91qWBIB1EA-1; Fri, 22 Apr 2022 13:41:40 -0400 X-MC-Unique: wgWQpoKsPXed91qWBIB1EA-1 Received: by mail-wm1-f71.google.com with SMTP id k16-20020a7bc310000000b0038e6cf00439so3986579wmj.0 for ; Fri, 22 Apr 2022 10:41:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=qS1z2/5qHncMhjCwTTUMd4XpJC28UxMysCRYKxl364Y=; b=c/rQcbJNwGCseTeJXQNnVUsQrlupeK9b3lppv6xEVNlyfFkk6LInjdNtYJwgRX77+o 4vgXcRPMw4YFjZLyZI10LdvYjG58PLJOMdrirZ5Kyi1lZfeJ3nIEcmkkIKLakV/YuvBi CI78wZ2fztISPCEO/GKeGtU6Y8bZ2qLYatFVnRTo5YEbVs9zgsZj72b9DHNM7a/usOxq Ov/SvfUEq54UdzbAKnKiZzjgPmaip/buUpJjc60kQiROcPLlnBlrkLqjJE4YneAO9R4g qcbeAOOAToxw8naU8a13ysvLkQ10jZ5BpEkirH2tdrUGgDaTQmK0z0nTg+Tm+Czu1iFc PWGw== X-Gm-Message-State: AOAM533ypj+VJCH20nfujJoGDDe40cL4A0pgqdA9xcQPyS6ap4zPWySt cy+icR5rs0S1jOSPAsH/zHUtf7Qnq/fig3vnofbp4QREfy9nbtHVuDR/abLfdMyXi3VuJNlcmrI Ou8bd50uSDW4= X-Received: by 2002:a7b:c205:0:b0:38e:b6b4:ed90 with SMTP id x5-20020a7bc205000000b0038eb6b4ed90mr5290003wmi.51.1650649298839; Fri, 22 Apr 2022 10:41:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwt73hO3Dy97LGUolcZvHHAxZgmOvXPUbuwOME5mBJ6jfcifPO0j4OjUm4GxUQAhhZyN0MblA== X-Received: by 2002:a7b:c205:0:b0:38e:b6b4:ed90 with SMTP id x5-20020a7bc205000000b0038eb6b4ed90mr5289976wmi.51.1650649298584; Fri, 22 Apr 2022 10:41:38 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:dd00:745e:20b7:bfa4:2e5f? (p200300cbc702dd00745e20b7bfa42e5f.dip0.t-ipconnect.de. [2003:cb:c702:dd00:745e:20b7:bfa4:2e5f]) by smtp.gmail.com with ESMTPSA id u5-20020adfed45000000b00207a480e6aasm2161989wro.116.2022.04.22.10.41.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 10:41:38 -0700 (PDT) Message-ID: <8aafe4ad-81a6-31a5-c95a-ce2943bf0525@redhat.com> Date: Fri, 22 Apr 2022 19:41:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH RFC 2/4] mm, personality: Implement memory-deny-write-execute as a personality flag To: Catalin Marinas Cc: Andrew Morton , Christoph Hellwig , Lennart Poettering , =?UTF-8?Q?Zbigniew_J=c4=99drzejewski-Szmek?= , Will Deacon , Alexander Viro , Eric Biederman , Kees Cook , Szabolcs Nagy , Mark Brown , Jeremy Linton , Topi Miettinen , "linux-mm@kvack.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-abi-devel@lists.sourceforge.net" References: <20220413134946.2732468-1-catalin.marinas@arm.com> <20220413134946.2732468-3-catalin.marinas@arm.com> <443d978a-7092-b5b1-22f3-ae3a997080ad@redhat.com> <59401856-0e45-0ee6-1e45-667c8e00cf21@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6A299A0023 X-Stat-Signature: ume3ttsjnc6cn8g8m8xyfn494reid3bs X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aGsZP9Yl; spf=none (imf15.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam09 X-HE-Tag: 1650649299-858460 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.04.22 15:12, Catalin Marinas wrote: > On Fri, Apr 22, 2022 at 01:04:31PM +0200, David Hildenbrand wrote: >> On 22.04.22 12:28, Catalin Marinas wrote: >>> On Thu, Apr 21, 2022 at 06:37:49PM +0100, David Hildenbrand wrote: >>>> Note that in the (FOLL_WRITE|FOLL_FORCE) we only require VM_MAYWRITE on >>>> the vma and trigger a write fault. As the VMA is not VM_WRITE, we won't >>>> actually map the PTE writable, but set it dirty. GUP will retry, find a >>>> R/O pte that is dirty and where it knows that it broke COW and will >>>> allow the read access, although the PTE is R/O. >>>> >>>> That mechanism is required to e.g., set breakpoints in R/O MAP_PRIVATE >>>> kernel sections, but it's used elsewhere for page pinning as well. >>>> >>>> My gut feeling is that GUP(FOLL_WRITE|FOLL_FORCE) could be used right >>>> now to bypass that mechanism, I might be wrong. >>> >>> GUP can be used to bypass this. But if an attacker can trigger such GUP >>> paths via a syscall (e.g. ptrace(PTRACE_POKEDATA)), I think we need the >>> checks on those paths (and reject the syscall) rather than on >>> mmap/mprotect(). This would be covered by something like CAP_SYS_PTRACE. >> >> I was told that RDMA uses FOLL_FORCE|FOLL_WRITE and is available to >> unprivileged users. > > Ah, do they really need this? At a quick search, ib_umem_get() for > example: > > unsigned int gup_flags = FOLL_WRITE; > ... > if (!umem->writable) > gup_flags |= FOLL_FORCE; > > I guess with a new MDWE flag we can make the GUP code ignore FOLL_FORCE > if VM_EXEC. > It's, for example, required when you have a MAP_PRIVATE but PROT_READ mapping and want to take a reliable R/O (!) pin. Without FOLL_FORCE|FOLL_WRITE you'd be pinning a (shared zeropage, pagecache) page that will get replaced by an anonymous page in the COW handler, after mprotect(PROT_READ|PROT_WRITE) followed by a write access. That was an issue for RDMA in the past, that's why we have that handling in place IIRC. Yes, it's ugly. -- Thanks, David / dhildenb