From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6632CC433EF for ; Sun, 13 Feb 2022 19:21:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD8B96B0072; Sun, 13 Feb 2022 14:21:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B878C6B0073; Sun, 13 Feb 2022 14:21:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A76276B0078; Sun, 13 Feb 2022 14:21:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id 94F356B0072 for ; Sun, 13 Feb 2022 14:21:41 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 55B8A181AC9C6 for ; Sun, 13 Feb 2022 19:21:41 +0000 (UTC) X-FDA: 79138726002.07.16B5004 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf30.hostedemail.com (Postfix) with ESMTP id F13FD80007 for ; Sun, 13 Feb 2022 19:21:40 +0000 (UTC) Received: from imladris.surriel.com ([96.67.55.152]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nJKR4-0000LX-Ui; Sun, 13 Feb 2022 14:21:26 -0500 Message-ID: <8aafa00865f564d58dfa39a1e2816a8ec0eab097.camel@surriel.com> Subject: Re: [PATCH] mm: clean up hwpoison page cache page in fault path From: Rik van Riel To: John Hubbard Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, Andrew Morton , Mel Gorman , Johannes Weiner , Matthew Wilcox Date: Sun, 13 Feb 2022 14:21:26 -0500 In-Reply-To: <10f4319c-45fe-2a7b-db6f-2d5fe8ae98a0@nvidia.com> References: <20220211170557.7964a301@imladris.surriel.com> <10f4319c-45fe-2a7b-db6f-2d5fe8ae98a0@nvidia.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-8nhOn9cXF7OD7/XqPxdK" User-Agent: Evolution 3.42.3 (3.42.3-1.fc35) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F13FD80007 X-Stat-Signature: d4yhmyhaqeokr1fupcqczdybsrr731tq Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=none (imf30.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com X-HE-Tag: 1644780100-974190 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --=-8nhOn9cXF7OD7/XqPxdK Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2022-02-13 at 00:56 -0800, John Hubbard wrote: > On Fri, 11 Feb 2022, Rik van Riel wrote: >=20 > > =C2=A0=C2=A0=C2=A0=20 > > This is particularly embarrassing when the page was offlined due to > > having too many corrected memory errors. Now we are killing tasks > > due to them trying to access memory that probably isn't even > > corrupted. >=20 > I'd recommend deleting that paragraph entirely. It's a separate > question, and it is not necessarily an accurate assessment of that > question either: the engineers who set the thresholds for "too many > corrected errors" may not--in fact, probably *will not*--agree with > your > feeling that the memory is still working and reliable! Fair enough. We try to offline pages before we get to a point where the error correction might no longer be able to correct the error correctly, but I am pretty sure I have seen a few odd kernel crashes following a stream of corrected errors that strongly suggested corruption had in fact happened. I'll take that paragraph out if anybody else asks for further changes for v3 of the patch. --=20 All Rights Reversed. --=-8nhOn9cXF7OD7/XqPxdK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAmIJWjYACgkQznnekoTE 3oNdogf+Ich/XnBrCMzlpA+55TM6I1e+YVX3wzvOc+1CPhoPe0GwAcxnPBKfDkOd Yh9T7IsM71FRlCHL7pl6P7fppcsrfgqcxm5dcsFwPY9Jcj74GCZs9Fi2jxfo8Exb NOHNFo4mj9X/izCQoKzF887bjoTXZpMhb0RylbNxrm1uxwbw8mSkfRyo7U5kYf24 9gtSCw6Ag/ZKLU5omsYLcvTqeJ5619m3wNwKGXoIKYyYRy74nfTykyD/y+xWIF1z lb3nNMqUJx4B8J0d6J/x1EafCxHLThObqw2dy6/expQpwDT/rzgNipFCdhDOG0rr 1PIkhOQi80oESJc0zmN/ocoz7I2r+A== =wbch -----END PGP SIGNATURE----- --=-8nhOn9cXF7OD7/XqPxdK--