From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C38A4C7618A for ; Mon, 20 Mar 2023 11:14:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D6E66B0078; Mon, 20 Mar 2023 07:14:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 486AF6B007B; Mon, 20 Mar 2023 07:14:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3284C6B007D; Mon, 20 Mar 2023 07:14:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2542D6B0078 for ; Mon, 20 Mar 2023 07:14:38 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E9426A09EB for ; Mon, 20 Mar 2023 11:14:37 +0000 (UTC) X-FDA: 80589018594.22.D6435C4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 5959020003 for ; Mon, 20 Mar 2023 11:14:35 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=erQjEfCL; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679310875; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B0EOqQNOoDr9J5ZhYSbGmkTrdHGjzdKjU2v0LKERLeQ=; b=5c2QHa7TT+yi9BUe2nOwreisPlRF73gGV2c4YyJZMTZBLh1InAXChL7K7sJ2+q13Yw9e9X e5GVf2niOQbGJDBciudTu/u6EgEWG58II9IobkSMxwVk3vHt+Y8l1xFIjpIGp7lFdiKF/O ssNWTQnSWPXuIjfPN06wazFYEmpzlM4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=erQjEfCL; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679310875; a=rsa-sha256; cv=none; b=OVGCo2MfJSh38VHjiCpvI0bavuf88FyeGcfImR6eAlwi+c6v4fELpOBWovHSwtv3kWuSIY Lh1rdym6gXu7LMAR6ZfiEw2Tr35AECYGwxEpi+Te74bLDbpwrHJpAE1IziMGCalHW8CtNJ gnLEfVFmeTKkOT4iRcckpxm5rJpXINc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679310874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B0EOqQNOoDr9J5ZhYSbGmkTrdHGjzdKjU2v0LKERLeQ=; b=erQjEfCLxk/jszXWpzrl8FIU8WaQYA3phLTP7BojMOLKqZOVWtOvMi5+Bu6hqiz1RkHXg/ FgBkJ3mPSnVNRdleVFddNtgTonm+EKjp6kq0xpi52rK6XVfA2lug3kHcmxkOEik66QDg0J GFe+vKS4kOLdWfAjBe2YialqPrDXDoo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-572-0L00GAyqNESYpDeUy6oLqw-1; Mon, 20 Mar 2023 07:14:33 -0400 X-MC-Unique: 0L00GAyqNESYpDeUy6oLqw-1 Received: by mail-wm1-f71.google.com with SMTP id p21-20020a05600c1d9500b003ed34032a01so5370982wms.2 for ; Mon, 20 Mar 2023 04:14:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679310872; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B0EOqQNOoDr9J5ZhYSbGmkTrdHGjzdKjU2v0LKERLeQ=; b=YHCxyj3IOol6R/jVifL45KPk0NSsYZVRT8+gt5kF3hccuOrahqsWVDP1LPVfhJ/OTb iQaXPTl0/XhNeINA9LnaZaJBThKD32q9NP8WxrP8kABcZzoZLIpZfCgDAS+zYSnCLcFl IdvL8P17IvWfD+57m2igsdwJnEqnoE7u7c9wnqpl67myWbu/fTEuuSh/VkxMFy0pMCf9 kzTVCjPFFdYqurEF5MfP/hlaO4SBjTd7hun8uKROdNt1tS3+rSOI/BPohMIe7wMP3xn5 51tHVnub/+p9auAxEMVcSOnlqS5C9DMpSXt4wkRTj5vKFDdTCvldiDMDxF8ZtEpV/lCU eROA== X-Gm-Message-State: AO0yUKXU4sFLODkcvAghuRc20WjWjzOUa+4+efmeeUjgiTprp/u1avRX DtQA/3n3vQUqQK1TKpRt019W970MSFlPrPeGgvPEBRh7nhrPvucsiUClH9txq0N/qNWsSAGIH+f uJXjL7YvgeSM= X-Received: by 2002:a05:600c:444c:b0:3ea:d620:570a with SMTP id v12-20020a05600c444c00b003ead620570amr31908131wmn.38.1679310871943; Mon, 20 Mar 2023 04:14:31 -0700 (PDT) X-Google-Smtp-Source: AK7set+oDHc1SsjzfN93tiAdKSTwxgdoq4X5250NkurTWNXcaq4UNjbKf13f5qD5SXb1ugKzI+ONSg== X-Received: by 2002:a05:600c:444c:b0:3ea:d620:570a with SMTP id v12-20020a05600c444c00b003ead620570amr31908117wmn.38.1679310871619; Mon, 20 Mar 2023 04:14:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4100:a064:1ded:25ec:cf2f? (p200300cbc7024100a0641ded25eccf2f.dip0.t-ipconnect.de. [2003:cb:c702:4100:a064:1ded:25ec:cf2f]) by smtp.gmail.com with ESMTPSA id s11-20020a1cf20b000000b003db0bb81b6asm10467233wmc.1.2023.03.20.04.14.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 04:14:31 -0700 (PDT) Message-ID: <8aa1db52-bc5b-a734-cf4f-ddee518ee9fb@redhat.com> Date: Mon, 20 Mar 2023 12:14:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 02/15] mm/cma: move init_cma_reserved_pages() to cma.c and make it static To: Mike Rapoport Cc: Andrew Morton , Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org References: <20230319220008.2138576-1-rppt@kernel.org> <20230319220008.2138576-3-rppt@kernel.org> <8a461e44-7d24-5b5d-db04-e7fa85beeaa7@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5959020003 X-Stat-Signature: 18i4pr1mueer5scwzczfhxu5fdh54t6r X-Rspam-User: X-HE-Tag: 1679310875-311244 X-HE-Meta: U2FsdGVkX1+hHOtpPov5b93N6mYruEqikh46BqTinNyFgZWLuf2ahGfyOpxLF8Y9x5HPC9pskPmsrDjP6jwCWk+GTQDR3fTxqWIICHB8lIEYmv+JmQav1p83v7llu5gDA+L5e1uDWXo/90MBzHR4wF1F0ghUz9cQSCQg2vKMyo0hWJplGlTP1MGNeEz2dYV0+2DfDS/Udi3Lg17I/Xq/xqd6u8kGW6LqhgFUb7InylXZvY2WVfWCbyTmwYgG/EHVNEOrIYjGPubkUwARz3RyCr3HZssPbPlvzIlaF4/Qt/34FDh+zQ0NGIo/TNRY8ITqfpkYe5fqHMavsp3i4MPQZ3Ss19UQ9GTFa6eceapZRDL7Tr048Zk1luymm41JoYgUepxCRgVOtzsW2pzQdXgZU3iCsNFA0VqiAqPhFJiNrIvKs86w9mUgAw7/1gCuNUIX69+TrWiutN0qI3xJAfdut2Y15DkZ6NWOMhVRAjQwd1GL0iuZwl9ycetT05wrkQ89VkOiSLcrEW/zdfOadjVzU8L4+YPSgPTflZcfQYWbaaqLn6Y5d8kf5ORrkMU6UAs3fEjaM9bpI2q8Cf9dwJPwV9E3cltRyl2fYFs+io13n7ijXCLXtwi50gBv9GhcO7/EIOGbUZqKLRKOUaFevK35njNd97LrzuiWs0j+4QPy4uHH3FuzxsNzPExIvPdbKm7/G4eA80M9hHnR+g7mJ5vp4/N6f/+4GOOcVOE9s5VQ9b54G9xAKs+Vx8ivMvWzqZT7gVBE/4a4VeTgkQnx9bLaeLN1K/+yTat+ZoOaTSwXmiFLmENjMWE2EJ6BkMB4T+Fix5xRlyY1PP0+h2tAEAiKPKEcdrZRLSI/BVCyIt/fArlxua2t1eBAZ/CeWlBNNoBSR6QXF2whkkKWY7QmRC4/RmuFcVMzGMFH7krlVCY+IXuEW1ceXiF2W+YEFCjtG2AURjS3zSwJS/tAoXuvWgk bvK0+E+a 7oKCHL0NHwnmP7I1ZA8fMQYGtm6S26phGnoGIDZDxjrFHG+wVm9Ox4SYGm8yIswOVJ+qFiLP14Bv790YspPKQP1/ABERFqx3+jMV+C1mbCe45Vr+f173H1y76Wkag1dEbd7m1oahCs/jfm+Sx68E49p/8KDisePZz53Wk00haJ10B/x1p6Y9kk2XtULHhJInaYqyJ9awSWtcrOkXaEz62hnFVVT4hmDJPEMdkY+2mILdoarzjFN/VeVz5Hx1UOUES2yipZX8Yr/ckYoNckS6k+Y8ldOMxjAfI/Q4eA8HiLo/VnHvp1tkpoR6tWG90gk725boVOmCvfuOWQ3biXhaW0ROlZ97Atos3cxn1bGQSoOOdo5WFhp4lX/Tse3HWfPLJU1o/w87XVEtyK+aPSbfn4xznzBil6b4sLwfsOTr7Q0IFoU2M8VkS6o147UhBSggaR59UXu1JpMUJt5X4vd8b3jIDADdV8WRNw1P9BrBGWzlElDkv+hf50nyNRgOnQLKg7CVz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.03.23 12:11, Mike Rapoport wrote: > On Mon, Mar 20, 2023 at 11:30:20AM +0100, David Hildenbrand wrote: >> On 19.03.23 22:59, Mike Rapoport wrote: >>> From: "Mike Rapoport (IBM)" >>> >>> init_cma_reserved_pages() only used in cma.c, no point of having it in >>> page_alloc.c. >>> >>> Move init_cma_reserved_pages() to cma.c and make it static. >> >> I guess the motivation is to avoid letting too many subsystems mess with >> pageblock migratetypes, managed pages, PG_reserved ... > > Judging by the git log it just ended up in page_alloc.c because > set_pageblock_migratetype() was static back then ;) Yeah, it leaked into page_isolation, which heavily relies on migratetype handling :) -- Thanks, David / dhildenb