From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93154E77188 for ; Tue, 31 Dec 2024 16:31:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E81BB6B007B; Tue, 31 Dec 2024 11:31:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E32476B0082; Tue, 31 Dec 2024 11:31:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF94D6B0083; Tue, 31 Dec 2024 11:31:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B11F56B007B for ; Tue, 31 Dec 2024 11:31:32 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 55AC51C55F4 for ; Tue, 31 Dec 2024 16:31:32 +0000 (UTC) X-FDA: 82955793312.30.AD079D9 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf02.hostedemail.com (Postfix) with ESMTP id 7D86580010 for ; Tue, 31 Dec 2024 16:29:58 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735662634; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HR7CArQyxmAYVZENgfZFXxvYRDZ+39SeDd6/ixhGHsw=; b=2rhlVSylFlL29sOneK5I3qxGXu6FViJ2/Od5G2WAjBSkLjjr9+8dpTQSrV3wQ1z8psnQ4P 9eqygxKmRw4dKVITIy776VHyvGuYSrpYNq/tiBhw5uAjNxFjjEQCj7zwJ7+pn3p7wp/bFU gSP3BwFOEDrudeXCSrWJPzyymBlpcpQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735662634; a=rsa-sha256; cv=none; b=BkCHeiAeW6R54YjUGMQFr8aK+/zFJQS4kraszb4A+TSDvf1Xz01IUB/Td/Ze6YJSydRNIQ fnhLcnHu0eMY/1g9lhPP0qONVDAWrsfhI2fv34nKnk3ac2jgYxiWuq3XhIEDXdm/rqF9rK 7OER2/j6ifL3kdyv0OyxFBJW5khQOpk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tSf8q-000000003eV-2OhO; Tue, 31 Dec 2024 11:30:48 -0500 Message-ID: <8aa196d4c781444cf55993faea56161b926cb311.camel@surriel.com> Subject: Re: [PATCH 01/12] x86/mm: make MMU_GATHER_RCU_TABLE_FREE unconditional From: Rik van Riel To: Borislav Petkov Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org Date: Tue, 31 Dec 2024 11:30:48 -0500 In-Reply-To: <20241231161931.GFZ3QZk8kSgiImE90y@fat_crate.local> References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-2-riel@surriel.com> <20241230184118.GMZ3LpTn3dHvu_bq-p@fat_crate.local> <20241231161931.GFZ3QZk8kSgiImE90y@fat_crate.local> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspamd-Queue-Id: 7D86580010 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 3kdxh4y7uquaouiqt8sfupk39qewxtdo X-HE-Tag: 1735662598-417013 X-HE-Meta: U2FsdGVkX19fl7uLgl2FDGvmknODATc7L+pvcP6sQi4/DmSnF/rSXgmvztPgBTqbvW9MSdrnhr2W2Ac47oRv1NnognbwBswySdEeqJ+RuNPdDGW5rBv+hSAV1d/WKp/BvL33MByx7hiJErNXvvzKQYQYbrRtMGx11Awc3jpMMaaw7/ix9TFdJDo2snJ4CNnbGvycSTbJfV01008tIu6nrNUIIqX6jr/6nyfVM10PgZ/uYzWyDolLQZ9sRkp+u4l69pI2h9JYgFnLQtN+n9xJ0CUfGRKpqZMq4Kptp0XczY8iFhkeNhQuPBEDObzZ1nhy6c+/B/TxA/qXZgsJjcTe0qB5QhXjYCq4Rc0NMzbYHr0ipL5kL7ZiZEp2/4vNKF4743wW+GzxrlPIYh8w3H2dm/ncEB30SjN+tjJommZzRluvXJa4hgXnfzEy8liu5FViaiXIjZxiRl5AFSWPqipyLRNyKZP7rHwoBxid03JFwSVio5WgYaMUB0qiEtWO0vOJd1R92J3yesbzvirJan1ma+XjDdn7jga/plycwDqWa/sQ2JRmAx08CLrYmHbc1beByC60gXoLZpgVZ7ASE7qKD1ryTIJMth3XSIVv3hsObKaVeeVTxwDvC3ApXK4LrYmYxVH12Ie7DcD2cLw9nXb46q1QLHifdBlLCHk7mVA98/QV4jwNWJrggV1y7mj/taapvk2ppotWhDEG+q/iTV15GTtrCgoJvsiVmmvr2eDQpcPcwZA0hB1k27BoRenbv4GIrp781ZZ8h/DPlWObjorDD5ZRt619oBWU7rp90jSyUNcH8rjAHU65EfslDiAl2ZBFJWXQYb4JQwzo8wXT6WN5TC1CNHFhA24TVgaa+5b65qQE5BBqiM0/RX79FpIYyke5LxVgZ3eaf/AMK4Bzb1QOvV+X30Kaz9tr4gnUdqBGUEAJRnoA5fuhn8wZE9i72H/q+0FCfWZ/kiT+S1aXXhh OWgjlN7N b07qR2x+5kU5Zhj04k+Qo5WV7NGyW9ESqQi+CuFIA3BqODFxDo6mXbFFY0JRN34poJ0dr+Hj7gDRXVlEn5QRUlE/BZnwkW0RNmyjCLii1MtYUSRfAnF1xVjJtltDdCNMapA/h1avClQMxbqoDe6fJdiV79uvZefh+9Bjc76Bo1iNsq2Jw1L6e0n32D2J8NHBI+XvXiEXq7REUXdwHXTV7LwbyO+hJ1suqqy/wPzZcWNfGjMgKhCEWlrTVHP8dha3W+TrxcsumlmS1pIMUDlBJVvGRP5hBGWdmPRrcrkrkKOdkF+0krR0AlPq5ylVVhFhsRu6rgWC5eg6+gqYpvnf2v9WxMNUX5BOKxn/NZUCop4Yv3LIhgMipYRcllXxloyXyH4tF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2024-12-31 at 17:19 +0100, Borislav Petkov wrote: > On Tue, Dec 31, 2024 at 11:11:51AM -0500, Rik van Riel wrote: > > Will do. Between your feedback, the suggestions > > from Qi and Nadav, and the kernel test robot > > flagging some build issues without CONFIG_CPU_SUP_AMD, > > there's enough to warrant a v4 :) >=20 > Yes, just take your time pls. I need to get through the rest, first, > in the > coming days. >=20 I'm incorporating the feedback I have so far, and will test with those improvements. I'll wait for you to finish making your way through before coming up with a v4 :) I do have a question about the second to last patch "x86/mm: enable AMD translation cache extensions" It looks like with this patch the translation cache extensions get enabled (when I read back the MSR), but the AMD manual suggests I may need to enable EFER.TCE separately on every CPU? --=20 All Rights Reversed.