From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7F53C021A4 for ; Mon, 24 Feb 2025 19:02:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C5F528000D; Mon, 24 Feb 2025 14:02:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5765128000A; Mon, 24 Feb 2025 14:02:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F05628000D; Mon, 24 Feb 2025 14:02:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 20BD128000A for ; Mon, 24 Feb 2025 14:02:01 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E5490161BD4 for ; Mon, 24 Feb 2025 19:01:59 +0000 (UTC) X-FDA: 83155757958.01.E894D2A Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by imf27.hostedemail.com (Postfix) with ESMTP id 52BB240030 for ; Mon, 24 Feb 2025 19:01:57 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aTMHYang; spf=pass (imf27.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.18 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740423717; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B4SMGfTNbkHaAnlMW09qtop5ahOuOzYGDWP4MEmktVY=; b=1pg9X27UWraWD0bVmhVo99iwRJ6N9sDHq6RewcWc3r+4j2Ov/z+VTOTjsk4BQ/QuN7IEZI 0uHAXqBCNC8MwV4Ezv66lwXcrCWhvtedLC31stVt5Az9hCDjWogDj+aq8Q5vhLJSKsXuBT xpKCfwhGg3tDbpQDdHW88RcJsvhQrIQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740423717; a=rsa-sha256; cv=none; b=AGHqFfFEE0CcMiiPNuOULtimlxba9GRF4bJ9XlLAPYs4Cq/RCkPMFSvSgIHq1WC9u1rv2E 4o7R+xh3oIHwUomYfwfLeL7QaTpIrdBFfiELWaXZHnEP988c3m5DtkBR/iIj0LN5y42eCs 7hgZjJsBBeWxqc90FDzP4u3DVYdXrPE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=aTMHYang; spf=pass (imf27.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.18 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740423717; x=1771959717; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ZUGjcDPk2Lo1x5UuXUtooRPeqqMudesG2iSo/3PqBNY=; b=aTMHYang9bWHCTtxE1u0VB4V1xbgEZ2Zji7ZkhLiNExgG1KI/E7uo0XR t1tol2ZVtgPeSeS9il1+ufkZ7PV6qsL9o93HqvkTckxNArfMMzMCOVHiT F53URMN81n29W+5p3DaPG1GWD4fxzhRiKIk8Wx9aRCFhGLOqmegw+veKC xYEocZWtahl0rGzsPK7UmJhXuJLklJrE7YdBB5+e30vYrgLZ21k5cQF2P 84Rx9sR/euHf8p7AVEfKzs6G1ee5W5yp0oBhmeFx0dee102KFcSsvZBWq bB2jtZ5l/7ZP7Rsb3g3uShpmV5UtRgOVaigXF8Cf0swhpMM4YKnXvKPbx A==; X-CSE-ConnectionGUID: Vws8EVtmTJm2YI+x1a7PIA== X-CSE-MsgGUID: xdGDgyljSrOfeqA5PPRuwQ== X-IronPort-AV: E=McAfee;i="6700,10204,11355"; a="40435088" X-IronPort-AV: E=Sophos;i="6.13,312,1732608000"; d="scan'208";a="40435088" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2025 11:01:55 -0800 X-CSE-ConnectionGUID: NzDkPt2xT76cm1IZtOQnxw== X-CSE-MsgGUID: nZHhHkOHQKi1ukro/1E7lQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="116637223" Received: from cmdeoliv-mobl4.amr.corp.intel.com (HELO [10.125.111.40]) ([10.125.111.40]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2025 11:01:54 -0800 Message-ID: <8a9c918d-7350-4fda-a2fa-7f613b71d047@intel.com> Date: Mon, 24 Feb 2025 11:02:01 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/7] mseal, system mappings: kernel config and header change To: Kees Cook Cc: Jeff Xu , akpm@linux-foundation.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, adhemerval.zanella@linaro.org, oleg@redhat.com, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com References: <20250224174513.3600914-1-jeffxu@google.com> <20250224174513.3600914-2-jeffxu@google.com> <443992d7-f694-4e46-b120-545350a5d598@intel.com> <385e1498-2444-4a7a-a1b0-0013b0b8fd68@intel.com> <202502241053.1FF33D5B0@keescook> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <202502241053.1FF33D5B0@keescook> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 52BB240030 X-Rspamd-Server: rspam07 X-Stat-Signature: rcwn5zcpo6kqq8xqruqmd3seg6x3bqjs X-HE-Tag: 1740423717-179289 X-HE-Meta: U2FsdGVkX1/l7KppPi+jhomUDFK50mVyZYGbiFRTvVne1oZ1MsGeMOsh0PvQEI+OBxLT5MHltF8nMHaj4/vMpnnkbfPqDTpPCFuW9ckvVnqGRloQdnCp6LpGL5z7K8d1eBSKtVVzoWkPVKzmmiFKQn7ehvZ06msMvpMikQdEoid3Xwl1IoG1Iffh4jzXRtSYPS+7uXrXmoTz0fKyf5siqC0B6Ac/VXfbxIRsSwlOOO1ppd9jyzGOq8NwgVqUIrxk/++/UniqeaFinR0mzY9Ku7p8bD47cUsWiQhmoxhsg4gAYsfiM7gmw3Vfr17nsRr08hzMlqIQVtUQpHQ0Ss2b+nOdSOURP6RKYN6QKG7QJmXot+nISKHrP5DlMMZx0vpumFZDnSrCWUsxAXleJYnPZu+3+xLaP4MNEP/fwBNGdNudk5WeUDpROKidXVHqF012eSoCCxme170F6Pb+pvcXHY2SQ/dJRox06i2H0wtt3TlmCEbd4U5U+xKFJ16NEblMj2h5I6HY+78EnbAudH1PBa97ddyEyE+yTUGXujCq1ynWOJ13lp7o/0eEWN2xy1dOWOoNfnmjN0a92Rdedav/jsImjY1Mv3osxktgEqNszvkq+AI4qYk7Rkj2RKGMZBUkZl3AkTvLhBYJHaRfTtA5kLWiSDe6s0G91fkEcaS0OQ9V3O9T2ogWyVvhXwiFGNwPNYL/i0AtWPXA8uFaysF7nQDaNlN68B+kD/QqKFVQWCqXyx92xCqGEGQvLBlVramR8hR98HEo1rCzdO1hJcV5Z6SDHFxxVAXGMVtpreYuDsnbqSU7ary3qlhSEaAyRmAxdqzBvFKCOzrMIjIXxdVUeya2re4wn1InzsZN5q/69AZFNb+C6B6DI/qjjXqFuKJQXzhvVoJEkthZVSK86i7cT2wP4yAWZcAV4q9qNZxNWGECdeBb8oYKZ3WJxjUJZXQ74K2fHbjjdfxbZRAvWAA LMFLUzGj RFSAzE7whKvMgrY7JYVINaCoSwnzsJQlhsq3AR+Pb6PYMOfret+CmGSDydPrcEf9rgtvR7oz23NI6B+6FV6XXZpB1p42bkrHu2AHSJDLaFIggGlFiEU0E011pVZqKdhHQ6RucAW9dSh18QT4zALxCUTTUL/P/9kTvSrnWR+ay/LkaKGc1Q+LaqAlqj7D+jvK5A/I8zDICkSoo1QnXdCF0L04OpOwhU6FzPpnaKrU+DE3pCXHssVKdWAz6kAJobzguHsIcPlFvmntoouhTOI8CdhSp7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/24/25 10:55, Kees Cook wrote: >> That logic is reasonable. But it's different from the _vast_ majority of >> other flags. >> >> So what justifies VM_SEALED being so different? It's leading to pretty >> objectively ugly code in this series. > Note that VM_SEALED is the "is this VMA sealed?" bit itself. The define > for "should we perform system mapping sealing?" is intentionally separate > here, so that it can be Kconfig and per-arch toggled, etc. Ahh, makes sense. > As for the name, I have no strong opinion. Perhaps VM_SEALED_SYSTEM_MAPPING ? Yeah, that'd work. Just something more consistent with the existing naming and more compact. I think: VM_SEALED_SYS would fit in nicely.