From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91514C352A1 for ; Tue, 6 Dec 2022 21:48:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BFE68E0003; Tue, 6 Dec 2022 16:48:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9709C8E0001; Tue, 6 Dec 2022 16:48:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 838928E0003; Tue, 6 Dec 2022 16:48:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 762618E0001 for ; Tue, 6 Dec 2022 16:48:47 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5054D1608FF for ; Tue, 6 Dec 2022 21:48:47 +0000 (UTC) X-FDA: 80213221494.23.BCB67F8 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf27.hostedemail.com (Postfix) with ESMTP id C3F6C40008 for ; Tue, 6 Dec 2022 21:48:45 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XarreB7m; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=862gYlhO; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670363326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8eObdsh0f1WoSow7cySCAshfEk8V655iOUfOT8wA5uY=; b=1+g0JNsuWabAVARTZ1o+qrrzvn1ljbD5IgfkptSXZbjriV1ZRpaVdsw8wJHhXYJfP4aSJI lP6OsRkAZZrgGzqw1yJgCxPPmXdO6HjdGeNWdfZntvJSAhMZrqdzPtYajhh3lhXSP80kBc 6ju+v91c8WXSKdVFx0iZaySlDNI3KvI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XarreB7m; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=862gYlhO; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670363326; a=rsa-sha256; cv=none; b=ivKjxp1cvlnX+h0BDNX4pFBatWLB8/CES+QG4CVAyrkhu/rHcecQCpbygTvpBLtjHBrAp0 VRbf1TqnouA8P6MzFJ9U8EA9Einsozo8nuxGpdHSYn6z/2oALQXStH7JmYHJig2LZKTDPH IQdVW+ywRwGG/wqr16095vXa7Vh7meo= Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 47B7021C31; Tue, 6 Dec 2022 21:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1670363324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8eObdsh0f1WoSow7cySCAshfEk8V655iOUfOT8wA5uY=; b=XarreB7m60SF4+AcLNKNd2OUP5Rxq4StRg05ASDpWWcaMCdHSWg+2KAGp/bOcpp1buKqm2 qbuo9W28yEkDZF7fG5zxFlSnZy41WYMQBI71qaJ3h/eFjcf/L9lCQes4uWhmqbhADmGPvK KxTmFOUv8uyTem0I8x0cni6INneOTuI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1670363324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8eObdsh0f1WoSow7cySCAshfEk8V655iOUfOT8wA5uY=; b=862gYlhO+Lrnm8WSWXalMv6GF93TCP8bc6LZfvvVoVJBr/bxQYjgvv15eVqYaDeBDfj0Yo eSfPgMPGRFYbD8Aw== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 28D5F13326; Tue, 6 Dec 2022 21:48:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id KnMzCby4j2OTdAAAGKfGzw (envelope-from ); Tue, 06 Dec 2022 21:48:44 +0000 Message-ID: <8a8f5758-365e-d716-de06-3963d7b7ec43@suse.cz> Date: Tue, 6 Dec 2022 22:48:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] mm: do not show ?? for VM_LOCKONFAULT pages To: "Jason A. Donenfeld" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Eric B Munson , "Kirill A . Shutemov" , Andrew Morton References: <20221205173007.580210-1-Jason@zx2c4.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <20221205173007.580210-1-Jason@zx2c4.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C3F6C40008 X-Stat-Signature: popx4b9x86wk1pa5ydogymfp71jbhego X-Rspam-User: X-Spamd-Result: default: False [-2.24 / 9.00]; BAYES_HAM(-2.84)[91.06%]; SUBJECT_HAS_UNDERSCORES(1.00)[]; R_SPF_ALLOW(-0.20)[+ip4:195.135.220.0/24]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; DKIM_TRACE(0.00)[suse.cz:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_THREE(0.00)[4]; DMARC_NA(0.00)[suse.cz]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; ARC_NA(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; SUBJECT_HAS_QUESTION(0.00)[] X-Rspamd-Server: rspam08 X-HE-Tag: 1670363325-768955 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/5/22 18:30, Jason A. Donenfeld wrote: > When VM_LOCKONFAULT was added, /proc/PID/smaps wasn't hooked up to it, > so looking at /proc/PID/smaps, it shows '??' instead of something > intelligable. This can be reached by userspace by simply calling > `mlock2(..., MLOCK_ONFAULT);`. > > Fix this by adding "lf" to denote VM_LOCKONFAULT. > > Cc: Eric B Munson > Cc: Kirill A. Shutemov > Cc: Vlastimil Babka > Cc: Andrew Morton > Fixes: de60f5f10c58 ("mm: introduce VM_LOCKONFAULT") > Signed-off-by: Jason A. Donenfeld Acked-by: Vlastimil Babka > --- > fs/proc/task_mmu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 8a74cdcc9af0..60851e96530b 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -667,6 +667,7 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma) > [ilog2(VM_RAND_READ)] = "rr", > [ilog2(VM_DONTCOPY)] = "dc", > [ilog2(VM_DONTEXPAND)] = "de", > + [ilog2(VM_LOCKONFAULT)] = "lf", > [ilog2(VM_ACCOUNT)] = "ac", > [ilog2(VM_NORESERVE)] = "nr", > [ilog2(VM_HUGETLB)] = "ht",