From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A7F6CD11C2 for ; Wed, 10 Apr 2024 12:48:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D89F6B0087; Wed, 10 Apr 2024 08:48:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86E8D6B0088; Wed, 10 Apr 2024 08:48:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 728FD6B0089; Wed, 10 Apr 2024 08:48:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 56CEE6B0087 for ; Wed, 10 Apr 2024 08:48:36 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 144BFA103C for ; Wed, 10 Apr 2024 12:48:36 +0000 (UTC) X-FDA: 81993601032.09.24DF00E Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf30.hostedemail.com (Postfix) with ESMTP id 471498000B for ; Wed, 10 Apr 2024 12:48:32 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712753314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gvsrp/VbXgMT97mGJBpYedK6cIU+qzEVbrqRPmB6Ffs=; b=spufVEqJNWNXiwc1Xv6705hUMYVnSVqe9H4Eb/vU1JhSs7oq4b+a2oofn7NHzIHckpTQg4 Cmc/zehlv24+nC+AsElvM2Ri8Mfavh727KGD22YOx62V+xRymT/ve8RpUHRqU2av9H+A5Z mo6Qx3j80rmK1XUYAytBbBnorQITag0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712753314; a=rsa-sha256; cv=none; b=I5prTMCMEF4RSu3Mvau5GOqICLgDn4mrn35sTScE+KLoWo3jkoLJtSxLof0SmnK+xjw8bS SwRxsByRo6vaCj6Bn7AYT/dqy0OwWxwXeShl5UZ+2mLFoMcvt4B0mHZpUY0mJnpcTguAxv 6dmNx/rurkfLkdz8hzKtFBxwolT228Y= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4VF2cK27dWz2NW6B; Wed, 10 Apr 2024 20:45:37 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 18FC01A0172; Wed, 10 Apr 2024 20:48:29 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 10 Apr 2024 20:48:28 +0800 Message-ID: <8a695c3f-a5eb-4012-a14c-1d76ad79c0dc@huawei.com> Date: Wed, 10 Apr 2024 20:48:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: mm: drop VM_FAULT_BADMAP/VM_FAULT_BADACCESS Content-Language: en-US To: Cristian Marussi CC: Aishwarya TCV , , , Will Deacon , Catalin Marinas , Russell King , Andrew Morton , Mark Brown References: <20240407081211.2292362-1-wangkefeng.wang@huawei.com> <20240407081211.2292362-2-wangkefeng.wang@huawei.com> <681e3bf8-dedf-469e-8fd3-0a67b8e6e625@arm.com> <0977b553-b0ae-4e4b-8cb4-007204381c0b@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Queue-Id: 471498000B X-Rspam-User: X-Stat-Signature: ej7bpm94mhrusym3gzs8yw9f8rkdjt5k X-Rspamd-Server: rspam03 X-HE-Tag: 1712753312-743295 X-HE-Meta: U2FsdGVkX19py9aYXbw4o5mu+KcfmkH0ya94jP5NzEiK4QitwgbfPSHZHG6tSYp49zri5BD4QfcdOAEyk4fZpy55SQJShZnWfrI/XAub0tVulae7Mjl3N0LUYClGChsJ1BdOD5A8a/fS/e6hzJl8Jlrtlx9ybkWsSWfO92O1/KddnyrbltMNTOVsQDUEHlLw0GKHheW7p78Cc+idb7pnLAEircO/6RTmQjg8VpeGNfsk9f1lGwJi8fagBpxpwzF3NnHcXOEqZL8gLr5wwsE1qvQjihj+2eYNG/aN9Hr1T6zzhwCOuWB+fcpLxOrV1iFwPTO16qjQ2jURjbkDRFbz8xxD8EeEwGaCgdldTscfdF7CJZ4MLIb5Y5e+rDFG+sgCSNs9UcaNW8MOoc88RS8N43FWIz+ReCoepjWGQjlVxOvz20QRJ99nui5AJqUN1oQ9puYRf7AgK6cUPFzc/cbAyLx6LqOVJ+nlZhpSFrSv+JudRBzHClssXQgFl06Ju8TWLJMo+blXO2pbfERGoDqBPpM7SXkIsRtN7Mb3qmrjTxbSRl8ipYIWIoEqJRXu63rl5N/lqDMaQbjDFOIrssEwOV8pZG54Kftt5z0IKME8r0tffGtpW+jitxs3x9K4mpPDxxCUGMVD62gw2UgnR7msvpk+YjO3e9mbLElWRdC67ngpHsdwLrDAlNTa/CCI4XurHQji+HXPJL3jP8ul6u/c8XJ/HlFVbJyKpnT0DRZ79txzPRKO3p4LNZ9GyOkHhdXajG3oo1ZKIKyeDS9bxMpaeuK3Z8cLVP/sNcq9KclrfjVhVpkRSlctBII8RkOA8YxavlNKa+yH0R4QasfozFsaYhSYsu8xiErIH1pR8i7sobr9V89genoZpjj527onP4OtlioXc/nP259rrWRauH9zL/sxssw3Nyhg6Tzc1rlY8PkkafflThqghKPcOuwfmx2mn+Do058/JRqT5nVN9v/ Tdz9Wr/+ vZ5GT0g1ThJ1xZ4f9KBKUUsePGN8jr4ukrMz0byDKw1/Rt1VRjPbXbVyr4btipqb7/2byzL1CQsaiMmg9BEGmNRi245u5aaAAyEjlrtM2I72koAw/J4vz4vJNs+y8KPHZgIGOSwzhYZc8HbMgqJ65SG8fxi+wo3bPHDID7UjLxD16MpbDCE+5tC1ytCpSaQJ2MgoBGGBwaD3XsqcwUe6QanfQdafMVhGMpwe9FX3NxoMsjNs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/10 20:39, Cristian Marussi wrote: > On Wed, Apr 10, 2024 at 07:53:21PM +0800, Kefeng Wang wrote: >> >> >> On 2024/4/10 19:24, Aishwarya TCV wrote: >>> > > Hi, > >>> >>> On 07/04/2024 09:12, Kefeng Wang wrote: >>>> If bad map or access, directly set si_code to SEGV_MAPRR or SEGV_ACCERR, >>>> also set fault to 0 and goto error handling, which make us to drop the >>>> arch's special vm fault reason. >>>> >>>> Signed-off-by: Kefeng Wang >>>> --- >>>> arch/arm64/mm/fault.c | 41 ++++++++++++++++++----------------------- >>>> 1 file changed, 18 insertions(+), 23 deletions(-) >>> >>> Hi Kefeng, >>> >>> While running LTP test suite, I observed that few test cases are unable >>> to kill exe when run against next-master(next-20240409) kernel with >>> Arm64 on JUNO in our CI. I can send the full logs if required, but it >>> doesn't say much. >> >> Sorry about it, as Catalin pointed, there is issue in this patch, and >> I replied today, could you help to test with following changes, many thanks. >> >> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c >> index 61a2acae0dca..451ba7cbd5ad 100644 >> --- a/arch/arm64/mm/fault.c >> +++ b/arch/arm64/mm/fault.c >> @@ -604,6 +604,7 @@ static int __kprobes do_page_fault(unsigned long far, >> unsigned long esr, >> } >> >> if (!(vma->vm_flags & vm_flags)) { >> + mmap_read_unlock(mm); >> fault = 0; >> si_code = SEGV_ACCERR; >> goto bad_area; >> @@ -632,6 +633,7 @@ static int __kprobes do_page_fault(unsigned long far, >> unsigned long esr, >> if (likely(!(fault & VM_FAULT_ERROR))) >> return 0; >> >> + si_code = SEGV_MAPERR; >> bad_area: >> /* >> * If we are in kernel mode at this point, we have no context to >> > > On my JUNO setup, the above patch solves the 'un-killable tests' issues and > all the previously failing tests passes. (I have NOT run the full LTP > test-suite, though, only replayed the tests that were failing before as > mentioned by Aishwarya) Thanks, I will resend v2, but let's wait for Catalin to see if there is any other opinion. > > Thanks, > Cristian