From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 515AEC25B76 for ; Wed, 5 Jun 2024 07:47:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4DB36B0093; Wed, 5 Jun 2024 03:47:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFE266B0098; Wed, 5 Jun 2024 03:47:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9DFE6B009C; Wed, 5 Jun 2024 03:47:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8E0C56B0093 for ; Wed, 5 Jun 2024 03:47:19 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id ED9E1811C8 for ; Wed, 5 Jun 2024 07:47:18 +0000 (UTC) X-FDA: 82196054556.03.4CCE37C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 8F5CB100014 for ; Wed, 5 Jun 2024 07:47:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BRNbz3E1; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717573636; a=rsa-sha256; cv=none; b=42V3HfVzqkgY59c+cCBIslD7288XwHaIt0NuFJ8n5+XcfZATiBlIiBWUptWDuhzzDe5MjE NMajDAiuJE34Epj8h8dup/URjbD9nLk8zjmRJ0+PaD5rcQZouPjUWtXbe+7/m/bRwCc5tm 4wtWxz6TLnwsw3U/YCYw4NDJytUmQAg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BRNbz3E1; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717573636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PpPer5HDsHQEuYFwEstuKaB5aiI/RjnExa6+wFQamo8=; b=eHoQL8QAHpULysV6HB/uycaWlZE/jh9VUhXiHiAvtV3TXvuufMNT3Y2suysqOLEOF2+NYF fsMmjpOkva30VLphFoZUh1m2dUk74utNHVDrUq/6p03gUo9pYmyTq57x455FzpM2+BkmIg l57yJj2vc1yDvxjQbdKB5oyJqt55L48= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717573635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PpPer5HDsHQEuYFwEstuKaB5aiI/RjnExa6+wFQamo8=; b=BRNbz3E1SEkPFskV7xftNMzBw+F46nA4Cq5ue4qokkSwMFi/eNdw2nKsJFyDVBb+Q7bXUl MhrkGL5HK/UTkiba2FDSHLI2e1wLoDLd6OSsOYEh90ARrhS0HutOQo23AY6aNYr6pXae0L PI6ChodwBlqXcXzIbNpegBk20nD6pTs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-271-5ewtoxBmM5-uScZOaxJw5A-1; Wed, 05 Jun 2024 03:47:13 -0400 X-MC-Unique: 5ewtoxBmM5-uScZOaxJw5A-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4212adbe3b6so38996795e9.2 for ; Wed, 05 Jun 2024 00:47:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717573633; x=1718178433; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PpPer5HDsHQEuYFwEstuKaB5aiI/RjnExa6+wFQamo8=; b=r8nm7PTt9uzkiewR43bxgIWExpDX7OkKGz9ecO8RlUAC3wNIqRT1dKmjgSt5es9/ar chVNqL2NOjCHIOouO/M6x1eO0DiW0Y6iiwJLubqF+KQIpwKNh33s52hZLl+XjlybX0DK 9tY+C6IxnD+SxigobUzImuo0/U8l95Ut7Z7VAXRDjaj3TMl/RfDyjNGefuQ29PqyusSw 5lzlBrVax0N2mrw6WwYpeKC3Es6CCZr33wS8EEw0tIWt0wfEIEThwVaMmjU6beddRWuy qaB0tTcj4HWH6IlzZM8tbxSgsV+3LMBKYHCdhpUsj9jvpi1Vy2PjnOlHlqxF/vrr1X3V Jr8g== X-Forwarded-Encrypted: i=1; AJvYcCX88/rmBIhrl+gLSB1+CbfOCqBoAQfXt5NBBNRpMqYLhjsCLfAAsp4RKuP3dGKpl3Ctcw3frbPktPy7yUQByjWQ1Lk= X-Gm-Message-State: AOJu0Yw0PAKnEdtEFV91rh78g+uhfxGXfVdV6R4ThbNYhLa7XTdvE5/1 PRruGYgXDE4U5EEhWqS9B661sd8MkHwb0Hlm3sgw9mov7acpproFXkHzU5rQW2GlyON/YKijKzG x03JoEaj0VLXPGyFxvCI0Jr4QSMejg3mU76KC8dOtCiHzyDBe X-Received: by 2002:a05:600c:4928:b0:421:1f6f:3e15 with SMTP id 5b1f17b1804b1-421562e9506mr13100915e9.16.1717573632784; Wed, 05 Jun 2024 00:47:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGHpaCM44skKTGZ3djOclrWxKM7oM/OanykiAjTZmoCoWqjlod1zN2vRu0MXgPuT+hYNSuCkQ== X-Received: by 2002:a05:600c:4928:b0:421:1f6f:3e15 with SMTP id 5b1f17b1804b1-421562e9506mr13100695e9.16.1717573632337; Wed, 05 Jun 2024 00:47:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:3100:19a8:d898:8e69:6aff? (p200300cbc706310019a8d8988e696aff.dip0.t-ipconnect.de. [2003:cb:c706:3100:19a8:d898:8e69:6aff]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42158141104sm10487915e9.48.2024.06.05.00.47.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 00:47:11 -0700 (PDT) Message-ID: <8a614d01-191e-45d1-b6b6-c36ec0bd9e5a@redhat.com> Date: Wed, 5 Jun 2024 09:47:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/10] mm/ksm: skip subpages of compound pages To: Alex Shi , Matthew Wilcox , alexs@kernel.org Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, izik.eidus@ravellosystems.com, aarcange@redhat.com, chrisw@sous-sol.org, hughd@google.com References: <20240604042454.2012091-1-alexs@kernel.org> <20240604042454.2012091-3-alexs@kernel.org> <5bb3bbf6-6a22-449f-96f1-b9476357f284@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <5bb3bbf6-6a22-449f-96f1-b9476357f284@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8F5CB100014 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: snopmc39j7m78kc5wspp8ge3sb4x5pk3 X-HE-Tag: 1717573636-879018 X-HE-Meta: U2FsdGVkX18LvgcPVfn6LQC+EpE30uo3hfgncm4NMupBqXbnjnNv/1q7joP75IXHfvKY79RaDpU9bKe94D/AkzrJQBPLgkYdyl5CuhUmCYARCdESXhhSEjiB7ie4022yZjt+zgTbt3St9aC6nrmDhJzZaW89yXXA54yPBw5uTzSh5JxQGRK8QR5orf/dcA7R77aES6uksdBtsn7tlqj6EuuIS3OKgZQDsaXUjShmS1gjdJqJbOK+1IFMcRlu7TWyHajkvwlFsupYbeWE3meZOKspBVUQigdrjmEZfXo//HY4kX3Tes6HkIbd+VojfgZ5rq4a65SM04plA7wGoIDlMxmKW3YDBaQ8A7HADXJu/aHJNOUyFfpfQzZ2GBVoeNs6nPJY8xdGlkSsmW0asNmZrUgEMJEJNB2wq+T1nLDTXEOZLYa6lw/opyg8VJTN2Spni31RzFjrMCDK8QjISN2DRauKsfk8Z9WepjN1WeLYe2gpPdqsqv9U3xJY9LkE7JLEU+y0qw5dnVwrUHf7fNylKZ/ldcabYoZdoOgYBAZuWzVsS2DYjnduGznHQxpZxZFJhORumJ0O4jaym87LC3WzoLe8wtxe3qoFsEgENlo9L4ZHDxPqjaRLJ0qSS9Q0EIPNgUV8sG/KCygWJ4ja/By102bjNKLT7P+Kg6dGejrN64XGYhBZreYI1InlhHUiKhK9qdgmoo124tipovMc+rmK6PCDlt1BVpfFy14yw5Dp8AzGlqwn62YETPFTxWTsKawjJldFAfpsGZdzv4eMR6cBhvO6+lTncIhQJL0QFQtjGNu+9X5HY8F4T0gFNA6Brpkf/eEccJUOgzmnUM6kXgpU9ANlsKzl7JpUBRIc3U+JhdfrYkM9scUY0ez6fXvaa0G814Yt0KQNtptqOl4UCtFBFotTmPnh5kKcmurlSW41Ry5e0c8w6pxlVhf4TEyKrFGcx+pGX7oC024Fb+4stiO IdRGp4Zz sOlMrz3T/m5vVTwRUWyw5+Ex1Ixwc/e1FMS8RNdomrCs7UrQ7vtkl5SH8vM6ZEZ933Tez417w7D4Y+hvX+zZ1F47fPTLB9b8k7bl2/rhuSTfzYD1nHyh1sy7iMHOFLXNB5CleUo0h4gNbZrEAigVp7W33gj/x/c7GxEOdAtI8y4p9/vFu0CCJJuJx5bjlgIdENnWWtY+X/WpsysqVMHiIGMsY/Y8xsuMQMeIYVaiYRNdlMxFFRU3Ak9mfz34MeGk9C4G/8A86inYwFlJO1Evzn3uhcsrp4LkIjDsjzF+kBIkiL2Tye0GYSUJy9f/navGNdbXPSuAxqCUP+WxA/SEH979amqv4QkoDmL+rOeGmvLTxUmmNfdTCHHOC7JkKVJiuSgcXJRk3GfNJB5MhDWp5zHYei7dJ4s9+MKJMJNghd2XlUDq92VSXPTomInK7PUOFlbWCTd8Aqj1rbsyMvwdi+F4y51SJxCUP00RpMTr1Fj/BbtIi9rnYf3hplBAcpZdN4xW5c5nCF858HxHa0SAfGKQilizyjD/6vJjVJHPxA1MJWYK1VeFvo7BQ1cjd8W01wrfHzoWD9DnsgbA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.24 08:14, Alex Shi wrote: > > > On 6/5/24 11:52 AM, Matthew Wilcox wrote: >> On Tue, Jun 04, 2024 at 12:24:44PM +0800, alexs@kernel.org wrote: >>> From: "Alex Shi (tencent)" >>> >>> When a folio isn't fit for KSM, the subpages are unlikely to be good, >>> So let's skip the rest page checking to save some actions. >> >> Why would you say that is true? We have plenty of evidence that >> userspace allocators can allocate large folios, then use only the first >> few bytes, leaving many tail pages full of zeroes. > > Um, that do need tail pages... > Is there some way to use more folio in ksm? My take, and Willy can correct me if I am wrong: "struct page" is not going to away any time soon, but it might shrink at some point. That is, we can use the "struct page" pointer to point at a page frame, and use "struct folio" to lookup/manage the metadata. That is, use "struct page" when accessing the actual memory content (checksum, testing for identical content), but use the folio part when looking up metadata (folio_test_anon() etc). In the future we might want to replace the "struct page" pointer by an index into the folio, but that doesn't have to happen right now. For KSM, that would mean that you have a folio+page (late folio+index) pair when possibly dealing with large folios, but you can use a folio without a page when dealing with KSM folios, that are always small. -- Cheers, David / dhildenb