From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D883C6FD1D for ; Mon, 20 Mar 2023 10:30:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE8F36B0074; Mon, 20 Mar 2023 06:30:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C96AF6B0075; Mon, 20 Mar 2023 06:30:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5E4F6B0078; Mon, 20 Mar 2023 06:30:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A5BD96B0074 for ; Mon, 20 Mar 2023 06:30:28 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 73C461202FE for ; Mon, 20 Mar 2023 10:30:28 +0000 (UTC) X-FDA: 80588907336.25.2DBFA52 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 26600100005 for ; Mon, 20 Mar 2023 10:30:25 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HBH+LEJu; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679308226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BgE1X4ekUlT0hc9XsprdaHvSq6/U0b4NczzgHQA4c5o=; b=M0aEmPJqUhAQPyqbwEoDbo4GdsuxDRybxk8/3j6yjrJxg6KceXHJYstxigtr+9/Awc9ErT nGQdQxbrUMH7+U1P78HUeX/or9AGhI4Dg2phSlsTSaQS2glqHVH26gkAtgwVnh8+2kn8r8 Zs/OiE0C+tCpLk97gwpKeoSAT/NAXsk= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HBH+LEJu; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679308226; a=rsa-sha256; cv=none; b=x/xSqJv4viL+CyJyBx2TMo3jnhYuo0BNtvYZK0BNeE8mHCEy1TnDZbXLrugnDIBDSQPFWq pyM7UMhYeBWpITCtHTY7xncETdciiWKW8npSqgamxSE33PncCHCeZvdSfKyDOQywUFG7xY Oaz2lERlOnDP5R1za312M7PtX5Xpp/0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679308225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BgE1X4ekUlT0hc9XsprdaHvSq6/U0b4NczzgHQA4c5o=; b=HBH+LEJu5nKP2hQ5j/lmGhDU2oeg3EJx0Zl2minj/jmJrQAK2ZeeV5NsmMk0wcy5vZAAou /RLk7NiEE4gZtKXWVV8FqC+lBBRn5/0dsAJn2/gKrvrwpCA9EALMTJ22C88j2QFmHWkQjU jbd5Tz0MGWPQwCIhSgfOmKE3NYDvTDg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-186-bVGsAwZoMp--7bnwgFO1dQ-1; Mon, 20 Mar 2023 06:30:24 -0400 X-MC-Unique: bVGsAwZoMp--7bnwgFO1dQ-1 Received: by mail-wm1-f70.google.com with SMTP id bg13-20020a05600c3c8d00b003ed40f09355so5305594wmb.5 for ; Mon, 20 Mar 2023 03:30:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679308223; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BgE1X4ekUlT0hc9XsprdaHvSq6/U0b4NczzgHQA4c5o=; b=plrbtJHM1l4ROmCzkAG4Wzpu8K9cjR9nDvJpe8JCavR5Bkl7ZlA4CioUk49SUXkn6n 3kRTbforKrNR+10pjShFTKNMpNT2Pa1iL7ye5n/OR7yOwrjZAEFPP0LiHA2BDI+kj9qp wmIw9R4mA2JeU89pdVPKFWDCeht5/RK9xQ9t7dPSlZsW/a5+KnxuDx1v0gbqv6jCeMp+ XyAEURFJUD9GtVE0BslOeNctYKlUKUi5a0ab9wKfA+KT8CuygnNKH1fxET8nhXRGSVlm WSKhuGQkmZMyaP+hC4OZ7iBDc3rEfc5LlteDnuzY2qtCwqJALYjgTsUNqGe3WHKGKLGK ILhA== X-Gm-Message-State: AO0yUKX8m/S6VSlSO3EnrSHzTUGercB6AcIxnd6Wg5a/muSty+lkPhWq U/HXbwLoWEkhLF/XxjTm8YF2lPOKTrMy7z+djwa9uLroBXDu2BXCW5E+cgVedKZzXKj1svvJKmt 3u2JTCgqoP1c= X-Received: by 2002:a5d:504c:0:b0:2cd:f2c6:5d37 with SMTP id h12-20020a5d504c000000b002cdf2c65d37mr12507925wrt.5.1679308223078; Mon, 20 Mar 2023 03:30:23 -0700 (PDT) X-Google-Smtp-Source: AK7set/fN142O0jmW4iqCLPXtEiyw9GviYWHg1q3pkSYIopaetrIf+KQV8h0TcW9SYuysz31BfdDJw== X-Received: by 2002:a5d:504c:0:b0:2cd:f2c6:5d37 with SMTP id h12-20020a5d504c000000b002cdf2c65d37mr12507909wrt.5.1679308222659; Mon, 20 Mar 2023 03:30:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4100:a064:1ded:25ec:cf2f? (p200300cbc7024100a0641ded25eccf2f.dip0.t-ipconnect.de. [2003:cb:c702:4100:a064:1ded:25ec:cf2f]) by smtp.gmail.com with ESMTPSA id b7-20020a5d4b87000000b002cfe0ab1246sm8565121wrt.20.2023.03.20.03.30.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 03:30:21 -0700 (PDT) Message-ID: <8a461e44-7d24-5b5d-db04-e7fa85beeaa7@redhat.com> Date: Mon, 20 Mar 2023 11:30:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 02/15] mm/cma: move init_cma_reserved_pages() to cma.c and make it static To: Mike Rapoport , Andrew Morton Cc: Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org References: <20230319220008.2138576-1-rppt@kernel.org> <20230319220008.2138576-3-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230319220008.2138576-3-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 26600100005 X-Stat-Signature: zppszft3i1dxxy75mn57mua4wumrq5a6 X-Rspam-User: X-HE-Tag: 1679308225-317983 X-HE-Meta: U2FsdGVkX18wWDI7tGtZa/sJxO2me0IMmdGTr5e9Ku8OwIGgAwQJ3ztCzkiMZN2i87tW5nFFbCFApa54S8Xqu9e90rdHKECXcD7w+Nh9EmQmdHYSoD55hAhRIlv0rjBBRAlhU/zHoGv4eUyA/oZvGEqgnAtUAZiFN+0y6bAHu52LbeiJQTMYVsHIcPEdfEbkkummgjiqNwRxL4tQ3rHMlLDu/es9T9/niQalQqb6KfzqbGiv1yHwDKxvNlA7sYgxdMUbxIUrHZllly8ZG35Xahdfd25TrttNHpTZ8HLUNSQ5RaL/54DKTYIBHuZEHVjC1Zflr6T9BO8lj3ypMoP20SV8cMl1iHfiFEEVMYF47TSKyakCqNwgBIDcF5ywNptZzHOTvqnehrw0b9N3+tpq78imFTXk/PffRwoBSAWS6RUeWOVOTeqrSn3qhs0tNeGr3XV6N4ixS07fzx4iV4ZOsLN0fWiEmfQ0/3NCoX2+J92GSsVakYokJbYSDtT7y44GfsTwXWIfZa9PTVyTwe1KvFlYvlaUhb3S5a7LgkFgNjzmAGJsj4RsRcqxDymYb7KxviFbbSl287k9fN2a8reigG3CgwV/F1sxLT9gGfKtJ+bvWKPok0rkFiVWp05wW86P4stjBUyio6YdbaFJVEfpbEG/XmkgW5z7AAFvTpPOPBhfouMeU5ssoXXdbB3x7SJwdT2bjGRQsTWZORINBsO0AMOugvlG5NbMCHh3wPhBSbj/1j//SrgR77zU3gotdrzqDRXzY3Xasq+hzIVNScxn0d6ok2VjmZEKbNvgC4zIRuSsX/JI4hlb859kNT1K3XjsYOhtBtUWMcQzYIkHyCPI+JXDGCUXS7rfxENxre8dfT11satePXV+XY4AMXv2oRX9TH+fZsxnE0edshocanD7SYvSwLLGvw8n2c6cFrEHejLpgTBm058g5Gx8Hwgyd2nU+ojIUQXeOfVW1MU1Ayu Sy3po4Mc aRHLdfOu3xiH/2qqNBX2XcBbmaDa7awg/LSmHXGgM8RKNn9LwVdpoRg3GYCcSgJZUfbViYsBnG52A00yQCWB6QyMxJoNAIBA2IME008RaAskkxpVwC+je4XmHf4JyoygoeBYaU5b8JKO6fbzIkyPZPno4uJfP4NKRJmbxoHsep7opa15roZXeqzuU0eJhBj27J2xboAytUuK+xjLGTTheUBROQzemX8w+81QOhrqDDxwNH//cPprhhrb0eZkDDlH6S7+ZpsDUjkIEZTLBbOGHz0H8aWNtcLGDtfISqFePufYXp5gXevpw3d96C7TAd7eDp1Qk5yQD1TT4JpBlVi4H6nz4HwL7zFoe5wnloh9iP2OO8MwNjfy2afNhrR50turufaDnp+Jr0CfIYcgmbLZUcyEd5+Oc4SNkGsx5py4IsZZJCKOn06BSDjM0PKIIjpCpbJW48KyHw3MmRBLbItg2/5ZZ3TRSStTK7JTVqUhKy7HtbvLXr6vlCxmQiDmMbi9Prnog X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.03.23 22:59, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > init_cma_reserved_pages() only used in cma.c, no point of having it in > page_alloc.c. > > Move init_cma_reserved_pages() to cma.c and make it static. I guess the motivation is to avoid letting too many subsystems mess with pageblock migratetypes, managed pages, PG_reserved ... So it kind of makes sense to have these low-level details out of common CMA code, no? -- Thanks, David / dhildenb