From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 673D2C4828C for ; Thu, 1 Feb 2024 12:24:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E08916B0071; Thu, 1 Feb 2024 07:23:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB7406B0074; Thu, 1 Feb 2024 07:23:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA6696B0075; Thu, 1 Feb 2024 07:23:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BA6A86B0071 for ; Thu, 1 Feb 2024 07:23:59 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8C468140974 for ; Thu, 1 Feb 2024 12:23:59 +0000 (UTC) X-FDA: 81743151798.05.E96B599 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf27.hostedemail.com (Postfix) with ESMTP id 7BCAF40005 for ; Thu, 1 Feb 2024 12:23:57 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="R/kJqq2e"; spf=pass (imf27.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706790237; a=rsa-sha256; cv=none; b=EbZ+pSW95lGc4fO/NLnHysscO5zLHucDvSdSX0KDnaXTQj+EEgu4xFiMNZZghFLSGxbwb3 6lgER2LloBztbgNG9XE3d9CXsH7SNARr1Xk+30RlPmqxOdzvVbpzMI1+39Rric3CHo5wI8 i1bBK2EW/FpUFaGCtTFUJVMLe/jx4h4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="R/kJqq2e"; spf=pass (imf27.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706790237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m2vKHRR93e+3YYKHOQ7fLrNNSojoXrx+12VS4MJqeeI=; b=Lt0AM+z7DAgMzxsr7I1Xe9O68dmgyJ6D+WDR0dhVc9+AEI55YVhilVOzv+QaYc40dmx4P9 1TjuFlIASx4KWFkbogrghEhC4Yd6L3IFPeFxnYY6DJsrE4Wc3nBUaofieN51Cn7n0+9nwW xWYgOAdoPEYgjxEqVJCY2mL1wsbC2SE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1706790236; bh=j8QKIz2LyfqG7kXLMqtzk7hMvrhGXzbOQETFhOd/EaI=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=R/kJqq2eBKZjoZTcmiUwCtX+KsvoexBVNOsYpPxG/pVOWmPoFjYSMFTbSMsA1VRkM NcMWRdJkLZ12znvltyCDAc31jvuLlhmsQdJqCf1dpnWuEb2zUwL6/2JBsnB3mDu2V/ bl1h9D+qNgcsdCQw4VGuUBZrwRhrKLPMhEVaJPXrubmM4XLbb6EQ8MhDiFQj69xeYZ WgYmEFXizgICcDWZ6a52qZ+MIkfBwy1mPOxaeUSZpgP9bWQFKEwhf8+iG4zR9kc06r +yRktM00Jeb2vplDjr1uJOAHPZu9HnQlhBGiJfRU6PAzTddQrhk5/ZNJ0NUDPZbiYI cJX7qaiINLpLA== Received: from [100.66.47.90] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id BF129378047F; Thu, 1 Feb 2024 12:23:53 +0000 (UTC) Message-ID: <8a340f1a-20b5-4792-9bca-b9ed2d95d384@collabora.com> Date: Thu, 1 Feb 2024 17:24:09 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/5] selftests/mm: run_vmtests: remove sudo and conform to tap Content-Language: en-US To: Ryan Roberts , Andrew Morton , Shuah Khan References: <20240125154608.720072-1-usama.anjum@collabora.com> <20240125154608.720072-3-usama.anjum@collabora.com> From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7BCAF40005 X-Stat-Signature: jfbmpwk47dmu5n98p1k9rpfrpwrfrxer X-Rspam-User: X-HE-Tag: 1706790237-683709 X-HE-Meta: U2FsdGVkX1/02YrQIrdT8uo5Twnf1R0WDaErCo47y+5oUy9EZft+Fh5aikMwMJFAztJMbCehn3G16lPZdOGeXGT3O9AWmRWTYmflAoQFJXeqDym3y+x6SMMTNX085FmEknxW3bQMJlU2qJCH2DuRAeJK2vbq6FphqMRYSYVP6hEd+zwTtCZ3u9KAA5QSld9L1xzBTHudKIFKLfxveqK0Y0Zb3BJ4kZJYnjGG9bx25XABDRpw+3h1edcNqqzzx2qxlOHOL0eaBRSTvZO65dTjo3LyU87GIk52uIbr+C1fzVUUYdENnEy1Y5DN+WIYmc8BD+fNdCaMtmvT/JE9qx6TnCmrq4XzP1YLIfHFLeipxtBA6jDNHD94A2XYZUN2rf+rj8+LC2MDXIWgYC9WOdxjGEBzlJzDIfuaZKfb/kT4/0ESbRyOMKV2ZOgChfMQdkqFcOu9qwI8NbQ4W4DtIBxjFKA0YCdp4IP4LIyxmzbRrhHpqZN7WpwgGltEEDIyv+obeMW00nX+Utte0OOWFe9TypesDK7eiw8l7LeJupcqWhxeNtK/69AgX3XYTwKyaBBGC7Wk1zWSxIsb2OxQT6/aBEK+m2dp9GChAsjsvvMkRvhlQMENIkUecqC6BQieyHO9Q8oXYqlXYIGWOZTColv0ruDEgm6H/LsKe/pv//aSL0WJM6RSduGq1MEG3uj7lvCVqmPy/F7eiCYarcz2zy8Q0qFfJi8MsDfdvYeOYNq+FKS9tEJosJai3NjVzGLnX5Lfz9j8cCOCeHpjwD/QOgAIFgTdjGetfi6V9JKdJ31u05PH4G4CXS3BwQB5OjGgO7psaLnGB1tHnCkLlcbbVki8PXhsRxybBpnLeSo3VwawTIsL0uxgZ4O/4yRkAqLH6yLv9/17gDVyfLWEAv2rpQFkmB93VK+wYITz7E6Nw5SFxVVt8XSLrhlTOGxl7AKS5rtPxlrAwqvrY8eEhJwT+G6 oGMmaHTJ aBLJlkFCotKdGIhrBgQJZKvVMo+7mtFtoPTJhtUC0jvkPm4geSKfvVaRDdPKiJOda/SWcBHxG2/WRhKzo3WQMCV6vheiEMRPTiWruBy/S2hlIryB9SPKqT6TU4ohxXXsPJyMIXXPdhQiKtKPBq8sqtcnBPJxZ2bLQVChUXF2cVZ6yYspNl2Pn3xxZ/5V4GXhqhfqugJNAgIemvfKT3BZSwUL1wwwjrpuVc90OQUDp+NFdwDEI0qVTQ0/nFczfBYoQK9TpK89Y4ISa+8goJfKl/R5mQj4bdQlTWV2fz/1rSvbg2FHJOuyFOqD+MMYPJGSEVnEL0EfY4s6hKDq/fjQUgoMNXPPQ7LNs+6VXk8Ch1WUbO023AnPIPNeE2mjoeKcdOTg3664D3HKxCOScT7IyUxTDAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/1/24 5:04 PM, Ryan Roberts wrote: > On 25/01/2024 15:46, Muhammad Usama Anjum wrote: >> Remove sudo as some test running environments may not have sudo >> available. Instead skip the test if root privileges aren't available in >> the test. >> >> Signed-off-by: Muhammad Usama Anjum >> --- >> Changes since v1: >> - Added this patch in v2 >> >> We are allocating 2*RLIMIT_MEMLOCK.rlim_max memory and mmap() isn't >> failing. This seems like true bug in the kernel. Even the root user >> shouldn't be able to allocate more memory than allowed MEMLOCKed memory. >> Any ideas? >> --- >> tools/testing/selftests/mm/on-fault-limit.c | 36 ++++++++++----------- >> tools/testing/selftests/mm/run_vmtests.sh | 2 +- >> 2 files changed, 18 insertions(+), 20 deletions(-) >> >> diff --git a/tools/testing/selftests/mm/on-fault-limit.c b/tools/testing/selftests/mm/on-fault-limit.c >> index b5888d613f34e..0ea98ffab3589 100644 >> --- a/tools/testing/selftests/mm/on-fault-limit.c >> +++ b/tools/testing/selftests/mm/on-fault-limit.c >> @@ -5,40 +5,38 @@ >> #include >> #include >> #include >> +#include "../kselftest.h" >> >> -static int test_limit(void) >> +static void test_limit(void) >> { >> - int ret = 1; >> struct rlimit lims; >> void *map; >> >> - if (getrlimit(RLIMIT_MEMLOCK, &lims)) { >> - perror("getrlimit"); >> - return ret; >> - } >> + if (getrlimit(RLIMIT_MEMLOCK, &lims)) >> + ksft_exit_fail_msg("getrlimit: %s\n", strerror(errno)); >> >> - if (mlockall(MCL_ONFAULT | MCL_FUTURE)) { >> - perror("mlockall"); >> - return ret; >> - } >> + if (mlockall(MCL_ONFAULT | MCL_FUTURE)) >> + ksft_exit_fail_msg("mlockall: %s\n", strerror(errno)); >> >> map = mmap(NULL, 2 * lims.rlim_max, PROT_READ | PROT_WRITE, >> MAP_PRIVATE | MAP_ANONYMOUS | MAP_POPULATE, -1, 0); >> + >> + ksft_test_result(map == MAP_FAILED, "Failed mmap\n"); >> + >> if (map != MAP_FAILED) >> - printf("mmap should have failed, but didn't\n"); >> - else { >> - ret = 0; >> munmap(map, 2 * lims.rlim_max); >> - } >> - >> munlockall(); >> - return ret; >> } >> >> int main(int argc, char **argv) >> { >> - int ret = 0; >> + ksft_print_header(); >> + ksft_set_plan(1); >> + >> + if (getuid()) >> + ksft_test_result_skip("Require root privileges to run\n"); I'd sent a patch to fix this behavior today. This test should run without root privileges. https://lore.kernel.org/all/20240201071307.592317-1-usama.anjum@collabora.com >> + else >> + test_limit(); >> >> - ret += test_limit(); >> - return ret; >> + ksft_finished(); >> } >> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh >> index 246d53a5d7f28..e373d592dbf5c 100755 >> --- a/tools/testing/selftests/mm/run_vmtests.sh >> +++ b/tools/testing/selftests/mm/run_vmtests.sh >> @@ -291,7 +291,7 @@ echo "$nr_hugepgs" > /proc/sys/vm/nr_hugepages >> >> CATEGORY="compaction" run_test ./compaction_test >> >> -CATEGORY="mlock" run_test sudo -u nobody ./on-fault-limit >> +CATEGORY="mlock" run_test ./on-fault-limit > > I think changing this is going to give unintended results. run_vmtests.sh must > already be running as root. "sudo -u nobody" is deprivieging the test to run as > nobody. The rlimit is not enforced for root so this test must run unprivileged > to work. See man page for getrlimit(): > > Since Linux 2.6.9, no limits are placed on the amount of memory that a > privileged process may lock, and this limit instead governs the amount of > memory that an unprivileged process may lock > > So I think the correct fix is actually to install sudo on your CI. run_vmtests.sh is invoked without sudo with following: make -C tools/testing/selftests/mm run_tests Installing sudo in rootfs wouldn't be trivial enough on the CI side. Alternatively, we can check if sudo is present before executing this test to avoid error that sudo isn't found. > >> >> CATEGORY="mmap" run_test ./map_populate >> > > -- BR, Muhammad Usama Anjum