From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 244C9C77B70 for ; Mon, 17 Apr 2023 11:01:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FE308E0005; Mon, 17 Apr 2023 07:01:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ADC98E0001; Mon, 17 Apr 2023 07:01:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54F698E0005; Mon, 17 Apr 2023 07:01:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4568F8E0001 for ; Mon, 17 Apr 2023 07:01:27 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0EAB21C65E8 for ; Mon, 17 Apr 2023 11:01:27 +0000 (UTC) X-FDA: 80690591814.28.0B0E754 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id D6E4F1A0011 for ; Mon, 17 Apr 2023 11:01:24 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RMXMAgmo; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681729284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oVc9uxy2kIdreOR/jYYEkHBdj+2RYiJitTncQTj92Ak=; b=lT8dGOv9aEyGNlODD+eSCtKB2NYz8FgMYctiUIrCDNcHGalF4yuy+QTfCKZCU3o2Y+IWuf JxEq+WXBB5jxX3/hyOtjwXGzSMOgFl5NYB4MDjM0DEDwDEWzDQ80VCZH8wMFS2+lZnh56T 8DZivIJz+jkNeo0lHrTIbce3jKh5GXQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RMXMAgmo; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681729284; a=rsa-sha256; cv=none; b=P/uoRG2C0ecmVxXZ2qowJkU0+TkjLJdk77kBWlEDrGjzbI62AGjEBoo9Lz2qR5oxs38tdQ ip+YvrEmBcbw2PHxVpIKa0FakYuzs2Zn0Fc8EnfV0Nbv8/DcAcVkLimJ6O7+xFl/Sr8CRn AVF9eoJO5Qk5B2VaWkKJoUPKPwpA+sU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681729284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oVc9uxy2kIdreOR/jYYEkHBdj+2RYiJitTncQTj92Ak=; b=RMXMAgmoqQsvdGXOhkP2NTHDRZy4pnVVhqt/v4itqOwBzpiijX2TrP9NA01B7qTkLAaDk3 vMNxvnyxHMW01RwQlLpoVNImrYQxiFweDGzPICX8QsBcjrsHCvvccbWzg+Ip1qRD1qXI1a zYCVk9Q316pSdxTgyklQ9FHmzDuG4C4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-Ab6yt4eeO9WpKGUQuMNk_Q-1; Mon, 17 Apr 2023 07:01:22 -0400 X-MC-Unique: Ab6yt4eeO9WpKGUQuMNk_Q-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f16f50aeb5so4645145e9.3 for ; Mon, 17 Apr 2023 04:01:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681729281; x=1684321281; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oVc9uxy2kIdreOR/jYYEkHBdj+2RYiJitTncQTj92Ak=; b=WQAljM881qY9Vx8b/pCFKOPAK+8Vx2YzZqKRsr9R0P7GjSXlGdDTZi11S79qDJ6W1z NIFSuE/+0iVFoiSf/bUUHnFCTg5nc0ZsdoWtDBnu642WNLkFj9u6229olFf8Sow5lU49 gG8pK5WdZZ8ns5guiRnPsNXI4hE28/8iPad18vZjAsYzA1v/irLaWHJ0u9BoJJWjTq6f 8NxQx+zcattUaXjDzu1nZx2vHbDbHe8pI5DtMVb+SMr77j//Je6gMFEkIU9WJ+i7mJG1 BkF65T4X5uxcWMSJFuEHbZkPgu4xWKg1gWYRUHdYDjA22UMASzqzqiPCMOmabWNRRNwb dOMA== X-Gm-Message-State: AAQBX9fJwKDr58rKmCPYOuRgI0epbft7xm4eZk02TxLhAn4uWEiFHlwT 1WySBf1rfyDRhTNyQBnt8HM7nGW2SavCLYgmfrWgUEvK/iq0CZCUCzioeY5FtQXlLFgcunJDPQs +edkkgubY9kQ= X-Received: by 2002:a05:6000:1376:b0:2f7:fb78:9694 with SMTP id q22-20020a056000137600b002f7fb789694mr5066277wrz.17.1681729281618; Mon, 17 Apr 2023 04:01:21 -0700 (PDT) X-Google-Smtp-Source: AKy350ZQIa4sVrexrjBGWt+x2dl05vD2C7OxIO4qZKWXoX9kbiyotAMI/EdKnSlVTtQjGuOSPjILbQ== X-Received: by 2002:a05:6000:1376:b0:2f7:fb78:9694 with SMTP id q22-20020a056000137600b002f7fb789694mr5066215wrz.17.1681729280958; Mon, 17 Apr 2023 04:01:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:fc00:db07:68a9:6af5:ecdf? (p200300cbc700fc00db0768a96af5ecdf.dip0.t-ipconnect.de. [2003:cb:c700:fc00:db07:68a9:6af5:ecdf]) by smtp.gmail.com with ESMTPSA id h12-20020a5d4fcc000000b002f22c44e974sm10214704wrw.102.2023.04.17.04.01.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 04:01:20 -0700 (PDT) Message-ID: <8a323d9f-f54e-065d-d611-0a07aea170c8@redhat.com> Date: Mon, 17 Apr 2023 13:01:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3 3/7] mm/gup: remove vmas parameter from get_user_pages_remote() To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Matthew Wilcox , linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, Catalin Marinas , Will Deacon , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Eric Biederman , Kees Cook , Alexander Viro , Christian Brauner , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Kentaro Takeda , Tetsuo Handa , Paul Moore , James Morris , "Serge E . Hallyn" , Paolo Bonzini References: <523f0764f4979276a6d4b89cbad9af9124e4bf0a.1681558407.git.lstoakes@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <523f0764f4979276a6d4b89cbad9af9124e4bf0a.1681558407.git.lstoakes@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D6E4F1A0011 X-Stat-Signature: qqgqji6hqpapcbpfhw9pqxnjrc4ah3wk X-HE-Tag: 1681729284-544481 X-HE-Meta: U2FsdGVkX1+oq5SxpnZ3fEOn9QluDRP08K9HUX3m9uYy7zqn6Avs7MFUn6/qf7FCL/+phmVK20vXsWVjiaNkTAEt9HGt5WTmZkl4x+jsSKxQ/7sz0QREmefUE/MAMTHIvo8B0SqMz//bMZllV/QxgT0ywuJ1IyCXXaFgIlUj+ryzOPlOmreC0XZJSXk1KW9Yf1IvJ47HtLCChhGjyitTUasXEEUT9w6IowvfMyp+5OpuNrvkpDakzWBMXRzCBcZeYZLhzASo50K50itr/fm2zVxJmGbahKCen5yBXcXCSL2QLlEC4qyfQQQJE8rIdCpw/qB9zi6LP7Jf++Dbfff75Zt6tj2RaVI7En+Zel8zjUimMyJYHSpoFujQjd0B+fOT425E+uzfPaszgiIaZQEQc/yzdciDyLVIZ+tKTIlTJysMorOEnqOU+5kCbvbXAa4s7rju93OqMv38m5iWfJc6RSnK8V2yxzkYt6Q2j8DmICQnK52+LlJWRdHVg5vTAEQD3DXOXDJqnKmj2eirIPVd+F4WwMGVx/zcVXkamIHBBK2A2zKAK91rl/5FE8VBEylDCj08HGhXmzhvW5AYKeh8b8ORu3+te0ZuPDSsPML1ciLZs0WyDbKNkO3tIY0SaReldtA7MI2ZzlqE+1ODrBf2nI+P/YJY51tuKWxQTaVdijh/PfBempzG/YMSnww97wouz+s1UMGhnIiWk2WKI9Vk/xl3kjAXJ/DAN3vuf3g3D9SpRqFm8XbPQw6BdO69FjBO8/nPkHdQSXqYHsT4hy5hIuOOCw/iSrsZ3uWH4aCW+ARU1gBglclK0CXwM3tWGIi6t2AZuL2Ui8zZWeTRnkZbMuU8tYLOQRozEhUZv+s/K27Er1FLuoOgvD4MY+iOxWM5kl54ohg2KRy5GpVmw/zGaX94GbzqKJam1IpRpv+8odF1KNmgkO5UQ4WC+YkXVRIh1UPAJfNFbkvd/erHr/a KYR6R21d jFRrCyZXHQGvWHsdEE6XTtJb8UJBr30KQWyeN5odANbjqWHbwQB6NkJiav2L1Os0fm67dicVT2YtxoCrJ97aj3wciKunDMdFSlNN0Qp8oCIIBcavXynUbnVTr1DvYV3roYRpRro1T5zyyUCsOgj5JAHByWnLpap0eGNHdg6xUlnDRb4v3t31MQ8wNy6YqNmik6R/VCFQLzQPS4OgTEPAEoPAJCQ5SKR725wT25KDg09YhLt64f/4UHr+NTmiX9oiM7KVdjN9hakSy+EEb9pJme8HTsHs5BY35qQxET9nVsKTFqu9S2r7pN4zQxUHJZlrkMKvstzNdPs0BE0rtv0vh08ASTMJtmkzJxSPp7o9dQuhdqVRQ2OKkdR+jDuW01dGWdT68nfsZO41gzFsIwMYEzXDQCcQn0l4w9va+tn15iGTl8GkcEFz9CkjTutyY1tfK+f176W9Rq4nbuJ2ZpqO8GxmnfSLMYICYjHp01vtQB2g/pzJzl0VHC4ZW9bNw44WfRkJUgsj5vuwXoXI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.04.23 14:09, Lorenzo Stoakes wrote: > The only instances of get_user_pages_remote() invocations which used the > vmas parameter were for a single page which can instead simply look up the > VMA directly. In particular:- > > - __update_ref_ctr() looked up the VMA but did nothing with it so we simply > remove it. > > - __access_remote_vm() was already using vma_lookup() when the original > lookup failed so by doing the lookup directly this also de-duplicates the > code. > > This forms part of a broader set of patches intended to eliminate the vmas > parameter altogether. > > Signed-off-by: Lorenzo Stoakes > --- I guess we should never drop the mmap lock temporarily in these cases, so it's fine. Acked-by: David Hildenbrand -- Thanks, David / dhildenb