From: Chuck Lever III <chuck.lever@oracle.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Chuck Lever <cel@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christian Brauner <brauner@kernel.org>,
Hugh Dickins <hughd@google.com>, Jeff Layton <jlayton@redhat.com>,
Tavian Barnes <tavianator@tavianator.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH v3] libfs: getdents() should return 0 after reaching EOD
Date: Sun, 19 Nov 2023 19:18:56 +0000 [thread overview]
Message-ID: <8F8B8E49-7AC9-4ECE-9CAE-8512D9C1DACB@oracle.com> (raw)
In-Reply-To: <20231118233626.GH1957730@ZenIV>
> On Nov 18, 2023, at 6:36 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> On Sat, Nov 18, 2023 at 05:11:39PM -0500, Chuck Lever wrote:
>
>> We don't hold f_pos_lock in offset_dir_llseek(), though.
>
> We'd better... Which call chain leads to it without ->f_pos_lock?
I based that comment on code audit. It does not appear to be
obviously held in this code path on first (or second) reading.
However, let me look again, and test with lockdep_assert() to
confirm.
--
Chuck Lever
next prev parent reply other threads:[~2023-11-19 19:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 19:33 Chuck Lever
2023-11-18 22:11 ` Chuck Lever
2023-11-18 23:36 ` Al Viro
2023-11-19 19:18 ` Chuck Lever III [this message]
2023-11-19 20:22 ` Chuck Lever III
2023-11-19 21:14 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8F8B8E49-7AC9-4ECE-9CAE-8512D9C1DACB@oracle.com \
--to=chuck.lever@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=cel@kernel.org \
--cc=hughd@google.com \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tavianator@tavianator.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox