From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63076C433E0 for ; Wed, 29 Jul 2020 18:41:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2BEBA2075F for ; Wed, 29 Jul 2020 18:41:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q4zvW/km" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BEBA2075F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 90EEE6B0002; Wed, 29 Jul 2020 14:41:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C0476B0003; Wed, 29 Jul 2020 14:41:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7863C6B0006; Wed, 29 Jul 2020 14:41:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id 622646B0002 for ; Wed, 29 Jul 2020 14:41:42 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A3DF398AC for ; Wed, 29 Jul 2020 18:41:41 +0000 (UTC) X-FDA: 77091982002.12.test06_520e69f26f74 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 3359618055A08 for ; Wed, 29 Jul 2020 18:41:41 +0000 (UTC) X-HE-Tag: test06_520e69f26f74 X-Filterd-Recvd-Size: 4388 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Jul 2020 18:41:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596048099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TG0mMl+qERD/p/lH0bBKbEKr9d96L0uZ7lfwhkdYZqA=; b=Q4zvW/kmw/vkMvkTIiH9z0eHpE1jQ6CU+lVd73rSMKAbsSIvZk0CUcuZ/igFHwAwqhbjbD V0wXiSkc8m60cywLFHx796AEwP7poB/S+t7XA4TcYdRv2ZEGRXNeJLRv/5DKo6UTBqhcyr zPMV4Z+A+Y+5SNILh9MR8RaxDBjzed8= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-LDQiNbD8Mk26TPZ3_5iJJw-1; Wed, 29 Jul 2020 14:41:37 -0400 X-MC-Unique: LDQiNbD8Mk26TPZ3_5iJJw-1 Received: by mail-ed1-f71.google.com with SMTP id r24so8733488eds.15 for ; Wed, 29 Jul 2020 11:41:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=TG0mMl+qERD/p/lH0bBKbEKr9d96L0uZ7lfwhkdYZqA=; b=PsMGRjIpQOpqi8mnXXbTkWG18GLXsXio0usaFROojZBBBiqOkMIfPR2S04kwLWsAmC 8N4ZbXCxAh2GyT8vCqy5vmhce9Yx/zJc8dCNxCfl/O8RjqaFoNMcTiDkZ9weIwPCMr/E +mErJwdgBI3ENiKFCHAvfBxuU4wzjOtxvMkdkAJdUQo291YnWXXjh1TItvh/Bjbatme5 np/WQLP6xzuXW8kU6tpyD7JW4V0dG12yR5cWO1ZPjBul5h1Wt6AAZYP3HJKAMyISt6yQ /NpBOeCaZG8dYodLTqbzKdioA7b7AVRmp0qhalXUzi2wQvheIbiG6KpFP52/OERGUV1J D2Kw== X-Gm-Message-State: AOAM5329V7f2Rg2U45T3OW9J0Xs+IAhxiZZU7RrJLaRy5xy1+JKHg2zF +2rI8SU0vV7X456fRCpC6jzC5ZtCeG6kpAj/yK37BBsb23Tnv5wSm/QkHs5oXXH97XMgYu/oo5H LQzdqliTwud0= X-Received: by 2002:a17:906:57da:: with SMTP id u26mr32850951ejr.157.1596048095927; Wed, 29 Jul 2020 11:41:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqBeHBARqfws6XTYi+Qge5cssgBVDY+eGXTA2/OoOf8zdNHETw9pWTyLkfcSfSO7LFjj/Y7A== X-Received: by 2002:a17:906:57da:: with SMTP id u26mr32850934ejr.157.1596048095726; Wed, 29 Jul 2020 11:41:35 -0700 (PDT) Received: from [192.168.3.122] (p5b0c648d.dip0.t-ipconnect.de. [91.12.100.141]) by smtp.gmail.com with ESMTPSA id k22sm2675294edo.24.2020.07.29.11.41.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2020 11:41:35 -0700 (PDT) From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v1 2/6] mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate() Date: Wed, 29 Jul 2020 20:41:34 +0200 Message-Id: <8EDC210B-0A0F-4FAC-B008-303CE2D65A26@redhat.com> References: <79240e7f-de16-aee6-fbf6-07e7f184a924@oracle.com> Cc: David Hildenbrand , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, Andrew Morton , Michal Hocko , "Michael S.Tsirkin" In-Reply-To: <79240e7f-de16-aee6-fbf6-07e7f184a924@oracle.com> To: Mike Kravetz X-Mailer: iPhone Mail (17F80) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3359618055A08 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 29.07.2020 um 20:36 schrieb Mike Kravetz : >=20 > =EF=BB=BFOn 7/29/20 11:08 AM, David Hildenbrand wrote: >> I have no clue what you mean with "reintroducing this abandoning of >> pageblocks". All this patch is changing is not doing the dump_page() - >> or am I missing something important? >=20 > My apologies!!! >=20 No worries, thanks for reviewing!! > I got confused when I saw 'Return -EBUSY' removed from the comment and > assumed the code would not return an error code. The code now more > explicitly does return -EBUSY. My concern was when I incorrectly thought > you were removing the error return code. Sorry for the noise. >=20 > Acked-by: Mike Kravetz > --=20 > Mike Kravetz >=20