From: David Hildenbrand <david@redhat.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: David Hildenbrand <david@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>,
"Michael S.Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v1 2/6] mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate()
Date: Wed, 29 Jul 2020 20:41:34 +0200 [thread overview]
Message-ID: <8EDC210B-0A0F-4FAC-B008-303CE2D65A26@redhat.com> (raw)
In-Reply-To: <79240e7f-de16-aee6-fbf6-07e7f184a924@oracle.com>
> Am 29.07.2020 um 20:36 schrieb Mike Kravetz <mike.kravetz@oracle.com>:
>
> On 7/29/20 11:08 AM, David Hildenbrand wrote:
>> I have no clue what you mean with "reintroducing this abandoning of
>> pageblocks". All this patch is changing is not doing the dump_page() -
>> or am I missing something important?
>
> My apologies!!!
>
No worries, thanks for reviewing!!
> I got confused when I saw 'Return -EBUSY' removed from the comment and
> assumed the code would not return an error code. The code now more
> explicitly does return -EBUSY. My concern was when I incorrectly thought
> you were removing the error return code. Sorry for the noise.
>
> Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
> --
> Mike Kravetz
>
next prev parent reply other threads:[~2020-07-29 18:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 14:26 [PATCH v1 0/6] mm / virtio-mem: support ZONE_MOVABLE David Hildenbrand
2020-06-30 14:26 ` [PATCH v1 1/6] mm/page_alloc: tweak comments in has_unmovable_pages() David Hildenbrand
2020-07-28 13:48 ` Baoquan He
2020-07-28 14:07 ` David Hildenbrand
2020-07-29 10:47 ` Baoquan He
2020-07-29 12:29 ` David Hildenbrand
2020-06-30 14:26 ` [PATCH v1 2/6] mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate() David Hildenbrand
2020-07-28 13:56 ` Baoquan He
2020-07-29 17:31 ` Mike Kravetz
2020-07-29 18:08 ` David Hildenbrand
2020-07-29 18:35 ` Mike Kravetz
2020-07-29 18:41 ` David Hildenbrand [this message]
2020-07-30 4:21 ` Pankaj Gupta
2020-06-30 14:26 ` [PATCH v1 3/6] mm/page_isolation: drop WARN_ON_ONCE() " David Hildenbrand
2020-07-29 13:24 ` Baoquan He
2020-07-29 13:37 ` David Hildenbrand
2020-07-29 14:05 ` Baoquan He
2020-06-30 14:26 ` [PATCH v1 4/6] mm/page_isolation: cleanup set_migratetype_isolate() David Hildenbrand
2020-07-29 14:06 ` Baoquan He
2020-07-30 4:31 ` Pankaj Gupta
2020-06-30 14:26 ` [PATCH v1 5/6] mm/page_alloc: restrict ZONE_MOVABLE optimization in has_unmovable_pages() to memory offlining David Hildenbrand
2020-07-27 12:23 ` David Hildenbrand
2020-06-30 14:26 ` [PATCH v1 6/6] virtio-mem: don't special-case ZONE_MOVABLE David Hildenbrand
2020-07-21 9:59 ` [PATCH v1 0/6] mm / virtio-mem: support ZONE_MOVABLE David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8EDC210B-0A0F-4FAC-B008-303CE2D65A26@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox