From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E112C28B20 for ; Fri, 28 Mar 2025 13:33:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4A20280144; Fri, 28 Mar 2025 09:33:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF93328013E; Fri, 28 Mar 2025 09:33:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4DFD280144; Fri, 28 Mar 2025 09:33:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 84F1128013E for ; Fri, 28 Mar 2025 09:33:07 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C4F64140232 for ; Fri, 28 Mar 2025 13:33:08 +0000 (UTC) X-FDA: 83271050856.01.29A3D02 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2058.outbound.protection.outlook.com [40.107.93.58]) by imf25.hostedemail.com (Postfix) with ESMTP id DEF40A0024 for ; Fri, 28 Mar 2025 13:33:05 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="t/+lV3PB"; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf25.hostedemail.com: domain of ziy@nvidia.com designates 40.107.93.58 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1743168786; a=rsa-sha256; cv=pass; b=wNmLG/YDU8y9uX7J6WhUKcmo7wtlog75pvuAtRW0K/orSPAAHLB2/gP9VewwcXhMyY2CRF 52aDYohwrRu/3CRndIR9hDSEon1fxY+ROtpmo+sOPc6267FyPUUJrhudreVV/bEzU5I0dM ED/x03g2LIL38KpQseQCzyoZm06Tsyc= ARC-Authentication-Results: i=2; imf25.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="t/+lV3PB"; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf25.hostedemail.com: domain of ziy@nvidia.com designates 40.107.93.58 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743168786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0nU3n73tPYV8VZurG6HKjH03RW5m2zF01blsm3NR8Ag=; b=f1VB0DemYolwJi3EYpsr99V2rr5ci4RaBzzm0BWokS/aboUHyLWiaNlhBCDevFgfPQdP6D aMrmtav8QtJ3dUI7ZvRQJ6xQMKdICdAaZ75vzjXPQHXYhi5L8MJfYN7Rj+JXlqGy8YUQ85 LJV1XZk5F/Jbxb6lZfe6AQNcoQbA7WI= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ceOLzQPTeZUUShMVIMWh/46GMWA6T8rpR9abFzwRm94GwdAbyWfUrLCajeMzySSN+Z2DU6kHaWUcTRsU6Awr8E+fki7ydFDwriYmFEfSPqzHDVYtf/L46wAmbQ7GYGpCf8fjNm0Xn0hn2ALIVVKIu/h90muk+k8PUyFyciWOBMHw0k9BapXPgohDv1KR6JmyVrOLPkJxZIotY7d2N95LKCvOKjlmAorU9XLN4dVtXDRJxt18ks/b70pLDGhbCArW9101fhnkrt9iek8y6NQ2BZ6yEM12d5gsxw0COYapfN0HMd5c+YcYV6PHE1nmfBP6u+6V8TlPpBPr1OOvxn84/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0nU3n73tPYV8VZurG6HKjH03RW5m2zF01blsm3NR8Ag=; b=M3EmStpDqYCbBm/801t35xBtsGmQiHGZPU9l6l7W5A3oWWPgVLunQ5yCg4YpzkE67oVp9zZEvsc6UDM4wIQmLfrdhUE6OAfmEAQYjTacRxr4h51sYolozeQ+C+yP1mTJpbkeAKW+YsRlVg/qqC/PobWz9gYjY/KY+exTTjLyXN2gqs40cPytsjLlCBB90BuaFHEorIwDADhpzL28XeuluQlKQdpTAuGHHnhGgvbAxVfq39V/1fijbMEWoGRYh7gzuM0wXyqPUH5Z2KhDTelp0N3gwXMeTRqu21owRkc1NuDRvmYBGNbDxyzK4PKFTT44o1vqDnsG7B/pidnY1VFYJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0nU3n73tPYV8VZurG6HKjH03RW5m2zF01blsm3NR8Ag=; b=t/+lV3PBmBF2x6tymMFQxAvyzsRhRF/yCjq5GoX0mJNBuI/Fh4iowvf6QQ382jY/FL1IyTeuj5GfdZZBesxXE3lH6+Vw8wZG9bTojvHT+qjRVgcZgNz8zYvMqV/nF8h7wu68tdfqPnAkWAPeem34UHGMWAxHY6VQIV7VDY+wFAFKWvqyul3haA7Ol7+TtsZ8vdHTpZY2GZDJYoz/AHjoNEFIaqXTaDbnBJEqTns6mH6nTagikOzce95sTgSaAPtgjIFemMgzcgRUUVsTTHKCq+edSKI/48/H0TkhtcV4VtPP3LfKdq01DFRS7kzPgsy5fBV0bSKPVG+ikgRE9FwnjA== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by CY8PR12MB8067.namprd12.prod.outlook.com (2603:10b6:930:74::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.44; Fri, 28 Mar 2025 13:33:02 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%4]) with mapi id 15.20.8534.043; Fri, 28 Mar 2025 13:33:02 +0000 From: Zi Yan To: Ryan Roberts Cc: Matthew Wilcox , Andrew Morton , David Hildenbrand , Dave Chinner , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] mm/filemap: Allow arch to request folio size for exec memory Date: Fri, 28 Mar 2025 09:32:58 -0400 X-Mailer: MailMate (2.0r6238) Message-ID: <8DEB30F0-52D0-4857-9BAC-CDAC045A396E@nvidia.com> In-Reply-To: References: <20250327160700.1147155-1-ryan.roberts@arm.com> <731D8D6E-52A0-4144-A2BB-7243BFACC92D@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BN1PR10CA0016.namprd10.prod.outlook.com (2603:10b6:408:e0::21) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|CY8PR12MB8067:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c0c7410-cf10-4864-5954-08dd6dfd101d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SjBteGNQV1pMUlpReExJc2ZZZWJNbkwya3BGcUlEVXNVaTBMS1BQT0FYUWUz?= =?utf-8?B?bnlYZGdKMlp6Y1pOZ3JpNXZPaHBCZ1o3SVlyWTJ6cFdsTUNjVlhzZHlZWWho?= =?utf-8?B?NzY0MkVmTGRKTXpRR0lVQ2tSTnpqYWd6V3JyWGJEOXZ0UDR1VUN6VmFwWkZE?= =?utf-8?B?RnEvMHlRUW1wNTZuSlJ3UzVUNVRKSEVuZ0ZPZWlNdDFrc3hlNUNNNjZKU3ht?= =?utf-8?B?N09udjRuQllYb1JaeW1WWDNuKzd4d2xYdCtVZmFWREJrSlFUWlFaUmJIQjFT?= =?utf-8?B?SUVENnNSWnFYeVpmMW1vaEttMUF1SFFHVDhPMnYrMWlJdUVBWXVVSHYxWVlu?= =?utf-8?B?eWxuUURGZU5uUHlwdXZOTUNIK3k0UENEV1BOUGc2SjM2MXFWbnFjUDZKSG1h?= =?utf-8?B?aHNMekRBTWZObmlGK1QzZUkwSWJWNldjaHBwSTJXK0xwdGpMd0I1STUyRGRO?= =?utf-8?B?UnoxOTZaa3NkUG1zczQ4UW53ZVFwUVFqQTIyKzlEeU10M1NZUVA3cmlXL2pr?= =?utf-8?B?KzgyYzhHM2dCMjVDU3lTU3lNZ0NCaGdtT3R4dGZqcjZFK0xsUHhKZUYxQkxl?= =?utf-8?B?aVpjbDlxODhkbkY4MllFZW5nN1VTT2tNZmErU1ZvRFlIak5RaDRqbW5NUTZD?= =?utf-8?B?WUxOT3lpNzYwZDJPa2pGcmROQVBpVDFGSjlEVlRmWWFSMUZwSW1oK1BoOVMw?= =?utf-8?B?Z05jMmthcWU2eFRYSEJIZDBiY0JId09tQ0E2NncvUmhJS2RWY3dkV3Zud0lp?= =?utf-8?B?N2xJVC9oT1J2UXczak0wVXc1R3NVS3FyR25XcFRwQ3l0S3piQ3ExZXEvWXhp?= =?utf-8?B?TkZGZ3VZVU96cXZoK0llendjTjVRT2VWTUc3VmRyRWZzMy9sVy9FRUV1c3F2?= =?utf-8?B?WjZKRThUaE5YeGtidGtOWllQUkFmV21BWHJqSjhiMkQycmFBdm9tOW43MlJy?= =?utf-8?B?d0Z6dWVXcXFtWW5zUitrUkdnL1Q2OXk4cWQwWU5sMzRPd25FaEhRci9VekR2?= =?utf-8?B?SGhOQzFLREZJVFJrU3VKakFZRFRRSTFzWkR1dHV2enZldHpSWGRQYm1TTEt3?= =?utf-8?B?dklZYkNVMmw3a1RNQnF5R3A2NHpudVFoMjl4b3Q5RU4zZUZIOTF4SzFBd0Va?= =?utf-8?B?eWxwQXN0akU5TW5iTDZvTTdtdm9BSis3VWFZbDNjRXZnRXRFUy9MVDUycTE2?= =?utf-8?B?OVZYSkZwaG42MlM0ZFBYU1RwaDlDZ3M3Y1BPb29DTCtBd1J6Vmd2OEw4RGoy?= =?utf-8?B?TDlZQUplQi9URElUODREVFY5RVFXejVSQzhtSExnRDdHU0V6cmx3L1h3N3JR?= =?utf-8?B?ZFhoZTlTZmJwRkREc2x4YjR1R2xOQ1Y4K2FDUzFkMEV3dS9ib1NIMHVjUlFH?= =?utf-8?B?S2ZqOEp5ajFkMGt5OVI2akRweEpGOUZscnNyaEJmRGU0QncwOHJra1A2NkZr?= =?utf-8?B?eVdrSC9TcEVURWVFL3pMZXZicnRqK0tiTktXeWlqcjZhRTlYRnB5L3MrQkRU?= =?utf-8?B?cHhHaC9JVVF6cFVOMThBWTNyVnlvZVZoTkc0dnd6T1l1R1Z6eWJCUFJKTWRh?= =?utf-8?B?S1hYL3RJeXFGWS9IS2pzNjA5TGNMSy9sZndTZlFYUHNyY0RNM1o1ajVJRWxa?= =?utf-8?B?QTlsbCtUb3JaZkZZejVxQWxZMm5aT1hIenNaU1oxcUlRT1RFZ081REhySGla?= =?utf-8?B?MTVLU3VmU0JKZEYwSG9yZHBFN0xPSmIxMWVXR3dDYmlUcEU1NHBvM1kwMWVJ?= =?utf-8?B?bVh1T3JIVW83NDhMbWVmaXB1eEUxTzBqN0ZtcjVwMEthZEhCTklQVUo0c1hh?= =?utf-8?B?L0N1Q2VQNTAza0VKQzdEWi9ydWxlZklaTTBKQWVWeCt1bjQ1VVdqcEhJTXdT?= =?utf-8?Q?g6jADLjSbSKed?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnZTa1BlVUpKSG5BdmZyakx4d2xFek1ETjVSNmxyeFc4WE5XOEhDUFkyd21S?= =?utf-8?B?SjVybHk3ZGkxWjNoUXZRL244eXN6UkUyc00yN0JSK2RWaXgxc0t0UkxDL05H?= =?utf-8?B?NWMxVDFSRFFpTmlmZ0QydWJsUmo5UEN5ekEvNjhtc21UankyMEQ4dGpRZFVi?= =?utf-8?B?MzIvbDRmNFdjR3dRR2gyT3pvMVFYTWFNK2g4WGhuRStaZU9lU0ZscnBZWXg5?= =?utf-8?B?S0c3NTZyYTVHb3UyYVZLVWpKSjY1VmtIMnhudUd5OEM4NS9XQ1JoM3lTd0t2?= =?utf-8?B?UEFZWEVMWWF3M2grZGVXUnNqd3V0SjlQc0hIbjArQ2w3WG1laWJEeUl6c253?= =?utf-8?B?TENxZFB0Lyt2eTVQYUtnbFJZNFdpS2w3OHBFWG5VMDZCUGMvYng1WHMrc3A5?= =?utf-8?B?bmluQXlzSUJHalhhRnFNbnFTOFhmc1Eycmdpb3BlUXNBcW5IZE9UbjV3YnA5?= =?utf-8?B?cFRpTnpUN2tHYkZ0T3dORVhoK2NYTWhiNVI5QUxod011Qktyd1pmWDdMSVBN?= =?utf-8?B?MHZseEZnVHE5T1YvNTUwM3JVREEyYjIvT2RRcG1UVXo5MWRESkhnNHJLamVK?= =?utf-8?B?d0habHAweHpFQkdLcDE3MlA2UjQweStBS3VaNkV2M2s1S2hxWXVVN3Q2U3Jm?= =?utf-8?B?QkE3UE1wdDZ3VGNlcUFUQ2xUQUZ0QTJKd1dsSFdJSW9HZVc4SU1TMWhFSUwx?= =?utf-8?B?WjByR1oydnUxWXgrd1pCNG5zSlhnZVEzR3ZJWHc3MzBZWVpaSWJ2Z1EvbUJj?= =?utf-8?B?aWd4amVrT05PUGtiZnlrajMrMWpqVHJlS200MmRWSmFsVERPOEN4blNOMUNo?= =?utf-8?B?bnpCSlJuSGl2K2JLTVNPZzRnVDhyaXp3eVNhci95UGpmRWVaN2JkbkdkMnNn?= =?utf-8?B?aWFBNllBdFRmaUlWMXIzTCtaM2dlVzhPLzhHQXdIaUlRU1hTemxWelJra0cx?= =?utf-8?B?NjFBUzlRbHN3NUpybW9nbDZMdE42Zklvb3k0em0rSVFneXVaMEZyeU43R0Q3?= =?utf-8?B?NXM2Rjd3ZS9LVDlqU1BWWWlKcDBEcWFYU3VpL2c3eGNBVjl5K3h6TU92TUFw?= =?utf-8?B?Vmc3TnRmdGp1TUNnUVlQem5vWGZ3SVpHZXRlMDBmeGNWNkx2R1NIQ1oxaVE5?= =?utf-8?B?cDlQeVJCZ2FIdWFKZ0RTWTE5N3NJbE5ZTHp2QWQvRloyVHJKeXIwOUVqOVFz?= =?utf-8?B?aVNuOGdxY1NWanlGdHBYbjg3bWVuc1cxVGJYdmVtNDlXRTVLYUF2MElCZ01U?= =?utf-8?B?TVBhWVdPQWRVd0trL3lZcVlBa24xdmVydkkrUER6Tkh5bVViNlllS0VoekxV?= =?utf-8?B?MXVwbVlpVmZiaFhHRjdnTlNXcVQ1NFpqY3prdXZPbzVZWTYzNXJaQTFJMlJn?= =?utf-8?B?Y1FQTmdneHlzdVJVOENaM0Nxa1VpVk1GY2JtS1hWa2UrL0haYVBZcjRta1J6?= =?utf-8?B?MlZzYXdlY01kdkg1VUt4bnpPTHU5NzMvZWY0enRGdk5kTWNBeXVBOHE4UWw2?= =?utf-8?B?dVN1MkRBOEJkUnJaWGRiaUhCYlcrejhuY0VDU0QzVm1KYjBGaWxhVmFDb0dx?= =?utf-8?B?SzkvMENrYzdQRFhiM2xLQUJVZFFodHY0N2lsYmhJV0VVMWVMaHVGL21xSXdr?= =?utf-8?B?U3psVUpFcExMUjlFVjlGSHo3MXh6UnY4SjdNdTVVZzFpbGNjS25TbWZpVTY4?= =?utf-8?B?OWxBNUMycHNmaExmVVhUQ0RmSzlONUdkRUtFaVhtN0pLaElFblAxL0lqdjQz?= =?utf-8?B?SHJDRjR6aE56Qmc3d21CRFphWDVKMGNFbEhYbG5UUExWQjBvV1NMVmd6U1Bw?= =?utf-8?B?K0owajlIaEpCOGltQUladVRkOGdOb0pkYVFGL1JxYkVqZEdKVFRwbmJJc1BC?= =?utf-8?B?K2JMVXNKa2R1dEdkWmJyaEt4MTNpMUluNUtvbDZzdlVvb2FsTTIraWJzRUVO?= =?utf-8?B?OGM5d21QbUVuZUd5LzU0U05jVzdjbzFlZXYxZHJuTm9vRzVYOVpCYkh3b0ZC?= =?utf-8?B?ZFJRZnNPTHBVd29CQkM5V0hGRjA0dkdQcFJpVEMySWJrRzZaVXQ4WTQwZ2Zr?= =?utf-8?B?Wm9Mdi9ycDI3SXI0bWZSYXpmckV2eEtKaTJ1T2dWdzVOR3FqSlNaY2tsRHkw?= =?utf-8?Q?/799p/9uFlqsvLiMf5IlOxOEG?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c0c7410-cf10-4864-5954-08dd6dfd101d X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2025 13:33:02.2166 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nPSJDJ13hI8UPQ2DyZSqpThgTcogcY2VQj4MNzAskNL9xq4rHDxozbUM93RGU97j X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8067 X-Rspamd-Queue-Id: DEF40A0024 X-Stat-Signature: yo1pi64qr9qftkczktky4jyo3yfkguyk X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1743168785-419351 X-HE-Meta: U2FsdGVkX18Q8YT8MYHGrzVSbd45A1DiT/Xwn7Z8Z1TYP677LOzslfA9UFxVlSpXsk01W4hD95UCKRi/1fWT73URFjGapej7hQ1Pgzyf0uOTh08jUiNKCAXDrxmVsyWt5RN5zw3XwQ2vW9wxr8utIjSf2YfJIbb5Js/WjwaqMQmSP40mOd2uoghPUMcGqvCVXxplLZufYRwtnfW1XHwuOXTG4MMN7sM2cjDJoQcDqlFgT2+X15xC5d+WiIMcyol3eW6XwQvn47nzFDJy7l7aTwsaAn6ZuLa8qcDqh9EFrce9cBxLvs5+C6/G7kpCT3m13ky5uk07y1cAVWQLAjbDrgMtsK0b8CFEt30TeL/XZk7Qj+/vvJF7fQlEF0ZoR7QQflAUpaJ7b+2fmrPT+mESmiO+cN7X5Lzjhi5etksH+cCc2QPmzDm9thRwBl3XGDvdfB4MbzpEFF4tTFWDPqYlgKnGy2N7fyTuokLdMBlC1G38JV+YHmc9ucEBsC25IcbrvC1GjvGZH4+34K3v82US478lIOg+/5ouvromvZmzaxJMVx/9eFCUdPu0O8m1olmM+Dby5Rv2ACmmhPJxIZ0zUP/dbnklJ3p/MsFspY89cm0DJXodN0u4/0eEkJLlr3YsTgVd7XnpK0anZeiFTYW0scdUzW10gs5FzhWG0yq0vvW2VIwKXXytKCt/rNIeLN74+/8/zTRbi4tU/YZZAxXRn2JKyjbOOdLmZ5nTS00U9mtLhoSEHdUAg9rPTg1j0rz2TXr6kRKXyREaJTl8LY853g5nEjPkRVmM9BWDHE/kqiRiqwZdQseSocnmHmakOT88NmYu+HP+nEHtduq3hFcTaxE+v0aq4ju0effmJFLSsN6RscOY/Vx/N4LNfOY90hutN8n7DDZhzv5BD3yrEa7sTw4wh7j+xDPuXfokrWqMQ7p7NFvq+IML+Dbvg0tWrhb6yWe/ELe97oPrng2Wh9O M91tXGPI 06TcS+dOkV3GNy31MHZ4uxTiM48Zytb5+u3TZVJu0r33V4loUw912hSMfHij+5grl8n/kZQBuimbgZh+u6JHXr3RrGSra/zt18DMEmBUq1MLBRurtmXxerVJmQwGRfKR0IgSJQmNsrjSz7gk6zw7EyzBys5HgYINcUv5XqRciB3VnVmXTUbqjkPbOdpuIUvjTs70bUd8KQBHwH9lpEql0SIQqzv5QLQo19sUAZOvPpDguz+ZhAzKrwUOh/jNKc/3FkPb0zSZDybhDhaRqztfHTt9lfa6qO43e2+iocMdX7+CHE14FWhJ7PcNiDk0/zvy3z65EN7PyzgGowOtTmZe9DfKQqkbgWVYilRDpIp05UC8MOp8/VWtNATJlZQNdLFVn5ETpZfdvU5m0aa0aNCK+rg1+Nw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28 Mar 2025, at 9:09, Ryan Roberts wrote: > On 27/03/2025 20:07, Zi Yan wrote: >> On 27 Mar 2025, at 12:44, Matthew Wilcox wrote: >> >>> On Thu, Mar 27, 2025 at 04:06:58PM +0000, Ryan Roberts wrote: >>>> So let's special-case the read(ahead) logic for executable mappings. The >>>> trade-off is performance improvement (due to more efficient storage of >>>> the translations in iTLB) vs potential read amplification (due to >>>> reading too much data around the fault which won't be used), and the >>>> latter is independent of base page size. I've chosen 64K folio size for >>>> arm64 which benefits both the 4K and 16K base page size configs and >>>> shouldn't lead to any read amplification in practice since the old >>>> read-around path was (usually) reading blocks of 128K. I don't >>>> anticipate any write amplification because text is always RO. >>> >>> Is there not also the potential for wasted memory due to ELF alignment? >>> Kalesh talked about it in the MM BOF at the same time that Ted and I >>> were discussing it in the FS BOF. Some coordination required (like >>> maybe Kalesh could have mentioned it to me rathere than assuming I'd be >>> there?) >>> >>>> +#define arch_exec_folio_order() ilog2(SZ_64K >> PAGE_SHIFT) >>> >>> I don't think the "arch" really adds much value here. >>> >>> #define exec_folio_order() get_order(SZ_64K) >> >> How about AMD’s PTE coalescing, which does PTE compression at >> 16KB or 32KB level? It covers 4 16KB and 2 32KB, at least it will >> not hurt AMD PTE coalescing. Starting with 64KB across all arch >> might be simpler to see the performance impact. Just a comment, >> no objection. :) > > exec_folio_order() is defined per-architecture and SZ_64K is the arm64 preferred > size. At the moment x86 is not opted in, but they could choose to opt in with > 32K (or whatever else makese sense) if the HW supports coalescing. Oh, I missed that part. I thought, since arch_ is not there, it was the same for all arch. > > I'm not sure if you thought this was global and are arguing against that, or if > you are arguing for it to be global because it will more easily show us > performance regressions earlier if x86 is doing this too? I thought it was global. It might be OK to set it global and let different arch to optimize it as it rolls out. Opt-in might be "never" until someone looks into it, but if it is global and it changes performance, people will notice and look into it. -- Best Regards, Yan, Zi