From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f170.google.com (mail-io0-f170.google.com [209.85.223.170]) by kanga.kvack.org (Postfix) with ESMTP id 74771828DE for ; Thu, 7 Jan 2016 08:07:06 -0500 (EST) Received: by mail-io0-f170.google.com with SMTP id 1so204410538ion.1 for ; Thu, 07 Jan 2016 05:07:06 -0800 (PST) Received: from mxout1.idt.com (mxout1.idt.com. [157.165.5.25]) by mx.google.com with ESMTPS id 32si3331881iot.211.2016.01.07.05.07.05 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 07 Jan 2016 05:07:05 -0800 (PST) From: "Bounine, Alexandre" Subject: RE: [PATCH v3 UPDATE 09/17] drivers: Initialize resource entry to zero Date: Thu, 7 Jan 2016 13:06:37 +0000 Message-ID: <8D983423E7EDF846BB3056827B8CC5D15CFB6756@corpmail1.na.ads.idt.com> References: <1452028537-27365-1-git-send-email-toshi.kani@hpe.com> In-Reply-To: <1452028537-27365-1-git-send-email-toshi.kani@hpe.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Toshi Kani , "akpm@linux-foundation.org" , "bp@alien8.de" Cc: "linux-arch@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Matt Porter , "linux-acpi@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-sh@vger.kernel.org" Ack-ed. Alex. -----Original Message----- From: Toshi Kani [mailto:toshi.kani@hpe.com]=20 Sent: Tuesday, January 05, 2016 4:16 PM To: akpm@linux-foundation.org; bp@alien8.de Cc: linux-arch@vger.kernel.org; linux-mm@kvack.org; linux-kernel@vger.kerne= l.org; Matt Porter; Bounine, Alexandre; linux-acpi@vger.kernel.org; linux-p= arisc@vger.kernel.org; linux-sh@vger.kernel.org; Toshi Kani Subject: [PATCH v3 UPDATE 09/17] drivers: Initialize resource entry to zero I/O resource descriptor, 'desc' in struct resource, needs to be initialized to zero by default. Some drivers call kmalloc() to allocate a resource entry, but does not initialize it to zero by memset(). Change these drivers to call kzalloc(), instead. Cc: Matt Porter Cc: Alexandre Bounine Cc: linux-acpi@vger.kernel.org Cc: linux-parisc@vger.kernel.org Cc: linux-sh@vger.kernel.org Acked-by: Simon Horman # sh Acked-by: Helge Deller # parisc Signed-off-by: Toshi Kani --- v3 UPDATE: Add cc to RAPIDIO maintainers that was missing. --- drivers/acpi/acpi_platform.c | 2 +- drivers/parisc/eisa_enumerator.c | 4 ++-- drivers/rapidio/rio.c | 8 ++++---- drivers/sh/superhyway/superhyway.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c index 296b7a1..b6f7fa3 100644 --- a/drivers/acpi/acpi_platform.c +++ b/drivers/acpi/acpi_platform.c @@ -62,7 +62,7 @@ struct platform_device *acpi_create_platform_device(struc= t acpi_device *adev) if (count < 0) { return NULL; } else if (count > 0) { - resources =3D kmalloc(count * sizeof(struct resource), + resources =3D kzalloc(count * sizeof(struct resource), GFP_KERNEL); if (!resources) { dev_err(&adev->dev, "No memory for resources\n"); diff --git a/drivers/parisc/eisa_enumerator.c b/drivers/parisc/eisa_enumera= tor.c index a656d9e..21905fe 100644 --- a/drivers/parisc/eisa_enumerator.c +++ b/drivers/parisc/eisa_enumerator.c @@ -91,7 +91,7 @@ static int configure_memory(const unsigned char *buf, for (i=3D0;iname =3D name; @@ -183,7 +183,7 @@ static int configure_port(const unsigned char *buf, str= uct resource *io_parent, for (i=3D0;iname =3D board; res->start =3D get_16(buf+len+1); res->end =3D get_16(buf+len+1)+(c&HPEE_PORT_SIZE_MASK)+1; diff --git a/drivers/rapidio/rio.c b/drivers/rapidio/rio.c index d7b87c6..e220edc 100644 --- a/drivers/rapidio/rio.c +++ b/drivers/rapidio/rio.c @@ -117,7 +117,7 @@ int rio_request_inb_mbox(struct rio_mport *mport, if (mport->ops->open_inb_mbox =3D=3D NULL) goto out; =20 - res =3D kmalloc(sizeof(struct resource), GFP_KERNEL); + res =3D kzalloc(sizeof(struct resource), GFP_KERNEL); =20 if (res) { rio_init_mbox_res(res, mbox, mbox); @@ -185,7 +185,7 @@ int rio_request_outb_mbox(struct rio_mport *mport, if (mport->ops->open_outb_mbox =3D=3D NULL) goto out; =20 - res =3D kmalloc(sizeof(struct resource), GFP_KERNEL); + res =3D kzalloc(sizeof(struct resource), GFP_KERNEL); =20 if (res) { rio_init_mbox_res(res, mbox, mbox); @@ -285,7 +285,7 @@ int rio_request_inb_dbell(struct rio_mport *mport, { int rc =3D 0; =20 - struct resource *res =3D kmalloc(sizeof(struct resource), GFP_KERNEL); + struct resource *res =3D kzalloc(sizeof(struct resource), GFP_KERNEL); =20 if (res) { rio_init_dbell_res(res, start, end); @@ -360,7 +360,7 @@ int rio_release_inb_dbell(struct rio_mport *mport, u16 = start, u16 end) struct resource *rio_request_outb_dbell(struct rio_dev *rdev, u16 start, u16 end) { - struct resource *res =3D kmalloc(sizeof(struct resource), GFP_KERNEL); + struct resource *res =3D kzalloc(sizeof(struct resource), GFP_KERNEL); =20 if (res) { rio_init_dbell_res(res, start, end); diff --git a/drivers/sh/superhyway/superhyway.c b/drivers/sh/superhyway/sup= erhyway.c index 2d9e7f3..bb1fb771 100644 --- a/drivers/sh/superhyway/superhyway.c +++ b/drivers/sh/superhyway/superhyway.c @@ -66,7 +66,7 @@ int superhyway_add_device(unsigned long base, struct supe= rhyway_device *sdev, superhyway_read_vcr(dev, base, &dev->vcr); =20 if (!dev->resource) { - dev->resource =3D kmalloc(sizeof(struct resource), GFP_KERNEL); + dev->resource =3D kzalloc(sizeof(struct resource), GFP_KERNEL); if (!dev->resource) { kfree(dev); return -ENOMEM; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org