From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E497EB64D9 for ; Wed, 14 Jun 2023 10:51:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC19A8E0002; Wed, 14 Jun 2023 06:51:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D721E6B0075; Wed, 14 Jun 2023 06:51:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEB5B8E0002; Wed, 14 Jun 2023 06:51:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AA8C06B0074 for ; Wed, 14 Jun 2023 06:51:23 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 64E5DA092D for ; Wed, 14 Jun 2023 10:51:23 +0000 (UTC) X-FDA: 80901036846.24.9A2226C Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf04.hostedemail.com (Postfix) with ESMTP id CA90740018 for ; Wed, 14 Jun 2023 10:51:20 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=oykCySis; spf=pass (imf04.hostedemail.com: domain of sachinp@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=sachinp@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686739881; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aJ7zyelotHxD5OBYsJJTeD3/e4ECrkKirD1fl7RcU0c=; b=W7mJOLM5cfs7eNmqv6kLUANo+VP1bHMPPvk9hPG89L+KvpWCn06VjoKyZIrxYyB6f2J/j1 56Tdo3ZNdFCROA78XRJwWbm4TwL6MFXZlE7kaiZW1zajBA4h1rKCCnFFLNNY6Mz+ctyRTw IbYbZzhZjDwJSEVo82RCMCwcrvA53u4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686739881; a=rsa-sha256; cv=none; b=bN+kMoFEKfkZujme5yyWhiomjpy6Y1KHSmRt3pZn6CCOP/Z9R/g3eQuzf1kVaAl3mqXNDB TDEFvuJRyeU7hEJIUwYoPwPfSPx+2fLyHvOSKxdJJv90Pe/QjBHk09YfBlFV3gvDOb++61 GPPZM771fbzUagV6W/4wrNXPByiw4BU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=oykCySis; spf=pass (imf04.hostedemail.com: domain of sachinp@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=sachinp@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35EAl2lI003835; Wed, 14 Jun 2023 10:50:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=pp1; bh=aJ7zyelotHxD5OBYsJJTeD3/e4ECrkKirD1fl7RcU0c=; b=oykCySisOsMrPs8cmXzBmBB4G0/ELlB6uQqZD2nqvk/tr8r4Ik7II6wRt6Q8t+if48pK kmalCFClMr8+8T/e3uIk/IkUZN1wm2dzSDhjiF+LPnTcs7Qwzsg6Wip0IOXqxyrNirnS bxV8+OuIz0uufeRqcq/Yp4quTiavfGj/NZ4e/oJ1YbYAVgQXF9DGvRl0rEyIHvJ2jP+r LF0/fwpnD7yCDhHZF7VShc+C7p9LhNxhdfZaUnaDzFazMEynoyw0VQ0KM2U6VgWzW+7a WuumK7F8Au+ohoHK5/9ssu0pnlKB58W916fy6D1J4kRKFijVRrj3yA15GjO9hDPp1LVm Pw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r7c3mg34g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jun 2023 10:50:58 +0000 Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35EAoYWr022030; Wed, 14 Jun 2023 10:50:57 GMT Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r7c3mg33u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jun 2023 10:50:57 +0000 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35E8JgTJ016406; Wed, 14 Jun 2023 10:50:55 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma05fra.de.ibm.com (PPS) with ESMTPS id 3r4gt4t3a4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Jun 2023 10:50:55 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35EAoqYw17826536 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Jun 2023 10:50:52 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C56E520043; Wed, 14 Jun 2023 10:50:52 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9B3CE20040; Wed, 14 Jun 2023 10:50:49 +0000 (GMT) Received: from smtpclient.apple (unknown [9.109.241.192]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 14 Jun 2023 10:50:49 +0000 (GMT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: [PATCH 14/16] powerpc/book3s64/vmemmap: Switch radix to use a different vmemmap handling function From: Sachin Sant In-Reply-To: <20230606045608.55127-15-aneesh.kumar@linux.ibm.com> Date: Wed, 14 Jun 2023 16:20:38 +0530 Cc: linux-mm@kvack.org, Andrew Morton , Nicholas Piggin , Christophe Leroy , Will Deacon , Muchun Song , Catalin Marinas , Dan Williams , Oscar Salvador , linuxppc-dev , Joao Martins , Mike Kravetz Content-Transfer-Encoding: quoted-printable Message-Id: <8D29C151-B9A0-4046-8A5D-56F8A9BEA68F@linux.ibm.com> References: <20230606045608.55127-1-aneesh.kumar@linux.ibm.com> <20230606045608.55127-15-aneesh.kumar@linux.ibm.com> To: "Aneesh Kumar K.V" X-Mailer: Apple Mail (2.3731.600.7) X-TM-AS-GCONF: 00 X-Proofpoint-GUID: _kqAG5tCdNU21ySkOV5WW-8WLcMBBaL3 X-Proofpoint-ORIG-GUID: bWxh9MkH5riO7X_c1axFRZPLXIXDUcE0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-14_06,2023-06-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 priorityscore=1501 impostorscore=0 mlxlogscore=950 suspectscore=0 spamscore=0 lowpriorityscore=0 clxscore=1011 malwarescore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306140090 X-Stat-Signature: piy46yc9arf3arwiuoapy57c6d6xgbsx X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CA90740018 X-Rspam-User: X-HE-Tag: 1686739880-132097 X-HE-Meta: U2FsdGVkX19NIoLwtAGIjevzQXAsDJegdFLYpHrPyerLZKC831SP/LRebBQ4+jxIys7RMg/FRBEJoybJ5TcqsabiXSWMYopEpNecDnzazS3gJeJGRPzxKF9FFj9ZQ8UevHGaYoI/9umUaxYZM3Cnl1qQeCTper4W+bAMNopCTyNtCU+/pqp2IZiVh8VUKJS3DkxsMe7jXclsincnKY7DxNa2loBi/ZhuqIDA+jVAIzmGfaDIOx+Wsetle6QrNUKxxInvfraBwt6RSqshSFDKmdQV0/a9ilScKLzVNYXIr85bIKSZqaAjpwD8mg0MNkFzpq3KuO9k+UM6J3YZUq+lr5w07dO42muE/zeivZ16bppo1udagWG/B4P4hLY2G3ACJ5XQIJnKDwaqFhYtY6uymeBnWCWKsoisrNPJ9c+Lz6bkMghFDN/5Aem5f6k17KAyQdRaq1mh7LSRhS7HSOYswAZeBMIsRALpXE2v6kOIzsbg5sOehlftQqT8bJ4J6D5d5NhVa0pU9azoVc/k3Mxjd/0Kb+oTEPU/2ZajhBXhDoUy4g+XKMmR0YNZu7LS3pAKT4YvePy9eilB3//wDYcIFVLD0Z6IGiQ3Fi5ZCscbq71oDZTi7agNdNqBIMCNySBnGLYT4qow8d3HwOFjPEnSrYAYd3bHobM9IpH7mIW7EbTyWs3mRpGnt7jHs62WM3t9Cnx6PnyFEEklFp+uSQKq+jJJxNez83glEmf1UPb5rHECSGnrx18L4L4Si78REOO2mrA5tl0CU00ZUTM3iNEz5KxNFpFn9KLZqeU05LU2C8FCo73U0vBF0i8ZM4pdgedOjLnTu+IHuPn7lpwDvWxnrarwMJx0xl7Y+WRmMc+dMzU7ipvLFkY0QMlsJKjay4aZND+pEoByL0KrnTFWNy/hjCT+xLQILaaCFngHJ7h5a+seyclA4CZXvQjpkQw7ZImXaLty7bEewbNVJWc4fZ1 rFjxd7y5 52EC2HFCOPKaHzt7AdFOxCxBuivBPPE/X2ugmCbQrQvcCRUP74dY9Hiqg1Z7YW5ngeA9Cv17B8PUY5HMB3VGsO1u/Vg656uAcOmRpwPXg2SG0ng6fXJ9398RSHisbUeL20AeZqpnHBKXXA/gDmIHV+9mqXvjm/WKweB43xl8d/FE3CWC8gwKPNpdp+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > 1. First try to map things using PMD (2M) > 2. With altmap if altmap cross-boundary check returns true, fall back = to PAGE_SIZE > 3. IF we can't allocate PMD_SIZE backing memory for vmemmap, fallback = to PAGE_SIZE >=20 > On removing vmemmap mapping, check if every subsection that is using = the vmemmap > area is invalid. If found to be invalid, that implies we can safely = free the > vmemmap area. We don't use the PAGE_UNUSED pattern used by x86 because = with 64K > page size, we need to do the above check even at the PAGE_SIZE = granularity. >=20 > Signed-off-by: Aneesh Kumar K.V > --- With this patch series applied I see the following warning [ OK ] Started Monitoring of LVM2 mirrors,=E2=80=A6sing dmeventd or = progress polling. [ 3.283884] papr_scm ibm,persistent-memory:ibm,pmemory@44104001: = nvdimm pmu didn't register rc=3D-2 [ 3.284212] papr_scm ibm,persistent-memory:ibm,pmemory@44104002: = nvdimm pmu didn't register rc=3D-2 [ 3.563890] radix-mmu: Mapped 0x0000040010000000-0x0000040c90000000 = with 64.0 KiB pages [ 3.703227] ------------[ cut here ]------------ [ 3.703236] failed to free all reserved pages [ 3.703244] WARNING: CPU: 41 PID: 923 at mm/memremap.c:152 = memunmap_pages+0x37c/0x3a0 [ 3.703252] Modules linked in: device_dax(+) nd_pmem nd_btt dax_pmem = papr_scm libnvdimm pseries_rng vmx_crypto aes_gcm_p10_crypto ext4 = mbcache jbd2 sd_mod t10_pi crc64_rocksoft crc64 sg ibmvscsi = scsi_transport_srp ibmveth fuse [ 3.703272] CPU: 41 PID: 923 Comm: systemd-udevd Not tainted = 6.4.0-rc6-00037-gb6dad5178cea-dirty #1 [ 3.703276] Hardware name: IBM,9080-HEX POWER10 (raw) 0x800200 = 0xf000006 of:IBM,FW1030.20 (NH1030_058) hv:phyp pSeries [ 3.703280] NIP: c00000000057a18c LR: c00000000057a188 CTR: = 00000000005ca81c [ 3.703283] REGS: c000000032a170d0 TRAP: 0700 Not tainted = (6.4.0-rc6-00037-gb6dad5178cea-dirty) [ 3.703286] MSR: 800000000282b033 = CR: 48248824 XER: 00000002 [ 3.703296] CFAR: c00000000015f0c0 IRQMASK: 0 [ 3.703296] GPR00: = c00000000057a188 c000000032a17370 c000000001421500 0000000000000021 [ = 3.703296] GPR04: 00000000ffff7fff c000000032a17140 c000000032a17138 = 0000000000000027 [ 3.703296] GPR08: c0000015c91a7c10 = 0000000000000001 0000000000000027 c000000002a18a20 [ 3.703296] = GPR12: 0000000048248824 c0000015cb9f4300 c000000032a17d68 = c000000001262b20 [ 3.703296] GPR16: c008000001310000 = 000000000000ff20 000000000000fff2 c0080000012d7418 [ 3.703296] = GPR20: c000000032a17c30 0000000000000004 ffffffffffffc005 = 0000000001000200 [ 3.703296] GPR24: c000000002f11570 = c00000000e376870 0000000000000001 0000000000000001 [ 3.703296] = GPR28: c00000000e376840 c00000000e3768c8 0000000000000000 = c00000000e376840 [ 3.703333] NIP [c00000000057a18c] = memunmap_pages+0x37c/0x3a0 [ 3.703338] LR [c00000000057a188] memunmap_pages+0x378/0x3a0 [ 3.703342] Call Trace: [ 3.703344] [c000000032a17370] [c00000000057a188] = memunmap_pages+0x378/0x3a0 (unreliable) [ 3.703349] [c000000032a17420] [c00000000057a928] = memremap_pages+0x4a8/0x890 [ 3.703355] [c000000032a17500] [c00000000057ad4c] = devm_memremap_pages+0x3c/0xd0 [ 3.703359] [c000000032a17540] [c0080000011c084c] = dev_dax_probe+0x134/0x3a0 [device_dax] [ 3.703366] [c000000032a175e0] [c0000000009f7e8c] = dax_bus_probe+0xac/0x140 [ 3.703371] [c000000032a17610] [c0000000009b5828] = really_probe+0x108/0x530 [ 3.703375] [c000000032a176a0] [c0000000009b5d04] = __driver_probe_device+0xb4/0x200 [ 3.703379] [c000000032a17720] [c0000000009b5ea8] = driver_probe_device+0x58/0x120 [ 3.703383] [c000000032a17760] [c0000000009b6298] = __driver_attach+0x148/0x250 [ 3.703387] [c000000032a177e0] [c0000000009b1a58] = bus_for_each_dev+0xa8/0x130 [ 3.703392] [c000000032a17840] [c0000000009b4b34] = driver_attach+0x34/0x50 [ 3.703396] [c000000032a17860] [c0000000009b3b98] = bus_add_driver+0x258/0x300 [ 3.703400] [c000000032a178f0] [c0000000009b78d4] = driver_register+0xa4/0x1b0 [ 3.703404] [c000000032a17960] [c0000000009f9530] = __dax_driver_register+0x50/0x70 [ 3.703409] [c000000032a17980] [c0080000011c1374] dax_init+0x3c/0x58 = [device_dax] [ 3.703414] [c000000032a179a0] [c000000000013260] = do_one_initcall+0x60/0x2f0 [ 3.703418] [c000000032a17a70] [c000000000248af8] = do_init_module+0x78/0x310 [ 3.703424] [c000000032a17af0] [c00000000024bcac] = load_module+0x2a7c/0x2f30 [ 3.703429] [c000000032a17d00] [c00000000024c4f0] = __do_sys_finit_module+0xe0/0x180 [ 3.703434] [c000000032a17e10] [c0000000000374c0] = system_call_exception+0x140/0x350 [ 3.703439] [c000000032a17e50] [c00000000000d6a0] = system_call_common+0x160/0x2e4 [ 3.703444] --- interrupt: c00 at 0x7fff9af2fb34 [ 3.703447] NIP: 00007fff9af2fb34 LR: 00007fff9b6dea9c CTR: = 0000000000000000 [ 3.703450] REGS: c000000032a17e80 TRAP: 0c00 Not tainted = (6.4.0-rc6-00037-gb6dad5178cea-dirty) [ 3.703453] MSR: 800000000280f033 = CR: 28222204 XER: 00000000 [ 3.703462] IRQMASK: 0 [ 3.703462] GPR00: 0000000000000161 = 00007fffed351350 00007fff9b007300 000000000000000f [ 3.703462] = GPR04: 00007fff9b6ead30 0000000000000000 000000000000000f = 0000000000000000 [ 3.703462] GPR08: 0000000000000000 = 0000000000000000 0000000000000000 0000000000000000 [ 3.703462] = GPR12: 0000000000000000 00007fff9b7c6610 0000000000020000 = 000000011057db18 [ 3.703462] GPR16: 00000001105c0108 = 0000000110585f48 0000000000000000 0000000000000000 [ 3.703462] = GPR20: 0000000000000000 0000000110585f80 0000000147985200 = 00007fffed351570 [ 3.703462] GPR24: 00000001105c0128 = 0000000000020000 0000000000000000 0000000147981010 [ 3.703462] = GPR28: 00007fff9b6ead30 0000000000020000 0000000000000000 = 0000000147985200 [ 3.703497] NIP [00007fff9af2fb34] 0x7fff9af2fb34 [ 3.703499] LR [00007fff9b6dea9c] 0x7fff9b6dea9c [ 3.703502] --- interrupt: c00 [ 3.703504] Code: 60000000 3d220170 8929b2b7 2f890000 409eff28 = 3c62ffe7 39200001 3d420170 3863c518 992ab2b7 4bbe4e55 60000000 = <0fe00000> fac10060 fae10068 fb010070 [ 3.703516] ---[ end trace = 0000000000000000 ]--- [ 3.703520] device_dax: probe of dax0.0 failed with error -12 [ OK ] Created slice system-daxdev\x2dreconfigure.slice. [ OK ] Started udev Wait for Complete Device Initialization. [ OK ] Reached target Local File Systems (Pre). [ OK ] Reached target Local File Systems. The warning appears after applying this patch.=20 - Sachin