From: Zi Yan <ziy@nvidia.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>,
Naoya Horiguchi <naoya.horiguchi@nec.com>
Subject: Re: v5.18-rc1: migratepages triggers VM_BUG_ON_FOLIO(folio_nr_pages(old) != nr_pages)
Date: Mon, 04 Apr 2022 12:41:04 -0400 [thread overview]
Message-ID: <8BCE1B82-6D5E-4E7B-B744-402167D34A3F@nvidia.com> (raw)
In-Reply-To: <YksXfckGevTN1QD+@casper.infradead.org>
[-- Attachment #1: Type: text/plain, Size: 972 bytes --]
On 4 Apr 2022, at 12:06, Matthew Wilcox wrote:
> On Mon, Apr 04, 2022 at 11:44:39AM -0400, Zi Yan wrote:
>> I am wondering if my change is the right fix or not. folios with order>0
>> are still available when CONFIG_TRANSPARENT_HUGEPAGE is not set, right?
>
> That's the eventual plan, but it's not possible today. We need to
> be able to split large folios (eg in truncation) and that functionality
> is still under CONFIG_TRANSPARENT_HUGEPAGE in mm/huge_memory.c. So
> large folios depend on CONFIG_TRANSPARENT_HUGEPAGE instead of having a
> clean separation between functionality-to-support-PMD-mapping and
> functionality-to-support-order>0.
>
> So I preferred your earlier patch because it's more obvious. I mean,
> we could pull in the two or three patches from my tree that convert
> these functions and their callers to folios ... we're only at rc1.
> I can post them and see what others think.
OK, I will send out my initial patch.
--
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
prev parent reply other threads:[~2022-04-04 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 13:29 Naoya Horiguchi
2022-04-04 14:05 ` Zi Yan
2022-04-04 14:29 ` Matthew Wilcox
2022-04-04 14:47 ` Zi Yan
2022-04-04 15:18 ` Naoya Horiguchi
2022-04-04 15:44 ` Zi Yan
2022-04-04 16:06 ` Matthew Wilcox
2022-04-04 16:41 ` Zi Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8BCE1B82-6D5E-4E7B-B744-402167D34A3F@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=naoya.horiguchi@linux.dev \
--cc=naoya.horiguchi@nec.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox