From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87249C433E0 for ; Tue, 14 Jul 2020 00:15:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 56DD2217BA for ; Tue, 14 Jul 2020 00:15:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56DD2217BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=i-love.sakura.ne.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C40768D0002; Mon, 13 Jul 2020 20:15:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF0948D0001; Mon, 13 Jul 2020 20:15:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B078C8D0002; Mon, 13 Jul 2020 20:15:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id 97F3A8D0001 for ; Mon, 13 Jul 2020 20:15:38 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 12E5A2DFD for ; Tue, 14 Jul 2020 00:15:38 +0000 (UTC) X-FDA: 77034762756.30.coal11_220b98426eec Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id D1E92180B3C83 for ; Tue, 14 Jul 2020 00:15:37 +0000 (UTC) X-HE-Tag: coal11_220b98426eec X-Filterd-Recvd-Size: 2633 Received: from www262.sakura.ne.jp (www262.sakura.ne.jp [202.181.97.72]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Jul 2020 00:15:36 +0000 (UTC) Received: from fsav405.sakura.ne.jp (fsav405.sakura.ne.jp [133.242.250.104]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 06E0FPTn049999; Tue, 14 Jul 2020 09:15:25 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav405.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav405.sakura.ne.jp); Tue, 14 Jul 2020 09:15:25 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav405.sakura.ne.jp) Received: from [192.168.1.9] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 06E0FPR7049994 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 14 Jul 2020 09:15:25 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Subject: Re: [PATCH] mm, oom: don't invoke oom killer if current has been reapered To: Michal Hocko Cc: Yafang Shao , David Rientjes , Andrew Morton , Linux MM References: <1594437481-11144-1-git-send-email-laoar.shao@gmail.com> <20200713060154.GA16783@dhcp22.suse.cz> <20200713062132.GB16783@dhcp22.suse.cz> <20200713124503.GF16783@dhcp22.suse.cz> <20200713190538.GG16783@dhcp22.suse.cz> From: Tetsuo Handa Message-ID: <89f091d3-2398-f3c7-94ae-b0172115ac25@i-love.sakura.ne.jp> Date: Tue, 14 Jul 2020 09:15:26 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200713190538.GG16783@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D1E92180B3C83 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020/07/14 4:05, Michal Hocko wrote: > Another alternative would be to check mem_cgroup_margin after the lock > is taken but it would be better to keep in sync with the global case as > much as possible unless there is a good reason to differ. > If mem_cgroup_margin() is something what zone_watermark_ok() from get_page_from_freelist() will do, checking mem_cgroup_margin() with oom_lock held will make more keep in sync with the global case (i.e. calling __alloc_pages_may_oom() with oom_lock held).