From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5457FE7717F for ; Wed, 11 Dec 2024 02:21:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 813876B0142; Tue, 10 Dec 2024 21:21:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C1E46B02A1; Tue, 10 Dec 2024 21:21:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 689DD6B02A2; Tue, 10 Dec 2024 21:21:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4A3D26B0142 for ; Tue, 10 Dec 2024 21:21:21 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A9564140D3E for ; Wed, 11 Dec 2024 02:21:20 +0000 (UTC) X-FDA: 82881075900.16.F07F8F7 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf16.hostedemail.com (Postfix) with ESMTP id 0BAFE180003 for ; Wed, 11 Dec 2024 02:20:52 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of yi.zhang@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=yi.zhang@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733883663; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LNZvn5CUZ3PJKpfXDehopMsIag1dTxA1Ih86EhGLlAk=; b=H5AsbF0CPZz9Ebk2EjXUMS3yXLhcJt1BhOiWnBlKxtUk/D0haXHWt60gVFZCJ2r6Nh/v3y iHcFa+ngWZ4tR0JTnMq0U5dwdllo/ptBwPh1XPJ2ExlCY4xtEQGElxUlg91weHeNzH8hOI RyIaMLIkSJnOwSc1fr4hNFixicD1pSk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of yi.zhang@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=yi.zhang@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733883663; a=rsa-sha256; cv=none; b=NZOLRww7CIw3Rj269A9ybVzJ/vqDwKZlie2dvsNFLQo/NhViYfx1BNBqbompiEttLQiAuf 2tck8QLT+0TybsD4lgkgohp9GdJTvkoQYjU6MP6u/FhAKqgeOJADGGwuMnjcMEDECfaLEF L//5Wr9En6XCTco4FEpQQK5LgNt5Z9g= Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Y7K8S1SHJz4f3jkk for ; Wed, 11 Dec 2024 10:20:56 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id 6EB751A0568 for ; Wed, 11 Dec 2024 10:21:10 +0800 (CST) Received: from [10.174.179.80] (unknown [10.174.179.80]) by APP4 (Coremail) with SMTP id gCh0CgBHIoYT91hnOzoHEQ--.51391S3; Wed, 11 Dec 2024 10:21:09 +0800 (CST) Message-ID: <89ef2543-7373-455b-83bb-c3d51afe9386@huaweicloud.com> Date: Wed, 11 Dec 2024 10:21:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next] ovl: respect underlying filesystem's get_unmapped_area() To: Matthew Wilcox , Jinjiang Tu Cc: miklos@szeredi.hu, amir73il@gmail.com, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com, Zhang Yi References: <20241205143038.3260233-1-tujinjiang@huawei.com> <4a8e2901-12b3-b700-383c-3193adc0ed60@huawei.com> <30caaca6-df23-c1cc-1980-88b83600807f@huawei.com> Content-Language: en-US From: Zhang Yi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgBHIoYT91hnOzoHEQ--.51391S3 X-Coremail-Antispam: 1UD129KBjvJXoW7AFyrtrW8Gr1DCr1UCr1UAwb_yoW8Ary5pF Z8Za1kKFs8Xr4kC39F9r15Xr1Dt345tF15u34rJ34SgFyqvFya9r4fK3Z8CFn7uw4xAw10 gay7WFy2gry3tFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvjb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lFIxGxcIEc7CjxVA2Y2ka0xkIwI1lc7CjxVAaw2AF wI0_Jw0_GFyl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4 xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43 MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I 0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWU JVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUF1 v3UUUUU X-CM-SenderInfo: d1lo6xhdqjqx5xdzvxpfor3voofrz/ X-Rspamd-Server: rspam05 X-Stat-Signature: w8dro7bzp49edmucrqu31mi7pyjnpwqo X-Rspamd-Queue-Id: 0BAFE180003 X-Rspam-User: X-HE-Tag: 1733883652-743484 X-HE-Meta: U2FsdGVkX190z22py7/gcdM51k91dWA3elvmjPENXPPQW0xE/vAWQr1dPbNzhA5S7qUoG+g7Ovh/o534bMs8m9M1IzPN/p6WEF6ITbBdXn6KsUkH0Q00vHu6dxZgPqdf9VxP5byW+qUnAXoGsDCM8pYRvm9e7abQaIUwmi8ZIAJhCutdyqHba4FC+3xMfdChVOSJKBsWaja1i23ccLhga59rKNIxd94b2DuxK72l+ysGQYS7w5i2kmzQ38BXwuQZ7AYocZWZ9wg0zce2x0IxnwNPgBTCocf7KPMR8luA+bOjqQlsP8WGfGK3ilJKE5iDzqnoRb+l/SZsDIFYk/v6tEwgZZWn7mE97q7uEMQtHCWBrjk8mkxAo6iouIPJGRStSyop4R1DK2+kV86stGL3f7nvBkETK8pCVGoo9m+5LXXZuQlevnFrVBWoO0f0rH156rJxlI7WAvketJ9LoQuU/HEGpSbAMiw8ZD365bOyvv7js2lM8AcHGRZb4Yad9DOd3vf76rS60MlVoKA7XK/R88Z9bKpvcRMXGd0sXAPXaHOoMW+0Lo/Ku/uCMAM5Ahq+sWJf/64adQsBfuyezftigGz8yYKGJC3HQNFfmXXCCIANXf01AS+8moCYKTgv2a8w8LpQfT84XRjkIR2YKMt1WCcQbLnOm0jTeCLuuNJXJDIMVmQr9ueOMCq02TPcOBWe4o7Vn2481iRhl0VEMhMuz88CQwXClsRBT2Bh3pjAytUZ8iJifCtpUGYWvon6d+8aKI/5UAu6VJPijpjfE5Eii0yNDJsXdcaMhJlLtX76TCAhaoOLI8eVFp7JmtztXpIQT4nC2NEEQ8LLwpALeCV1y49Ww4mObS/UzZoaRRjNaeI0jKBOifle5jT889cz2OJRKIHtkviFQ+93MPX4Ee4TiuKtvNaF3xfs0x0fQbXZcm+PcWLT6wYDAvByY0rSni74sgSyzBAmSxa3HJUhJRW 7+jBlHlj OMzROsnG7XZ9Xk8/vPlYTu0Ed+QZb/v7HKAfGuS7/ruXP/mNCWYNpJowrQpq7wp0BKK/RtVLQYKhO3i8MQJpIYp7UOxvpZm3wc0pXyTZFfizEov7IZ0wdW5AoItWqzOOzpC8N2epPeHZQlbHTOwdETb4wkQUr1VH9RjhB4KY6WKYJkFYRIPsHFfLeZcUNtMLCdaujTVy/57xb6PbrhKqIWCySR5luV1qQyS7hmAoBJmlhpwyA3nJNF/IZlj1lAQK6HpHL/n2LX/JC99EDYvTdkNh2Qg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/11 1:58, Matthew Wilcox wrote: > On Tue, Dec 10, 2024 at 03:13:21PM +0800, Jinjiang Tu wrote: >> 在 2024/12/9 21:33, Matthew Wilcox 写道: >>> On Mon, Dec 09, 2024 at 02:43:08PM +0800, Jinjiang Tu wrote: >>>> 在 2024/12/6 21:58, Matthew Wilcox 写道: >>>>> On Thu, Dec 05, 2024 at 10:30:38PM +0800, Jinjiang Tu wrote: >>>>>> During our tests in containers, there is a read-only file (i.e., shared >>>>> Show your test. >>>> I mmap an overlayfs file with PROT_READ, and call madvise(MADV_COLLAPSE), the code >>>> is as follows: >>>> >>>> fd = open(path, O_RDONLY); >>>> addr = mmap(NULL, size, PROT_READ, MAP_PRIVATE, fd, 0); >>>> ret = madvise(addr, size, MADV_COLLAPSE); >>>> >>>> The addr isn't THP-aligned and ret is -1, errno is EINVAL. >>> Then your test is buggy. >>> >>> * Check alignment for file vma and size for both file and anon vma by >>> * filtering out the unsuitable orders. >>> >>> You didn't align your mmap, so it's expected to fail. >> >> When mmap an ext4 file, since ext4_file_operations defines ".get_unmapped_area = thp_get_unmapped_area", it calls thp_get_unmapped_area() in __get_unmapped_area to >> mmap at a THP-aligned address. >> >> For overlayfs file, it's underlying filesystem may be ext4, which supports large folio. For this situation, should we mmap at a THP-aligned address too, to map >> THP? > > Actually, ext4 doesn't support large folios. > I have sent out two series to enable ext4 support for large folios. Feel free to give it a try. https://lore.kernel.org/linux-ext4/20241022111059.2566137-1-yi.zhang@huaweicloud.com/ https://lore.kernel.org/linux-ext4/20241125114419.903270-1-yi.zhang@huaweicloud.com/ Thanks, Yi.