From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23FA3C433FE for ; Tue, 12 Apr 2022 23:35:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 928DA6B0072; Tue, 12 Apr 2022 19:35:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D6726B0073; Tue, 12 Apr 2022 19:35:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C5696B0074; Tue, 12 Apr 2022 19:35:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 6D7286B0072 for ; Tue, 12 Apr 2022 19:35:06 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 310D4121EF3 for ; Tue, 12 Apr 2022 23:35:06 +0000 (UTC) X-FDA: 79349835012.12.7D6E7CC Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf25.hostedemail.com (Postfix) with ESMTP id 96F2BA0004 for ; Tue, 12 Apr 2022 23:35:05 +0000 (UTC) Received: by mail-pl1-f173.google.com with SMTP id y6so429544plg.2 for ; Tue, 12 Apr 2022 16:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=v3LmgCFYjJTtgy2P/sVi0E16CrjX+gEYqyGQNLsRn+4=; b=WF/gxV4Uzq+1Ie+JART8CiACqUetITjYYftWV6JzqUCORfdhubyUb5jExhtOFxoxN/ Z5yb6G4gjmKkJ4FgHguSnih2sQW6cauW1RiaJQMVp7G05cWN2Ea4SmDVsDe6EwqpLCr/ COalLlnFXB4OoUMPlxzQTvBWQeD5Tl5nfFV4jmYIVYDUcLLX7vl52Y2Dok9cXu/terpo 3pxuStP/tE7ZsQ0BfML0wQXhtyr8kLERv2H1UQUj3Ln5A2D9v3PAzb9Xgslaba0BkSes BBEfilcWGopjWK/DLHyYEHAT0IT/q7/NUfttAmPS4IswCBdUtLxoY/N+Rb1EXZUFIhGS 9LHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=v3LmgCFYjJTtgy2P/sVi0E16CrjX+gEYqyGQNLsRn+4=; b=To7WFXd1RSivvyA4fV4oT6EJW3vdBDbGp24GhByaI4mUajmxQV3PEvtEHSLeRNiK8v OUSxXUgk+/CtD3RJfRQMQCB/FJ9Am1D7qm1+6H1QjvefkOeJJTUyk0l3sx09R15uQwbb Qfk4aOBsUEcl+34MNXIOBN+1+6PPprNDEtl9Odt80bAyd257GGr/AoV/Mh+zhEumMt6p wN2iPAqQqwEnLOPVtB5XeHBtvONATp8i1N435lspdHgE9uhAQLByinG05T2c5X8HBbZD zxiROCtL7LUWJFTrOe2S5JGJfqnif63M04RzOG6bjRKZbYUmHUrKNkbF0sUAsNZ0yr62 oA9w== X-Gm-Message-State: AOAM532ynfkPjq+w6LQiHDbMD01xw7ErFAtnYpDYrPYlMgjeTqTTf8bd zoEOVBM0/eQUqhqkQ4J+0Tgtdw== X-Google-Smtp-Source: ABdhPJz/mXbbbncHMs7aYHE5yX2Gf+irBnmESeOYzYPCGTcqSEOVSMz7JDK47tpFFlazpajv502rNQ== X-Received: by 2002:a17:903:4c:b0:158:8e21:213d with SMTP id l12-20020a170903004c00b001588e21213dmr4386023pla.108.1649806504282; Tue, 12 Apr 2022 16:35:04 -0700 (PDT) Received: from [2620:15c:29:204:1a89:45ec:16da:55dc] ([2620:15c:29:204:1a89:45ec:16da:55dc]) by smtp.gmail.com with ESMTPSA id f23-20020a635117000000b0039d4f859738sm3859103pgb.71.2022.04.12.16.35.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 16:35:03 -0700 (PDT) Date: Tue, 12 Apr 2022 16:35:03 -0700 (PDT) From: David Rientjes To: JaeSang Yoo cc: Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Ohhoon Kwon , Wonhyuk Yang , Jiyoup Kim , Donghyeok Kim , Christoph Lameter , JaeSang Yoo , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slub: remove unused parameter in setup_object*() In-Reply-To: <20220411072534.3372768-1-jsyoo5b@gmail.com> Message-ID: <89e4e3a4-111e-18fb-3542-acc45b8431cd@google.com> References: <20220411072534.3372768-1-jsyoo5b@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: b6so931mrtyan1hrimmkch8piwmsngyn Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="WF/gxV4U"; spf=pass (imf25.hostedemail.com: domain of rientjes@google.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 96F2BA0004 X-HE-Tag: 1649806505-630637 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 11 Apr 2022, JaeSang Yoo wrote: > setup_object_debug() and setup_object() has unused parameter, "struct > slab *slab". Remove it. > > By the commit 3ec0974210fe ("SLUB: Simplify debug code"), > setup_object_debug() were introduced to refactor previous code blocks > in the setup_object(). Previous code used SlabDebug() to init_object() > and init_tracking(). As the SlabDebug() takes "struct page *page" as > argument, the setup_object_debug() checks flag of "struct kmem_cache *s" > which doesn't require "struct page *page". > As the struct page were changed into struct slab by commit bb192ed9aa719 > ("mm/slub: Convert most struct page to struct slab by spatch"), but it's > still unused parameter. > > Suggested-by: Ohhoon Kwon > Signed-off-by: JaeSang Yoo Acked-by: David Rientjes