From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46655C001DF for ; Tue, 1 Aug 2023 03:02:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D26542800D2; Mon, 31 Jul 2023 23:02:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD5A62800C8; Mon, 31 Jul 2023 23:02:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEB122800D2; Mon, 31 Jul 2023 23:02:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B32392800C8 for ; Mon, 31 Jul 2023 23:02:47 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8656812042F for ; Tue, 1 Aug 2023 03:02:47 +0000 (UTC) X-FDA: 81074038374.10.2745652 Received: from out199-15.us.a.mail.aliyun.com (out199-15.us.a.mail.aliyun.com [47.90.199.15]) by imf12.hostedemail.com (Postfix) with ESMTP id C122B4000C for ; Tue, 1 Aug 2023 03:02:41 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.15 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690858966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HP73KXO7HtYfzx/yAF2iDcsbWuE+EizWZFx8q0hWYgY=; b=RVoxovwuc6ld6XiTFNb2f8dlakGUXrkiJcxfCNa0/+v/hiwyOWQyzToB5eM2m3yM28R+Ia J+d8IawzcOGL+1OGwQozzdCbjQ81Cvjh6Zm0d2KdFDjk9RGJKBThzVqpAqogtZijumPAlX W5XN1SSj0OWYXYENATxBxQXh8kDoUcM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690858966; a=rsa-sha256; cv=none; b=GGNQFNnFFza9kZ7gZkqdEJP/BjR3JWZ2s1PzHSZVXX7b/nGkSJS2TJ8C5YzkbWNsN4sTz2 b9kGYmGurBYLT1XT/189n9M3MZJF0Bkmrl5slc59u5apXZVfcPHfwwlmS+GtXgHzAJE/H5 kWT2fYREcsyIz6sB8ZONK6jaJ1OB3GM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 47.90.199.15 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R921e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0VojoVVU_1690858355; Received: from 30.97.48.66(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VojoVVU_1690858355) by smtp.aliyun-inc.com; Tue, 01 Aug 2023 10:52:36 +0800 Message-ID: <89d7ec1d-ac48-64e5-1d3c-d3ee5c66a26f@linux.alibaba.com> Date: Tue, 1 Aug 2023 10:53:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 7/8] mm/compaction: remove unnecessary return for void function To: Kemeng Shi , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mgorman@techsingularity.net, willy@infradead.org, david@redhat.com References: <20230728171037.2219226-1-shikemeng@huaweicloud.com> <20230728171037.2219226-8-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20230728171037.2219226-8-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: xbdr8n9rtz4tnzursdyifos4cnk7oi43 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C122B4000C X-Rspam-User: X-HE-Tag: 1690858961-237000 X-HE-Meta: U2FsdGVkX197FSu17mcxMFmjYCa5vdePX8uB0+mgXqxLcMqYaRHW/ZFvmHceNH0tMEsuutwRlgzZXhN0Tdwm9Hfu7Kosln1sENfHd2dcsqJvMIB8gLlpwyNmgKM4NOwqAjY7AkoskdxUl6aIZ7inmRBGmOjD2cEjCtSPjmxk82m590AKDye8SLm0ApL3867uQWvJ8kja8ck8hVMDyHzXKEPvUjmwmCyPv7D9Fbatoz01tPxwOYW5RhkSxjJzMCJiwCDCS5yd5BfEMZH9E4jTEgJplseVtDniLQhS560hO1apkLtE1mz3g9De2Vllqfkh2pTonyNC47U++/V+t21L6+qo95x9BKaDdlCrP7O3VI6o/1SNMlcEec1d1AhpLfJyEm7roVdwFEBZ51XFec9zkzR1Jr1pZH/ilRVev2XS+k1oSz17t0GQrj2uk2v94HtOD9cpU6O571H52ig7NkZAwtIHBnUw/3IMJCEPhPHocRvD0m3tvIlMJU3HfOhHlQn12x4Vz9tijce2MN9GvHz+mdyopOwSNGpeyzetn4J04Voglte5MgcsFzPdmwpVvOqKBgNxrFQdzJJgt2SOPHpa/IShxmRYy0bq18214k5zKkaG3vwrrj5T67j95G38NRTiP8xo8UQyrBZKO8D43mISu3oFrjdxB0ScW9pKCRUK95Dlv2ALbRLfYEeYWFwggbrkxzJTvwHZpuJxFICo7fcbzsmccfX8XfSyYr3jVDIZsV4bSlNzmnQrOfMumTZHQNvW5RrD8ksBfz1Z4azSM2Ar77VvZhBQwT6O5NRSGjdd0TCVLNYIQuQCtxjKcuwf+e6xNkcqDk5K0Ks6h9SaZzSCdXQq0/VZy6XPgejOzvK4k06uva+07cUdk4jV1bCD5pwhNsssdbZ9CGUZPgEFvksKY064XuZiG9istT39LQnVBoUYFq8w0i4JIpVpYf+R0igQzGj6MU88A/6TDT0aZI6 RxNpEqeS rn3M/wTho1GNMS0U1AIwzRnZoDdqO9tSJ2aKLbwWI5RWN+fV3V2VJViCzTnfaHDxE7M3mtyho54bV9NEz5PkF+ndwhHlVzebnSh9YtRHPUjk/bFg9Y4FswHNWIc+pf8OCdBxky3GUCzqid9lxbzozfbpjiQLrWcxUuFcV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/29/2023 1:10 AM, Kemeng Shi wrote: > Remove unnecessary return for void function > > Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang > --- > mm/compaction.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 6052cb519de1..188d610eb3b6 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1420,8 +1420,6 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) > /* Skip this pageblock in the future as it's full or nearly full */ > if (start_pfn == end_pfn) > set_pageblock_skip(page); > - > - return; > } > > /* Search orders in round-robin fashion */ > @@ -2863,7 +2861,7 @@ int compaction_register_node(struct node *node) > > void compaction_unregister_node(struct node *node) > { > - return device_remove_file(&node->dev, &dev_attr_compact); > + device_remove_file(&node->dev, &dev_attr_compact); > } > #endif /* CONFIG_SYSFS && CONFIG_NUMA */ >