From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9A2EC433E0 for ; Wed, 17 Mar 2021 10:12:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C87DD64F6A for ; Wed, 17 Mar 2021 10:12:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C87DD64F6A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0D9AB6B006E; Wed, 17 Mar 2021 06:12:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B2076B0070; Wed, 17 Mar 2021 06:12:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E93DF6B0071; Wed, 17 Mar 2021 06:12:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id D186B6B006E for ; Wed, 17 Mar 2021 06:12:47 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 98E1B814F for ; Wed, 17 Mar 2021 10:12:47 +0000 (UTC) X-FDA: 77928952374.15.4437CF3 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf03.hostedemail.com (Postfix) with ESMTP id E7754C0007D4 for ; Wed, 17 Mar 2021 10:12:46 +0000 (UTC) Received: by mail-ed1-f45.google.com with SMTP id y6so1540539eds.1 for ; Wed, 17 Mar 2021 03:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=g6jWkldAHO5fX2fG11foqEywJJvIYAjFVfktp5dG8UE=; b=dmWU5CkJN4qow5UZOOVDkEx2U/1U2Td7MwDJq8e/465o/XY1/bklUN4eFHZyMj9Em4 y+MjuRKKxuVY++jC+LMab0eIS7ngeRN2FEMbMzpwNGG26bGp8ieVxWYFqceptZ1KWUjz g5utfiSnjU5NJO5sNoXcXxlPTavsPz7n98QRE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=g6jWkldAHO5fX2fG11foqEywJJvIYAjFVfktp5dG8UE=; b=uKxEyh8rz5JSBN1HboGizFuWey4FIZlfoRLw8hacZj1Wmcw1iL7YmW91QRWwfF1XbL YgpWBlTiAfPCy7LZ8YrQrME/cJfia89yf6clo+RZGr9vksPz7do08560MWXdWrNhs6tI 0t0l+h7hNyheCS5wr5nL+7lmYOrrk7ozgxY8D/qSg6HurRTgC3UdlzmZzdxpCR9Zyg66 jD8jDaCcCD/5L6CeK473YTsqW/uReoOnRZR1+ZRj5nAntKos5ZptZn18kPOt/bASX43b F1DN7waBfJn7qXG1JxChRniYh2JHSVrx1L/QYCQcAKfXEr3o2GQ0ncEO6PSTVxj1CpmF bT+A== X-Gm-Message-State: AOAM533OkdjDw/royX59g8QXofOp2CeJ8A+V6pjjb5kms5gZv4nnOzk9 6TEJbMSbgIOvScy9qVbHr41vVg== X-Google-Smtp-Source: ABdhPJwU+dmqZqqJcrlBnwk2GG7j9R7yBflLt8u0uwaTSwxwQTw1HuU1HGn4BQglcxrKOhmq/1fALQ== X-Received: by 2002:a05:6402:17d6:: with SMTP id s22mr40687326edy.232.1615975965680; Wed, 17 Mar 2021 03:12:45 -0700 (PDT) Received: from [192.168.1.149] ([80.208.71.248]) by smtp.gmail.com with ESMTPSA id si7sm11098174ejb.84.2021.03.17.03.12.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Mar 2021 03:12:45 -0700 (PDT) Subject: Re: [PATCH v2] Increase page and bit waitqueue hash size To: Nicholas Piggin , linux-kernel@vger.kernel.org Cc: Andrew Morton , Linus Torvalds , linux-mm@kvack.org, Anton Blanchard , Ingo Molnar References: <20210317075427.587806-1-npiggin@gmail.com> From: Rasmus Villemoes Message-ID: <89cb49c0-2736-dd4c-f401-4b88c22cc11f@rasmusvillemoes.dk> Date: Wed, 17 Mar 2021 11:12:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210317075427.587806-1-npiggin@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: uh5g6jea1748fr3efmy4yoc39qtsr1ec X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E7754C0007D4 Received-SPF: none (rasmusvillemoes.dk>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=mail-ed1-f45.google.com; client-ip=209.85.208.45 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615975966-777533 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17/03/2021 08.54, Nicholas Piggin wrote: > +#if CONFIG_BASE_SMALL > +static const unsigned int page_wait_table_bits = 4; > static wait_queue_head_t page_wait_table[PAGE_WAIT_TABLE_SIZE] __cacheline_aligned; > > + if (!CONFIG_BASE_SMALL) { > + page_wait_table = alloc_large_system_hash("page waitqueue hash", > + sizeof(wait_queue_head_t), > + 0, So, how does the compiler not scream at you for assigning to an array, even if it's inside an if (0)? Rasmus