From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E92E3CDB483 for ; Wed, 18 Oct 2023 10:32:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31B058D014B; Wed, 18 Oct 2023 06:32:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CB5D8D0016; Wed, 18 Oct 2023 06:32:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BA448D014B; Wed, 18 Oct 2023 06:32:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0CCFC8D0016 for ; Wed, 18 Oct 2023 06:32:30 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CEE5F120211 for ; Wed, 18 Oct 2023 10:32:29 +0000 (UTC) X-FDA: 81358218018.24.6C06AA2 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf20.hostedemail.com (Postfix) with ESMTP id D8FF41C0011 for ; Wed, 18 Oct 2023 10:32:27 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=AS7BXjwI; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf20.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.44 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697625148; a=rsa-sha256; cv=none; b=IPOKrB/L1tIGHWbA8GCFAffdIc31QUCKJWoWFWSzn1T7uCndtKTMyPb/v3caY9erA4n6Qv WFlMGwHPspu+2CiPe26VSuC2ApdxWyVnruUfEb8rFz8H1oIfiZHGuBvpc6XL4AIEzjrw6X ZxSc848TeYfuM5QF6Ki20ZzkgmFr3yY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=AS7BXjwI; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf20.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.44 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697625148; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VsiPnpSACr9B+lnlwbErKj29RaM0XAz/xPYHLf8w0YA=; b=fBaYu3KcudBpWiXLNnRaHtM8xIsGGueBQsBTGZ+CJBXUdQFdHzM3gmdHulfALSZ7GwnI1r UkPrII+1ORuiV8cI1di5M24k7TgwUUgIESIjiG7eXVnAWja7HJ/YD3ZMrbaORaFjc7raEM Hajn1u54D/gdCkH7h/B2dt5Xl8+b2YA= Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-40651a726acso58686165e9.1 for ; Wed, 18 Oct 2023 03:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697625146; x=1698229946; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VsiPnpSACr9B+lnlwbErKj29RaM0XAz/xPYHLf8w0YA=; b=AS7BXjwI5k+jryTq2PGowyfhcy328DiN5bvwnZVNxBR17u665fZlTSM72pbqZqsJ0s Glweg0ytxfAZiHiQMeT4/32yKFuUBgqbICOIuP9MRqrRXE58YNvCthqKM+P4fTOyK/7O aiOuEli+gZ9momG4abtClb6wubkP7gYwSG82MD20omY8WC3D3h+OQtpFOBH+jmXINRqD ej2hofIY/Jd8UHk3u11Cd1QPr8ip29kV49lkLKMONxluIQ/xIPTCNZqpC6q4UpvmEjLC 6sOxQ095qVOsuLBYykT7Cc/WZIs4b5u9W+LylhagqWyYAV9GpzAfTtS23vHXGnYD2Nhl mngg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697625146; x=1698229946; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VsiPnpSACr9B+lnlwbErKj29RaM0XAz/xPYHLf8w0YA=; b=Xpt1NH6Jtn0b2cGGBDhjgLtYxyM9mA1DKyFVXX6O/cMiryIxKMoqGIm3vclQtQWgDm nj7ZYXhkI/SyodYVdyqXehS4T6R2UHgqnki+mWsWDZ3fPuJWwmcMpe+/00KPRMOXMZWJ XtPe+p1QIA23HBk7SOA1J9DjGISDoF1T3TT9KCzyqWHvI8OAzKq8r8M13ZDSOVmG+cOB bjjgGZqQynW33WmfwkLbhLN/qekJKLIrFCeXjfQlT1AFtDolU+h86Tm2J5zHUx4g7hq9 KL2DQi9JUShHgIXVuLRiPxD15tCV2UMnicxJvLUhjTGGCvp1q4r9xxS0DC+1TTQOIlZC NoJw== X-Gm-Message-State: AOJu0Ywp4Z2m7jkZP4hcXuLqhju6AjK8S7BJQBdRkXaIw2JJ42P15wye p8nex2fFPr8YzOQEikOfHXv0oQ== X-Google-Smtp-Source: AGHT+IHcrwjdRkE5UPJdS7rOGC82f4RgDgBOYpmwPQMMUj4HIKQ5pdH5V2CaRMgoGmuCxZRJQM7h5w== X-Received: by 2002:adf:fd50:0:b0:32d:87c8:b548 with SMTP id h16-20020adffd50000000b0032d87c8b548mr4100977wrs.21.1697625146265; Wed, 18 Oct 2023 03:32:26 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id y18-20020a5d4712000000b0031984b370f2sm1798863wrq.47.2023.10.18.03.32.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 03:32:25 -0700 (PDT) Date: Wed, 18 Oct 2023 13:32:21 +0300 From: Dan Carpenter To: Baoquan He Cc: oe-kbuild@lists.linux.dev, Lorenzo Stoakes , lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: Re: mm/vmalloc.c:3689 vread_iter() error: we previously assumed 'vm' could be null (see line 3667) Message-ID: <89caf59a-d3b9-409d-b1ae-9e370cb9ee7d@kadam.mountain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D8FF41C0011 X-Stat-Signature: 5n8rbgx85dfjh7z48u74n1adm3eodqnn X-HE-Tag: 1697625147-271395 X-HE-Meta: U2FsdGVkX1+XYVMHrl3m4Dl+o+nDT/V9c5BwFBvv2lqCeIMv9nHTfoln9dOKrUsyaSIyPFf79XB+chtz+dSiKVNwD72hvWFvIINgo8atUS2sSaGtk5vvzliugUxxO7WoJXh+ymaa1YmH4B5L+uoxtZ8a+DLMaBnDtNeGSX9QAFXLS71ExBVLn82jo9kmwp8bbMvnWvWJOWl/YmE9c0XvXd9ttvC1bi7IUqFNCIBXvGPW62+iQ6F5JZxFpdrYOMUWR81WSxU2FYlt7isvTuZs6UZr7P/NWVysquae8XlthHTluLmyivvFeVp/Dlz7bNVbvcwxKYnBn+MH+zU7QHJ7BYcWIVXLkHAu9OI+9wgDSfKuhXYEp4X6Do0e6ZFhrAWz3qfca61BfT+bDukwg/gAbg1EqifSF0NCUp5T/pzahNkiDWdGej5b1uXKAs7C1JuXf14jjW8WMnnbssMQ8IaRe/NEipFZKb0niGeneKQWu1yv43CpTm5T5iMr32MNAo13V4mA7+1htNl80Ht4acqXkuAM7PVK5D1SxXe4eXHBt4sbUDZ+eW38kmVL8xS6u9je62EYYkc0h305JAeJJ7BoXI+p2mRUsZng98Qn/wZJqIObxaojpL2024gE3L5JGBDXFQ+rvilVB3+1e2bjlZF0kY/qsEOJcBxMmxw7ZYOXQA/cUTIwXGtOCK6VD9HPSXKFs36Ys8DkDkhH6zeHSfC9x8ZOVchA+vDeXYH+4BQFyKQNInUHqct1H8TG0r+SraeUQO/cyjYftzSTG9CRn+USniSf1QgcH9SYlwulF2VO137RZ3XlFZob2xb7Ghzo84vVE04DhNkKbRcAuOSqMY4QXd53hEoE7nzwKTJaphCk2hXd6HWNzSYPYC9A3KIh1AJqbVtwX1niFTIr0HI4DLzLf90IGM0ZW807FuGC+UoTY6D03guKBiLm5C8aeotg9R9cE6F/pFMkHuvc5lY4mTV jrvbbyI+ ydR9oltXfuQBBC4hakQiLoi0iDa3JhhnrCbSsf+XyrGgkUSWLzD6tbABWA2bK4Au45sPqmarLzazcZ1+hO0OqdSSvX8LWuUHFYpgRMNhEWtH3BoLSPmriGYT+obw84/OSysh9hS4ShuY3khyFnSC2DanEuWdlg0U4Dy5KaiCfeLULp0W7rVjWkJhHbIq07c22gToCpoMsK7a0eHxEr4rYZ1Mo9EEjwUJ1Hu8I6f/+F6uMML9qru6JpHkF7zO1SIocsDb8Q1Z3rprUihzGaxtYLb1ZWev9RN75YvBrvYTyWlLn0FK0R5zo0SsWuKiZseVPJW1utBMyMy5kgxDBZyw9oXbzB4nKliyASqTfxP0er00559CC2SsVG84Dg2Vap58vDwpnVLeVBeiggLFT8iLIN78LRmi1vN/mg4EDy8UouqNRniF+fu4x0DdnM1xtorGRFBQC7lmHAmb2F3ydH6hm+TyhsTkQvNc9V3fRJo7+3ISF/S51eL/8JsJpkpGPMhS+dyGZW67nh3YcPjs8XnVruMaaWYzHT7HULCArxECAOrkFxINhxoVa3W35ihUBRFd7hOzs6vs8qQBidsrMD/ImVGPBPPYXp2QcJtkq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 18, 2023 at 04:54:33PM +0800, Baoquan He wrote: > Hi, > > On 10/17/23 at 05:26pm, Dan Carpenter wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > head: 213f891525c222e8ed145ce1ce7ae1f47921cb9c > > commit: 4c91c07c93bbbdd7f2d9de2beb7ee5c2a48ad8e7 mm: vmalloc: convert vread() to vread_iter() > > config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20231017/202310171600.WCrsOwFj-lkp@intel.com/config) > > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > > reproduce: (https://download.01.org/0day-ci/archive/20231017/202310171600.WCrsOwFj-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Reported-by: Dan Carpenter > > | Closes: https://lore.kernel.org/r/202310171600.WCrsOwFj-lkp@intel.com/ > > > > smatch warnings: > > mm/vmalloc.c:3689 vread_iter() error: we previously assumed 'vm' could be null (see line 3667) > > I see the code deficit, while the reproduce link seems to be unavilable. > Could you double check the link and provide a good one so that I can > verify the code fix? Here's a link. :) https://repo.or.cz/smatch.git/blob/HEAD:/Documentation/smatch.txt Just build it and run: ~/smatch/smatch_scripts/kchecker drivers/whatever/file.c regards, dan carpenter