From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DE0BC433F5 for ; Mon, 1 Nov 2021 21:39:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 129E360F02 for ; Mon, 1 Nov 2021 21:39:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 129E360F02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9192D94002C; Mon, 1 Nov 2021 17:39:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C8AD94002B; Mon, 1 Nov 2021 17:39:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F4E594002C; Mon, 1 Nov 2021 17:39:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id 5D51194002B for ; Mon, 1 Nov 2021 17:39:33 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 18DC6181019AD for ; Mon, 1 Nov 2021 21:39:33 +0000 (UTC) X-FDA: 78761678226.13.867D7E9 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf04.hostedemail.com (Postfix) with ESMTP id 5AC8950000B7 for ; Mon, 1 Nov 2021 21:39:25 +0000 (UTC) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1A1Juwhf004932; Mon, 1 Nov 2021 21:39:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=/c7rMVo4fehBm1xhZ/7YJFFC/4osbfP5pOF630yf//o=; b=02v8PiXlOtZGgHNI07nwubXaYTmJmrBU9ZgrihVklHPa0UiB7Cbex0Z4LhTqxERrJ5rC xXvlhQeyrEJpozHZ3AKfo8Khyrq3FYjZv4hjG/qZ4AJqIwBDn+QRYVb9jq1yPSFrD9u9 RIq4ORtWiMBYQyTYIX7hWDZti7Z/X9+DEzqSLuApMGdbXvn3f7xoH9JPN4c1yqWRy6KQ BoT48Up0c1Mu1Yh5TTG629RRZlZraQ1Uf0YM9ZPUWeJa7NTPCcFf4hrgccm8oc6DMef8 iYEafTro+i0Lb39DYW/JvGz+3BFhp5904o4JPs3luMsVXwu+g6vte4RSu6jCyryYwMH/ tA== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3c28gn4f6w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 01 Nov 2021 21:39:19 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1A1LaElX019242; Mon, 1 Nov 2021 21:39:18 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2176.outbound.protection.outlook.com [104.47.59.176]) by userp3020.oracle.com with ESMTP id 3c1khsj91m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 01 Nov 2021 21:39:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hYR1+XzsoMe6Gs8G5X+13a2bClRP1i8TJxx+8WIo+IkEkYl0aFByPTsJh0EugHu7d9HasTlL0sQzrssmJE1F0PSU6//BvJOoq454yZhjFIWe70tH/1UDrmIpJ7TCRffglC8onnHC9/TZRIX/ZpuH/TLgP89H5GHYyqT5tCi7I3lSTElh2MBo9ynVFZAir4to3lB2TBFSO6+dxRZIAIZTHt910J8I7xTyh1Lb36qlgsEmUgkTLN4a+BIrDjgslIX4nV6tFj1bkTxUY+zImSU7m8HWKjXLlCKLqxWkizpx9K4j2QoElt/yJPSzfqT9wxcfmUvHOOqBAxvLCelSLVD7Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/c7rMVo4fehBm1xhZ/7YJFFC/4osbfP5pOF630yf//o=; b=MiVaasJ03SJf9y53dsjIJXAjo5pz+d9lQT5DdoOJtKlNdMWK39003ZnKHHCE7f27VaoAvfQnFlA3Ud3AXLxcjMRgiX4o/5WEygN3aoT3Ygy6QUJ+InOCy6ZdvLB2yb7EPgW05y6q+kcKeQE8NSZco0q0EBWJaII+CL3u5lePOGr3EXSCGVoMpG47nluMfBy99TJuBWmbpJ2oVtrdOk79SeUUAmqkCpManh2V5NybfkYOJflUmIH9JMU64c+AiXAjZswpfzig32FPhqP2HU0d7R858Ove6sPEHTsLqUQV9CHgc7A0TmldhZA1Zi+lkKcrjNNy6WdjDAK2bvaBYLrAsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/c7rMVo4fehBm1xhZ/7YJFFC/4osbfP5pOF630yf//o=; b=jUdqjYuBPN7Yjg81vZq41vIZCDoLOH61ezujb/jBH41QZHJ7Bx2nP/K7MBoW+IqnLlltamUEndIp3knx5vqJEIlPBYQa43ccPJi7EPNpg+taF9iwo46zaTy5LlQ4U+OWh53gmCbQdtC4AzmPcoQgq2sHw4ykXjCsaE6fhKKPODI= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by BYAPR10MB3446.namprd10.prod.outlook.com (2603:10b6:a03:86::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Mon, 1 Nov 2021 21:39:14 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::bc59:71de:1590:cbf5]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::bc59:71de:1590:cbf5%8]) with mapi id 15.20.4608.026; Mon, 1 Nov 2021 21:39:13 +0000 Subject: Re: [PATCH v4] mm,hugetlb: remove mlock ulimit for SHM_HUGETLB To: Hugh Dickins , zhangyiru Cc: akpm@linux-foundation.org, linux-mm@kvack.org, mhocko@suse.com, wuxu.wu@huawei.com, liusirui@huawei.com, liuzixian4@huawei.com References: <20211009094355.127705-1-zhangyiru3@huawei.com> <17d4c5c5-af74-c6d1-f05d-1c2078c2d6a@google.com> From: Mike Kravetz Message-ID: <89c863cc-1700-348d-85ac-0e8c3ced7a66@oracle.com> Date: Mon, 1 Nov 2021 14:39:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 In-Reply-To: <17d4c5c5-af74-c6d1-f05d-1c2078c2d6a@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0097.namprd03.prod.outlook.com (2603:10b6:303:b7::12) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 Received: from [192.168.2.123] (50.38.35.18) by MW4PR03CA0097.namprd03.prod.outlook.com (2603:10b6:303:b7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15 via Frontend Transport; Mon, 1 Nov 2021 21:39:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c8eb4757-1cb1-4e99-a37d-08d99d800c36 X-MS-TrafficTypeDiagnostic: BYAPR10MB3446: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1x8UR/ZTuvmuzWTC2eaOhh9wJj7l3io1Mxt3dGsw3w3zpY6FiOVMq6b29xxvGltbpdVee8kCxuITKhOO4xz33YRUbx3PWKkc1auextv38HiFWLYl/nQmM7Lmd2m1LjZM/4mjHQyQLOSlEPNI6Pzan8cOZdJ7X6sFspWyzEbqou/Yha0ky9zqj/Bb6DH3aw2ff7xGN1stZzvtVwuhStT5+rT1zskePw4vC0ybZ1hGUhy7y49kk2QtODUZhnN/zv3ljxLSSF3NccB/Ky6jLt7EkghxMYKSwv0x09gFM3MPgtJ8FYIhd10zh+UuckAtbx4gfvWbu3Q2rQYx/NGAH9PHDwPBxX6Z+tIn/ay4TrpM51JhL4PQMiEWvE643zEaPtOtpTpU0F8unRefQOHn2Lac+YlJRt+uFw978vkHYrLnx7eqjTFLHHBbdHGoDGqg2LZQH6Qn5x1qXfwRSOpKYz06BqMg89GXrSUPXHtOvJy4r0U19qx1ZP5mgVmlUYw4gvC9Fuj34SUIjwPJv6gBdURogCYJYY833tEwqB1P3R3cJHmkH7sWJwJi4Ncp1niC1Dg4ra9G3q+iel139GKAmeox8R+E20HfzcPTekXnYC5FExVby6rRiiciIq09885asbY9gWDegy57PhXBW7FWE/nAqr7R0HZf3MhdgxIh8p9j9HlF4wsIJC8oRKmzUsJsk+ZSPL36my9uiMBrT8APDa38jx7NHlXt3/IiX8c5bILudZkvyftcifzCUC5xyU/+MRGNLKxhNzWd9I+/flBb6/aRVQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(44832011)(8936002)(508600001)(956004)(2616005)(26005)(36756003)(2906002)(186003)(31696002)(110136005)(31686004)(53546011)(5660300002)(4326008)(38100700002)(38350700002)(6486002)(316002)(52116002)(86362001)(83380400001)(66476007)(66946007)(8676002)(66556008)(16576012)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1ZoalVKbTd5Y1JOTHByMDNNNUJ6WklsaVBpL2ExV0hKdmxLaTBMZ0JCWFVC?= =?utf-8?B?cDRrSjExdFdsT01BYXdwMXdoYmtZclFwS0RHVVpxcm9KUDFvQnpMbElNdy9p?= =?utf-8?B?RVZGaFdlemNsa2RWOHYwT3BnWWc1TmlJaDFob2tTWC9kN082Vk85UGRwU2lS?= =?utf-8?B?R2c5blVwZzRlZWNDdnRBSFMzNXVpMS9rTDZ2bWJGR0lOV3k5ZzZWUHJieG1M?= =?utf-8?B?cnRJdHJKZys2NGJvcFVGdTBXL0h0SHdsaWxNV28vTUxyN3A1VStlZmYyNURT?= =?utf-8?B?anVlVXBhYmJMMzBDQjY1OWhBaE04WEpkNFllUHNCdHBVekNqT2VuVjl6UWhW?= =?utf-8?B?dlRJVXp4OWVidVRnem5PQi9pdjc3VFFGK1RaNnNoeFJKTGJOc3RwakN2TVNp?= =?utf-8?B?dFcvbEtwb0NyWDR4SkpVRHZWbTFzbjd2ZHpWTUMrVUZtOEJEbXVFT1ZoNnh3?= =?utf-8?B?UjczaXRHMkxhU1VuUm9UVEFwSmFrem9rdXplNWRCaGZZWFA0MVYzMFMxRCtD?= =?utf-8?B?cTBHVzZsc1ZpenV3T3pnamYrMDI4OVlVOUF4ak5CTmlTNFZHdHN6OXNMMmZR?= =?utf-8?B?R1R6Y2g0ekpkUXZaSjdNOW84S2hZNEJqQjJVWitVd3lJYzF6YUFUOTNtbW5G?= =?utf-8?B?ajY4VTVvWWlHWGp2cnM2Q1ovUnZQaHRUUTd1VFBFY09sd2Q3MG8rZjBRdkNx?= =?utf-8?B?RW80Vk5PZWRxRzg4Y3YvV0tzOGVRc0lGeG9vdTF6UHhzeUd0YVQ1cGlDTUFH?= =?utf-8?B?SHdZcUVLM0FGWERLUndPUS9vOHpnRXEzY3FYRDlwaktJTWZPTlZ5STlkcjNo?= =?utf-8?B?RGp2b001bXVybmRYTlVZbndUOTlsdkhCY0VyM3pnWGJFSVlXS21Ka3MvU1Bs?= =?utf-8?B?aG8xRjZKNytwZEtNSktESWRsMnlmM1NybWpjanJXM2IxdGxBektrSnpOSllP?= =?utf-8?B?MTVCOXY3ZDhKb0pBbHVXcnpnWmVsSERzOHZacFpWcFZzbFl0SFRtbkRQRWRm?= =?utf-8?B?azdwdVJ0RFVJR1ZxQWZIMk0ycUhFWU95TEtWYldvYU9iaW5vYTliU3ZuSXE1?= =?utf-8?B?OStQQkhGWndPb2tZWDVTL3BjVGEzaE40VG9yeGViZnNMSW4vUWRiUnZuSVQ5?= =?utf-8?B?SldMeXVlRjdxQ0JkaVhueDFPT25tZHpUWTREaG1VNXlzdm1rRGtwMnR3M3cw?= =?utf-8?B?K1hmRTZwdkRqQ2t2UXVlZ3BwTzFRazg2aDRtckU0TVN1UGNmYWtYZnlnRjdS?= =?utf-8?B?aFgrQms2clY3citENVFmNjlHWDFVeHpNMyszN212MlNNYjQvc3ZPY3FnOE45?= =?utf-8?B?Q2FQeHl5VjVaQkg5Y0hGbjBLT1BBSDcrbUpoK3FuVUpJUFl5eXlGRGZRK0FS?= =?utf-8?B?MVQweWI2WHVxVkJ6WjBtSEl1Z2I5WHVwY2RDRUhWTmNDT1JLM0dibEhQS0Z2?= =?utf-8?B?a3UvbDhyeS9RU1hrVWFUSTlNbXhXMTU0dXRLbVM1SnBlcHU1OUV1OUEvVGtx?= =?utf-8?B?d2gva3dZOXN5bmN0R0I3SEcyS2FDSlRRVzBBQi9RTDFaVWppTXlzU0hkdmQ2?= =?utf-8?B?MkltNWxuQ2NNMGdPQ2lmQXNJbEoxYk5JdXQxdTd1QkhIQnVRU1ErUy9ab3pW?= =?utf-8?B?RklZVGdnNWtTNzRmVXdETi9IUmR0N2hxWmJTQVZGWHNmNmY1VlVEeGdBc1VK?= =?utf-8?B?SGwvMUx0MVF6a0UwQTBGRVFPZWdXZVdPTVpucG9DYmRpZ0NMNEt6ZGNqV3pq?= =?utf-8?B?bVV3dk5LKzBaU08zWDMvSEFsMWM3SWN5OUdwUTlmVDl2ejkwc3dmVGVXUWlZ?= =?utf-8?B?ZTdHOUxmMlN2Q0U1QWNWRTVjSVRCNll1R0VtZFhqcVl6MkZ5UTdBeXAyVS92?= =?utf-8?B?QjhvT1hDTmVxem5pcVNYMjlUQVJXcHg0eDJsdkJVS0VHdkRzV1p5Tkt1cFRh?= =?utf-8?B?ZnVEdW5lOHcrdFQzT1d6ZG9iVWxPTUNBTHp5Ym5Eekp1WThpSkorRm1ONTRG?= =?utf-8?B?bUNHblVLMVU5VnRmYkk0U3FzR1VheHN3RC9aS0FJVk9jaU5KSU1ZSnU4dU5Z?= =?utf-8?B?ZzZDclM2cU9OSlJEaFNkU0NNQVpJRUtwaER5aHlaTk1NeFBoRFFRYjRFdjVV?= =?utf-8?B?Y3VkSmoyZnh1WlhaZ0xaMEFOY2NZUk4wNlhnQWZIc2o4QmFvREZyQW10R1Ry?= =?utf-8?Q?i6O2RqR7XJU/n948pB2Iyf8=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8eb4757-1cb1-4e99-a37d-08d99d800c36 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 21:39:13.8287 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7fmZ24f9ZC4AiX8XvM2WGI6YzfOmeckHw4LwZsF+3qZfnz9j/xxCr00ua3lyUiLSY/5nlhR+EyZmZMAXeNOB2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3446 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10155 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111010112 X-Proofpoint-ORIG-GUID: AuvV1i1bGwezNhdUFcwNp6hDHOBY4YW7 X-Proofpoint-GUID: AuvV1i1bGwezNhdUFcwNp6hDHOBY4YW7 X-Stat-Signature: nkjd55tbsnp5yr3azsjqig76t8133iw3 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=02v8PiXl; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=jUdqjYuB; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf04.hostedemail.com: domain of mike.kravetz@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=mike.kravetz@oracle.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5AC8950000B7 X-HE-Tag: 1635802765-121925 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/1/21 12:01 AM, Hugh Dickins wrote: > On Sat, 9 Oct 2021, zhangyiru wrote: >> fs/hugetlbfs/inode.c | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) > > I have nothing against the obsoletion itself; > but this patch appears to be incorrect, and far from complete. > > Incorrect (unless we actually want to *punish* those who still use > deprecated interfaces) because in these latest versions, it consumes > from the mlock ulimit (if use_shm_lock() succeeds), but never gives > back what it consumed. I don't see why user_shm_lock() is called. Thanks Hugh! I was so focused on how how this might impact people still using the deprecated feature, I missed this. Since I have seen the 'this is deprecated' message as recently as this year, I suspect this will impact someone. The way it will impact them is that their application will no longer work due to shmget() failing. This is why it would be good idea to at least log a message saying someone tried to use the obsolete feature. The most convenient way to determine if the call would have succeeded due to the obsolete feature, is by using the existing user_shm_lock/unlock calls. I suppose we could create a separate routine to just check the limit so that a message can be printed. Or, possibly open code. But, I would advocate for removing the 'this is obsolete' message in the next release. When we remove the message, we can eliminate the calls to user_shm_lock/unlock. -- Mike Kravetz