From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A658C432BE for ; Mon, 2 Aug 2021 02:45:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3CFB761050 for ; Mon, 2 Aug 2021 02:45:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3CFB761050 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B82916B0033; Sun, 1 Aug 2021 22:45:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B32A08D0001; Sun, 1 Aug 2021 22:45:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FA036B005D; Sun, 1 Aug 2021 22:45:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id 848CA6B0033 for ; Sun, 1 Aug 2021 22:45:02 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 242D11D994 for ; Mon, 2 Aug 2021 02:45:02 +0000 (UTC) X-FDA: 78428598444.06.0ED51F6 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf03.hostedemail.com (Postfix) with ESMTP id 0E19830002FF for ; Mon, 2 Aug 2021 02:45:00 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id q17-20020a17090a2e11b02901757deaf2c8so22832067pjd.0 for ; Sun, 01 Aug 2021 19:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=7u4fte1I6XIi4Oa7tBUvd/LMR8RaZqPasnqunasW4l0=; b=TY3Et26rst9zBPDSawe9WsBnPw9rX53CTLEDaL3lUnZDtW0Xk/Qxr5OKE9/fIe0EmV QaI27nyiIrxnZOhtzYucKFt49lB0PLoaMNpurrU9eHQZpBeOciZRx6ghD1hOovrK3JPP zu6cw5v2sP53UoYfyJ4nKho65DbHfRujSZ0WJzQfcu9sOjgEOiTGdbKaEmgZQ5MW29an j4jVaEXyowSCQJQZZcQ2y/pnDG4RPtXUPVNR7KKEApAJE5BUSBIGX0G2UVyRH5Uv47m9 +k9HTNRnS8f9+VdP3eyFdKp7aAugOp072LM27gB1z20PeDoBRX6pWNPsv5fjN4ZQ30MK TT4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=7u4fte1I6XIi4Oa7tBUvd/LMR8RaZqPasnqunasW4l0=; b=EEqIJrbUcXhywAXhlXpuymrNhdTYrXGDRC34UNs46cdFrUi9/xbvExNFT3FCvO86Jh ZiakgGzb6CGWtR/1Sl1lKauHvLysGdvHeuyyxe/Nccw94/2zFsGQese3P0jzCq9X3Xsw updsAHdSLXQ9vqsoUliYrnDwuMrgr3aoGDmXk6xZ+2rYER+AtZLhDXRbxdtpcvQTlMsC 4QEFthrIl8aXcGYnDPqDT9Q+MP/ijRGQLbGCVurCCmu7xshY7X+iaaA4V9HFMn0yk1Fo EJrlCi9mo9prV72KUHrXYLoVQ6C99drbaoigd1lhSN65KhkbuC0SsjHqSvJSRSSA5aA+ 2pzA== X-Gm-Message-State: AOAM533RDnEnI3rWCDnaURg0CLkuZ+AARnbEjxu56BEebjLuGDJEcZjT ylbjcs1oywAdzDI3uIhNcpHSKymx44jTxg== X-Google-Smtp-Source: ABdhPJxThBu6/4FiTIIrPr1IbLXE3F7yeSoCP4Q9JCx1pYA9F/leuwwCu+SM59zcybTR+zcm5EWLsw== X-Received: by 2002:a17:90a:6e47:: with SMTP id s7mr15295337pjm.160.1627872299586; Sun, 01 Aug 2021 19:44:59 -0700 (PDT) Received: from [10.76.46.68] ([61.120.150.72]) by smtp.gmail.com with ESMTPSA id w11sm8676719pjr.44.2021.08.01.19.44.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Aug 2021 19:44:59 -0700 (PDT) Subject: Re: Re: [PATCH 3/3] mm: mmap_lock: add ip to mmap_lock tracepoints To: Steven Rostedt Cc: Axel Rasmussen , Ingo Molnar , Andrew Morton , Vlastimil Babka , LKML , Linux MM References: <20210729092853.38242-1-ligang.bdlg@bytedance.com> <585f936d-9d27-a481-f590-bd07f98f34de@bytedance.com> <20210730160319.6dfeaf7a@oasis.local.home> From: Gang Li Message-ID: <89c20b62-c0ab-3200-fb33-eb2058b7ba67@bytedance.com> Date: Mon, 2 Aug 2021 10:44:56 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210730160319.6dfeaf7a@oasis.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0E19830002FF Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=TY3Et26r; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf03.hostedemail.com: domain of ligang.bdlg@bytedance.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=ligang.bdlg@bytedance.com X-Stat-Signature: 5bio7ddiitujbey3hgs68a1ij3exhnr4 X-HE-Tag: 1627872300-521448 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/31/21 4:03 AM, Steven Rostedt wrote: > Yes, synthetic events are just like normal events, and have triggers, > stack traces, and do pretty much anything that another event can do. > > I'm just finishing up a libtracfs called tracefs_sql() (hopefully > posting it today), that allows you to create a synthetic event via an > SQL statement. But I don't think this is what you are looking for. > > What about using function tracing? Because the tracepoint is called > from __mmap_lock* helper functions that function tracer can see, you > can just do the following: > > # trace-cmd start -e mmap_lock -p function -l '__mmap_lock_*' > # trace-cmd show > [..] > trace-cmd-1840 [006] .... 194.576801: __mmap_lock_do_trace_start_locking <-do_user_addr_fault > trace-cmd-1840 [006] ...1 194.576805: mmap_lock_start_locking: mm=000000006515cb1f memcg_path=/user.slice/user-0.slice/session-2.scope write=false > > trace-cmd-1840 [006] .... 194.576806: __mmap_lock_do_trace_acquire_returned <-do_user_addr_fault > trace-cmd-1840 [006] ...1 194.576807: mmap_lock_acquire_returned: mm=000000006515cb1f memcg_path=/user.slice/user-0.slice/session-2.scope write=false success=true > > trace-cmd-1840 [006] .... 194.576811: __mmap_lock_do_trace_released <-do_user_addr_fault > trace-cmd-1840 [006] ...1 194.576812: mmap_lock_released: mm=000000006515cb1f memcg_path=/user.slice/user-0.slice/session-2.scope write=false > > trace-cmd-1840 [006] .... 194.576815: __mmap_lock_do_trace_start_locking <-do_user_addr_fault > trace-cmd-1840 [006] ...1 194.576816: mmap_lock_start_locking: mm=000000006515cb1f memcg_path=/user.slice/user-0.slice/session-2.scope write=false > > trace-cmd-1840 [006] .... 194.576816: __mmap_lock_do_trace_acquire_returned <-do_user_addr_fault > trace-cmd-1840 [006] ...1 194.576817: mmap_lock_acquire_returned: mm=000000006515cb1f memcg_path=/user.slice/user-0.slice/session-2.scope write=false success=true > > trace-cmd-1840 [006] .... 194.576820: __mmap_lock_do_trace_released <-do_user_addr_fault > trace-cmd-1840 [006] ...1 194.576821: mmap_lock_released: mm=000000006515cb1f memcg_path=/user.slice/user-0.slice/session-2.scope write=false > > > This looks exactly like the robots you are looking for. > > -- Steve > I think this is exactly what I am looking for. Thanks!