From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E087AC43470 for ; Thu, 20 May 2021 17:52:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7D5AE610A1 for ; Thu, 20 May 2021 17:52:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D5AE610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E64848D0010; Thu, 20 May 2021 13:52:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E12888D0001; Thu, 20 May 2021 13:52:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8C308D0010; Thu, 20 May 2021 13:52:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id 9335D8D0001 for ; Thu, 20 May 2021 13:52:19 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3822382D6B6D for ; Thu, 20 May 2021 17:52:19 +0000 (UTC) X-FDA: 78162353598.01.61C6052 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf05.hostedemail.com (Postfix) with ESMTP id 3BF93E000800 for ; Thu, 20 May 2021 17:52:15 +0000 (UTC) IronPort-SDR: aegvJHl4XQwLaryjs/6otle4lxHrVll9zLmpefPzkHu6PE3IF4wFs46BU6nOtL0Xkk5yJ8EHqO +PBLJDe26X7Q== X-IronPort-AV: E=McAfee;i="6200,9189,9990"; a="222387732" X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="222387732" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2021 10:52:16 -0700 IronPort-SDR: ubV1dR23fZlDz8Sl4x063SQ54XDoUp+GTBJetaZzXSZU0o/60mTcOtrSvgH0x1hH7/ek3qQ6NG boZITUeOglsA== X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="475295383" Received: from yyu32-mobl1.amr.corp.intel.com (HELO [10.209.167.234]) ([10.209.167.234]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2021 10:52:15 -0700 Subject: Re: [PATCH v26 26/30] ELF: Introduce arch_setup_elf_property() To: Matthew Wilcox Cc: Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , Mark Brown , Catalin Marinas References: <20210427204315.24153-1-yu-cheng.yu@intel.com> <20210427204315.24153-27-yu-cheng.yu@intel.com> From: "Yu, Yu-cheng" Message-ID: <89be0683-e1b3-d843-c4b4-ba351ede7427@intel.com> Date: Thu, 20 May 2021 10:52:15 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=none (imf05.hostedemail.com: domain of yu-cheng.yu@intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=yu-cheng.yu@intel.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3BF93E000800 X-Stat-Signature: w51j6pj7zqpykftneu1xp85f56whprae X-HE-Tag: 1621533135-278487 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/20/2021 10:38 AM, Matthew Wilcox wrote: > On Wed, May 19, 2021 at 03:14:58PM -0700, Yu, Yu-cheng wrote: >>>> +++ b/include/uapi/linux/elf.h >>>> @@ -455,4 +455,13 @@ typedef struct elf64_note { >>>> /* Bits for GNU_PROPERTY_AARCH64_FEATURE_1_BTI */ >>>> #define GNU_PROPERTY_AARCH64_FEATURE_1_BTI (1U << 0) >>>> +/* .note.gnu.property types for x86: */ >>>> +#define GNU_PROPERTY_X86_FEATURE_1_AND 0xc0000002 >>> >>> Why not 0xc0000001? ARM64 is 0xc0000000... >>> >> >> I just looked at the ABI document. >> >> ARM has GNU_PROPERTY_AARCH64_FEATURE_1_AND 0xc0000000 >> >> X86 has: >> GNU_PROPERTY_X86_ISA_1_USED 0xc0000000 >> GNU_PROPERTY_X86_ISA_1_NEEDED 0xc0000001 >> GNU_PROPERTY_X86_FEATURE_1_AND 0xc0000002 > > Please add all three, not just the last one. > Ok!