From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27343C433EF for ; Fri, 17 Sep 2021 09:49:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AA3D060F48 for ; Fri, 17 Sep 2021 09:49:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AA3D060F48 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 2395F6B0071; Fri, 17 Sep 2021 05:49:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C1D26B0072; Fri, 17 Sep 2021 05:49:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03BAF6B0073; Fri, 17 Sep 2021 05:49:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id E897E6B0071 for ; Fri, 17 Sep 2021 05:49:00 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A212E824556B for ; Fri, 17 Sep 2021 09:49:00 +0000 (UTC) X-FDA: 78596591640.18.E066E9D Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf13.hostedemail.com (Postfix) with ESMTP id 6A9CD102E22F for ; Fri, 17 Sep 2021 09:49:00 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id u13-20020a17090abb0db0290177e1d9b3f7so9642535pjr.1 for ; Fri, 17 Sep 2021 02:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=WqfCnFXW1pBqpEUkFm98tBUfFU7a1074L/dYXgavkKo=; b=MJbLs4R0uSc49AGTR7ef3oagIGcP6rAtUCHkV85uhDqEzAupYjwTjVrWhu15Sew6ZT 2a+vvTp8E/KcbcCsxCyJ3kuS9gSZnZB1rttDEY6YRO51Fm2A6fJkrLOxGCo88ZU6NP9P 80ddzxv7DdXH/a7TCIRgYXrgDibJhS+K6cgoOzCfkTR7gCd11p6dmAsH7U1uZYuEqO7c 812TwiIi4OoPpOVvB99x7RWp+jatZM1vVWHQv/lFHvGqGPv9mt0SNZ51AR5CRrGTC+eg zCJ4EKGspsUwaJwjjkwDQ6P8C3PnxnBFeOGFLTf45TWkwQz7TcjTugpAT+GHqm2aoPSq kvhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=WqfCnFXW1pBqpEUkFm98tBUfFU7a1074L/dYXgavkKo=; b=dT0uJ7MyCrhdtYfdNtlesCsLwlcOsL566CNb1QvxkGOtfsqMifvH0Z2+6HeFC/yWl0 VCaANhpkA/R8hVmYT5sUUqNo/mGwh2vrXe5PeUd4FrGHtW3G5dds0+WGKQy5PJuxDEIB dtk4ARAKj0MIhqixeZp35jiMMzQ0QEU6vx5MB6Jm/5WlFTPye1djt9PjiUUy1gNElwrN q9y1QeghwjuiiynjEx2NBljllFb3rvkGYvvV2pljAT0+adM6CzoIiHADPvJve3N60r3Y mrj6uSpGCyQ504GKTPxGMC0mTnTzmyssJ4JLDhIsO4i0qhAAqRfz5hLZPOKVYnJKuZHs J53A== X-Gm-Message-State: AOAM530xhDAKtp85YxNurK/s48L5pWwa1ORI3ZJWjhhraTsIwiN98+42 o8M4jOSREE8OD0OiNH8+8l4= X-Google-Smtp-Source: ABdhPJzpRPcQIbkoO5TPWguJ0M0FqIx8ZkxnclzmicInsnZPZ+WqmRKOtT3KszUBqviNXdIuwvehTA== X-Received: by 2002:a17:902:680d:b0:13a:503f:f381 with SMTP id h13-20020a170902680d00b0013a503ff381mr8878825plk.30.1631872139307; Fri, 17 Sep 2021 02:48:59 -0700 (PDT) Received: from [192.168.30.11] ([173.248.225.217]) by smtp.gmail.com with ESMTPSA id z11sm6020142pff.144.2021.09.17.02.48.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Sep 2021 02:48:58 -0700 (PDT) Subject: Re: [PATCH] mm/debug: sync up latest migrate_reason to migrate_reason_names To: "Huang, Ying" , John Hubbard Cc: Andrew Morton , Pavel Tatashin , Oscar Salvador , Yang Shi , Zi Yan , Dave Hansen , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210917061432.323777-1-o451686892@gmail.com> <871r5nptt7.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Weizhao Ouyang Message-ID: <89a06743-b37a-b85a-1c04-5d863a1d2cb4@gmail.com> Date: Fri, 17 Sep 2021 17:48:53 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <871r5nptt7.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Stat-Signature: c4b6dmpxasoicckuhsfgdpco5tudfskb Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MJbLs4R0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of o451686892@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=o451686892@gmail.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6A9CD102E22F X-HE-Tag: 1631872140-385514 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thank you both. On 2021/9/17 =E4=B8=8B=E5=8D=883:03, Huang, Ying wrote: > Weizhao Ouyang writes: > >> After related migrate page updates, sync up latest migrate_reason to >> migrate_reason_names, page_owner use it to parse the page migrate >> reason. >> >> Fixes: d1e153fea2a8 ("mm/gup: migrate pinned pages out of movable zone= ") >> Fixes: 26aa2d199d6f ("mm/migrate: demote pages during reclaim") >> Signed-off-by: Weizhao Ouyang >> --- >> mm/debug.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/mm/debug.c b/mm/debug.c >> index e73fe0a8ec3d..733770b0ed0c 100644 >> --- a/mm/debug.c >> +++ b/mm/debug.c >> @@ -25,6 +25,8 @@ const char *migrate_reason_names[MR_TYPES] =3D { >> "mempolicy_mbind", >> "numa_misplaced", >> "cma", >> + "longterm_pin", >> + "demotion", >> }; >> =20 >> const struct trace_print_flags pageflag_names[] =3D { > Good catch! Thanks! > > Reviewed-by: "Huang, Ying" > > It may be better to use BUILD_BUG_ON() to capture similar issue earlier= ? How about move migrate_reason_names into mm/page_owner.c and make it size= uninitialized(get rid of MR_TYPES). Then use BUILD_BUG_ON(ARRAY_SIZE(migrate_reason_names !=3D MR_TYPES)) to = check it? > > Best Regards, > Huang, Ying