From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4BA1C433F5 for ; Fri, 3 Dec 2021 16:35:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E71866B0073; Fri, 3 Dec 2021 11:35:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E21936B0074; Fri, 3 Dec 2021 11:35:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC24E6B0075; Fri, 3 Dec 2021 11:35:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id BD3336B0073 for ; Fri, 3 Dec 2021 11:35:34 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7A74D184B2908 for ; Fri, 3 Dec 2021 16:35:24 +0000 (UTC) X-FDA: 78877033368.30.5B3D77A Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by imf01.hostedemail.com (Postfix) with ESMTP id 284CD40004 for ; Fri, 3 Dec 2021 16:35:24 +0000 (UTC) Received: by mail-il1-f175.google.com with SMTP id m5so3226038ilh.11 for ; Fri, 03 Dec 2021 08:35:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1qeWfvSCIJZvQVrGPshmVmH+uaG4Erun9h7pEUbu2Bc=; b=DsVO37JwMJgMmYLxOf+fyOyK8H8fScKV7kthHhJgPUj3RqBDWwSft4Sj70Xxjng0NP jjbn7MUP1+VrSYnIHWfjKGPInOeh4spMVSSQAsgHhLq1Q7dTD/tzo6Bsdb/4ODknDMW6 RQER7K0mWGErRCKAku99keNy9gb02Ryuwq6HCO3rglrGJIkdx2759ZcVS2u0P6CsvuWP p5kj0y4Sqx7jSffLMSq+eWe68BoFMtNXsIatZdqR5OKSS81yuFTCIpnE8y4LP/C9Nvfw 32dnYbVJipRwNwO1WbFNPZ3VtO0ilTz/ERuZjGk4SpCBXWfs17w6OusPJEjLYHdUryKe RZeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1qeWfvSCIJZvQVrGPshmVmH+uaG4Erun9h7pEUbu2Bc=; b=Eo8iENlo5jA29vVDmeUFUC19Ro/tXmT6Y6yyZHW/0NcY0JjMuntnEc0UTeMpyos3lb IPdB9pqs/dlUPy1M26UgLIeqlQzfMky1RJzLzx1DpbvJZ9ukPX4YfY8VVUrBZxDF91TK 0XVUS11xxVuOsata7iJIKla2sFXetXS5+tCbB97QsXB9zpH5sPCa7EMLuRNGam31GojM V13Ft6NPdw8pvmm/3RNdHknLKG9alMB0iP6yYF4w6j6dTtm43RrC56wg65e428b8Esf2 1eoFKDRU3vn4mAEnE+AsOSZKrs4ZXxLqFuEgxPzqmXIKR7b2WX+pZ4lqMSkm1uUpA3e5 koeQ== X-Gm-Message-State: AOAM530qz9f8fLUdlJ9FRH7nl6jzT4qxAuD0tFNAszJSx0XFNclhNxD6 g96N+JoY72FUvyFGSFALDCzZ18A503APF8wq X-Google-Smtp-Source: ABdhPJz1DiNW7n9LmgAKMcJA7RcFFuZAF2ax8ELghhyidCNAKxvN8JITy7A+iwO5sTexPCI0b+3Y7w== X-Received: by 2002:a05:6e02:148c:: with SMTP id n12mr20995263ilk.209.1638549323311; Fri, 03 Dec 2021 08:35:23 -0800 (PST) Received: from [192.168.1.30] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id s20sm1866720iog.25.2021.12.03.08.35.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Dec 2021 08:35:23 -0800 (PST) Subject: Re: [PATCH 1/2] mm: move filemap_range_needs_writeback() into header From: Jens Axboe To: Matthew Wilcox Cc: linux-block@vger.kernel.org, linux-mm@kvack.org References: <20211203153829.298893-1-axboe@kernel.dk> <20211203153829.298893-2-axboe@kernel.dk> <5e92c117-0cdb-9ea6-3f1c-912e683c4e51@kernel.dk> Message-ID: <89810ae4-7c9b-ec8f-5450-ef8dc51ad8a4@kernel.dk> Date: Fri, 3 Dec 2021 09:35:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <5e92c117-0cdb-9ea6-3f1c-912e683c4e51@kernel.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 284CD40004 X-Stat-Signature: ozp977c3upn65niejcsj419ta65b8sc9 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=DsVO37Jw; spf=pass (imf01.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.175 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none X-HE-Tag: 1638549324-948152 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/3/21 9:31 AM, Jens Axboe wrote: > On 12/3/21 9:24 AM, Jens Axboe wrote: >> On 12/3/21 9:16 AM, Matthew Wilcox wrote: >>> On Fri, Dec 03, 2021 at 08:38:28AM -0700, Jens Axboe wrote: >>>> +++ b/include/linux/fs.h >>> >>> fs.h is the wrong place for these functions; they're pagecache >>> functionality, so they should be in pagemap.h. >>> >>>> +/* Returns true if writeback might be needed or already in progress. */ >>>> +static inline bool mapping_needs_writeback(struct address_space *mapping) >>>> +{ >>>> + return mapping->nrpages; >>>> +} >>> >>> I don't like this function -- mapping_needs_writeback says to me that it >>> tests a flag in mapping->flags. Plus, it does exactly the same thing as >>> !mapping_empty(), so perhaps ... >>> >>>> +static inline bool filemap_range_needs_writeback(struct address_space *mapping, >>>> + loff_t start_byte, >>>> + loff_t end_byte) >>>> +{ >>>> + if (!mapping_needs_writeback(mapping)) >>>> + return false; >>> >>> just make this >>> if (mapping_empty(mapping)) >>> return false; >>> >>> Other than that, no objections to making this static inline. >> >> Good idea, I'll make that change. > > That does introduce a dependency from fs.h -> pagemap.h which isn't trivially > resolvable... > > What if we just rename the above funciton to mapping_has_pages() or something > instead? Or just drop the helper, to be honest. There are more tests for mapping->nrpages right now than there are callers of this silly little helper. -- Jens Axboe