From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Dave Hansen <dave.hansen@intel.com>,
linux-mm@kvack.org, akpm@linux-foundation.org
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
David Hildenbrand <david@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>,
x86@kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Move set_pxd_safe() helpers from generic to platform
Date: Fri, 20 Sep 2024 14:57:25 +0530 [thread overview]
Message-ID: <89806be0-c95d-4a85-a8da-a253aea68093@arm.com> (raw)
In-Reply-To: <2924c274-2b01-4b33-87e7-5b66aceba3b0@intel.com>
On 9/20/24 14:22, Dave Hansen wrote:
> On 9/19/24 23:42, Anshuman Khandual wrote:
>>> I just did a quick grep and don't see any difference between the _safe
>>> and normal variants. A quick grep didn't turn up any actual users.
>>>
>>> Did anyone actually double check that these are still needed on x86 in
>>> the first place?
>> arch/x86/mm/init_64.c
>
> Ahh, the #defines make them immune to grep. :)
>
> Long-term, we should make sure these are still necessary. Short term
Agreed, David H has also mentioned about that.
> (in this patch), please just put the #defines in init_64.c if it is the
> only site that needs them.
That is not the only site where they get used. set_pmd/pud/p4d/pgd_safe()
are also called from respective pmd/pud/p4d/pgd_populate_safe() helpers
in the header arch/x86/include/asm/pgalloc.h.
Besides also hit a road block in converting these macros as static inline
functions as suggested by David H earlier, because pmd/pud/p4d/pgd_same()
macros are defined in include/linux/pgtable.h, way after <asm/pgtable.h>
gets included.
I guess we will have just leave these macros is in arch/x86/include/asm/pgtable.h
next prev parent reply other threads:[~2024-09-20 9:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 5:30 Anshuman Khandual
2024-09-20 5:49 ` Dave Hansen
2024-09-20 6:42 ` Anshuman Khandual
2024-09-20 8:52 ` Dave Hansen
2024-09-20 9:27 ` Anshuman Khandual [this message]
2024-09-20 6:39 ` David Hildenbrand
2024-09-20 8:42 ` Anshuman Khandual
2024-09-24 5:28 ` Anshuman Khandual
2024-09-24 7:39 ` David Hildenbrand
2024-09-26 4:18 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89806be0-c95d-4a85-a8da-a253aea68093@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=ryan.roberts@arm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox