From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C60C77B7C for ; Thu, 3 Jul 2025 08:29:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7D9A6B010C; Thu, 3 Jul 2025 04:29:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C55566B0110; Thu, 3 Jul 2025 04:29:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6B1C6B0112; Thu, 3 Jul 2025 04:29:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A769F6B010C for ; Thu, 3 Jul 2025 04:29:46 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2C30A1D8759 for ; Thu, 3 Jul 2025 08:29:46 +0000 (UTC) X-FDA: 83622279972.26.7401F53 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 8675D180004 for ; Thu, 3 Jul 2025 08:29:43 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eFXGnCa0; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751531383; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ao7iXo6bPr/lMtF2Dn4u+FVUcO1qO3WglYeGUpi07GA=; b=I4eLTI2lV535EZw6Ay4ZnVa6NEpPTfa5dJo8BwQc6PXSw7oMvJYuLKVcKYVGZEmP/KP6nJ nxnhP+hlrEYfgFOHhOWO2o14IdKiCkydIm2xtGIOzXmp4tzLoQoxEPuecrRV5TbHn64XdL cEPuw4bfn/xmk9XBpxIUWzNMjjTwnds= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eFXGnCa0; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751531383; a=rsa-sha256; cv=none; b=ypWRQ8jTV+tyBfFClsxp84vsNs5pV7DTj7uWFjhSa1Rn9YjGRDbNts9/8ElZKZAJViG0AS b/mayu97d9fYvyxQ5N/iRpGLagX+P/bDMh7d4pRu7II+nwGrjqWr7vxzahK6rpbQTT2++O BNv+OBVjoWH2g75sM3VN3RhiviT8JPs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751531382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ao7iXo6bPr/lMtF2Dn4u+FVUcO1qO3WglYeGUpi07GA=; b=eFXGnCa04wNomChCFDCUkL13zzN9VrFpfAJkyrAX4YysAAOwyXfkoyEbd4aw5dnUU5Cp8S wHjTg48mN5k3UJk0WqJrV+tBvl6EbrQG1aiwuuU9zL9iK/C09isO7VtV9SYzL1jqvpV8HD ju++0xcFlLiBLdGLd4+WXd0UvFmSodg= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-LRJkVPzYNzCgzeathYeMJQ-1; Thu, 03 Jul 2025 04:29:41 -0400 X-MC-Unique: LRJkVPzYNzCgzeathYeMJQ-1 X-Mimecast-MFC-AGG-ID: LRJkVPzYNzCgzeathYeMJQ_1751531380 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-ade81d27cddso751243366b.0 for ; Thu, 03 Jul 2025 01:29:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751531380; x=1752136180; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Ao7iXo6bPr/lMtF2Dn4u+FVUcO1qO3WglYeGUpi07GA=; b=VptHR3ads86k3+kmKhV/3qSY+Xl6hiAW2m5h9ctzQtFk+mSwppiiYKBZgF9mrT1OsG Yo8eye3tBWC8DcGpyscL9wScdofbgsCC12uvDl4BYO4lfTJ1db+ookjr6Ovrr72KlaEN OgvVOyL5uV6vjoF7eirDIHlr0EkoBfwAW4x/uCwcF3CbBXPlqQ20+Tu3h7uZz/lqxREh 4Wp+FimmTWra0hM9NRC7ESCD/sIoN/HZwU+LeMhubqkLmUfbf0HX0XlC3M59McP1cwxx cvRqHV5OkOOpNPljTKziu2pw29cB+O7jeSPMyjazxYUpTVwuxWh4LlVzW8FOi3CgOdso 32Jg== X-Gm-Message-State: AOJu0YyKnB8iI9xXqOZyWgnGVlP+EqbHp41WYyYomnHdAIL86AdYFaev HX1XEg529PaZBgoI6C287H7TNSTd8MDHEiF+nKq3ri7BQV6v03LsBtsLQxJaZQXXFOpc6XgHNdR 0+gwlxgaKoPAgBz6NcDUO9XcOttCHn5+6I193jV4xpc5yIcaxRZMG X-Gm-Gg: ASbGnctpaiaE0BbyUTOiVVOn/sDVGHAO0qPDo9kfEIOahem/nbz+T98xfUW8crQYNG/ 63MkiTfGP7pIGXW138BJd2tIG7RJErImNrgRRl/zAjhfMgQ1D/kWXQcQDg+ukwVnpUSPeSrVh20 Gvv8FyxANtZfkmaNjLSqFO66iZPpZyundYHZVij6ndlCzCFeiYLkSLvLbuF1T4BhpP2zgmTxF9A 9L6foO/K8u861816V3hZIkabdDBHm7vP85DhSAF3Pv+R0jXu1JoYOZ3jmhgfMt7s7d+9uWcVDEY hcVb4DwWtjaKAB/jPXcer6O1rkRMZsafz0ATRPgoAAU4 X-Received: by 2002:a17:906:ee89:b0:add:ede0:b9d4 with SMTP id a640c23a62f3a-ae3d7dec8c4mr211838366b.0.1751531379339; Thu, 03 Jul 2025 01:29:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQR9Sq+kwX+EgrNsiJGUPRsQvrn7rKaEleIhOhduYW9+Qa0jv7W//ZA8gBY3JGvvrmcUIaZQ== X-Received: by 2002:a17:906:ee89:b0:add:ede0:b9d4 with SMTP id a640c23a62f3a-ae3d7dec8c4mr211834566b.0.1751531378784; Thu, 03 Jul 2025 01:29:38 -0700 (PDT) Received: from [10.32.64.156] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae353c6beb8sm1226408166b.132.2025.07.03.01.29.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jul 2025 01:29:38 -0700 (PDT) Message-ID: <897dbcbf-d98e-4177-9d38-3d179c7d560b@redhat.com> Date: Thu, 3 Jul 2025 10:29:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/7] selftests/mm: Fix child process exit codes in ksm_functional_tests To: Aboorva Devarajan , akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de, ziy@nvidia.com, baolin.wang@linux.alibaba.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, donettom@linux.ibm.com, ritesh.list@gmail.com References: <20250703060656.54345-1-aboorvad@linux.ibm.com> <20250703060656.54345-6-aboorvad@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250703060656.54345-6-aboorvad@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Jy_x2iICpMBxhswum6ZPP7Kh1-ZdkdwZfc0YUjLSSW0_1751531380 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8675D180004 X-Stat-Signature: dyrsi348xqo18zbprgbuxh17u6xo3otu X-Rspam-User: X-HE-Tag: 1751531383-565270 X-HE-Meta: U2FsdGVkX19NCDU5Bm02pvqpVNg09C6zLN5wnUYl2DHsO+vsNJJwcCjObmndpFDY4zg0kQCh99Zh0P8OovTuVU7Kg4HBb3a5cwKwLso579CEPpLs5GsLs5apE7AVdSyPhMqolQbOV44WNvdJwz0mhKHtqGDr8bYu29WS0Z4YGHiWKA4MjcQTOBKy0e34K9dYlbil55dD0IXfw2/wOOF1Cpyncmvbe3VdDJrOAWciQFJlFe8IcYJrvYNT0YypTXjxSsDrlkZ+gQkGzlYrEenPm59ALAofuVn4t00LkGSgHeX3hU4UhmVwxmuxl/WgYc5n8A1+SfDc1s/7ImHtoTZiFC6XbOC8d4UQx79PT1C4zTJrHjDtKsmjqnOcIPCMC49T5fOpr2oBrD9MMe1PABcOUMvDYAlPqXEz2WZKaeLNiEYDEKAZjRC5nhOCvjnbSvgTVGQYBTzZVrlNFZNd2EqS+eEvwD91+KUbbiDcdoealzIENC5XGSedMiT1YxaRFiH75bRGXEWu5L7zJTQBSXFkAZo1Lk8Q1S3K7QDLan1utkx8c9iDy8VfP21QglKoRLav82xsn1Key9CPuUtsTLLnN2QTAwL+0zV/kwFb1fuyv17CUMPa117gyX8ZWHDGVDzyY7WNEdp+Z9o1b9rmRLwuRaLrCzJFzybEIBmFl9ijetr9322GJ4+ZK7EBmQ03n5lrPhYI4jLNfBiTCQTjFSIvSk7mXdk2U0S8gGzk+EVuK2kpjLvkysfdUMrH221sxqRMSBxY+X8f6tttV9hNm1k4UqnRTizzhjEZPdJkl9Mp5yIpTU++L7C/KvOuPVEecffbE/+9RsLTSmleuilMZEvPuwmx2TK7FX0rYYsWiKohjdH5NjVLAgCs/+Bw5xOGmJaxbH5OT8/57+mmuKjoQvyhJZbVT7uAabs1Kr3G1jiwDOp2fZNx/sO9CjG1+ajbUol2CCX+GTFG9RPTjzY0DLJ UauYXwdJ EeR6ueZpmd+mZUQr6VjzG7h1/3xCvw/5/N7OD6xjRMOKMRoTCKWID9cJWL1uLydynekeXSEHOncXLE/EVJ8BZ9jYeANJ8XmVxXoNveyrt3Ica8BcrZa35unJhcO/vOzkG0gxQkh2l9NhXXPeVhLzwT/+fWtwLprnYn8Vwnh9YKAijfmy7zrxRx5PtzZlMm2eMOeKbFcaDrP0caQAq4GMp1WzKf+LLyDSE712d+43Do+rRhQidXC+q5AlhBNfiLM6If1/YOtONh1VoOyuHe+P7IMmJ0OlHQ2AdW9HhtW25H2G91p+9wEnAkHTdEgN747jLEydIT0a+DUxNzc0JwkavM7rcB0GoD6blBGzJfbIrgn5MnFaMJJ3Uv67NPi+svUDDlcPZ7qmQMRJtgZLt1ayEN8AcPrOhzaviLMSdq9pe2N0fuQJOxCWatZZh1xbbWXwoulgRt8qOXZL38iIWW73Hiud7MNwDbnKHelE8sx58aDZn1SUVljNHsrs4Y0cYqbsAQeoKV8XQm4kMNfHM+EcxjRqpZvNpIvEvqV0Q/s4fd0hvv7WQqaCBpglzEwDV9vSkCO43cPSLXkwcGznVHFMcompvCA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.07.25 08:06, Aboorva Devarajan wrote: > In ksm_functional_tests, test_child_ksm() returned negative values > to indicate errors. However, when passed to exit(), these were > interpreted as large unsigned values (e.g, -2 became 254), leading to > incorrect handling in the parent process. As a result, some tests > appeared to be skipped or silently failed. > > This patch changes test_child_ksm() to return positive error codes > (1, 2, 3) and updates test_child_ksm_err() to interpret them correctly. > This ensures the parent accurately detects and reports child process > failures. > > -------------- > Before patch: > -------------- > - [RUN] test_unmerge > ok 1 Pages were unmerged > ... > - [RUN] test_prctl_fork > - No pages got merged > - [RUN] test_prctl_fork_exec > ok 7 PR_SET_MEMORY_MERGE value is inherited > ... > Bail out! 1 out of 8 tests failed > - Planned tests != run tests (9 != 8) > - Totals: pass:7 fail:1 xfail:0 xpass:0 skip:0 error:0 > > -------------- > After patch: > -------------- > - [RUN] test_unmerge > ok 1 Pages were unmerged > ... > - [RUN] test_prctl_fork > - No pages got merged > not ok 7 Merge in child failed > - [RUN] test_prctl_fork_exec > ok 8 PR_SET_MEMORY_MERGE value is inherited > ... > Bail out! 2 out of 9 tests failed > - Totals: pass:7 fail:2 xfail:0 xpass:0 skip:0 error:0 > > Fixes: 6c47de3be3a0 ("selftest/mm: ksm_functional_tests: extend test case for ksm fork/exec") > Signed-off-by: Aboorva Devarajan Surprising, but seems to be the right thing to do. Acked-by: David Hildenbrand -- Cheers, David / dhildenb