From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D56C61CE7 for ; Thu, 5 Jun 2025 12:22:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8706B6B05AD; Thu, 5 Jun 2025 08:22:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 847AA6B05AE; Thu, 5 Jun 2025 08:22:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7377E6B05AF; Thu, 5 Jun 2025 08:22:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 53ED86B05AD for ; Thu, 5 Jun 2025 08:22:04 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id ECD771207AD for ; Thu, 5 Jun 2025 12:22:03 +0000 (UTC) X-FDA: 83521258926.22.F6F5EE2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 76EBFA0005 for ; Thu, 5 Jun 2025 12:21:59 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jE12g9E+; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749126121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wldJrlgD5xSFvxqsPYQgEMgA0AgR4qOzKzhiKtc8NNY=; b=aZ/nSqnH7dRXBIGqlXQI0fTz02LiPqR/Aq6uphDw3fAWhvIDro1IJppilv1giSaHVSZtv8 u9NweH/uTeY4PSgQfe8loPGmnHW3ksi+u+EoMqtiaUhLRKUio1xj23DpfS6AOM7c7eldRf iJvwHfWPhUWR+vsZfD7vcMfmJ8eF4qA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jE12g9E+; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749126121; a=rsa-sha256; cv=none; b=200/Xlreq3ZNc+KVOY2sTTowPHSa0nS7/Nxr9b9AGJvb1eGPMOPJUVWSvTzHlwBgi1Imcb 1uxUIQImiPDAUkHmo5eoeKHxrwd+oGjOwjHwo+nOqs5hREUh0+1OSVh3wCypMHDzTeXxnw nN5ACkC9F7fQfpuNSj8vd/E0mFNFEWw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749126119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wldJrlgD5xSFvxqsPYQgEMgA0AgR4qOzKzhiKtc8NNY=; b=jE12g9E+OI9/zIeclRLI0VdHKfEXZ2slyAEczWVhWt3z56eFeyiV70bsMnTQywniCRtOLY 2SSbUK2VoWPsQrz39Wn2TgdR7SjwFBjs2EgI41voclpqyjeqbjlFj8GHUGCPiwbyLSFqGE osTm0VPduvMsOFVQYxB/E8yORwO9RnQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-I_uYqhxQMryf4JYpHVWg6w-1; Thu, 05 Jun 2025 08:21:55 -0400 X-MC-Unique: I_uYqhxQMryf4JYpHVWg6w-1 X-Mimecast-MFC-AGG-ID: I_uYqhxQMryf4JYpHVWg6w_1749126113 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a52bfda108so312075f8f.3 for ; Thu, 05 Jun 2025 05:21:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749126113; x=1749730913; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wldJrlgD5xSFvxqsPYQgEMgA0AgR4qOzKzhiKtc8NNY=; b=hUvyHqiPHW3a5RRMOCCmpxWKdVmcLbfNX/xYmuv1yCaqHny9XSmIN80HnB1t2NbSdL KnAJba3lc7carpq1voPb1aVQal1k3TI4e7X2tADzI7zW+sR39dqYl1lCAX03omiWxN+Q ktuQlqVRzdFLe7f7IvKfPra8gg/r3KrT/zICF1cPuxi9kDCEik1odTzgoDKdNP4Q42fA cXvVMn2kZFJ7Anr37ON3efguCi49viMAH02juS6ZByq+WlyhVaiTjUVr1HdaBxpJxDsy nTLpMfOcnlLRyPqkygAnZLPx+5J2gztioSdKQAt0gnVLfswzzf5lDmnfulI0dhbXt8zf NffA== X-Forwarded-Encrypted: i=1; AJvYcCUZcbM2WAkqu0iRLiz3R8ao4vGJWowbHzk9PYqajuzfCijGFs7zAeXpDs+ji/uVL1PoII5x0GvaXg==@kvack.org X-Gm-Message-State: AOJu0YxRmX8S3iDzed75KU3drYL7CI/vuFQngTE1hzl9CMu51hbMFutd dauwuGQL/YaZGEVj/5L1zO2cDkU/+eRqL2fhwl1GI8FfNsQzwsA7r5jk4k35p5ktRdT03mkvcGr A1qF8yD1GTl0+hHMgfV8g0kqr0OG4FgkaSNG2bAnrpZ3vRE2M2Q3Y X-Gm-Gg: ASbGncs2dNzZvV09GAz2ryh2jCl28u9LcCT5IID3OOFTyQhPXECXR/PDBbCHOSvo6XP XCwwQ/AAX5YtE/gLZamCNmLQKkqp5dBhXM1jTiqLLfjqBO/cQOR39EElVjeKEOBRD29+zEm6mTd h3whCJZTtcVOjGwry8yvsC2fhAMdxzQytOBQVtl5dUTsmaQcxO5JeB4to1eTpUJ6ys4rnD5l9B4 DTm03dRRXJDJBG5300OJ4u3IpF0zwogjs5WDbgCvciLYMQC5ezlMWfKvmuVkpB4eNgjR0Hd23w8 U4HfDzm9/r8L7Tlz+RwQ6qjiOHbqzTLvsywgFiXNHNRaAoWKZT64C3lYCnBWwPctRRoIb4F70Ak wme9a4a5eqwxj79hjMAyxonvsAbO5zBvS2AQX X-Received: by 2002:a05:6000:2411:b0:3a5:2ed2:118e with SMTP id ffacd0b85a97d-3a52ed213bbmr588079f8f.9.1749126112959; Thu, 05 Jun 2025 05:21:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEqjyD+ON8FzosZudBIIk1cZ1N02kAPjk9ZRTcKJAP4iMjdx7JwYGTIDMl9lWAJcTgFebdUXw== X-Received: by 2002:a05:6000:2411:b0:3a5:2ed2:118e with SMTP id ffacd0b85a97d-3a52ed213bbmr588039f8f.9.1749126112497; Thu, 05 Jun 2025 05:21:52 -0700 (PDT) Received: from ?IPV6:2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2? (p200300d82f27ec004f4d0d38ba979aa2.dip0.t-ipconnect.de. [2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a526057278sm2657445f8f.63.2025.06.05.05.21.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 05:21:52 -0700 (PDT) Message-ID: <897590f7-99a5-4053-8566-76623b929c7c@redhat.com> Date: Thu, 5 Jun 2025 14:21:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/12] mm: Remove redundant pXd_devmap calls To: Jason Gunthorpe , Dan Williams Cc: Alistair Popple , linux-mm@kvack.org, gerald.schaefer@linux.ibm.com, willy@infradead.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@groves.net References: <2ee5a64581d2c78445e5c4180d7eceed085825ca.1748500293.git-series.apopple@nvidia.com> <6841026c50e57_249110022@dwillia2-xfh.jf.intel.com.notmuch> <20250605120909.GA44681@ziepe.ca> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250605120909.GA44681@ziepe.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hUQb4HyWA925QDoOBUA_nVHPj0ekTspsg_QF6snOF1c_1749126113 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: xmkf8do3bc1kc9hd98judq4gyw9wmzym X-Rspamd-Queue-Id: 76EBFA0005 X-Rspamd-Server: rspam11 X-HE-Tag: 1749126119-299863 X-HE-Meta: U2FsdGVkX1/G6Fq2ctxu4oxLFkPaIl/HbGADgziCLlOOkT9YDBQeDxoV+2bnmyNAa/p8FqhDtcYN1LsYicWjN08Hmko8A3XvirIP6iz3JuJf+ZsIEn2fIpipTryfsSzUHX+n+xcBEy846wEgPDBtf4+J8yMrHn80STLhxOVuN0fVxtlLAnzmvNB0wYEWwASIZvG5k4PQab1YicXEqSs77jTE51dL5G4itvHaRrLNQFpZJDRK0WLlylKjYIsyu8lU2X1v/8wSdOR0zLRbEPs91mbYF+9O9DigxG8/qwoCNjesKAckf3MNH1TZASmR7qrjyyo2ATIMctZgJdy07fY5mJXydbESM5xlGjU8UM00/rA5/HfrUeVOmILg8qvNkmiZQgN4PgzZWFX67+jT4Z/9f4ZURKyyYS2Pi5qvNnxXgQul0STDzJJ8gbh2oqf3ZOIr17bTheCKGFsAc8g1uDG1pQ6COdVsW/HgqVAacAjKYn79I/EljW0pS/+FSCriygB4MOGnHOU1UOwOocpfKowWbhF9auKDgiwyMdfBBxPCIZ9wWeqQBUcA8xyqq/R+SZHvmhjjp9srBceEIezYcY67/tGU5GT0otqZJfrAF+ik9jg6i1AGfjjCm81t1v1tWAHwJhNdK9UpAsXVWI+RXECpFygr6v/LqznfS7BdLzclFjB3OybpvNDnlXZ8yLouksl7WcJ5vO2PnWHlGohDsfcfXVnQ4uVMD4A2iDFXQ0pXRYN4hzcC+kUjIJo+jKOP/KoEIOFRqu6joImHV85Qj/wF61YUkyo7xKIf4F64DsVvqqosS8D+sP6dpipvGSR9567iIOvR/S4vt1L6XWnBldk8vE3ejseC5gVmboKATxRiUnnjmXxAgA+MWv1iC0Ybr0hITO5BWql6i4y9qGXbGFXxdiqHX/FAOnbRRQJgkSf719FIlUGn0LyorY9rv9oZaGpwxgvjWLDvID7/IZW/p4w S+aD5kip XGsDZFJjeK8QzqKKiZG3j19IN0bi/9fQ13aMONoBxa1O/bMHvnlEtxs3j0Vj93TMvYrRcv+vNWo6sH8UC+CVMm8baNNusaJchqDcbgbKInmIewhwndeOoVgPtB6m6Yigh7xjr824jx5k7c62+qSrVRTfyBT7Hr83LJZ4WGhMDVEUXxndMT2sQ+TTm4YMfesw9MhVQcNcGyxN0YjTcrO+id02Ch5kgXIvNHP7mx9aS7gqpjxLbdCp7OgeL/KUgp+BsHuac2hHLsBcidWgbrAhfitpYcBKI0eQEUCwq7kopsfQg05QXsyr6J1hCRbD4qeaSqEFZmCUMrx979MYPb7Ga+1j1epJjL8/Y25DW3zd8unztd4VxzIa6ctbGg7k2HM2Ky0CiNS4YxMwdO5B0XgJQx6KTGdtVsVUNa0Amo2dkKvlfg2Cu609IWSkyL6rHDbs/yw6VEadYjHhpz6xCfN5ZL3mZGBbxF+3hi6BhZoyxGg794uWmlHQRCoaA908zMR9dkCnXwG1HZdpp46q0jjICObcfY7JGJ0WvXf7+wxuRmdeSAze3jrvalftllhhDnqpwRKrW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.25 14:09, Jason Gunthorpe wrote: > On Wed, Jun 04, 2025 at 07:35:24PM -0700, Dan Williams wrote: > >> If all dax pages are special, then vm_normal_page() should never find >> them and gup should fail. >> >> ...oh, but vm_normal_page_p[mu]d() is not used in the gup path, and >> 'special' is not set in the pte path. > > That seems really suboptimal?? Why would pmd and pte be different? > >> I think for any p[mu]d where p[mu]d_page() is ok to use should never set >> 'special', right? > > There should be dedicated functions for installing pages and PFNs, > only the PFN one would set the special bit. > > And certainly your tests *should* be failing as special entries should > never ever be converted to struct page. Worth reviewing [1] where I clean that up and describe the current impact. ;) What's even worse about this pte_devmap()/pmd_devmap()/... shit (sorry! but it's absolute shit) is that some pte_mkdev() set the pte special, while others ... don't. E.g., loongarch static inline pte_t pte_mkdevmap(pte_t pte) { pte_val(pte) |= _PAGE_DEVMAP; return pte; } I don't even know how it can (could) survive vm_normal_page(). Of course, a wild (and different) mixture on pmd_mkdevmap() as well. So happy to see that go away. [1] https://lkml.kernel.org/r/20250603211634.2925015-1-david@redhat.com -- Cheers, David / dhildenb