From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88CADC4707B for ; Fri, 12 Jan 2024 00:09:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E58706B009C; Thu, 11 Jan 2024 19:09:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E057D6B009D; Thu, 11 Jan 2024 19:09:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C80A36B009E; Thu, 11 Jan 2024 19:09:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B962B6B009C for ; Thu, 11 Jan 2024 19:09:08 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 931FCC0C2B for ; Fri, 12 Jan 2024 00:09:08 +0000 (UTC) X-FDA: 81668723976.09.1573DDB Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf23.hostedemail.com (Postfix) with ESMTP id 3B953140003 for ; Fri, 12 Jan 2024 00:09:04 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=iCXHZm6V; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Skk84Bdf; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf23.hostedemail.com: domain of jianfeng.w.wang@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jianfeng.w.wang@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705018144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=76CB0YjqyDqF1JiJpAD3K+0svNXqQ0qe5z3+AmRZmgs=; b=eeFNNrRptzq70aDnC3flub6VJVmo+KLCrxAG+xro1oeVvDKX5NHzZhShYvoLsIRPzHTwfD r8tXgO14tOfYxLUFBbEFpj3oDjwhuGDol2HBXItU0lFWuub/y030m0nJS+Y9mpx0cnj2NU NVBEgNb+sZNIwhGWIUqfXMuCw5LL7N4= ARC-Authentication-Results: i=2; imf23.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=iCXHZm6V; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Skk84Bdf; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf23.hostedemail.com: domain of jianfeng.w.wang@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jianfeng.w.wang@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1705018144; a=rsa-sha256; cv=pass; b=EG1Ncs49CqML8JaRQ3if5dHq2zjuy6cN6MN/SbJt4GkrrqRgIMnPgKzeygWbIiwEA6PYze 400Mv0DfJgf+fgg+tVj5ydTJV2gnnbD7LmacYWlttCQ27TT1sCizwf6R1GcI7FxesAM+pE iw23TfuNAvrP7UhaNOFcc82CLgUsjDM= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40BMPdYg012708; Fri, 12 Jan 2024 00:09:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=76CB0YjqyDqF1JiJpAD3K+0svNXqQ0qe5z3+AmRZmgs=; b=iCXHZm6VUVVoIHrPXbiKMUm1Ns+AgtZl5w4Qkun0qUG4Zbt2LHuZVLmN1rhD46y6een1 xEXmQFK1TcKisD7n5w5KuWVrEEXPH8jXUlrYgMf96eHZRnz02o8Gpe9eLNeq11ZLL5Uq 49T5fX7Gp7lSIOKtveu/hf3sK5gh22EwDbgsDFwctnkrPrunkhLg9mL8+nzwnedXa26d FFrsT0Q4lHuesfy0BXUROOsJe5W+nCg/aEZ2Co67EYrLRyhNVIkDbrmCmrJpdHA3hmjK 2diK2LeXiHgwUWfRgpfdGZ2tmK0n1Un1wCQXXVtvazUNBub+8E2yvWL1LpVMtNcgTXgo Lg== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vjq0xrhta-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Jan 2024 00:09:02 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40BNhAJX013691; Fri, 12 Jan 2024 00:09:01 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2169.outbound.protection.outlook.com [104.47.59.169]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3vfurfgr2x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Jan 2024 00:09:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cc0mpk9bZtBA5ebjAYqLFABcr7hIv1AbpL/7OtJIGJHPcfknPCxgMd+cR+oAwnGpDhEwcqJUTCzbTr9YYBOf5e3xQnZqREIDmBNkK6jl2n8GGj157Gk+Xpu2F30bjpIG2zEt+jD/eEUJ+i4Unhev4LfEyRvHBVkABoNyH2lrKoIVXoSQU73KYWBgV1fJUQtIwY0IyITZjQoNNbf1t9vwGXUr00LiJa3kolbKV8qGGiixyhNvTMinwNvWQyn4xEfoVGEA9MSE9uyAMzktNsD/mRAAB3Kjvf6QbSQRYB57Ulhmu2u8pZuv499f6Dsh0iBySqqY7jBiIFJH9psErIKTkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=76CB0YjqyDqF1JiJpAD3K+0svNXqQ0qe5z3+AmRZmgs=; b=jNq/AE07G2rO4Ao5ryk0pbv11zjsd/H7m2eY87rmziicJUPbQiZ1YraEXyjAlvj2zS9KyT16Dlkrf/I37pJJFN7kIvOl8jA10Ac+MrZvDMjrcW6w7NYxbXJPoi4csaKsMpc3VpNwx7I0VTuskr6QqRY6Dxc+8G2V9FP3oi5iuci3MKzV74g2cEQI2RlQ8UQcorPSuTZTn+zMcnCwJip1Qa4Bx++0bhmeJ7FQKygXjQZWVzM0/6OkICNbEW0+vKwii89J2zZZ7WIjYf5+2AbhsNV6FnE4c+XOKRV/5VVORtdA3qzA5RVDgrnEMEGVPop2Y4t4PvuUc+HIDOGN+U/AbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=76CB0YjqyDqF1JiJpAD3K+0svNXqQ0qe5z3+AmRZmgs=; b=Skk84BdfNSfhwfObhUXRPK9Lsd8Kv9ad+vqiCQG8lKPHueTiRluQKHSUPmC68QMDQNKy+x1LPgYpdxa55gfhaw6JpNDW1u1RGaOTgUKzMBHqcI/FbbaiQthY+P8Epk6aYME9tSoRUQEy39yqM+0WVWK0ZUvRvkbb2RdNfuG2fDg= Received: from MN2SPR01MB0026.namprd10.prod.outlook.com (2603:10b6:208:cf::18) by BN0PR10MB4950.namprd10.prod.outlook.com (2603:10b6:408:12a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.21; Fri, 12 Jan 2024 00:08:59 +0000 Received: from MN2SPR01MB0026.namprd10.prod.outlook.com ([fe80::7dbd:113e:6ce0:23d3]) by MN2SPR01MB0026.namprd10.prod.outlook.com ([fe80::7dbd:113e:6ce0:23d3%7]) with mapi id 15.20.7181.019; Fri, 12 Jan 2024 00:08:59 +0000 Message-ID: <897538a0-5ce6-484e-a9bc-4e61b3be2265@oracle.com> Date: Thu, 11 Jan 2024 16:08:57 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [External] : Re: [PATCH] mm, oom: Add lru_add_drain() in __oom_reap_task_mm() Content-Language: en-US To: Andrew Morton Cc: Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240109091511.8299-1-jianfeng.w.wang@oracle.com> <1d866f1b-94b3-43ec-8f4c-2de31b82d3d1@oracle.com> <20240111135404.609af4a26d0118c0d290f11c@linux-foundation.org> From: Jianfeng Wang In-Reply-To: <20240111135404.609af4a26d0118c0d290f11c@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR03CA0341.namprd03.prod.outlook.com (2603:10b6:a03:39c::16) To MN2SPR01MB0026.namprd10.prod.outlook.com (2603:10b6:208:cf::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2SPR01MB0026:EE_|BN0PR10MB4950:EE_ X-MS-Office365-Filtering-Correlation-Id: d5ab18a2-8ea7-452b-8bce-08dc1302acfd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qsPrEJwjRLUuIwwKOgOtmcxOd81T4Xp62E/KNoRbab/JNtKXIlXSDQg42v+rA+AEZIWR1ICcHgWlJINf9LGs6WzuYG6pTfL2hVo+pSc3JJyhS4C/UV92Aura6cAZ+9wIafH5dmhuck2es43/hoROw4KYiG8LJr2hREGjIlZMEuiC7wDja2STFK3m+xjbxG5iilgJ4bJP97KwFHf2GPKmY65hCeKmuYfTD9TF6/XEPO/EAJcyJyFUVdG/NjOjbYtjW7I+C/d5GzdzkDLnAcPSYmI03J89IE4t/B0Sy6kKWEYyA640piePxJxbtLRf+RATFfeX8VjM9Vr1V/XWKlcvZBCaVGQKNIRY/Vra9G0F5sNMdGY2jnJS364kmLgCb5XVFdEweZMjejnJPoJgfa00oa7Jz6pX5oSzjTjnqP2FLsvh0mokGEnEMu0QPZJdfFkmslWSorEJN95rgO1ZmOjkeO6KrQW/MHZl6CJKdAOOGnvA4oZ0elBNooOCcGxcf95gjHWRR867vmQKtSqPj1ZLI+WnKJ+kPtK5eU1hHdRBpRjiuLan/E4GAEem95ovV8MaEjq8ZZtllk1dHwX/DU4Slbg/gqLN0GMof19xK0lSvfhvdz2h+umN/FhWeqjZ3XcsTexPTKX9bUUlSnmDJ64XVA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2SPR01MB0026.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(39860400002)(366004)(136003)(346002)(376002)(230922051799003)(1800799012)(186009)(451199024)(64100799003)(2906002)(5660300002)(4326008)(8936002)(8676002)(316002)(31686004)(478600001)(6486002)(53546011)(6506007)(6512007)(2616005)(83380400001)(26005)(6916009)(41300700001)(66946007)(66476007)(66556008)(86362001)(31696002)(36756003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dG84b0hJWVM2bjlRQnU3R0J4Z0NhSDAzSjJJRVVuQTJjZkRCTmFoVnZIdmZG?= =?utf-8?B?UDhqVEtjZW1vRmFIRzFCd3VYQTJuZ3d6OGNDQzVrRHlxOWdmR2lncjFhbmpi?= =?utf-8?B?NVA5YmEwYnBFdVJQRVlpSXhYbDB6aWZ4RWNXT0hnaEdaZFhQV09QWXpzRXpR?= =?utf-8?B?WDJ6WGxqcGs1Rzl2K2V3Q3VaanpyMWlOZWlJUXl2SEFHdGpENWFicG1PWlFV?= =?utf-8?B?S1JKc0s3MmFySWpGRmVORHBORUNyYXhrMjFyRk5VZ1ZHNTlhcnJnd2VPd3dJ?= =?utf-8?B?RGFNTXdtMWpkekdCdC9heHFxQkk3cDhSRkNqcjZabzdyQmFBVDdZUzZHYlpq?= =?utf-8?B?RUZHamhTamsrQ21NRnRyemVybTgyVW1WZ1A1SmZqUUhZdnNZVG02MlNMaloz?= =?utf-8?B?bG40c0JhaHFtbTJXbGZIWUsvWVlNLzZqT25NMDhSc2JIbHExbkx2WDZTeEhW?= =?utf-8?B?UlVyaXltUXlyYnFEaTFWTFhOLzhRWHhaOTFtaVVCVmM5ZWN5K1FTNFE5ZFZY?= =?utf-8?B?VXhlU2M0cStEVnBmOTh0U0cyY2U3cmJBbXlZditwSzJMeGg0dHpSK1JlU1lz?= =?utf-8?B?SG9CT2FWT0VWMUorTGxaWDNDTkYyMVU2OThGM3NZZWl5aTd1VTJ5eHZQZDFq?= =?utf-8?B?OXpUVGhqTHRkUzUxVlZFMVllVEtsSkoxVGZLMW5WeSt1cnlHQjBaYjllUmI4?= =?utf-8?B?NDlpVndVSzZ1SXNKZVl4MDMwU2I3TXh4WVBPUzRNSS9oRHhIN3MrY1cxcHVu?= =?utf-8?B?UGZOakRCV2FxbHlJendmeFo0VlMrd1lwdEtyQ21hK1c2OXhCV0VkRmI5OU5X?= =?utf-8?B?a0hVZGJyUnJYdUxaWDdmZVJMWmFOMEhleDNLQnU1NFVEbkMydTNJRXNpT0hF?= =?utf-8?B?OEZabVhOamY0a2tTZlBrYkxGRzMvUGtwVVFjNlR0UE9sSVNha2ZlN0VUM3pl?= =?utf-8?B?S2cyUFRnamhPTzVkRTA5cGhtMHlJM2MyRmhTQnJqa2ZGU2hKWm5jR2IvV2lW?= =?utf-8?B?Y3NmalZMTlJaSnUvSXVOWEdFb0UwT0NPYXpNbE0zMnhsVUdtL2RjUGxZdTN6?= =?utf-8?B?dVJrOE1mMzV6YlBsRStuTGVweHIvcm5ZeHFVWGRqSmxDbHVnUHhjK0ZYVXpp?= =?utf-8?B?KzdNMHFFa2JwdmFsMzZPM1kweFROOGhPQXFnOCtHRWZubVpvYjFPTWV4c3A5?= =?utf-8?B?bGdrNWpXRlBNc3pSMDMrUFJzWlhuNndCdis4VkpFd2lxLzl5b0tVZFloVUtM?= =?utf-8?B?dnJ3WUQzaWR5Z0tyTjI0WUZiSHRLb2NRbStXYnhvUkFtcTBuS3l4Mm5IMnZM?= =?utf-8?B?empJbUR6d01PTTVCSDNGL1UvL2JnSHRUSHQwaWlsVEhIRkdBR0FocCt0bndD?= =?utf-8?B?d3BtdHB4eUxaSEt0THV5Z2h3OVdmUndqOERnQkFzSzU0KzFzQUJBdlk1L1J0?= =?utf-8?B?cktvbng2Vms3QjlIOG9CZnVIQW9qMjhNVVJvekJJczRlamZsdmRNQ3k3SUZX?= =?utf-8?B?VjU5ZlYrdWw1ckYzRmxNQ1g2QVlGNzNnZzRwNHpYeklzNkpDc3Bqa20wdkQ3?= =?utf-8?B?bkdza1pYRzUwc0Zrd1FtWkVzb1FodFNsV1dacTQ5aURjamNTOU1EeXNqVlF6?= =?utf-8?B?dmp5M1FxRWI5ZmF4V24rL1BPRHV0dVQzTjM4QWJSaTg2R2RmamFOZy9MREFU?= =?utf-8?B?bmtNb3RLS0Q0SVlBc2VkQzdaQUx3RkVKbXZFM3NqVTloTHZ0RTBvWEZySjlM?= =?utf-8?B?U0Z5VjFQZ1Z6Q29EZ0pLVG9vRDE4NUxzSG9Pa09XdEU1T0QvRmx0Mmd1cTRX?= =?utf-8?B?K3RBNE4zejVFNG9PQk1sYlQ4eEF6QStNaHlnWllPeUlNYkRINzBLa2h6TWo1?= =?utf-8?B?ZUFxa1V3YmFwVnBZNTNvT2tPZVJQUXRXNXV4cHpSZVR1Qnh0ZCtDaWdpM2tW?= =?utf-8?B?dFpxMlJQNC9GQ1E1MXdFMEQ1R2ltaHBiRmpQNDFKVkFQc01sUERMZ090T2Zu?= =?utf-8?B?VGM2OVVwOGhYYjhCbkFVQVZzOEd2VDRUczI4eHRXS1hrTmU0d09mT2NvN1By?= =?utf-8?B?K1NuK3VjaFc0QWE3d0N3bjdqLzlBVnRPcHFVcThXdDF1OW1NZXIwRk9YaXJU?= =?utf-8?B?VnRFY2I1dXhyRUVQQVp5UFJSUjdlU3N1bzUvSDlLUmZoeDVKRXBlQkFzV3hu?= =?utf-8?B?akE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: KtaGd4/3z9eBTo1hBtNMrY61OfVWRRsoM2F3NCjhIb8/tTgfR+/b0ZIVya1+q3zkwy94Egub2iFFTgStYzYDeHsadk1gieVlYvoYKSNNJcoEuBy1+9ZXEFYIGO3L9U40wZQM4+QaPhAejVH5ADQTqvs0UV+Wj4v00nbfM24Up0UQjHHMenvUBJoTjrCVzAw5sBwcAEAbdfFSfqO9Ozx0drUlTQBcgxU1UDNE43rNPkRpVoh5uGLSzLWm1fS2Aaa7E9eRvj++P9O6E0GDAr6gKAP9FZpgvVowo6Ch27dGSu2160hHPAse9HQGUzXHmd00F62Ny6PZI/vubgh8CnR+iia+Fe36APxYF9Z88V95dhrnmGlHbQr+ttk+htOeb4xh0peJyAIH/xtZ59rCsqCBhY5N5LIrvuZnoT7jFc7+IB4Zd9z/xQtJ4KnAGPykCNSWMxamfrCt6Vpocihx9gbXL6jzR+qh3Jy3yz1ca96jPfc83sxRDfgBSHomI+jW0Sl1/UViftxNMRVgZbintCfKHolq5dYPaT0SOmVy3GIEONOgSxKf7ma3GpoIE3p6BMTTD2F+DTyC9AWMpwyJfrBV/3VbIfz69/R6dX7y6xj4LT8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5ab18a2-8ea7-452b-8bce-08dc1302acfd X-MS-Exchange-CrossTenant-AuthSource: MN2SPR01MB0026.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2024 00:08:59.4815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oejoRVNrappPI9vHYksjTQ1Vc+E2lM8E9IULMOK2yTGLenRxWGO38Fzeroe30i2TuHyhmPzO3XOEz/65mKPn5gV+AlP6cG/tK075/pjnRwY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4950 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-11_14,2024-01-11_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401110185 X-Proofpoint-GUID: H9ECK4a1o80PtHFR2PiZbk7ciFTtxz_V X-Proofpoint-ORIG-GUID: H9ECK4a1o80PtHFR2PiZbk7ciFTtxz_V X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3B953140003 X-Stat-Signature: n6p3jh81sgbmuqc4qz4fsyhhw5yt65e4 X-HE-Tag: 1705018144-191205 X-HE-Meta: U2FsdGVkX18vL1CwGsA7ES5WdWEsB19Am5gtibkwxoUCq1ZnPRy2zIFfEdhvns4xdgC/HPwvILq5EQGhU1C7CEbXbOmUfv0EvhpiqIvBPXSt6i2n6cqLX8kHNSNa9OzRFSOV0o5WDDM5B9hUDePJqkFBY7e4NYICA5LFvnDFyag4jZug5CI1UfQQuJie88LO2SAGzFfHmfnelKIRROF0YtSqFc+GAmXIiAXqz3Cp4Z7C2gUd5ziIQ2BUjqndYcYQ7JGRr7T8UDgn88xeGjtvr0oqMkjxazCdfoGSCEidD4zmiHYEZtTkBmpBFICDJGGSsdRkt9xoswI7FYzZa6y+tBzOJxcjzOQ6cMqQD0pCRcmX8pud6/+/D1geWNlQEZU2FMqBzh0ZR6WQ/cZfeWAUA18VhFtvflet5iL1bGk3DZVoDLNJRAMJtA0GlCvz51PlrVHz2mn+Psk3/hp8boCVNLOc9I+Cn11r3NhhY+ZPYpWpLXrHpyrF3rYfC1g2x0FUBzlXknvoZ3kSmeWtO4rId9n54eW7YAME6oN0G9Df6zOnrMxXDmUaarZ9TEdB5T0AA0UpO3t8EHQ8v0ci+Uu01gDz9pIHuB3VziHtkSjx+Nf/p7MD2OZEC0Ysnjffk4pNYfnvsKmaycaLxfR0RsoLmZlGgNALA/YnZJ8JopZMAqVlfViHN0u7lnmt+4yizCdjPuaHZsJoBffH1kJUeTJBIVfWrbw+z/HAT6S2XQI0ZtELixHtzZdGd6ipNd2DyjHsShHfiZnTM0Uk9ui5tBrD8hxnfkW+4Q4Cs8NpeBy/Vb3omQmk6x/Fq09dYd8WO60wgcY64hKVbpqSvU75zogfbU0sxQb6jOw1rSF2N4PUnShQEmXVnv03JT5w+o9mdbnzvlZV+m2IikvqPoy8PnWIDCsR38II4y9jLf0OHCVM0k25VjdpeHcoc18hdsTLV6E7z56elINn/ONhI46gvHQ x2BUKZYA F8Mr0mhBTrTVmpnsx7liL0SJmsba6hXtrfeSmGSuazKYkBsBapMLCPQRRFHfm5yD44ZTboFkvU9CyctuNnFOJ2szMqrxqyuEOMuUK+TylcGKPcM4tcDiednz476YCVprZ0Dj+vIzpHIhOuCC8JiGR4g3b3yv+akpHZ+4CqKU9XNMyFFUIpr0QxUv8KuOPLxKQF9o++tSx9jSuldmf3r3b3nJlLchvbooZWApEVlyGlpCT5v28LTumzlUglKtiiUlPJ7B8Z4ebZnKNT9Yw4R06cn2ulmP7bY0Zd2le6YI9wjVZclrbKBVU+ugBdvdaJeAqB/h4NHp27STLEHxHsFlIqa+4FCocPyPP+ndwWrjP4lJj9O6UYcT9m4TmYCdkvt/MFAwrNz6xO3J2n9myPWUg2AaJJ6QF03HU61KvGfL7C+OCc49biDj/N/o4NdW83y9q+wASju80crMLEaAD/7eKr1mswTtCTLxjVsfmEeMhnAKkfl6MSYIGIMNp3JLD6RO5ubIS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/11/24 1:54 PM, Andrew Morton wrote: > On Thu, 11 Jan 2024 10:54:45 -0800 Jianfeng Wang wrote: > >> >>> Unless you can show any actual runtime effect of this patch then I think >>> it shouldn't be merged. >>> >> >> Thanks for raising your concern. >> I'd call it a trade-off rather than "not really correct". Look at >> unmap_region() / free_pages_and_swap_cache() written by Linus. These are in >> favor of this pattern, which indicates that the trade-off (i.e. draining >> local CPU or draining all CPUs or no draining at all) had been made in the >> same way in the past. I don't have a specific runtime effect to provide, >> except that it will free 10s kB pages immediately during OOM. > > I don't think it's necessary to run lru_add_drain() for each vma. Once > we've done it it once, it can be skipped for additional vmas. > Agreed. > That's pretty minor because the second and successive calls will be > cheap. But it becomes much more significant if we switch to > lru_add_drain_all(), which sounds like what we should be doing here. > Is it possible? > What do you both think of adding lru_add_drain_all() prior to the for loop?