From: Dennis Dalessandro <dennis.dalessandro@intel.com>
To: john.hubbard@gmail.com, Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@kernel.org>,
Christopher Lameter <cl@linux.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.cz>
Cc: linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, John Hubbard <jhubbard@nvidia.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Jerome Glisse <jglisse@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Ralph Campbell <rcampbell@nvidia.com>
Subject: Re: [PATCH v3 0/3] get_user_pages*() and RDMA: first steps
Date: Mon, 8 Oct 2018 11:50:50 -0400 [thread overview]
Message-ID: <8973680e-4391-48cf-e979-1e9a10be0968@intel.com> (raw)
In-Reply-To: <20181006024949.20691-1-jhubbard@nvidia.com>
On 10/5/2018 10:49 PM, john.hubbard@gmail.com wrote:
> From: John Hubbard <jhubbard@nvidia.com>
>
> Changes since v2:
>
> -- Absorbed more dirty page handling logic into the put_user_page*(), and
> handled some page releasing loops in infiniband more thoroughly, as per
> Jason Gunthorpe's feedback.
>
> -- Fixed a bug in the put_user_pages*() routines' loops (thanks to
> Ralph Campbell for spotting it).
>
> Changes since v1:
>
> -- Renamed release_user_pages*() to put_user_pages*(), from Jan's feedback.
>
> -- Removed the goldfish.c changes, and instead, only included a single
> user (infiniband) of the new functions. That is because goldfish.c no
> longer has a name collision (it has a release_user_pages() routine), and
> also because infiniband exercises both the put_user_page() and
> put_user_pages*() paths.
>
> -- Updated links to discussions and plans, so as to be sure to include
> bounce buffers, thanks to Jerome's feedback.
>
> Also:
>
> -- Dennis, thanks for your earlier review, and I have not yet added your
> Reviewed-by tag, because this revision changes the things that you had
> previously reviewed, thus potentially requiring another look.
This spin looks fine to me.
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
prev parent reply other threads:[~2018-10-08 15:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-06 2:49 john.hubbard
2018-10-06 2:49 ` [PATCH v3 1/3] mm: get_user_pages: consolidate error handling john.hubbard
2018-10-06 2:49 ` [PATCH v3 2/3] mm: introduce put_user_page*(), placeholder versions john.hubbard
2018-10-08 16:49 ` Jan Kara
2018-10-06 2:49 ` [PATCH v3 3/3] infiniband/mm: convert put_page() to put_user_page*() john.hubbard
2018-10-08 16:49 ` Jan Kara
2018-10-08 19:42 ` Jason Gunthorpe
2018-10-08 20:37 ` John Hubbard
2018-10-08 20:56 ` Jason Gunthorpe
2018-10-08 20:59 ` John Hubbard
2018-10-08 15:50 ` Dennis Dalessandro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8973680e-4391-48cf-e979-1e9a10be0968@intel.com \
--to=dennis.dalessandro@intel.com \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=john.hubbard@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=rcampbell@nvidia.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox