From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F6A3D111BD for ; Mon, 4 Nov 2024 08:31:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A60676B0088; Mon, 4 Nov 2024 03:31:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A10556B008A; Mon, 4 Nov 2024 03:31:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B0F06B008C; Mon, 4 Nov 2024 03:31:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 661A56B0088 for ; Mon, 4 Nov 2024 03:31:22 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CF6CF1414F1 for ; Mon, 4 Nov 2024 08:31:21 +0000 (UTC) X-FDA: 82747742616.11.09EDA45 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf01.hostedemail.com (Postfix) with ESMTP id 251C140004 for ; Mon, 4 Nov 2024 08:30:54 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=RU1CMVQE; spf=pass (imf01.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730708897; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=T5vDLGsbEr0SVIowN1t5ye+7OUL4pjjT2D7werAFSjM=; b=BoIdfIwbW7/KL7Av41DJnpmZwDE5OuRNVpoiV7iYagp7pvZkbCC1GU1hoCZHtyZld/+V/4 ftHtaRlu4zmXiWq/velg7DcYBfnm6ShBJP7gfLtyHpYLixIXW2b4nf5xa7/r/W/4rsxTeM RmM9QXyQDsPdcYELheasAUUiRu3EWXw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=RU1CMVQE; spf=pass (imf01.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730708897; a=rsa-sha256; cv=none; b=MFpWXq0f7rEyi5A9ZNJ9WVh0ntJW1qu6YQ7pCbwi36dUUon4aF1oieHFR78KW4Hg3tCyVj b2iGPI0VAnmqE8PbGpDqyoO/32BCM5JtUX3c/vRlFm3LVkJKGu0S5r/iS2U18XojVpnCvu HZ5VcGGKkL9hoNFHnmCazXPWISRtJNQ= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-43155afca99so28512955e9.1 for ; Mon, 04 Nov 2024 00:31:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730709078; x=1731313878; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T5vDLGsbEr0SVIowN1t5ye+7OUL4pjjT2D7werAFSjM=; b=RU1CMVQE3YntISidv8kO/WKUWQqCCXEwPi6AVZSSPVDrE7YCZpaagZi59uq4lNqgrY +6dbXpkYj/zQ+2oCkxmZecny7UZf//Akcecjv4VJqYpyu7+BP/aHX5d7IrNR+DkJ7Kqf I6rG8uZYrOCCDOAB7gZfIyUbYCGS0Ni1IbixBtxcmE2nkbYgnlVNIsnnfa45t/pojN7v Xk8aZl3J4AfYd4IyQSYMBzEcdt3847Buompj0UAVMarg5SHbUnqHgwN6cOQvl69lB9qx IT699ej2L8uJFuxgQ1D0SQbuSfRZrgogxE2aIzyBvEZOw1B2ezJQo2ZMyo9xYQXtIIfI sJdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730709078; x=1731313878; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T5vDLGsbEr0SVIowN1t5ye+7OUL4pjjT2D7werAFSjM=; b=JOJTXtHuvco9DeIEi9icxYhS8yati95UQfvZaaLkRJpOwhsKbJ9YwPwjl3In4sJxt3 GQwIMcThtwBPHbighBXYgryhOBmz+MEwCRMnY21s14BoL3N0BQqHAjSZNa+m2kzjnIA/ 7k0lQ2lYCDbf926zoVOpmeL6zD61uIuHLWUcWfiI8E9tvEOGCyTzSKqusDuQXBmTEBmU E6kc943Z0mhnreEMT30wydR4nqKRU43raqelbrfkyeRZbDxYehNM/HzH9RFs2qu/jyQS p6gBHijwNDLGRHoOx5yUELU3RmGgDzmAIG3Fr7Z5VgPHTKHW15C/zRy6eVHMtExFA3bA 6Bjg== X-Forwarded-Encrypted: i=1; AJvYcCWf9ILGgl2Kv43ZGRvU2jRu76FvQyXbiIYmvGBEfqzW4O0gCdiaFtN2ZEaIKZPsDJjEjvhtnbESSg==@kvack.org X-Gm-Message-State: AOJu0YyxXiO9hwGvpV8R6WjOU+lhwCUNSTYwslRRr7VRW1y1F2nLApaQ 8UYqLTyKX7PVEFYF+SDYZ0cdZpujCRZzVfYVG34ZSdDhZQp0RSo6i/unAkjYrEI= X-Google-Smtp-Source: AGHT+IFFiT8xMGT+o7kM5vRaU6KjK8tqr+AcRQcVqXIZYuM1L7HGi9LZqQfv+QQLXIRdVtTWEYW6xA== X-Received: by 2002:a5d:64a7:0:b0:374:c7cd:8818 with SMTP id ffacd0b85a97d-381c79e366dmr9155476f8f.22.1730709078297; Mon, 04 Nov 2024 00:31:18 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c10d439esm12549514f8f.44.2024.11.04.00.31.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 00:31:17 -0800 (PST) Date: Mon, 4 Nov 2024 11:31:13 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Kanchana P Sridhar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, zanussi@kernel.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com, kanchana.p.sridhar@intel.com Subject: Re: [PATCH v2 13/13] mm: zswap: Compress batching with Intel IAA in zswap_store() of large folios. Message-ID: <89728727-0fd2-4539-bc89-17a699d7179a@stanley.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241103032111.333282-14-kanchana.p.sridhar@intel.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 251C140004 X-Stat-Signature: z4fy81apensqbu7jic683xwm7koe7m5d X-Rspam-User: X-HE-Tag: 1730709054-793453 X-HE-Meta: U2FsdGVkX1+XxWtptn2pw3TiR/Yo+QP+vWraS6xnqneoYEL3cKmcwTG8R6IfghFdi8tNTeKhEVVMtOL1P4kgD/sm26HfVZB9+A0ewaeTQpsB09Jpkjyf2JW2oHkyWucbLW2to09hKdKjJ2st3GA19eefG4ljlHoMBXbLvhUffQP9qc5loZhrklPxCG/Qeydpk1A4KyYXmxz/ufI+7EfQFhLITrrsWmbwoZbM9VjJxwuc6rjDiXSAOSSz3mGuQzUqEq5Jvpcn+QFjBhxEBmnXme09y87QCVUuWqAPsky1qlyBgVazQqddtVWehRR/LEMKgYX5o0CJa05yvBD4wnLQSV+gKjhW9VSqSyM9gcwWp/XQGIgIG2zjxE9cVLw7tkF+/U9ssxx6MMUaD0Gh7b0EzqpN7IF+8vslPVWNidAV24ZScF+MPno6SAuiCXUeJdgdB8autcqJkAnoGMsWSBPkfM0OPZI3aDdTCnuohpDETjzqMvs3gvjwkFWvmvQ5a/bXjiUAV8QXtuctoMHllJFZgDGg7UdSGJXud/uw+jbwMMaIdM0FQFY8MaSr7J46mr2b3ogfLd/4cvsaoQakdGHJJ8A99ULaib7+V/zqY1xSC0qHnoCXvtJD1PYx0lpHDJIgZKVplsGce5DGVVZa1eh4ElqDLDLo6SuMygf4HFh30tn+jLnWQ7BTGNNKEjZmolhaKLwd90v1ukzn4RTZu35pagfYVFrrQ30MvjRUYg62/Cth/rgGbJECWv6v6iUORBHe/uF30B2hOAisvTZP8Nqy70UOZ/WuuxCgXv9NmTUS6wACmZ3J09QBL3opFykcS3L6VrRfG6K4JbjDKg3Q+t13K0YKfY2UlAlSOZrEQWgiUV8qlxfqBFwgZzMyQBar0JrK98KXL+H9B9S6h9Pxqeib5JXlzJqOE4PMC32bVhUXcooo0h4y8gLgaAKedMBumOvzZe2xOFsn//lPBcki7CZ fHckrUGL f70ybvZqQ/7djTNClS3KRUcFLFv7YRWy7nrKmKCLKqtevtb3JrgWZLlorwGF/Ug9397hdIesKkgZEoEFRillueg3kqgZD7zDmLVg6qI4KXb+Nc2wccKKgXA29wr2OcsMZ9mPsF/bdQhstNtxVjy5CbnOVVeuelHLCh/PW3qQLml5R9pqWGWNKVHoxy8cNrvUFjWpkb4vPgx915MZgbpptntG0ZieXRYJ+Fgj5gC35MhZr1JPB5qEimT3u+iMwAcqewWMDUGJYp+hslGBYsOC5zGlq0gVFuxcTxisUtOLeEXHI7hlpiQAxyZFTtu24zJa89DBL4wogZMiYTHylex3fNR5ElcNNfPimtWfEy0lsY2yFzZRAPVfwns9jxIdPam9gMw0d3XIrfFglABUE3yazjy33+Rf9V++YRbA6pzO+RpcpkWcR28RT9iJwR/1HEwDY/01WcGiAhysOH82B+n82j4mStItPNvZLmFW8ae9UFzWWXHSvJEUqOyiUGEurmcWPltmz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kanchana, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Kanchana-P-Sridhar/crypto-acomp-Define-two-new-interfaces-for-compress-decompress-batching/20241103-112337 base: 5c4cf96cd70230100b5d396d45a5c9a332539d19 patch link: https://lore.kernel.org/r/20241103032111.333282-14-kanchana.p.sridhar%40intel.com patch subject: [PATCH v2 13/13] mm: zswap: Compress batching with Intel IAA in zswap_store() of large folios. config: x86_64-randconfig-161-20241104 (https://download.01.org/0day-ci/archive/20241104/202411040859.2z0MfFkR-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202411040859.2z0MfFkR-lkp@intel.com/ smatch warnings: mm/zswap.c:1788 zswap_store_propagate_errors() warn: variable dereferenced before check 'sbp->entry' (see line 1785) vim +1788 mm/zswap.c c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1771 static __always_inline void zswap_store_propagate_errors( c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1772 struct zswap_store_pipeline_state *zst, c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1773 u8 error_batch_idx) c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1774 { c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1775 u8 i; c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1776 c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1777 if (zst->errors[error_batch_idx]) c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1778 return; c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1779 c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1780 for (i = 0; i < zst->nr_comp_pages; ++i) { c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1781 struct zswap_store_sub_batch_page *sbp = &zst->sub_batch[i]; c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1782 c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1783 if (sbp->batch_idx == error_batch_idx) { c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1784 if (!sbp->error) { c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 @1785 if (!IS_ERR_VALUE(sbp->entry->handle)) ^^^^^^^^^^^^^^^^^^ Dereferenced c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1786 zpool_free(zst->pool->zpool, sbp->entry->handle); c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1787 c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 @1788 if (sbp->entry) { ^^^^^^^^^^ Checked too late c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1789 zswap_entry_cache_free(sbp->entry); c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1790 sbp->entry = NULL; c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1791 } c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1792 sbp->error = -EINVAL; c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1793 } c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1794 } c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1795 } c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1796 c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1797 /* c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1798 * Set zswap status for the folio to "error" c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1799 * for use in swap_writepage. c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1800 */ c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1801 zst->errors[error_batch_idx] = -EINVAL; c1252ac91d6a6a Kanchana P Sridhar 2024-11-02 1802 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki