From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35B36C71136 for ; Tue, 17 Jun 2025 18:58:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFE6F6B00B2; Tue, 17 Jun 2025 14:58:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7B306B00AF; Tue, 17 Jun 2025 14:58:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F3E76B00A8; Tue, 17 Jun 2025 14:58:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 71B816B00AF for ; Tue, 17 Jun 2025 14:58:15 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 30E61140ADC for ; Tue, 17 Jun 2025 18:58:15 +0000 (UTC) X-FDA: 83565802950.09.F90AAEB Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf03.hostedemail.com (Postfix) with ESMTP id D6D1620005 for ; Tue, 17 Jun 2025 18:58:12 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tKtNSkr8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0nXMkjcv; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tKtNSkr8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0nXMkjcv; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750186693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xQIN6SGamOBSCPtNQTnN9qvUtYsIZ0wcOZBFq4Yrn10=; b=mqw8xPSx1lh/BB4T2AiLoNHgTiUxUMmb3x4SsBBAA2ZwXw5gbV/eJMfHSQft8CsMRBNWgq kOYFXF5oZTSKW0ESA2otbkX21JKqoL8l0DX27AzqHP4UV4ydjsNRNWz+S7Vf4S8e1YSkd1 rfuH1YBT0B/oAO3F052ZklYx7tvaIgA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tKtNSkr8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0nXMkjcv; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=tKtNSkr8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=0nXMkjcv; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750186693; a=rsa-sha256; cv=none; b=IyfnXvWfHeUXgS5zM84uk17MwWYJvTCnmZ2CpSrZPByY3rk2/01jaByqqvhNy/kpSvKa3o dpT3W7vsODensNSvSG4AxZP3CqYQwf6QfocxyKUmUxM6M8VVEbH6lyYjrPVJrBPyDjxguO 6Yxql9iCPxrzcrjHny7Zz8AP8F+CrvE= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 78F3B1F7B2; Tue, 17 Jun 2025 18:58:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750186691; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xQIN6SGamOBSCPtNQTnN9qvUtYsIZ0wcOZBFq4Yrn10=; b=tKtNSkr8RTlyOYCgUlHc1jFxTt1XfwcnpIwgMWTNfPVuDzXr+cN6gsT9sXcMEa7g5nWn6y hSyfx4EzrZhKiYWCULyLuN8VVkf+TyHJPku8FAw21+7bf4dTWfXicv6u8gPRYV/6LOx0sh I+2YM/eEtDGVW8mAgAHfxqRarsxDLvo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750186691; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xQIN6SGamOBSCPtNQTnN9qvUtYsIZ0wcOZBFq4Yrn10=; b=0nXMkjcvOqwE/sE4iS+2RLR98yXcX0zauLgNZHeecfFMuNTAjJUxzZ4T9IceTonWPXDrvd z5IW95JnDhJcHlDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750186691; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xQIN6SGamOBSCPtNQTnN9qvUtYsIZ0wcOZBFq4Yrn10=; b=tKtNSkr8RTlyOYCgUlHc1jFxTt1XfwcnpIwgMWTNfPVuDzXr+cN6gsT9sXcMEa7g5nWn6y hSyfx4EzrZhKiYWCULyLuN8VVkf+TyHJPku8FAw21+7bf4dTWfXicv6u8gPRYV/6LOx0sh I+2YM/eEtDGVW8mAgAHfxqRarsxDLvo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750186691; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xQIN6SGamOBSCPtNQTnN9qvUtYsIZ0wcOZBFq4Yrn10=; b=0nXMkjcvOqwE/sE4iS+2RLR98yXcX0zauLgNZHeecfFMuNTAjJUxzZ4T9IceTonWPXDrvd z5IW95JnDhJcHlDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BEF73139E2; Tue, 17 Jun 2025 18:58:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id AIVSLsK6UWgAOQAAD6G6ig (envelope-from ); Tue, 17 Jun 2025 18:58:10 +0000 Message-ID: <896f522b-c055-442f-b6d6-82869bbe57e6@suse.cz> Date: Tue, 17 Jun 2025 20:58:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/10] mm/nommu: use file_has_valid_mmap_hooks() helper Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev References: <5f120b644b5890d1b50202d0f0d4c9f0d6b62873.1750099179.git.lorenzo.stoakes@oracle.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <5f120b644b5890d1b50202d0f0d4c9f0d6b62873.1750099179.git.lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D6D1620005 X-Stat-Signature: remthfakgdzfgztjooj3qdttmjaomsrh X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750186692-495602 X-HE-Meta: U2FsdGVkX1/ZTKJ0TzyWMdBVQ+Y07ciFeaqcZht43zIddEB0Z77VUMcH6yVtufjM5ka+/s8WkmIYqd1zowMWY4JggUW8a9GSzAfByotGzC+fpjFX+Tq1RLsUcjLtaDbB8yRVKPD7GbmomnJivKNZgAerw5ARlps9TkK2v23tn+HBFsQSBXiBY31GjJc0I2HRG8eamxS5d3i7WZ6Oqm2x7/XxpLthnmHlwrbrr9QPFBcBSj5gB5YFEz5XmkTrYy4zeULNx+SsT/3cxqVcASkIioBy2m1b41Qb7W4tyx4JdrQYJkziMDVjHzZpcPTn9gnfmERqEzISqe1BAWtSyoJm4DNlCLuy3d1/QkrGcdUTShWfDPwUFA5MJ7hUsLaDpYxfAODyxB6jY5LHByY2l7baBEmEiAHttSYL6Ah38FnhbuhiT+e4MTRwDU33qZSOJoKTslNTIH3ye+EAHLQJ9Mfb2EhsIg66ErmZzgeMRmTudZyXWHINKSvjKANWE7Fb5X63LUjp9N4zVHMCiAeP3HXOcDXJtC4N571jkikDvw2tsjrELeRMI0lGxTPZbqGnfAxUlHdxdkPo1T3q+6a3TLDDHSH6F2pGc+akAbEGl6NnGEisbPKi6RNkIW+ViBWIqLH6w5dQgL9pzL5cKZKZ15y2b3C8oex2pLc87VzSMcOzLiof+6wnEby09TB2sxIk70RMGYOm70lTZWcWegEkN/rqTJv6Wcls04CzIIZYwGYKowwmf2SMzWDUHS9M3w+c5gkIN0ZRJCH2CShvy2IL3oFe5nHM06Qvmv+ga1Upxotdj4Pk8A8HfVN6798PQlFlX5TMSlcx/1NmizX9e0Ht1jKhgDE+DbFh/2NdFaiRJK7+m7NFaRkDr5J/nrs0Taoq60zImtLndebWpJRZPZ8JpjHZUTMygr8Mi/1KFaFdov6Ev+ozt1kbqyDeljK/IQ9TbQGbBc1pDD3Bv4p1JGX5Iyd WTvylBJ3 0/KvLnWq0woLQAUtCgSUdgn+CUWi8e3ndk9EpWa3C6HeNYAnOaVo440L51Qxv6GicyIWQDpXDYDqwWXoFF3pk7SU+xP1QFnTmrw+tDcoumAiiTgS/qqrKReV8k1VWPjkdCTKQHOX85VgsriJTiX3VoYKWjsIQCp40Uto1mdWl0yzaf4LUGp93FvbCq5Lbvm7TeSauahzaFObQJi+6fu74KGJkiodiohxKeEo+6xQSD6sWYpuz83Zg7PGCyaUy8f92oHMV5vPwp57Ua4z1kvHvLDsJ/MHlb4maxzTWtuMvCFNz1wElwSXlgX2z8jz1dxR6EM+cLFPkiilK+qNRMrSd86bywtHlg1AyzDSwVSzWyUoBNUsGeYkt/AIyLF+BKPfl9dx6LAVxF45lXgfXLOYwB9sBa5ck6VkAMdSLYtYRZlYqleE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/16/25 21:33, Lorenzo Stoakes wrote: > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > callback"), the f_op->mmap() hook has been deprecated in favour of > f_op->mmap_prepare(). > > Therefore, update the check for file operations supporting mmap() by using > the file_has_valid_mmap_hooks() helper function, which checks for either > f_op->mmap or f_op->mmap_prepare rather than checking only for f_op->mmap > directly. > > Signed-off-by: Lorenzo Stoakes Acked-by: Vlastimil Babka > --- > mm/nommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/nommu.c b/mm/nommu.c > index b624acec6d2e..38c22ea0a95c 100644 > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -719,7 +719,7 @@ static int validate_mmap_request(struct file *file, > > if (file) { > /* files must support mmap */ > - if (!file->f_op->mmap) > + if (!file_has_valid_mmap_hooks(file)) > return -ENODEV; > > /* work out if what we've got could possibly be shared