From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B595CC3271E for ; Fri, 5 Jul 2024 18:16:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3425B6B0099; Fri, 5 Jul 2024 14:16:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F0AC6B009B; Fri, 5 Jul 2024 14:16:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DFC46B009D; Fri, 5 Jul 2024 14:16:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F00376B0099 for ; Fri, 5 Jul 2024 14:16:42 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 96B881A02EF for ; Fri, 5 Jul 2024 18:16:42 +0000 (UTC) X-FDA: 82306504644.14.46C7609 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id CC8F140017 for ; Fri, 5 Jul 2024 18:16:40 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aLPsR7qd; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720203379; a=rsa-sha256; cv=none; b=PFKkWiOHOpA/c98p5MBQwhFT61OetHagL4DjUd+C7/0XgO9bHzBvNCePIi83b5qadIWvLk 6uNstcWS31eRVPNM8hJY+lUCpeTGA9m9JZs4GSzGbqMNRoYO2IT3KCAbMO24YeCAa3+1cL kUhqiQr34tNVYYmntTr+xIq92W9cYtQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=aLPsR7qd; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720203379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=umcAgQJkLcCaXTlNxikI3HT8i9WrQb11v2QIvoRv5/0=; b=oOr1LbtAtzGEDG2NrImzwUWg/pIQUVDYGLjHi2/cYHJjfSxIG1A3OK4BO5Gu59t8dpQIts xIfqx3YnLF5sKqAzowhKKRzCa7qT2H+nb5c0dBSAmmuxIFKwKKtIY0/pJvFTh1hoFMdRNi +bE6TccJ/e8BU/t9mhrKMkyIb20IE7Q= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D12F762B26; Fri, 5 Jul 2024 18:16:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 102CCC116B1; Fri, 5 Jul 2024 18:16:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720203399; bh=Bb5YnOqTQcdobdzl7rj7W0NcvDf4NfDGtBSkHIO+W6w=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=aLPsR7qd6mwWpjFUGCb0nwvuwTVkmMS20f5hAZiWMd4QCcYinMZ/r1W5ELsmgp5vx emKp/PejOwirkxKuck8UVQJyPxiHu/dET4c/vCdeUoiOiPC0ysq5uD5iQtqtzA8hrT dmoikSOL1gvXvanXIVqgdBW55KxEBUt4XzW3j19rNE0B1Bbz8wFjGiylVmHqoXkzwj bLlbfn0k2uv3rProwmqRKgAIt1str9zBcQUCKtkHPd1lNK0wFTwYzuJnKpjyGRFZS5 aig1U5Ej04DkG7JgGz7pADhdvyvewTZNU+zUFeHnLrUwSfnh5xED4ldUdIdw0IRb8X JXn4dr/pltKUg== Message-ID: <89658a8eb54acf4dc46da6dbb05c2007c5b8179a.camel@kernel.org> Subject: Re: [PATCH v3 2/9] fs: tracepoints around multigrain timestamp events From: Jeff Layton To: Steven Rostedt Cc: Alexander Viro , Christian Brauner , Jan Kara , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , "Darrick J. Wong" , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , Jonathan Corbet , Dave Chinner , Andi Kleen , Christoph Hellwig , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-doc@vger.kernel.org Date: Fri, 05 Jul 2024 14:16:35 -0400 In-Reply-To: <20240705140703.711d816b@rorschach.local.home> References: <20240705-mgtime-v3-0-85b2daa9b335@kernel.org> <20240705-mgtime-v3-2-85b2daa9b335@kernel.org> <20240705140703.711d816b@rorschach.local.home> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxwn8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1WvegyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqVT2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtVYrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8snVluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQcDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQfCBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sELZH+yWr9LQZEwARAQABtCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozzuxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052L aPc0cedY xp8+9eiVUNpxF4SiU4i9JDfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRDCHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1gYy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVVAaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJOaEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhpf8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+mQZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65ke5Ag0ETpXRPAEQAJkVmzCmF+IEenf9a2nZRXMluJohnfl2wCMmw5qNzyk0f+mYuTwTCpw7BE2H0yXk4ZfAuA+xdj14K0A1Dj52j/fKRuDqoNAhQe0b6ipo85Sz98G+XnmQOMeFVp5G1Z7r/QP/nus3mXvtFsu9lLSjMA0cam2NLDt7vx3l9kUYlQBhyIE7/DkKg+3fdqRg7qJoMHNcODtQY+n3hMyaVpplJ/l0DdQDbRSZi5AzDM3DWZEShhuP6/E2LN4O3xWnZukEiz688d1ppl7vBZO9wBql6Ft9Og74diZrTN6lXGGjEWRvO55h6ijMsLCLNDRAVehPhZvSlPldtUuvhZLAjdWpwmzbRIwgoQcO51aWeKthpcpj8feDdKdlVjvJO9fgFD5kqZQiErRVPpB7VzA/pYV5Mdy7GMbPjmO0IpoL0tVZ8JvUzUZXB3ErS/dJflvboAAQeLpLCk QjqZiQ/D CmgJCrBJst9Xc7YsKKS379Tc3GU33HNSpaOxs2NwfzoesyjKU+P35czvXWTtj7KVVSj3SgzzFk+gLx8y2Nvt9iESdZ1Ustv8tipDsGcvIZ43MQwqU9YbLg8k4V9ch+Mo8SE+C0jyZYDCE2ZGf3OztvtSYMsTnF6/luzVyej1AFVYjKHORzNoTwdHUeC+9/07GO0bMYTPXYvJ/vxBFm3oniXyhgb5FtABEBAAGJAh8EGAECAAkFAk6V0TwCGwwACgkQAA5oQRlWghXhZRAAyycZ2DDyXh2bMYvI8uHgCbeXfL3QCvcw2XoZTH2l2umPiTzrCsDJhgwZfG9BDyOHaYhPasd5qgrUBtjjUiNKjVM+Cx1DnieR0dZWafnqGv682avPblfi70XXr2juRE/fSZoZkyZhm+nsLuIcXTnzY4D572JGrpRMTpNpGmitBdh1l/9O7Fb64uLOtA5Qj5jcHHOjL0DZpjmFWYKlSAHmURHrE8M0qRryQXvlhoQxlJR4nvQrjOPMsqWD5F9mcRyowOzr8amasLv43w92rD2nHoBK6rbFE/qC7AAjABEsZq8+TQmueN0maIXUQu7TBzejsEbV0i29z+kkrjU2NmK5pcxgAtehVxpZJ14LqmN6E0suTtzjNT1eMoqOPrMSx+6vOCIuvJ/MVYnQgHhjtPPnU86mebTY5Loy9YfJAC2EVpxtcCbx2KiwErTndEyWL+GL53LuScUD7tW8vYbGIp4RlnUgPLbqpgssq2gwYO9m75FGuKuB2+2bCGajqalid5nzeq9v7cYLLRgArJfOIBWZrHy2m0C+pFu9DSuV6SNr2dvMQUv1V58h0FaSOxHVQnJdnoHn13g/CKKvyg2EMrMt/EfcXgvDwQbnG9we4xJiWOIOcsvrWcB6C6lWBDA+In7w7SXnnokkZWuOsJdJQdmwlWC5L5ln9xgfr/4mOY38B0U= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) MIME-Version: 1.0 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CC8F140017 X-Stat-Signature: r76af6xjqp1ojm8tkc7adgccs56hqoe5 X-Rspam-User: X-HE-Tag: 1720203400-942072 X-HE-Meta: U2FsdGVkX19gHiCkryXtxTTSPOLM6/xAj7+Zc1NSeu4orgU1D0P33bhikpk6OP5jrSmPbVIkcv4+j8IH9kgl0i4DlbSlH9yEUvub9KfHA4nWFMqiB34jshZWI59s9ZATHfO7hKn3NWLHJIxR9QdLeH9mCkuR+0gTMAUdALUHg/I2YrcNKd6GB8LgFgiiu6KvDZc+UpiQS9HYDkppM0zl+reTIniRvDIZFV/PuwiG4Mk8YVFqPps1ocLDD7D1YRGEDfxXU84xcEfGhzhGw1RnnR/xKY0KfBR+ug8FsrkNSywZiAAF98AH2CrRcXgegVrswe3hxb+WNcYPFGeXqbE16jqQe8CF/PYZR6BAYDpdQ5TNOhMwvpmlBH2TFLzAvppBEvFeZay/8dNCv363zsSyWH18XVgyxqDUErtZilN+ys9Sck41QkZWmbQt26d8y02sAxA/rADOc8527gZPdYRuN0lp2BWbZ6q8B6N+d4ohBT4KP6Smrtn622wuO/TC89+na81cfkcL4fI3LcieqBjbvfPO535lU0he942Ewu3TbFZXtsy9f4ffuhVezV4PG68RReEraIavKwJoNdDB363AGgdtWxD2/EQXAHoLunTJRdcA98K17SBwb8G0ti8GTRFIoFWHo/okzn3kr1deY1IwcOYYqtmxK1ntX3swOUc0OnF5iifkmeYlL8oDmhvCLe3L69qR8THrNmbqUzmJAEgRVgJfdGFJFzMeHq6vK+sFwaGZyx2P7fjuFK1fzq0t0Q5BmQQR0760DHna7+wNzKpKjSpogJEagkKmB01CA2WXEKklxUFJSpBcM9q6n263AsNOfX7pz5CVhh98DXNAQsMIPnmTPQSK+29lxWg/vZ2so9MXOTHtru3TsauCZpkfzVEumFFrl/oi2m9kG3VLCdkUEYEB2arIOkjYE++FHZDo5sUnoeurJCeGf1KEk6aFBPDjD4kxmQNBxgAVL/j6a1C pKwTw44j tSaONsqul4uWS7moMBkPNBKThssqtyUvHxAx3QZBy4N54yZ2R3QwKcIvN+FuMVwZCmmXA3HVR1vsvi6OVsbMSZc+Pte5OfhCxa3tWZTlpQ+rZ+qFUpQjHyB9NZ/d2BEnsTfOkYV1dFOjUNXo3ttBbP1hKYywQzr4jdQIdk2SOaMwtDh/qY5Du6Is/uLEdRA8eAZOrGENfGsw3+iHKZvIFQKvYfhX6bdhzuqsrZq+9vdQpY05hJ9Qr0fw2HoVvybOOTW060XrproXEiICwmVPG6zl4Ms/AgcX8MZDv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2024-07-05 at 14:07 -0400, Steven Rostedt wrote: > On Fri, 05 Jul 2024 13:02:36 -0400 > Jeff Layton wrote: >=20 > > diff --git a/include/trace/events/timestamp.h > > b/include/trace/events/timestamp.h > > new file mode 100644 > > index 000000000000..a004e5572673 > > --- /dev/null > > +++ b/include/trace/events/timestamp.h > > @@ -0,0 +1,109 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#undef TRACE_SYSTEM > > +#define TRACE_SYSTEM timestamp > > + > > +#if !defined(_TRACE_TIMESTAMP_H) || > > defined(TRACE_HEADER_MULTI_READ) > > +#define _TRACE_TIMESTAMP_H > > + > > +#include > > +#include > > + > > +TRACE_EVENT(inode_set_ctime_to_ts, > > + TP_PROTO(struct inode *inode, > > + struct timespec64 *ctime), > > + > > + TP_ARGS(inode, ctime), > > + > > + TP_STRUCT__entry( > > + __field(dev_t, dev) > > + __field(ino_t, ino) > > + __field(u32, gen) >=20 > It's best to keep the above 4 byte word below 8 byte words, > otherwise, > it will likely create a 4 byte hole in between. >=20 Thanks, I'll fix up both! > > + __field(time64_t, ctime_s) > > + __field(u32, ctime_ns) > > + ), > > + > > + TP_fast_assign( > > + __entry->dev =3D inode->i_sb->s_dev; > > + __entry->ino =3D inode->i_ino; > > + __entry->gen =3D inode->i_generation; > > + __entry->ctime_s =3D ctime->tv_sec; > > + __entry->ctime_ns =3D ctime->tv_nsec; > > + ), > > + > > + TP_printk("ino=3D%d:%d:%ld:%u ctime=3D%lld.%u", > > + MAJOR(__entry->dev), MINOR(__entry->dev), __entry- > > >ino, __entry->gen, > > + __entry->ctime_s, __entry->ctime_ns > > + ) > > +); > > + > > +TRACE_EVENT(ctime_ns_xchg, > > + TP_PROTO(struct inode *inode, > > + u32 old, > > + u32 new, > > + u32 cur), > > + > > + TP_ARGS(inode, old, new, cur), > > + > > + TP_STRUCT__entry( > > + __field(dev_t, dev) > > + __field(ino_t, ino) > > + __field(u32, gen) > > + __field(u32, old) > > + __field(u32, new) > > + __field(u32, cur) > > + ), > > + > > + TP_fast_assign( > > + __entry->dev =3D inode->i_sb->s_dev; > > + __entry->ino =3D inode->i_ino; > > + __entry->gen =3D inode->i_generation; > > + __entry->old =3D old; > > + __entry->new =3D new; > > + __entry->cur =3D cur; > > + ), > > + > > + TP_printk("ino=3D%d:%d:%ld:%u old=3D%u:%c new=3D%u cur=3D%u:%c", > > + MAJOR(__entry->dev), MINOR(__entry->dev), __entry- > > >ino, __entry->gen, > > + __entry->old & ~I_CTIME_QUERIED, __entry->old & > > I_CTIME_QUERIED ? 'Q' : '-', > > + __entry->new, > > + __entry->cur & ~I_CTIME_QUERIED, __entry->cur & > > I_CTIME_QUERIED ? 'Q' : '-' > > + ) > > +); > > + > > +TRACE_EVENT(fill_mg_cmtime, > > + TP_PROTO(struct inode *inode, > > + struct timespec64 *ctime, > > + struct timespec64 *mtime), > > + > > + TP_ARGS(inode, ctime, mtime), > > + > > + TP_STRUCT__entry( > > + __field(dev_t, dev) > > + __field(ino_t, ino) > > + __field(u32, gen) >=20 > Same here. >=20 > -- Steve >=20 > > + __field(time64_t, ctime_s) > > + __field(time64_t, mtime_s) > > + __field(u32, ctime_ns) > > + __field(u32, mtime_ns) > > + ), > > + > > + TP_fast_assign( > > + __entry->dev =3D inode->i_sb->s_dev; > > + __entry->ino =3D inode->i_ino; > > + __entry->gen =3D inode->i_generation; > > + __entry->ctime_s =3D ctime->tv_sec; > > + __entry->mtime_s =3D mtime->tv_sec; > > + __entry->ctime_ns =3D ctime->tv_nsec; > > + __entry->mtime_ns =3D mtime->tv_nsec; > > + ), > > + > > + TP_printk("ino=3D%d:%d:%ld:%u ctime=3D%lld.%u mtime=3D%lld.%u", > > + MAJOR(__entry->dev), MINOR(__entry->dev), __entry- > > >ino, __entry->gen, > > + __entry->ctime_s, __entry->ctime_ns, > > + __entry->mtime_s, __entry->mtime_ns > > + ) > > +); > > +#endif /* _TRACE_TIMESTAMP_H */ > > + > > +/* This part must be outside protection */ > > +#include > >=20 >=20 --=20 Jeff Layton