From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFD0AC3DA6D for ; Tue, 20 May 2025 14:01:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6534B6B0092; Tue, 20 May 2025 10:01:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62A676B0095; Tue, 20 May 2025 10:01:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5401A6B0096; Tue, 20 May 2025 10:01:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 34C196B0092 for ; Tue, 20 May 2025 10:01:55 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id ABB05C03EE for ; Tue, 20 May 2025 14:01:54 +0000 (UTC) X-FDA: 83463449748.30.9E696FA Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf06.hostedemail.com (Postfix) with ESMTP id 7EF9418001C for ; Tue, 20 May 2025 14:01:52 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Gv65T8he; spf=pass (imf06.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747749712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PV1FL/a31fFF87tKpEa3eS5r97RWRD8TAOaHpu3NmaI=; b=Irtl3H6WlzYkwQiLMLRJ2zNz19N/alS9x3RWBfuxuJxXkZD1VPx4awB6UczT6R7n7x7Biq 8vSNvhgy2ysnPjWOoU3D0TtpWtZDs596feJQ7oAw8TiW9dn6ww2S6uwpKEEMlmakcgt0ec 5PRVQ1C2XHNKFPdy5YZ9vU1/tp+IVnI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Gv65T8he; spf=pass (imf06.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747749712; a=rsa-sha256; cv=none; b=rxDkYwse//PPMIO2EfNdkzGFa4YiKJn5e1uvqtI3fc9ZXPXo8/dsCdri4AaSjfV2/MEpFE hCP4jGAlLyB/AuqYwuVO6pVK5S7YC0/l6KnVq8xig9Iza3mKAiWxMrvaMFOBoXCfSlqwmT sH4FkSpf+VufrsYbj5A8zVqbhbbRpf0= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-601ad859ec0so5593618a12.0 for ; Tue, 20 May 2025 07:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747749711; x=1748354511; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PV1FL/a31fFF87tKpEa3eS5r97RWRD8TAOaHpu3NmaI=; b=Gv65T8heKsdEEAdkfV74d+ZCCt/2xCxSIsXe8GWTN/l5DqSymTdhGoDc6WfPhtpue4 /NcRynp/kzmEU6Q/UeNMgoBz3f85sXEOcsI6j7r3177FLRF63XO4NWnWOa59HFiqz/9p iVOgvIE3sMO9JBP3gtiHJNgkkJ79kjlvYkBRfWHqAxA7975M7eDwPS+PGP1WsFtbOx87 DsqQBqU/u5drBI7LyNzxLndh9ze4YAOjiDRFEnH8DPOucTb98XX+AxMA1pVjuXt6ypDk PykHuTLQHEEeBXUwE858TIE6r3c2L9t+mrtf5Tgu+bhGcnMLtZkGvEdep+D1oJr+r7Qd AJgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747749711; x=1748354511; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PV1FL/a31fFF87tKpEa3eS5r97RWRD8TAOaHpu3NmaI=; b=MePtj3hHL4PQiMb4ea264lMyssoR7advZl9jLTiatUEXdKG6rK/ZvZkhMGIHImurDf enRHgqcvdJIu5DIedMnhKeP9Jcgxh/C0MYp/R7dkS5A8xUjkxWMCRVB6QRz88we+QWoh LNt0nOhTL0ZdM+EK2gQhaNWhVo2SSgIbqX70+X0RWxWpKu8qL1/ejotp0H/y91qopc8W kXSitcP2M0BKThP2FRZ1Gyg45/OwS/6FcCs3OM05wPKnU9eUacv74iH2z80AAUHNTPBV PgcpJqMs00tW1anudER21r2kDpaLP5c4DOOTjbsm1knaejLxE4hRPL46mEPnSgQIaQA7 rD8Q== X-Forwarded-Encrypted: i=1; AJvYcCX1q9RcBlSc7SkomPTx2jrTMIiOUDWa4wCESnBy2aCP96jIiy6266fzPePU6mKXK4wj9tZGS3A3rg==@kvack.org X-Gm-Message-State: AOJu0Yy0OElA+hIgBZ0v5cRoEY48W6QqznsVkIeuaY95hSmhqOZJwQnv FcCI60MPVhICk4QSoo5cxncxO2HairNUaoUXtAod743Ma+GdJ7jN9Kfx X-Gm-Gg: ASbGncsj3qvPq883c0fn3Bngr2amzUVkKoZ1YeD59fB34LeWOwoYfDZfgmTOaDUs5oV nNKdfNo19gna+jaVCNWDfMieUhb5NHQNi5pc3xHKXWf+/O20zafc2D7bDjBRkMG68y46T4t5DGC FfJLGvTKAX9DX16UAhyAI54LV586at6ljW7L9fpzaN7OYDnUEJm/jZCvrRGNIjVuYn1ZXWTyOLZ +RbINPsfsao3F+HDPLYZmeYjkUlJMoFJGgeQ7iRvmwHZC3dDN7IkMnFDv80pPcMp/eLYp0pU4BT tvuD4WNtkDXEOL6reS3lEKf+9HO1GMxs99KXZs1ws6Xf4RnKyj8mMPESh3AqtI7B1eoA0yk4Txd H0yEyIhCCR9EYqvNQfTVVeKdu X-Google-Smtp-Source: AGHT+IHYDfOBB6XOAPFWgeSvqBqbLUR4EmvrA6HlSBGcoEyDnSyMz9RMu73gKqe3sYbMbufPdTMBXQ== X-Received: by 2002:a17:907:3e82:b0:ad4:f5ee:3c0 with SMTP id a640c23a62f3a-ad52d49b412mr1830301766b.16.1747749710121; Tue, 20 May 2025 07:01:50 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:1c0a:f3ac:4087:51c8? ([2620:10d:c092:500::7:66a9]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad52d06bc66sm731573466b.46.2025.05.20.07.01.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 May 2025 07:01:49 -0700 (PDT) Message-ID: <89553e3b-48a2-4867-a082-5a530620c427@gmail.com> Date: Tue, 20 May 2025 15:01:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: slub: allocate slab object extensions non-contiguously To: Andrew Morton , surenb@google.com Cc: hannes@cmpxchg.org, shakeel.butt@linux.dev, vlad.wing@gmail.com, linux-mm@kvack.org, kent.overstreet@linux.dev, linux-kernel@vger.kernel.org, kernel-team@meta.com References: <20250520122547.1317050-1-usamaarif642@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: <20250520122547.1317050-1-usamaarif642@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Stat-Signature: anbb3yhkkjr741yn5f6rfuau8dgiue67 X-Rspamd-Queue-Id: 7EF9418001C X-Rspam-User: X-HE-Tag: 1747749712-664367 X-HE-Meta: U2FsdGVkX18OMqECFgfHocy9gt9y6z9NLB4Vu7wYKkX7MiTvCPKmO7uUMCbDt3rcvi044cmiyht9b29x/q16G3CqqPMgo9QQNpkLBfLMJ1OjZ1FXilSFJh1Si5onH0Rhow+72yN2w6Rl1uim5jyooMmyhmLixLENpoaHf8BqrDylIHJOGJjbjqXBhTOgnBiJoZY099KizzGWTZ4IB7GOG5SFdUu/4K33i0bksRpIleh7w+nuYo30BNk2r6TTZox4/coRNGWUqVd2BekmzaZyOxJOpopqHDJsZ5OsVf7WAQHU9nOj7QoCWR9sDoekqahPpgJs7pVFRluMjUXuNsNAAb4oJpNffpNxpiOnVgXqZrKUR+Uh/YZ0FKGnmWLEXt1PWiRkwA72OP7ASxhTXmApcr+Jjs/+sjLfQDoTOn8BE6kFrtok/1df+sMMy1lv/6F4ILRjyF75MSLYSa8EYYZ7XNMhoipbEz0sw3m3VzhObunjfCdKr2yy8KPoZ0IoSnFxJH1Kccg62+6y3te3sZ6nVYk323UXKaUFtXeg4ayuKCmTZSHuRgCkoLhfbiCllKJmG1q4EfRVnr0ClbAbwVcPGdsbnTCva54WFaJE9yX/eJKtWfPGjKDKWTQQh9g8CsZetKyXU2ktyx7NmEtksA9NVjkWpmXwlfWt9Dw2ZzK3zc2gcpKinh0I/7aHWKctNOkj7n+dQdTam0FhJSrb3Uim7wZbtSLec1eKTsOzqCLQREphXdF2aCdSksIo71nxJCy/AP4EFY4RIoYPZJIU6YHCt66hQu+z0C1M7d8uuZPo/2/iEwiCf8MCkG4fBs7KVtgfYhk2w3Ys39qD+lCy3lWNENOq+UJsgt1p5txPwHnG23uvNAqetQg/Cku5/f1+H6PUTWj6yTyFvZrvLCkYiGChtDShYt39B+zEqQJAPyRGsQ8mHHX6gyLtZrTivAPhJUy755kxNFrKNxOC9yHJHDU +gJw68Vf qKtQPuZvGCqvD7xcuCRAYvrvG01ygvd/wimwU23JxdQK/MGF4Yr1zKLC6F7ObwxaijhseEjU8DKKGdsQPPxjdCX/V8ywcP3Oz+NnKgMGMSuqRdo2wGitLx43GJcAywkRsyJv/mAC5ZYz14KXOBLpqJ7OlE+8o9fTYWaq7v6mE6ejjXzPBBtMeDM5ze3FFHwX5jY2N4nmiSIi/bQBwhbQu2dFYxlRil7b5gV1R+/QF9qs023Yfu0vpbc7cf0+vhR3271cZg3bQ7vTN4LeHewCzlEPjrbxuV1EMy4q4x+GBIreHaXDu8/jtoVVaxTOahq9gZSsInmpEdIBwWZEdNcgsSkKhO5H7WzbIgicB0dKz2rKntdaP894IoiJ0M5/lVv8XrC4vaaKArNXe962+6JR2+0eIrMkVxC1dyTUnSNzIiTyceheyEclh+bHMmQ6owjjDxyqWwGUKbdNmvcrYdCBkSQwuFzgXDZrdy8zYda2RIfW4d1Xd5vfF8RtWAlDUqxHw4II+rym1953NtQceiIY2HvIA1ndSSEGfaKlJrUBSWfLm7eA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20/05/2025 13:25, Usama Arif wrote: > When memory allocation profiling is running on memory bound services, > allocations greater than order 0 for slab object extensions can fail, > for e.g. zs_handle zswap slab which will be 512 objsperslab x 16 bytes > per slabobj_ext (order 1 allocation). Use kvcalloc to improve chances > of the allocation being successful. > > Signed-off-by: Usama Arif > Reported-by: Vlad Poenaru > Closes: https://lore.kernel.org/all/17fab2d6-5a74-4573-bcc3-b75951508f0a@gmail.com/ > --- > mm/slub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index dc9e729e1d26..bf43c403ead2 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1989,7 +1989,7 @@ int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, > gfp &= ~OBJCGS_CLEAR_MASK; > /* Prevent recursive extension vector allocation */ > gfp |= __GFP_NO_OBJ_EXT; > - vec = kcalloc_node(objects, sizeof(struct slabobj_ext), gfp, > + vec = kvcalloc_node(objects, sizeof(struct slabobj_ext), gfp, > slab_nid(slab)); > if (!vec) { > /* Mark vectors which failed to allocate */ I forgot the freeing part, This will need the below fixlet as well. I will add it to the next revision if there is another one, otherwise it can be folded into this one. Thanks! commit fa48eab7faddfdb94faa80a1575ac1840919071e (HEAD -> prctl_huge_v3) Author: Usama Arif Date: Tue May 20 14:58:10 2025 +0100 mm: slub: change slab_obj_exts freeing to kvfree This is to match the kvmalloc. Signed-off-by: Usama Arif diff --git a/mm/slub.c b/mm/slub.c index 97cb3d9e8d00..2245e8d8fffb 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2045,7 +2045,7 @@ static noinline void free_slab_obj_exts(struct slab *slab) * the extension for obj_exts is expected to be NULL. */ mark_objexts_empty(obj_exts); - kfree(obj_exts); + kvfree(obj_exts); slab->obj_exts = 0; }