From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAC37E7717D for ; Mon, 9 Dec 2024 14:57:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 788C78D0075; Mon, 9 Dec 2024 09:57:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 738498D0058; Mon, 9 Dec 2024 09:57:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D9478D0075; Mon, 9 Dec 2024 09:57:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3A1D18D0058 for ; Mon, 9 Dec 2024 09:57:11 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 12137414F8 for ; Mon, 9 Dec 2024 14:57:04 +0000 (UTC) X-FDA: 82875722328.27.B1A42F1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 8293A18000F for ; Mon, 9 Dec 2024 14:56:40 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dxAjj0Qi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733756211; a=rsa-sha256; cv=none; b=F9c1ZLKv2shP9zC/9tsJf7wftlFIDNxM+kDRgfKqifx+VowuBnUq1sfGsJlA3IX7Z5T+bB N2per8VGc7nG0sdVcjYLZEKRq7rVs4dBKT5v0EOXSkkVQ1K9/5By4zBv++AhcJ3Mx+Kqxq VSy9ZGCWcWFpX+wNx4Uuu2Xq+8+dX0g= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dxAjj0Qi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733756211; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=roWTLSJ7MEavdcgWqDfPRHJNRx/XLwVh8vycUNykgJ8=; b=2kQCASW3ld+UeCIOER+eGQsGROM/4vEbttEePrEbYgQ1Zy/bDDvf8njM/8Nln6IU2iQ1ZK HfqeKcMZyauOt+1YAy9xJMcum9hr2lJAB9SqmLMrbXY4Okd5iJLXDA98MVc6fVRZQ9wuh6 R/5hDoLrayGeyl3RXdJpSYlb1ErbatI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733756221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=roWTLSJ7MEavdcgWqDfPRHJNRx/XLwVh8vycUNykgJ8=; b=dxAjj0Qi48ZfCIL6mlXOfp0FDJz1uaY37dq1OWHY+Y8ch/DLg/K/SZ6Vuvk1A3aQ9AxNHr t8cULhDurAD3d8Lj6dVaaOLzlJ4LTnE2gSmErM4CPBfELO41IzeWxzVtqD7nvlV9IZIuMY sOOOb2gcvwibtWDeMW7/JFqI8OVQsx4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-9mtJEzXwMTeZGxrzXsAKBQ-1; Mon, 09 Dec 2024 09:57:00 -0500 X-MC-Unique: 9mtJEzXwMTeZGxrzXsAKBQ-1 X-Mimecast-MFC-AGG-ID: 9mtJEzXwMTeZGxrzXsAKBQ Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3862b364578so1536410f8f.1 for ; Mon, 09 Dec 2024 06:56:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733756219; x=1734361019; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=roWTLSJ7MEavdcgWqDfPRHJNRx/XLwVh8vycUNykgJ8=; b=qWMRpSj/IdMeoaKHNXfAQBzp+MPs6EExt6TzvuMDHIzEJYvofOK9rmQatis21U94zO Pe85UymQ2mLooeVvMWB/dZMY+pt1j+BZ6VlJCtAYB7vbx/7CDXtbhKpBv36mK5GEsIFQ L+1aOtDQruceVJAjdqHkI0+9nLfncVtM2bC1fQJUhFtWPG9TQST8crZSSdeFurXi34tr Mwp3MxwySKOh9U2fX2vAYEtaQSiWkgNs96Amo/KCwlOsIJhHYwkYUw0mUcZy5QjCElrq Smxjfq2yLy/64KSjCJC1qE8/EYzPo7VudXCpBUOn2zy1qRPT9OdJN3INKK3ow4P6RRCe TSBQ== X-Forwarded-Encrypted: i=1; AJvYcCU1zX6oE1uFDtHU0ZfE+zauqbdv7beBNJ5YckHFe3WrlcS9sKYXGIky57ojJLBm5OXK6mhswYF+0Q==@kvack.org X-Gm-Message-State: AOJu0YzEwAB1LzDwmGcDi36q7X54eQGqHknUbikfaIMkZyTVY/oFW+VC 3E/xdaXC1PTQfWYQ06zBGORVRVreVQnQFgs41rMGGp5rq9wzGuNquih45Q+3vLHnPhYj3WOgWEu YPgwMXbqDyPJZJoUm3Pq5Ck6RmiB5FSWT4n6t1VIPKxN6MoFO X-Gm-Gg: ASbGncsLfengrPU0ZY/s+Rk7pvg4CAP/BE+478VUvdKmFFG2uX0JOMqRSXYJiDlI95q wbWYYZ4tqsS81MnSCrQ1HmptE4xSdcmzFN2A3g1jLHOHubPOVFJdkWJygnNXt6SeIgFivYaYkeM W4rKayAnY4ZHgeKHUIQh4iXnjb4aun7DXlcercd3pKL/nJwChIwMNy7fhB31kkFCCCSxTjIUyw8 xtwdWwaZqxlLJq0cc8qfpNvKPM/UbipjoHbq/vMnATFLKg4iZRSNS+R/1zmOAvrBN0O87YiD4dw jlf6FGg+ X-Received: by 2002:a05:6000:188c:b0:382:4b69:9ca4 with SMTP id ffacd0b85a97d-3862a92c99amr9917414f8f.26.1733756218723; Mon, 09 Dec 2024 06:56:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+QHN3yRBmtV+la/fTQw30I4VAQMjj194cqnPOAyEI2uhOyrZTFJHQbXqnjcn6qts/TXZGXQ== X-Received: by 2002:a05:6000:188c:b0:382:4b69:9ca4 with SMTP id ffacd0b85a97d-3862a92c99amr9917398f8f.26.1733756218364; Mon, 09 Dec 2024 06:56:58 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3862f0e6ea2sm9701148f8f.79.2024.12.09.06.56.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Dec 2024 06:56:57 -0800 (PST) Message-ID: <895361fe-5fe0-47c1-81a9-e930fde482a2@redhat.com> Date: Mon, 9 Dec 2024 15:56:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] MAINTAINERS: group all VMA-related files into the VMA section To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241206191600.45119-1-lorenzo.stoakes@oracle.com> <23d3d7f6-d6d1-430e-8ea0-ccae76b253fd@redhat.com> <9fb4761d-db28-4271-afb7-9e3cafa89438@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9fb4761d-db28-4271-afb7-9e3cafa89438@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: s0yBBIRSX-GQ8WRTXsgtgblBNu4yUb3CblN8Mdoqduo_1733756219 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8293A18000F X-Stat-Signature: 8n4po9qewduksqkzm47fqxh6z9eewgjc X-HE-Tag: 1733756200-939189 X-HE-Meta: U2FsdGVkX1/DpXcQiJL9XLeCY5ou/hxLErKb03g9PBv0FGdDCLNKskemcvRj0bYcudscs0lthiq4iptfuP+1CyTgDwOL328U70+eZSWzy7/LTWQjuWzcnED+6I35yFX//5s/bGny9Iic9tOTHbhOZAsMdmagvtVrr/98Me1pshS2DpPZeNDQzM4kxBzrVEgnizQJeIx3FL11SdyFWtW9bx4kIc6UDPc5dHUOlglEs/Labmx+IFC0E8toJkaiJp416ds0417sYhsA5tsviEqQEwPER7MDWscOuFxkWte8+/6g8JNPjQz3sWbyadVkqGtB/Dvsb8bmJxIUZ0mhTKTEkr6IOK3Qx5LcBqTffuEs6ztbmuIr/KA8u4OW+uvTJv+QkiZUSXKsZWZW2gYf/lg/iW98eh+raTfQhyczB/3TgyEOJbJcmu811WpV24VcbDd5jieG2SpcKqvYoJd3NQOO/54iEcXitR83aopEt2HYs8f/7zsXhX2unDY0crGHVdDAhX4dFkdVboyKibmO9WmfzKrWrlz5O5VRLM0NttnqHEOzVKuiLgAWhr67E+mYVE/h2qP1Pmb5UJQc4KKrlSE289EDjGHPbyHqm4QwJwbWQVdK0MnPu4Ip+hbAHPtDm9EW6yA5gQcvusiR+Lp0gRA6H4G2pGwBUP8mtZ532EPIPCbTIDFbKjd6JYA+ZyUoysCN5U0o5EtkhCJ4VIGlQWU03NJfpxvabDsoxEeWBipDyGVKFtPkrP2TORKGOzUF7JguRgoeZIjVNRUUFJ7ou0RxhvUlJjcjASyhp8f3Sr4Vtw/xMlsJB6GwcCy7e+PoePOmeE8m/UaM0qGsp89i6yVT+XhPffiknrFFZ/5tiaGLmVwrTSfdkwKPy/RjnicsPpDufMyWVqw/UHclWlubJgEzyM1RW35CijgX4eRATsVDc1B1PtUlYURBnOhGnAtXFc6KPCWVhZu62T3SX7l1NiD kD/Gh/1h KM0TzBt8dtKYIm3m6tYfPBEhD0Yh+akDQlpEOdzdIlZvcMWZOwQ+ZC0IfDtA7wdC/OZ5wD1KObNugTf2WbthTp1cpOjKLOvB7fLLSPmeAfciNamGAt7Y/7luX3jQq6t9wICWtT7qmBPQkHWrqzxqMrspY82L6U4Bp5n75JTd8PdGo7JXmUcrXVzvoWN/zEO9ugMcUmslXf/zp6jZf1LJ0Kop6995Gqgr9WUw3Vy9EMt1bakl/EC6lenyrAcJD9ng7dDp9D+d9Zb/E4zN+IQwqPwlh7st9he/VdBv2h1ub341Om0AUUXuwuEm1yuhzCZm5TY/3in28/FUcdK7xhUolJ+dqe6zphXUZdJzJcy/agraD+WuUIlw2loBHOdW5DpkG+9C2y46w5Rw5PtjTkC9YXJFpJIpKDuxwbSWeMvOVUdc5mrGwaYMPk7/ODVpQR009ORSRGP2+gdEbyUxmNhOvE4nCo+rsa4JbwsAJSMpbRUiJaHxGhBQK7WKVFwkixBRUQYemEDVtK8rDW9p41AFj0L8YC+LyFTM19Ry8z1Mfzo/tUZxMqh3WLdwX7xXebEpdPD8viHPH+xpGRtPhs8YHSrIibIF1ebsuI9ThvNUQ+JbkYBxYhrr4WVN659ZyO2T9xva+kygCmcxq6uXhvoJVxgkosM3953F7DLBmgjMNjAKTfKjxvODFPXc0o5rQ7q1hOftmRMYn6j0Q0+pmHngzhB4olIBPfgdz1cIzha9Gwbcba9vqp6UIZ8lUD7UTPlaKpQlJsZnk6DIteAAcs+ShhIcHcnT2JyXAAa8o X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.12.24 15:28, Lorenzo Stoakes wrote: > On Mon, Dec 09, 2024 at 03:09:26PM +0100, David Hildenbrand wrote: >> On 09.12.24 11:06, Lorenzo Stoakes wrote: >>> On Mon, Dec 09, 2024 at 10:16:21AM +0100, David Hildenbrand wrote: >>>> On 06.12.24 20:16, Lorenzo Stoakes wrote: >>>>> There are a number of means of interacting with VMA operations within mm, >>>>> and we have on occasion not been made aware of impactful changes due to >>>>> these sitting in different files, most recently in [0]. >>>>> >>>>> Correct this by bringing all VMA operations under the same section in >>>>> MAINTAINERS. Additionally take the opportunity to combine MEMORY MAPPING >>>>> with VMA as there needn't be two entries as they amount to the same thing. >>>>> >>>>> [0]:https://lore.kernel.org/linux-mm/CAG48ez0siYGB8GP5+Szgj2ovBZAkL6Zi4n6GUAjzzjFV9LTkRQ@mail.gmail.com/ >>>>> >>>>> Signed-off-by: Lorenzo Stoakes >>>>> --- >>>>> MAINTAINERS | 19 +++++++------------ >>>>> 1 file changed, 7 insertions(+), 12 deletions(-) >>>>> >>>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>>> index 1e930c7a58b1..95db20c26f5f 100644 >>>>> --- a/MAINTAINERS >>>>> +++ b/MAINTAINERS >>>>> @@ -15060,18 +15060,6 @@ F: tools/mm/ >>>>> F: tools/testing/selftests/mm/ >>>>> N: include/linux/page[-_]* >>>>> >>>>> -MEMORY MAPPING >>>>> -M: Andrew Morton >>>>> -M: Liam R. Howlett >>>>> -M: Lorenzo Stoakes >>>>> -R: Vlastimil Babka >>>>> -R: Jann Horn >>>>> -L: linux-mm@kvack.org >>>>> -S: Maintained >>>>> -W: http://www.linux-mm.org >>>>> -T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm >>>>> -F: mm/mmap.c >>>>> - >>>>> MEMORY TECHNOLOGY DEVICES (MTD) >>>>> M: Miquel Raynal >>>>> M: Richard Weinberger >>>>> @@ -25028,6 +25016,13 @@ L: linux-mm@kvack.org >>>>> S: Maintained >>>>> W: https://www.linux-mm.org >>>>> T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm >>>>> +F: mm/madvise.c >>>>> +F: mm/mlock.c >>>>> +F: mm/mmap.c >>>>> +F: mm/mprotect.c >>>>> +F: mm/mremap.c >>>>> +F: mm/mseal.c >>>>> +F: mm/msync.c >>>> >>>> Not sure about mprotect.c, mlock.c and madvise.c, though. I'd claim that the >>>> real "magic" they perform is in page table handling and not primarily VMA >>>> handling (yes, both do VMA changes, but they are the "easy" part ;) ). >>> >>> And large parts of the VMA logic interface with page tables, see - the entire >>> 6.12 cycle - around recent changes in mmap() MAP_FIXED - which... the VMA >>> maintainers fixed :) >>> >>> And then there were the issues around VMA and mm locking relating to page >>> table work which... oh right yeah we had to fix again... :>) >>> >>> I mean you can make this argument about probably all of these files (mremap >>> has -tons- of page table-specific stuff), and then we get back to not being >>> notified about key changes that interface with memory mapping/VMA which we >>> end up having to deal with anyway. >>> >>> A lot of the reason we have 'magic' in these files anyway is because we >>> don't have a decent generic page table handler. Not sure I'd actually use >>> the word 'magic' for that though. >>> >>> I am planning to make significant changes to mprotect/mlock soon, which >>> have some terribly duplicated horrible handling logic, and both are key >>> considerations in VMA logic as a whole. >>> >>> Anyway, as far as I'm concerned page table manipulation after the point of >>> faulting is completely within the purvue of VMA manipulation and a side >>> product of it. >>> >>> However, can concede mm/madvise.c if you feel strongly about that as that's >>> a bit blurry, but of course contains a whole bunch of VMA and... page table >>> manipulation :) I mean it still to me seems very pertinent. >>> >> >> And then we have mprotect.c being heavily used by uffd-wp and NUMA hinting, >> which don't perform any VMA modification. >> >> That's why I don't think the change proposed here is really the right step. >> >>>>>> They have much more in common with memory.c, which I wouldn't want to >> see in >>>> here either. Hm. >>> >>> No, memory.c is really dedicated to fault handling. This is really >>> different from manipulating page tables in specific cases in my opinion. >> >> And fork and such stuff. And if you look into huge_memory.c, we actually >> moved all of the THP logic for mprotect()/madvise()/... in there. >> >> Not sure if something similar should have been done for memory.c, or if the >> THP stuff should actually also have gone into the respective files. >> >> To me it sounds wrong to have VMA maintainers maintain a lot of the code in >> these files code because these files somehow modify VMAs, sorry. > > This isn't what I said, I said that de facto we (that is the MEMORY MAPPING > maintainers as well as VMA) were dealing with a great many issues around > page tables and page table manipulation which are rather inseparable from > one another. > > I even went to the lengths of writing a detailed set of documentation on > locking behaviour in and around page table manipulation and solved > security-sensitive issues in relation to page table teardown over the 6.12 > rc cycle. > > To me, the idea that mprotect() and mlock(), operations that are explicitly > about manipulating VMAs (_and of course consqeuent page table > manipulation_), are somehow separate is really bizarre to me, but I respect > your opinion even if I disagree. > > But unfortunately your arguments apply equally as well to mremap.c (more > than half of which is dedicated to page table manipulation), so I will have > to drop the whole patch then. > > If issues arise there in future, I guess others will have to deal with them > if we don't notice them (luckily Jann did and pinged this time, hopefully > will in future). Again, the main point I have is that basic VMA handling (the now very nice vma.c! ) that wouldn't even require page table modifications (the very nice testing framework you added) is different to users of that functionality. And I agree that many VMA modification users imply page table modifications and more. > >> >> -- >> Cheers, >> >> David / dhildenb >> > > To be clear, I made this change in the interests of the community and > contributing. It seems to me that within mm has far too little sharing of > the maintainership burden and I only wanted to help with that and make > explicit what I work on day-to-day. And I appreciate that. But putting everything that touches VMAs under VMA is wrong to me. > > I am glad you at least don't object to my doing so with respect to at least > some parts of the VMA logic. I really enjoy how well you separated the core VMA logic from everything else. -- Cheers, David / dhildenb