From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFF04C19F2D for ; Thu, 11 Aug 2022 07:28:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 642C98E0002; Thu, 11 Aug 2022 03:28:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F23D8E0001; Thu, 11 Aug 2022 03:28:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 445798E0002; Thu, 11 Aug 2022 03:28:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 343468E0001 for ; Thu, 11 Aug 2022 03:28:21 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0B9B5806FF for ; Thu, 11 Aug 2022 07:28:21 +0000 (UTC) X-FDA: 79786483602.07.2D2ED21 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf20.hostedemail.com (Postfix) with ESMTP id 57FDE1C0068 for ; Thu, 11 Aug 2022 07:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660202900; x=1691738900; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=he2MDm6hTH/NTckTW+ataZ2kO4cH6hsCfzCFu48FURw=; b=CRVi95FhJD7D7Q1CsII+o1obvUyy99y6PDXVVKxQBDmrynNcCrPQxzLI exVxtqUwIE7hznw4aKzDtHnR04+u62YW51DKTiDODjEp1AOiQm12hmWlf rhiasxzbqeKYmnGZ++OCG7t2uhNnHbt+GJ3kqVkqOBBSxixd6J+IlZsXT WDXKT+eeS5+UUQ+ALDHHUYBBF3/x3MEPgNfGqE5csEd9CvdFioXFag9eQ o3hZ+u8wjarHL4O3XxA0flO+xR9hOl+puhBPYkwgp0Cuw2fWdBuNYNaMu 6yi7z/Tz1JDd0TlR+MsDJl0hmW2fTpHshRvbKfhRShQDifrtg5X2NITda Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10435"; a="292539354" X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="292539354" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2022 00:28:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="665255865" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 11 Aug 2022 00:28:18 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 11 Aug 2022 00:28:17 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 11 Aug 2022 00:28:17 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 11 Aug 2022 00:28:17 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Thu, 11 Aug 2022 00:28:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NycqA8IAFxc3TZyw8/EQQZop595sBXq8JJfz0C5hOtXX7NSOx4valTlojhUl2vsfLT/Fc3w71V1nyIIIfV3lZxlV7z+YCTHR68jTTv3HrBqF0hPpqBny+kIdY1ar0WMNusRcvJhuXB93kejEtmdUoPWIUE8e+5UVZOFy9UCgDrin4lIJ0XGzIRNq3VYYrGlPzJE8BRoSwFcpMQ3xvITHL5+uGuC1FRmm0e87VcY6QXpk2vtSlU1fqz5nRa1iiZKpxbt96QDAUlp21Gc8PshsWjvTxV2o9+opxNu4ZbA7rU2CCEIIzrJyEJuXcin4kbqzeOezkW1+KAkL3XXbV+Sf1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IziJlHEHIfkRCohMXcQO9On+5K7LD+FpAx14uhnhxf8=; b=aYLoQzDzl3NoDVVCdLb8zfMi50KD1gA+fy/tGzQ4beSR4fuokijgzQ2FhQWNjTD3JVCPD1CfZuYb/izdEvSqG2stauvOThsf3dVzwV6vVuwtrYxStRevQ74gnTB7fFU8YKK5LHhxTp6wzuJDgFQjS0FYxvkaYx/usuuV8LEWGXCD9etmIzHd+qXTRM5vXpDfovd1NDgm6JKdnN22mk8HKIesyFJSdoElA6UXt0tC0jOh6CBn97HQlxW5j5AFE2zW78sR/E5LXQmme/zVUqEAtZNhrMoG0P2tkR1Rxcbv3DggDfjSVs9uZ9+44L8czvVV75PV4vmm1CQ4Sx7a8WLp1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by SJ0PR11MB5616.namprd11.prod.outlook.com (2603:10b6:a03:3aa::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Thu, 11 Aug 2022 07:28:10 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::fcda:4c77:5786:209c]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::fcda:4c77:5786:209c%4]) with mapi id 15.20.5525.011; Thu, 11 Aug 2022 07:28:10 +0000 Message-ID: <89527e99-7c58-beb6-7b48-2bb96322b5b5@intel.com> Date: Thu, 11 Aug 2022 15:27:53 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] mm: release private data before split THP Content-Language: en-US To: Miaohe Lin CC: , , , , HORIGUCHI NAOYA , "Matthew Wilcox" , Yang Shi References: <20220810064907.582899-1-fengwei.yin@intel.com> From: Yin Fengwei In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR02CA0044.apcprd02.prod.outlook.com (2603:1096:3:18::32) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 92a3eb14-d0bb-4294-6aa3-08da7b6b0afd X-MS-TrafficTypeDiagnostic: SJ0PR11MB5616:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QLw+B348oUSOoWyehrBOXVKY739rpgAH3g9TJqBBar10ZoDb/Jvw6uz2cXVD2G5eyobpDOk5tH8C4gdgLG5oQBNRsnOv0/H+ZrH+Z/3kfK1E4GRbFzKGOMs7KHCHO95PJIgwpJ7ZFDXaNkV7zkR4fGYLuSUgW+3h8q4hgdtOzENq/xYVQ1XGymRImq046rn+OxF46NPVaxUakn6lvH+bKPABesqnuq+/Z3CkcjBP4a3HSgN2nBHNAq1Qg9QacMdzCoRtQrD2tsacMTkazGyBfWUws1XADDzCgVkYFbGsjCgqVA3KZ27aaRrVIv2X53IBdSR1tb/8cXFzw6TxELb34beW/RnjxC/ORkrlUDQLOITrEH97xv6SEdPhzLK9iHhnOiHjaD9CY5UIHOLZ7/3GdsoWpJElM+TnhY6ZTPLx/jvdEkm19X8vLaf4FFh/IIRNZK3F/I797P71q+PuosCpsyfxH2adW13ScqLPWxVOepzgJ9wKg+5qhDL9oQp+oANWLZASoZSPv62ilVjx+dysJXsEwySdjHZ9S3RJKyK6EEy+rsWNrKn4NSILO+0ZyYqNwa+onyaUzhXA+gLjiUFRmhdh09D2UqBJ5b/6xuQas9XGFf+9kxjU0RnmxEC6YyLMw6qnNfXysuf1gUCdVPdTK5Qlxoq0VZSuh9APyl2H5mPjCOR2gLEwqOCLVAxV1cR1TIvc8inX4wtBJHP9rmYbEP/TpAt9RAbF+XeRbXIPa4pVKJrgWFdW8BgQccQo49nso/vGU3hrtVg0bdy/dKWU7ImTC8KZTIs7NBIxVkQvqqxs33ATgcsWaMy1z6dTmWHjLdVEgTrBETpcsvlhK3LXYg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(346002)(366004)(136003)(39860400002)(478600001)(6486002)(31686004)(26005)(82960400001)(2906002)(31696002)(66946007)(4326008)(66556008)(41300700001)(8936002)(5660300002)(86362001)(8676002)(66476007)(316002)(38100700002)(6506007)(2616005)(6666004)(186003)(6916009)(53546011)(83380400001)(6512007)(36756003)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dS9zM2JsVEI5Wmw4YVdSajV3K1ZieXFXRjdOaWNwekc4VG1iWmR4UGU0UEJi?= =?utf-8?B?czF6bjFFWUVyVk9RM01nelZjVW1ualE0d0hGcGppbXhOd0FNWFozUjhYbk9J?= =?utf-8?B?amdrZTkvZEZXTTh4TVZEd1lobFBoWE92L2JRNElHR1NMcmovazZIS0dwQ1RV?= =?utf-8?B?K0ord2V3SHU2ZFFPcS94RXdYTmEyKzhOUDd1NHBOc1g2T0wrU0RHVHZDeWRR?= =?utf-8?B?RHYwcHl3Y09uUUVyUTNiNDlFZWlEL1ljOTY4RVpNWmtHNXp4RFFmSllaaDdu?= =?utf-8?B?YTVNN2lSbGUwR3llSlJsNHIvbTRnSUgvLzh6ZTlMaXZ2MDlXVTRwKzA0SGha?= =?utf-8?B?Z0xpMVROR1RkZ0Nzd2VxRi9vaXpKWmhnSW4rQXBZT3FCb1lmWXFmVHE4NFV0?= =?utf-8?B?d0JRQmJqZTN2ZEZzSGY0WVN0YlJGUW1pS0FkMUdHdjFnbEl5WEZHV2tJamVQ?= =?utf-8?B?dEJ1ZlRGaDluV3lkaGZ3bW9kbWtoanVZelF6QWdEREZudzZuS3Y5VVgrZXFk?= =?utf-8?B?b0JnYWQ5dzEzd29lYk1VRWE3VHpCb2d2aHhQQ0VOQm4rNkJqbTQzYzNwOVJW?= =?utf-8?B?MGJ6dnF6Rk45TktpSzVPd1ZaZ0V6L0FiRThpWXR6b2RnSDY0N1R6NXpzMExB?= =?utf-8?B?S1h4SDVBVHBuRVhhdThiazYvbjJRK05JQ1o5REh1bHdrakNGQVZDU0doUVhG?= =?utf-8?B?cUhhdnlPYUd2d2NlcUg0NnhaNm13cnhrYklZbHNnSDFrM1lCS3ZpcmFFZU1H?= =?utf-8?B?N01LcHhabU8yc3h4RWxSUWJTa1BjRW5rcFlZZlhvUzNlQVIvTFNEQUNwc1Ji?= =?utf-8?B?TkFaWHdXZlpzR3F0NzczcktnMTh5TW9VNnlpaEZqaHZRVWhGRStFWSs5N0xQ?= =?utf-8?B?aTZtRjlsS1NIcFhkMlZuZ01xeGNKZ1VpNHU5ZUNjYXhNcVgydGs3aUUrRWlv?= =?utf-8?B?WGhjVGx4RG00L3dmMHNLSzNzL1lBby9laGlydEViVWFHcGZTQ1B5eDJXeXpB?= =?utf-8?B?NDl1d1BQdTJxN0p0dXJvSGZBMDJJRDE4UkI5NVFBc0FYY2ZzRG9TZDZxV1d3?= =?utf-8?B?RjJOTVNjNVcwZUVLTERTdzZRR0syMUxaNVk0VUtzMlBPVUQyMGdzTTF4SDQr?= =?utf-8?B?RjZzTjRvTXRoUWVyVGoySHBRY0MvYWRjUnhmbUhSWnJsaWQzSVVmQ0tMenlv?= =?utf-8?B?emttOG1zSjdCU2V4S3VSc3BFQ0pIS0Z3WXU4NUc5aVArUmtJSTFDQ3daclg2?= =?utf-8?B?aDZVUHBZVGdqbGtXMTJGRUFHczFBQWxSaGVxVkx2S1hhbU1VNjlZYjAvWmts?= =?utf-8?B?YnlPSTZTWERBY09JamYzOFNKZHJHazhISWRibTROY1o0cUQ0bVh0VG5od05D?= =?utf-8?B?dFgwbzdkcVNLc0o2OVRQRXFLOWhmSXdPRnN3cExOMllET0ZBN0w1STlaK3Vl?= =?utf-8?B?UCtpL3czSnQzUjlraTM3ZVJ4VUQ2RjB2cDFoOHFEd1ZsT1FxVEFVbTdPQ200?= =?utf-8?B?NEk3L2lsK1d5QTc1NHhqaHlQMDRnTmQ1K1F5RzR2TytFVkVPUTZWQWdrM3RO?= =?utf-8?B?T1lnekJlcTkwUGRtK3I4NUY4UjlKaG5DcXEvY092WU9wRU1OaXBpcHdTMVhE?= =?utf-8?B?N1BRSGErdXNpNnI5UncvaVlQQXlJR29sY1BacWpGb2VNdmJwS2FiVGNjdzlV?= =?utf-8?B?dEMybnBaMnBmNUxiaUdxbUhJOVNPT2FRN1ovVGxhakRUTVdQLzE2bThxN0xt?= =?utf-8?B?aWUvanNtOE1VQjBBczJLdVJ1blNiY1Z5MXpGU2N0U2VuWllweGVmNTZVZ0cw?= =?utf-8?B?V29lOXVJbjg5NjNGMzkyaUloaVEybFVxQ0pycTcyY0hhN0Z1WEZyMW55RDhD?= =?utf-8?B?dEJFUkRoZ2RiZml2eDFPQncvYTFhYjY5OVhEWFREcWVKeFVkSkYxRUI3aTlE?= =?utf-8?B?YkMrTkRXQUxxbmlRL3g3bHV2SlZUaUd2Ri9nM1hWeG53T05hMktLRWtiMGFU?= =?utf-8?B?dThlNlJOOFVkcmdtNGI1bUNlalh5NjNBOUthL1kxTmpBYnVha2lCMG5pUk9V?= =?utf-8?B?UU5NTXcwRDR3VWtUU3llOUZUdlhScHlSbkg0b3FJNVpMNWlKK1pqYkJpWXRV?= =?utf-8?Q?8JSLWNxIMaYuMjUF8klFrMYno?= X-MS-Exchange-CrossTenant-Network-Message-Id: 92a3eb14-d0bb-4294-6aa3-08da7b6b0afd X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2022 07:28:10.5255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oFlBFyvb/8XdckgWPjwnkkq+IpBZq5ifzQ8UDAznm/czcm8XP5U+88uc7awBmvA679ihecwlysetr8BeC50HGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5616 X-OriginatorOrg: intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660202900; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IziJlHEHIfkRCohMXcQO9On+5K7LD+FpAx14uhnhxf8=; b=GH9KrcyhGm++Dh8QpLyGtUmsek5buKZGMuCnYLnVTBLmKPKWTQKAiZC+kVNquuSCBMTPah wmCgab35fQjsz4McLztH723vLdScU13a11LYH0WJeFxVFQJcvntUz9Jp7FJsBFlF+MhAG3 6dxQe+4x6uXGBAU98f1hyrQh77ikfik= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=CRVi95Fh; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf20.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1660202900; a=rsa-sha256; cv=fail; b=BJxeRCKNdQkqhlpZ8UvKv+y0cn1RCWsa6KXeNliby+PW5+0ECUm4FzpsPmoGmOq3fKP3XB APJCNGlvGh+X02jkI4G422+5bRZFqJtsyWgkKm540qxyUELHtV8zXKEmD4r3swAZ+jcjSG Sqbl/rLHMgTY10BZ8u9aD8GOEPplN8U= X-Stat-Signature: w15tq7ixz1t8jt4xdnxuog135yi9h4ah X-Rspamd-Queue-Id: 57FDE1C0068 Authentication-Results: imf20.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=CRVi95Fh; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf20.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1660202900-881295 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/11 09:54, Miaohe Lin wrote: > On 2022/8/10 14:49, Yin Fengwei wrote: >> If there is private data attached to THP, the refcount of >> THP will be increased and block the THP split. Release >> private data attached to THP before split it to increase >> the chance of splitting THP successfully. >> >> There was a memory failure issue hit during HW error >> injection testing with 5.18 kernel + xfs as rootfs. Test >> got killed and system reboot was required to re-run the >> test. >> >> The issue was tracked down to THP split failure caused the >> memory failure not being handled. The page dump showed: >> >> [ 1785.433075] page:0000000025f9530b refcount:18 mapcount:0 mapping:000000008162eea7 index:0xa10 pfn:0x2f0200 >> [ 1785.443954] head:0000000025f9530b order:4 compound_mapcount:0 compound_pincount:0 >> [ 1785.452408] memcg:ff4247f2d28e9000 >> [ 1785.456304] aops:xfs_address_space_operations ino:8555182 dentry name:"baseos-filenames.solvx" >> [ 1785.466612] flags: 0x1000000000012036(referenced|uptodate|lru|active|private|head|node=0|zone=2) >> [ 1785.476514] raw: 1000000000012036 ffb9460f8bc07c08 ffb9460f8bc08408 ff4247f22e6299f8 >> [ 1785.485268] raw: 0000000000000a10 ff4247f194ade900 00000012ffffffff ff4247f2d28e9000 >> >> It was like the error was injected to a large folio for xfs >> with private data attached. >> >> With private data released before split THP, the test case >> could be run successfully many times without reboot system. >> >> Co-developed-by: Qiuxu Zhuo >> Signed-off-by: Qiuxu Zhuo >> Signed-off-by: Yin Fengwei >> Suggested-by: Matthew Wilcox > > Thanks for your work. > > Reviewed-by: Miaohe Lin Thanks for your reviewing. Regards Yin, Fengwei >