From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E63BFC001DC for ; Thu, 27 Jul 2023 09:09:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5541D6B0072; Thu, 27 Jul 2023 05:09:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DDEF6B0074; Thu, 27 Jul 2023 05:09:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 356D78D0001; Thu, 27 Jul 2023 05:09:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 23EA36B0072 for ; Thu, 27 Jul 2023 05:09:09 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E6F8B140F49 for ; Thu, 27 Jul 2023 09:09:08 +0000 (UTC) X-FDA: 81056817576.23.1423883 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf13.hostedemail.com (Postfix) with ESMTP id 01E9220016 for ; Thu, 27 Jul 2023 09:09:06 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=XVbZZB1b; spf=pass (imf13.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690448947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4HPzHhawuqBHwf73jZH4M+rJ1h4rzhX4x1A5fzulUtE=; b=GQQ9GlI8SisJX/uhnjbdCrjJvKyeILzbhc3jzr4VudU4I3JohUWprWTYyaTEpqEkDXrPVa kI/9+XVI+IUtRGbAew2Qg4f4X/IxRSHjYjb11b1jon5pv7WC2cw1IsBadPqppo1B4iISHf +/sUazlyGWJzlBnSUR8hvwf4O3JnXtU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690448947; a=rsa-sha256; cv=none; b=EL/ksMvnuNubSvl+KBHGwPOzJITP2QTxoxTt5IjYsU9GdQwG0mKUEyt9S0dKACDjt1FqoT IS37doXILdpqLIWZMzuUnbnRFhQt2h3vdR7rTxRwkKtNf4VZ+7gjkAY3rL9l/CpkUnlwUE xwnw247pJ0hpIQG5UqJ1T+IXHfLNYEw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=XVbZZB1b; spf=pass (imf13.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-66d6a9851f3so176806b3a.0 for ; Thu, 27 Jul 2023 02:09:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690448946; x=1691053746; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4HPzHhawuqBHwf73jZH4M+rJ1h4rzhX4x1A5fzulUtE=; b=XVbZZB1bCuIddvCOd7ZdoZjiMRRT7dPd70cLEHChe028013CtZN4CJhyjaofMQGOCp aGQjkAdZJwrw0kO7FWCF+3wJu4Bs3hfpCHjXHte7v9cy4EJx3v2HSegV5fKDUggsvKcE rfw3ctmBIqNX3YVyLliz70Ow03c79YTqviRSUBhyV37ISoYoH05fZe12pteMem3zIYaK h5yTEuui+F8UDLetCnDn4Wd0BNAlUwOjTRf0Uzpr8uRBgvycDrHuoECz5/KoSjtrxNcd VFQA9eIykS0N+Aj/4rgCWZN2Q01gf7n56+E22JNqNX6qv8VxHS7PwBWWAHU3NZ4I85Kn Kvtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690448946; x=1691053746; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4HPzHhawuqBHwf73jZH4M+rJ1h4rzhX4x1A5fzulUtE=; b=Myf8O7nelyJ7NeaIc0dFurgan4oXuN1y7e4oK5c2ggLwhwFZ6uYbMPfpR0JOeYQand JaFwULFCPbjFgU1ufzCB/QAB1hax0ijyUEuOlVqtxwqikjUr884/LddAhg88J0jWSfqw h0uBIkb9gOUPyRLLrdl8TfjhM8BTu+YwXo6PIIdpAsFbv62RWWrukHVyoWnX6jcEJNIf e9w/rEc7K755mVvY6FMpqHPxjQUrO294xpEvKTX7SAR9RtBuguzyoIqCCcX5xVIVb0rN vhgqU7UhMdvGcrB3uM2hFDdeobE9wi+eFFlS7UD/A/abCUV5LJmJEdQxvAhPjD6d4jty ARwA== X-Gm-Message-State: ABy/qLaDPcs2tJmSTyfdLSPSLtD9Oc1fsV97PfR2lNQAC2GtCJ848dYF IbN5EEhvllXjQZs56WxcRtOrpGRmgZvjtwMEdsE= X-Google-Smtp-Source: APBJJlGcM2GBnp4i4GpCfKYembVJdmGwthtzp39QltAoTiMbksVAbVCn2LuGL8UI/2xPGfcHp3vTrQ== X-Received: by 2002:a05:6a20:1595:b0:137:30db:bc1e with SMTP id h21-20020a056a20159500b0013730dbbc1emr5836590pzj.3.1690448945731; Thu, 27 Jul 2023 02:09:05 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id f17-20020a635551000000b00563ea47c948sm930669pgm.53.2023.07.27.02.08.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 02:09:05 -0700 (PDT) Message-ID: <8951e9da-15ae-f05e-a9a4-a9354249cee2@bytedance.com> Date: Thu, 27 Jul 2023 17:08:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 16/49] nfsd: dynamically allocate the nfsd-filecache shrinker Content-Language: en-US To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Muchun Song References: <20230727080502.77895-1-zhengqi.arch@bytedance.com> <20230727080502.77895-17-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: <20230727080502.77895-17-zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 01E9220016 X-Rspam-User: X-Stat-Signature: 7dwkfaak9fcrabqegshxymkdnas43jo4 X-Rspamd-Server: rspam03 X-HE-Tag: 1690448946-858426 X-HE-Meta: U2FsdGVkX19u7R1POJWO2Xz8442Ex5/tYQAiR4CTHYvkoMq0x/yLOCbpZe0aIK2PU0FzfnWxANIJpOUukaRxwiPlYjdE9pEl4eTNla9CsTDzG3saD/p/kpqZZRpJcYMHE8JYtHzH/HobuTq5ED3ZTNZVz+w1A0iKTsEot1HVzSqIzci0nUGIJUo6z6e903Em7bAT2qY4ZrxHxFX8OODGaq7y9Ai6DL9Jd27NQ9+RQVh7gl8vFK6csAYXvfYmmY3ygX+BFBUwR1KK7DobWmuQxTA6ULL0q1xiU2fuypEO6eShLEi9+hSIAwz08phzFRSo2quxxTGIYn3cemQ7/0easKeXl9IuBzK8ePE6mZ0aaTrWJBWRF2nJOIuwJrgvgWAK5HOMmd2htuhW9oZt2wTy7sNh25hJ8gO0+9aMk23Mn+6u3SYPQzJ3DvjW5ucu+MOMXPvbftwtBqcA4Py/D22+hqFRpeItdXM+pBom2ufopnz+EfSWbIzK7ceZsVUQQIjMXeXUbRpHlHAA6u5Uv4DweY4bow2m8vKwuw5mhmiKzWPgTnJiZ8yaz3JN3EsFjGIQ5hbzFcuqIRrqa5Nx/Fr1WvFrJUOHkLMcQbKJEQje9AFPm+0LLtdIlDAbQgIwhR/OG9KVJoJVcNdGUq3+F97UfmMJcDrcHFuuTbftlstmAdZdWUL8pdO8EoPFgfUqy1DOHGRzLmb7MSzTqUDreYBP4YCe11/QcJkRd62xOy7RBxBwiraqWFHrJ/rHTShQETfycmNuezcPCPdSSjP25UMosPJg2Dxbe9vAu1gu4JNnBQ6+Nk5BxcaUXkD6Zm1jBpUP5a8L0rtYuwe82kcXwSkI7CRp6L4ktrCu/UlTr7UzWHA/t5ct1LVBP1sFMtZlrgtE6yO7taeKh50eUCdKb8XgjGB2wEL7A0TWVPq4NO7jyvONsHqJtCsjY721PmXpJFWRPo/uC7wG/MjvPHpNPDJ CMx2v6sR ZAPezEurVFs4cw7rLnIPIv0KKeClfWFjnZOWQ+kgGikNBz3TWR1Fu94xqiOckatOMQZDK0sQVFc0EgYi/L7WPPWngqMJhRQo4ZhOOO00KHYjkWi0drWVkuH6qYp9ShcnUX0TBlekmnDfvKWG/LPcWoV1WuN84zg24WgEKc+PiWZD/LRVdhXda/leb9eKpYXiwEDL74rLjTsFvo0JAuJWU9ojQftZMy3CxhWfE4KOTAjHaiB3W8Tk82UdFtm4aeujJfn1RWKOpsCIDCgPoiL2pWagRyI77IldS49yvTiui/9PTvnyl1+5V1A7wPHyDFEYTfRbdH/sKOiuJy+56lJmsqbG8OJ1E26pjkEgTVfSX3hx2wBr86m/M0f+WQcR0cOBQpD9PzMGW40o+U3G4+g5IPL8b6JO2pbBoEDoj4CURHHPh9yA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/27 16:04, Qi Zheng wrote: > Use new APIs to dynamically allocate the nfsd-filecache shrinker. > > Signed-off-by: Qi Zheng > Reviewed-by: Muchun Song > --- > fs/nfsd/filecache.c | 22 ++++++++++++---------- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c > index ee9c923192e0..872eb9501965 100644 > --- a/fs/nfsd/filecache.c > +++ b/fs/nfsd/filecache.c > @@ -521,11 +521,7 @@ nfsd_file_lru_scan(struct shrinker *s, struct shrink_control *sc) > return ret; > } > > -static struct shrinker nfsd_file_shrinker = { > - .scan_objects = nfsd_file_lru_scan, > - .count_objects = nfsd_file_lru_count, > - .seeks = 1, > -}; > +static struct shrinker *nfsd_file_shrinker; > > /** > * nfsd_file_cond_queue - conditionally unhash and queue a nfsd_file > @@ -746,12 +742,18 @@ nfsd_file_cache_init(void) > goto out_err; > } > > - ret = register_shrinker(&nfsd_file_shrinker, "nfsd-filecache"); > - if (ret) { > - pr_err("nfsd: failed to register nfsd_file_shrinker: %d\n", ret); > + nfsd_file_shrinker = shrinker_alloc(0, "nfsd-filecache"); > + if (!nfsd_file_shrinker) { Here should set ret to -ENOMEM, will fix. > + pr_err("nfsd: failed to allocate nfsd_file_shrinker\n"); > goto out_lru; > } > > + nfsd_file_shrinker->count_objects = nfsd_file_lru_count; > + nfsd_file_shrinker->scan_objects = nfsd_file_lru_scan; > + nfsd_file_shrinker->seeks = 1; > + > + shrinker_register(nfsd_file_shrinker); > + > ret = lease_register_notifier(&nfsd_file_lease_notifier); > if (ret) { > pr_err("nfsd: unable to register lease notifier: %d\n", ret); > @@ -774,7 +776,7 @@ nfsd_file_cache_init(void) > out_notifier: > lease_unregister_notifier(&nfsd_file_lease_notifier); > out_shrinker: > - unregister_shrinker(&nfsd_file_shrinker); > + shrinker_free(nfsd_file_shrinker); > out_lru: > list_lru_destroy(&nfsd_file_lru); > out_err: > @@ -891,7 +893,7 @@ nfsd_file_cache_shutdown(void) > return; > > lease_unregister_notifier(&nfsd_file_lease_notifier); > - unregister_shrinker(&nfsd_file_shrinker); > + shrinker_free(nfsd_file_shrinker); > /* > * make sure all callers of nfsd_file_lru_cb are done before > * calling nfsd_file_cache_purge