From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80994C83F17 for ; Thu, 10 Jul 2025 21:31:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DAC56B0088; Thu, 10 Jul 2025 17:31:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18AEE6B00A0; Thu, 10 Jul 2025 17:31:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07A276B00A1; Thu, 10 Jul 2025 17:31:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EC56B6B0088 for ; Thu, 10 Jul 2025 17:30:59 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AEEBDC0194 for ; Thu, 10 Jul 2025 21:30:59 +0000 (UTC) X-FDA: 83649650238.26.E5F8A6A Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf10.hostedemail.com (Postfix) with ESMTP id 1BDA2C0007 for ; Thu, 10 Jul 2025 21:30:57 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lChuc2aI; spf=pass (imf10.hostedemail.com: domain of alx@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=alx@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752183058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FG5EU/f/hB5bUkYkfvMhOxqTQ8gFlOM0lPZIWF+q+cc=; b=dFdtHwGSAD67U58cKYW/77C8J/Wf3hBThWajwy+Jb6k8E+0X7UAOo3D91HwZBK4U3E51Ob woXrzgdUFvvo/WQJebzqH4wSC381oEa5URtHqJuYHIExbepyFnpW2lPZZa57MXuSfOtVzw QFUqqPYpxEYp7DOgRyeflO6IsE6eflk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lChuc2aI; spf=pass (imf10.hostedemail.com: domain of alx@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=alx@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752183058; a=rsa-sha256; cv=none; b=gwrgrghtV9UtxpxZWLz0tnrfdnX9+UCDi8Uu/GEDkGxl0Jxd1nhVTbhKNfzjGeyd20EF0c hOZJuT062YZs7UJpjQEVaQaankKqN1i+HLhHRw5c7tIT7sIQeJ7La2bUkkA4UYVgoki68A wh9GJQIidkToE1tZjFq6m+ze3BOt4Q4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 777BB61423; Thu, 10 Jul 2025 21:30:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B5FDC4CEED; Thu, 10 Jul 2025 21:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752183057; bh=KFeH759S2pXUEgcinWQTZzWHu8P8w4ivkJjMDXMeyRQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lChuc2aIiaz+0Xm8z58EsB2dHZQKTk61AFuU2NkYge2fIKkiE9k7JcRFDKte6DbHY AJtgvve0gU4KmxO3Ho8wsXHyXVy5d0cllRYD+5RLan44LxpHFgfnr01I9UIz4oxYUG GnO17+7nijRIOuijJ2XJrkJwxD+V03QKG362wyPhVYqYablzyTtA5tzDvvrJ2FpaBC s3cPgtg2bDj7KsqYw4T/wNYRKrMNVbhxt7fehQMnHh/YLFHgEU09yFQStXHs2oox1v wHDN10DuGpyblOdjFc1Y5qlCvWMd+nd2mUptEGU1Y2DX1AKgOnRJHXJqB7HO8n6dsl q0WedwcuImZLg== Date: Thu, 10 Jul 2025 23:30:50 +0200 From: Alejandro Colomar To: linux-mm@kvack.org, linux-hardening@vger.kernel.org Cc: Alejandro Colomar , Kees Cook , Christopher Bazley , shadow <~hallyn/shadow@lists.sr.ht>, linux-kernel@vger.kernel.org, Andrew Morton , kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Marco Elver , Christoph Lameter , David Rientjes , Vlastimil Babka , Roman Gushchin , Harry Yoo , Andrew Clayton , Rasmus Villemoes , Michal Hocko , Linus Torvalds , Al Viro , Martin Uecker , Sam James , Andrew Pinski Subject: [RFC v5 2/7] stacktrace, stackdepot: Add sprintf_end()-like variants of functions Message-ID: <894d02b08056c59b5acb79af73a1a698d56016f5.1752182685.git.alx@kernel.org> X-Mailer: git-send-email 2.50.0 References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 1BDA2C0007 X-Rspamd-Server: rspam09 X-Stat-Signature: xwpqgf1r8jk5rqmierum1uuyz99ixe3d X-HE-Tag: 1752183057-996164 X-HE-Meta: U2FsdGVkX18BstJAa9XspcpspoRPo2ndkE47wZA2w6ZHKcRgu4Ok4KXzwtjv+2umO1uR/UdeM+aZRlNyR08305EIzT5YKF682xT+Ia1YfrKk5XbUZZ8ppxIBletinncs/MNr60lm3tkp3pji0kug4K2WJiThV1wJIcv7/C25NvTbPqsq7FzWnSEQ76lhatJLp3lER+tEueGqg4PnBxZ7y0EptwEb2vAJCI2erMytrjN62uMRsYK35sPHON55YpxUhyJ+JhdxvzE5qxhM/HOLEbt41JGwbTbe+fzjfTguFqoVFNtN47TmV8XDKP5M0DE5ohx6k/QJykseZvnlaQgST9tqoi6x5XNUMsk/MRMy9jBHxDpKJ8zLz9SDJjbC8j3/eIJyal1tYNPpVSOm7/3+S0OaF+ae0UVLal9vfVCszRLKxi/+3tyz4l7kjjvKBGCTi8KQzZHoMi8tKLon6rfAvxJJmxr3gFKr48JpzrXEj1n7jgS71OGmKxfCjC3nxBSHuFrnhfn2bp+H3EceNADCH0Ozm/5pCKGSOCFqrXyzMk6zSMxj6dYr3dm5PxFXKu7pZH4iKwqQsJ7jk3Rf21PrFBSkxKSo6ZOdI5mOz7hBiZ5TpWO2x9DBFykJURqOplJATeVDQkJ4zvjMjgoREgdLXqBnjEvkFFbqQ/ZiC6eklu702vD6BNGLtfysJegPZLaORD3tY9j881A2l1JIGkmOhe9NSgQBTMx4UD23nqKvVrgdCHR4Gy54mc/HSLLwiJFJKI7/4Vgtcy9uJHdNLcstVzylkUtW/iITmXZB1u2vqbIEt3kw9Wqwm5m3Oa7D77lA0hnAeJIJgttIaWkSJlV3qup3pEvgA0VkW2HEvTQmrdvgYOfix7J8rRIwvtiKsxGGuk2G/Wi8+9n3QOMkSHiCNSHYPEKokrZe+gLfPhyI52ROmI8wU1BIgVNX2V1mqcN3jtiUjTY70LXllHKLWkY uslZe/KY oPHPy9zMsM4mCYtW8QWOeFDa/SG/hUZKjJj/nKiBMJbkqAqauhMt7+J51aYLv3Di7TONg/IU0ipuSv04yEt7glOIptPQsQftDiwgkcH7ti9NlrvJQder/U4yA00ycKYZuG94DdqQwwbj4lEY18owbypp9f4adxyR9QF3nDnYXkj1a4hW1qjdBqqdDXfTNe4BB8vjHwQTcVfqjS9WOI21p+cZL4bmBcNECIyrUyAjeEv2JgPA1k8+l62FaKNceQ9BKOrDSAr615zP/S6C2VJVjlI3gNHsoviest1ysK5p7tLPI0QEeE/QEJtoRj+PV29Qf9WljpGlUZ/rxeDaX/a1RyCPy8K33ZxtGDIz7+mt7dSYYF48mNUWesN9XQAe0I99QF/wgkxfHWshuw25LdeU+Tyx+MqQ9T4wJwYAOswf8Um/06zQCiEaeoT2jaqgaI/gyMvfIuHRSev2BO/g6ZUOcIl5J+/0+xj+VP39PiEBTNj0oYNf4rmekIKTaXs9DbeaQi6u0fqun5EjvcgSnk4/u/Kd50vFPkYyBCWSUfafZnK42e7bM1EuatwQeY/EbdIHTOF9aXi9hOaFVmwQYegDSYCqBL19Qj8xwpQlNZ4paiN3lZ9WjN2xf2U/A6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Cc: Kees Cook Cc: Christopher Bazley Cc: Rasmus Villemoes Cc: Marco Elver Cc: Michal Hocko Cc: Linus Torvalds Cc: Al Viro Signed-off-by: Alejandro Colomar --- include/linux/stackdepot.h | 13 +++++++++++++ include/linux/stacktrace.h | 3 +++ kernel/stacktrace.c | 28 ++++++++++++++++++++++++++++ lib/stackdepot.c | 13 +++++++++++++ 4 files changed, 57 insertions(+) diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h index 2cc21ffcdaf9..76182e874f67 100644 --- a/include/linux/stackdepot.h +++ b/include/linux/stackdepot.h @@ -219,6 +219,19 @@ void stack_depot_print(depot_stack_handle_t stack); int stack_depot_snprint(depot_stack_handle_t handle, char *buf, size_t size, int spaces); +/** + * stack_depot_sprint_end - Print a stack trace from stack depot into a buffer + * + * @handle: Stack depot handle returned from stack_depot_save() + * @p: Pointer to the print buffer + * @end: Pointer to one past the last element in the buffer + * @spaces: Number of leading spaces to print + * + * Return: Pointer to trailing '\0'; or NULL on truncation + */ +char *stack_depot_sprint_end(depot_stack_handle_t handle, char *p, + const char end[0], int spaces); + /** * stack_depot_put - Drop a reference to a stack trace from stack depot * diff --git a/include/linux/stacktrace.h b/include/linux/stacktrace.h index 97455880ac41..79ada795d479 100644 --- a/include/linux/stacktrace.h +++ b/include/linux/stacktrace.h @@ -67,6 +67,9 @@ void stack_trace_print(const unsigned long *trace, unsigned int nr_entries, int spaces); int stack_trace_snprint(char *buf, size_t size, const unsigned long *entries, unsigned int nr_entries, int spaces); +char *stack_trace_sprint_end(char *p, const char end[0], + const unsigned long *entries, + unsigned int nr_entries, int spaces); unsigned int stack_trace_save(unsigned long *store, unsigned int size, unsigned int skipnr); unsigned int stack_trace_save_tsk(struct task_struct *task, diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c index afb3c116da91..f389647d8e44 100644 --- a/kernel/stacktrace.c +++ b/kernel/stacktrace.c @@ -70,6 +70,34 @@ int stack_trace_snprint(char *buf, size_t size, const unsigned long *entries, } EXPORT_SYMBOL_GPL(stack_trace_snprint); +/** + * stack_trace_sprint_end - Print the entries in the stack trace into a buffer + * @p: Pointer to the print buffer + * @end: Pointer to one past the last element in the buffer + * @entries: Pointer to storage array + * @nr_entries: Number of entries in the storage array + * @spaces: Number of leading spaces to print + * + * Return: Pointer to the trailing '\0'; or NULL on truncation. + */ +char *stack_trace_sprint_end(char *p, const char end[0], + const unsigned long *entries, unsigned int nr_entries, + int spaces) +{ + unsigned int i; + + if (WARN_ON(!entries)) + return 0; + + for (i = 0; i < nr_entries; i++) { + p = sprintf_end(p, end, "%*c%pS\n", 1 + spaces, ' ', + (void *)entries[i]); + } + + return p; +} +EXPORT_SYMBOL_GPL(stack_trace_sprint_end); + #ifdef CONFIG_ARCH_STACKWALK struct stacktrace_cookie { diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 73d7b50924ef..48e5c0ff37e8 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -771,6 +771,19 @@ int stack_depot_snprint(depot_stack_handle_t handle, char *buf, size_t size, } EXPORT_SYMBOL_GPL(stack_depot_snprint); +char *stack_depot_sprint_end(depot_stack_handle_t handle, char *p, + const char end[0], int spaces) +{ + unsigned long *entries; + unsigned int nr_entries; + + nr_entries = stack_depot_fetch(handle, &entries); + return nr_entries ? + stack_trace_sprint_end(p, end, entries, nr_entries, spaces) + : sprintf_end(p, end, ""); +} +EXPORT_SYMBOL_GPL(stack_depot_sprint_end); + depot_stack_handle_t __must_check stack_depot_set_extra_bits( depot_stack_handle_t handle, unsigned int extra_bits) { -- 2.50.0