From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB7D2C54E5B for ; Tue, 14 Nov 2023 20:12:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 841ED6B030C; Tue, 14 Nov 2023 15:12:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F1B06B030D; Tue, 14 Nov 2023 15:12:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 692956B0311; Tue, 14 Nov 2023 15:12:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 57B116B030C for ; Tue, 14 Nov 2023 15:12:32 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2193E80347 for ; Tue, 14 Nov 2023 20:12:32 +0000 (UTC) X-FDA: 81457657344.21.C93126B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf30.hostedemail.com (Postfix) with ESMTP id E28D280024 for ; Tue, 14 Nov 2023 20:12:29 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KL32TVBx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=L3J2R54N; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699992750; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3oWHSyp79oNEAgxAW4ytBgCxzKxU2JyVRlj3iU9Pw8Q=; b=YULY19/u3xXf+jV9RJdjniUvosUwgAwW5E5xp++itGJObS7QRcOun2vsaPgNu6N1KWpx3G ZbwmJBp3uSiZD2fvsRM/e0xKvpf/hRKxz/5Vo7OuWWWhnV0zwFrqAmQQT8wTR4Uk+N/M3/ upTbko/8TdrwVBVvpslWh8JISCYAsQg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KL32TVBx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=L3J2R54N; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699992750; a=rsa-sha256; cv=none; b=CMVNk8H5nC5DmQyvCMbwBIUOEiGadUITa7QRqnAXv9H+iEdKpr0W8ARr9+beMdH7ox+dZi PZXBGP9rkLlcc8Ja0oqLCk6zc/bfTJy/TOyYUg0TEEM+5x+Bx2rJBG1Hsi0i29kZN625VK wgwQyb3mK7BsStVhTz1TA4SnkWQE00A= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A85D6228DF; Tue, 14 Nov 2023 20:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1699992747; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3oWHSyp79oNEAgxAW4ytBgCxzKxU2JyVRlj3iU9Pw8Q=; b=KL32TVBxQW6+GtVEfqM8IxU1HpDPnjwzKYDi8t7DlqxtkVGoll2S6coi19xOD+SetzF8as CfxAmzEA17DWL6Ubjz4iuSkfiWCjwh+Phjz0Z+gam96Bey9MZuDrTCAeSxu3ZE1HZEsmPD Yk2+zEFYTUNyxJHsa7cN2HDO4Y63C6c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1699992747; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3oWHSyp79oNEAgxAW4ytBgCxzKxU2JyVRlj3iU9Pw8Q=; b=L3J2R54NClnDf61QqWa1WxXEGfMp3intqNZu57qpKVE39SYitMa5NuODSNEbw/0PLiBjV6 6Da9th5iNMO/5SAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 658A613460; Tue, 14 Nov 2023 20:12:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id I44uGKvUU2XOWAAAMHmgww (envelope-from ); Tue, 14 Nov 2023 20:12:27 +0000 Message-ID: <893d2289-e463-dd00-84cc-e77aed93cf53@suse.cz> Date: Tue, 14 Nov 2023 21:12:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 05/20] cpu/hotplug: remove CPUHP_SLAB_PREPARE hooks Content-Language: en-US To: Kees Cook Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20231113191340.17482-22-vbabka@suse.cz> <20231113191340.17482-27-vbabka@suse.cz> <202311132020.5A4B63D@keescook> From: Vlastimil Babka In-Reply-To: <202311132020.5A4B63D@keescook> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E28D280024 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ygjhoi9rx1idm357m1ouorsjixp5xuzb X-HE-Tag: 1699992749-43752 X-HE-Meta: U2FsdGVkX18lONCcZejat0ATCXuVoUoYYzAedS39FtJt0cfCOCi38g+V4fj7TtFmy8dAmjhba+HQZtVdEaISqFFONl3yrdM/cfs74YndVVKXzB7dQntt4xPoIBCVw+NHtGtPc5Uewk75WYNFIhI71oSNx6N93NlEvPW0x4xmD7lcVw4OMse9iHpu8LptEDhWbh3YuEAvGi/pbOkgfUjh/Jbz7pbybTF9I7lYENb9zusx6VZNNywIZgPbAklwQ0RSIo/JdQ0mrBP1qaiC3zeV2wMhBldPHBwSxWopceTEn5SYsigbx3CzBRbVaAKQJ6pHvzrQem9bn3tQJzIA0lFQIxBOGZX5i5PE5EXQcqNd4JPOfPojjNjCwwFebWfSLLJIpCW17uiDggzcfb4perC4ZJOmfpQ0eA+ANYW2nR51V5kr0Y5F77bpwtwdxUndbrBKwGn/xg4UOfuvyFcpS4xdNpTWFg9n0DLj37TbIBusF9SmVqxdr7aG5ohZ3du4q69WZ3k8HIzW3+QEqoyuE70NsHvhCcWEt+hHtbIPzevwfSeOzcuyNgI0DLPJfh9bz78mG4Pzi4E3XkK5smIWDvKjk4VZ+5554RBCIm+LAmqYOTRiIOplyjlkgUw/jSgni5XN1QOuD3TF85HD3UllDUnATDOFkkr3gCQbHT+0X0wu6/zYVC24F4+3GCiVy9L5gs4WmPiXSYdIF1vph+2wWIvj7wQlzWqzAPi50gmOuH4UyzZdZ36JjUbLDMrl71GP3DWN3A0wbtKKw8fi2bqctj5oZK+jn/ykVKgxLUAjTFOm0wpeOh3GrbvXQyL21fJeOGCLdY4l1MPc2lWxPEIuDbNe6Cb7Fzse6GF1D1uYVWQFMW4ecc9gzDQJDHqGMeSL76NgnGcaytZVLHoWIsdNgicKBa2kGrrhZ9k80dHLJMt0alb9DDDQGC05cC5r2rN2FUHe2GxgSZEUxEp/1YXJjZh F1d9YQGX Cv8EPMT4xP9Bj1X/c7af0DYHRK4EbgZ0rwfJ814SxhdACzrTtYmBzev2Cyus1IIY1fhhMK3VVxhRJ7LQzfu2VGXekGeZ7zLj90SileQHEQV9QHqE25x6oqC8JjxvSBMBJiZikBVegOrLd4iDv7CGIBU86WqbKq9gj8dNi3DmGqVUDW711faMkg76UGYtwNtEqTfuUs4kSZmvnyCR+7raivp472m61ff2OfgUxY9EgP48nddUIIp/UFxWwP35f6470pmUmbdfbW9R7IE2unB4ItQ3Pprlimp5D8YG6aS4QRdZe+4CPHY9c1/HBqIIEm4/B0BnN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/14/23 05:20, Kees Cook wrote: > On Mon, Nov 13, 2023 at 08:13:46PM +0100, Vlastimil Babka wrote: >> The CPUHP_SLAB_PREPARE hooks are only used by SLAB which is removed. >> SLUB defines them as NULL, so we can remove those altogether. >> >> Signed-off-by: Vlastimil Babka >> --- >> include/linux/slab.h | 8 -------- >> kernel/cpu.c | 5 ----- >> 2 files changed, 13 deletions(-) >> >> diff --git a/include/linux/slab.h b/include/linux/slab.h >> index d6d6ffeeb9a2..34e43cddc520 100644 >> --- a/include/linux/slab.h >> +++ b/include/linux/slab.h >> @@ -788,12 +788,4 @@ size_t kmalloc_size_roundup(size_t size); >> >> void __init kmem_cache_init_late(void); >> >> -#if defined(CONFIG_SMP) && defined(CONFIG_SLAB) >> -int slab_prepare_cpu(unsigned int cpu); >> -int slab_dead_cpu(unsigned int cpu); >> -#else >> -#define slab_prepare_cpu NULL >> -#define slab_dead_cpu NULL >> -#endif >> - >> #endif /* _LINUX_SLAB_H */ >> diff --git a/kernel/cpu.c b/kernel/cpu.c >> index 9e4c6780adde..530b026d95a1 100644 >> --- a/kernel/cpu.c >> +++ b/kernel/cpu.c >> @@ -2125,11 +2125,6 @@ static struct cpuhp_step cpuhp_hp_states[] = { >> .startup.single = relay_prepare_cpu, >> .teardown.single = NULL, >> }, >> - [CPUHP_SLAB_PREPARE] = { >> - .name = "slab:prepare", >> - .startup.single = slab_prepare_cpu, >> - .teardown.single = slab_dead_cpu, >> - }, >> [CPUHP_RCUTREE_PREP] = { >> .name = "RCU/tree:prepare", >> .startup.single = rcutree_prepare_cpu, > > Should CPUHP_SLAB_PREPARE be removed from the enum too? Yep, will do, thanks!